)]}'
{"marconi/tests/queues/storage/base.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"e81957e5895df55d52e06b30b5bed1ceea711851","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    def test_message_lifecycle(self):"},{"line_number":245,"context_line":"        queue_name \u003d self.queue_name"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        message \u003d {"},{"line_number":248,"context_line":"            \u0027ttl\u0027: 60,"},{"line_number":249,"context_line":"            \u0027body\u0027: {"},{"line_number":250,"context_line":"                \u0027event\u0027: \u0027BackupStarted\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fllg%3D","line":247,"updated":"2014-03-15 23:24:14.000000000","message":"What\u0027s the benefit? IMHO, the previous way is more clear for me.","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"4c54899e1ff9b9487d8d1d2320d095be34c79fcb","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    def test_message_lifecycle(self):"},{"line_number":245,"context_line":"        queue_name \u003d self.queue_name"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        message \u003d {"},{"line_number":248,"context_line":"            \u0027ttl\u0027: 60,"},{"line_number":249,"context_line":"            \u0027body\u0027: {"},{"line_number":250,"context_line":"                \u0027event\u0027: \u0027BackupStarted\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNHk%3D","line":247,"in_reply_to":"AAAAWH%2F%2FhGc%3D","updated":"2014-03-19 13:27:51.000000000","message":"OK, it makes more sense for me. Thanks for the clarification.","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f08c1314d0f730f3f43e1a22e6b12ace751fca0c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    def test_message_lifecycle(self):"},{"line_number":245,"context_line":"        queue_name \u003d self.queue_name"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        message \u003d {"},{"line_number":248,"context_line":"            \u0027ttl\u0027: 60,"},{"line_number":249,"context_line":"            \u0027body\u0027: {"},{"line_number":250,"context_line":"                \u0027event\u0027: \u0027BackupStarted\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FhGc%3D","line":247,"in_reply_to":"AAAAWH%2F%2FlQY%3D","updated":"2014-03-17 12:02:57.000000000","message":"FWIW, this works and seems fine. I also appreciate the asserts not having `[0]` :D","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"},{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"46134d6b3b6158d923c9fedcf6c8ed39adcad965","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    def test_message_lifecycle(self):"},{"line_number":245,"context_line":"        queue_name \u003d self.queue_name"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        message \u003d {"},{"line_number":248,"context_line":"            \u0027ttl\u0027: 60,"},{"line_number":249,"context_line":"            \u0027body\u0027: {"},{"line_number":250,"context_line":"                \u0027event\u0027: \u0027BackupStarted\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FlQY%3D","line":247,"in_reply_to":"AAAAWH%2F%2Fllg%3D","updated":"2014-03-16 07:38:53.000000000","message":"Yes, I agree in this point, the old way is clearer. But when in asserts below, I need to use messages[0] to get the message it fills a little bit ugly. And since the test is about testing message lifecycle, I thought it is good to clearly see this message :). Pure IMHO. If I don\u0027t not convince you, I\u0027ll rollback to old way.","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"e81957e5895df55d52e06b30b5bed1ceea711851","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                                                project\u003dself.project)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        for idx, message in enumerate(messages_out):"},{"line_number":316,"context_line":"            self.assertEqual(set(message), set((\u0027id\u0027, \u0027body\u0027, \u0027ttl\u0027, \u0027age\u0027)))"},{"line_number":317,"context_line":"            self.assertEqual(message[\u0027body\u0027], idx)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        self.controller.bulk_delete(self.queue_name, ids,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fllc%3D","line":316,"updated":"2014-03-15 23:24:14.000000000","message":"What\u0027s the benefit?","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"4c54899e1ff9b9487d8d1d2320d095be34c79fcb","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                                                project\u003dself.project)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        for idx, message in enumerate(messages_out):"},{"line_number":316,"context_line":"            self.assertEqual(set(message), set((\u0027id\u0027, \u0027body\u0027, \u0027ttl\u0027, \u0027age\u0027)))"},{"line_number":317,"context_line":"            self.assertEqual(message[\u0027body\u0027], idx)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        self.controller.bulk_delete(self.queue_name, ids,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FNHM%3D","line":316,"in_reply_to":"AAAAWH%2F%2FlQA%3D","updated":"2014-03-19 13:27:51.000000000","message":"Ok, I see.","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"},{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"46134d6b3b6158d923c9fedcf6c8ed39adcad965","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                                                project\u003dself.project)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        for idx, message in enumerate(messages_out):"},{"line_number":316,"context_line":"            self.assertEqual(set(message), set((\u0027id\u0027, \u0027body\u0027, \u0027ttl\u0027, \u0027age\u0027)))"},{"line_number":317,"context_line":"            self.assertEqual(message[\u0027body\u0027], idx)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        self.controller.bulk_delete(self.queue_name, ids,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FlQA%3D","line":316,"in_reply_to":"AAAAWH%2F%2Fllc%3D","updated":"2014-03-16 07:38:53.000000000","message":"It is the same check as in test_message_lifecycle, basicaly to ensure, that we are returning all keys that is required and only them. I though it is good to test it not only for get, but also for bulk_get","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"a85eb680332d7de5267406bc3843e38fe700c304","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        self.assertEqual(messages, [])"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def test_first(self):"},{"line_number":454,"context_line":"        client_uuid \u003d uuid.uuid4()"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        [msgid_first] \u003d self.controller.post(self.queue_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B7n4%3D","line":453,"updated":"2014-03-21 15:51:04.000000000","message":"Can you please make the test name more explicit on what it will do?","commit_id":"39affc53795cb3d679fcfd593c7e85c2a9d1c154"}]}