)]}'
{"marconi/queues/api/v1/response.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"3a9b874ecc1d8b6483532d8d52a9cfc32129027f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                            \u0027required\u0027: [\u0027name\u0027, \u0027href\u0027],"},{"line_number":98,"context_line":"                            \u0027additionalProperties\u0027: False,"},{"line_number":99,"context_line":"                        },"},{"line_number":100,"context_line":"                        \u0027minItems\u0027: 1,"},{"line_number":101,"context_line":"                    }"},{"line_number":102,"context_line":"                },"},{"line_number":103,"context_line":"                \u0027required\u0027: [\u0027links\u0027, \u0027queues\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FUkI%3D","line":100,"updated":"2014-04-22 14:35:44.000000000","message":"Can you add a maxItems too?\nThe max # of items should not exceed the config value max_queues_per_page","commit_id":"2ebcac0745fa5cd8112ecadeb5ff49ed1ac3d684"}],"tests/functional/wsgi/v1/test_queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"92e07029c32bbc3ed7bab1c63477f19e38ea6079","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                                 params\u003dparams)"},{"line_number":298,"context_line":"        self.assertEqual(result.status_code, 200)"},{"line_number":299,"context_line":"        schema \u003d self.response.get_schema(\u0027queue_list\u0027)"},{"line_number":300,"context_line":"        self.assertSchema(result.json(), schema)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        response_keys \u003d result.json()[\u0027queues\u0027][0].keys()"},{"line_number":303,"context_line":"        self.assertIn(\u0027metadata\u0027, response_keys)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FrCM%3D","line":300,"updated":"2014-04-18 11:09:38.000000000","message":"There\u0027s already a validate method in ResponseSchema. Have you tried something like:\n\n  self.assertTrue(self.response.validate(\u0027queue_list\u0027, schema)","commit_id":"d81464f21dfd030edb86d0195b8495bdb5aadd29"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"c4b5c625fd2179bf26414ac113a85ee3520cd2d4","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        result \u003d self.client.get(\u0027/{0}/queues\u0027"},{"line_number":280,"context_line":"                                 .format(self.cfg.marconi.version))"},{"line_number":281,"context_line":"        self.assertEqual(result.status_code, 200)"},{"line_number":282,"context_line":"        self.assertTrue(self.response.validate(\u0027queue_list\u0027, result.json()))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    test_list_queues.tags \u003d [\u0027smoke\u0027, \u0027positive\u0027]"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FeZs%3D","line":282,"updated":"2014-04-21 13:55:14.000000000","message":"You can use the assertSchema to do the validation. See here for an example https://github.com/openstack/marconi/blob/master/tests/functional/wsgi/v1/test_messages.py#L129\nThis will help us keep the validation style consistent across all tests.","commit_id":"34a8f2a9ce0e8a4bb4cfb84593c761a19a8d0610"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e53335acebd4284d5d917e976aa749b1a0447838","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        result \u003d self.client.get(\u0027/{0}/queues\u0027"},{"line_number":280,"context_line":"                                 .format(self.cfg.marconi.version))"},{"line_number":281,"context_line":"        self.assertEqual(result.status_code, 200)"},{"line_number":282,"context_line":"        self.assertTrue(self.response.validate(\u0027queue_list\u0027, result.json()))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    test_list_queues.tags \u003d [\u0027smoke\u0027, \u0027positive\u0027]"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FU4o%3D","line":282,"in_reply_to":"AAAAXH%2F%2FXK0%3D","updated":"2014-04-22 13:55:23.000000000","message":"mmh, I had forgotten the `assertSchema` method is something we implemented. I thought it was from testtools. I\u0027m sorry for my misleading comment in the previous patchset.\n\nI agree with malini, we should use assertSchema.","commit_id":"34a8f2a9ce0e8a4bb4cfb84593c761a19a8d0610"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ff7c7a80962ce8f5813f3f689139f271abb2712d","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        result \u003d self.client.get(\u0027/{0}/queues\u0027"},{"line_number":280,"context_line":"                                 .format(self.cfg.marconi.version))"},{"line_number":281,"context_line":"        self.assertEqual(result.status_code, 200)"},{"line_number":282,"context_line":"        self.assertTrue(self.response.validate(\u0027queue_list\u0027, result.json()))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    test_list_queues.tags \u003d [\u0027smoke\u0027, \u0027positive\u0027]"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FXK0%3D","line":282,"in_reply_to":"AAAAXH%2F%2FeZs%3D","updated":"2014-04-22 09:55:19.000000000","message":"I actually asked her to use `assertTrue` and *our* validate method. The reason being that this will help us test the `API` validation method and make sure we don\u0027t break anything when changing it.\n\nDoes this make sense to you Malini?","commit_id":"34a8f2a9ce0e8a4bb4cfb84593c761a19a8d0610"}]}