)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5e2c1a1191b354016e51335d84256f87ca7a48e1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"following validations,"},{"line_number":13,"context_line":"1. pop \u0026 id params cannot be used together in the request."},{"line_number":14,"context_line":"2. 0 \u003c pop value \u003c\u003d max_messages_per_claim_or_pop"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I63b22e57ed5ab398b81cde2d0284767e9704ec11"},{"line_number":17,"context_line":"Implements: blueprint api-v1.1-pop-operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baada198_7f611538","line":15,"updated":"2014-07-14 05:25:31.000000000","message":"(nit): Should we mark this as docImpact? Given we\u0027re adding new feature.","commit_id":"ff9b9c50d3e4c153f908a3253b80915dab26f8b1"}],"marconi/queues/storage/base.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"6feabf1d91ed66054c3e21ed7b4037c4f7e9d393","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        raise NotImplementedError"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @abc.abstractmethod"},{"line_number":333,"context_line":"    def pop(self, queue, pop_limit, project\u003dNone):"},{"line_number":334,"context_line":"        \"\"\"Base method for popping messages."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :param queue: Name of the queue to pop"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_be2eccf8","line":333,"updated":"2014-06-16 20:45:59.000000000","message":"NIT: The name \"pop_limit\" seems redundant, since you are calling the \"pop\" method already. Rename to just \"limit\"?","commit_id":"685c9e88e62f0a4ad3505c0e8d9c80731d9e9002"}],"marconi/queues/storage/mongodb/messages.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":740,"context_line":"    @utils.raises_conn_error"},{"line_number":741,"context_line":"    @utils.retries_on_autoreconnect"},{"line_number":742,"context_line":"    def pop(self, queue_name, pop_limit, project\u003dNone):"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        query \u003d {"},{"line_number":745,"context_line":"            PROJ_QUEUE: utils.scope_queue_name(queue_name, project),"},{"line_number":746,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_32af0896","line":743,"updated":"2014-06-10 20:35:49.000000000","message":"Nit: Blank line is not needed before L744, since the code is already visually distinct.","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"80a0ddb90379067e604d1d24c5b23bebea8ada4b","unresolved":false,"context_lines":[{"line_number":740,"context_line":"    @utils.raises_conn_error"},{"line_number":741,"context_line":"    @utils.retries_on_autoreconnect"},{"line_number":742,"context_line":"    def pop(self, queue_name, pop_limit, project\u003dNone):"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        query \u003d {"},{"line_number":745,"context_line":"            PROJ_QUEUE: utils.scope_queue_name(queue_name, project),"},{"line_number":746,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_a6557e1f","line":743,"in_reply_to":"1ae5cdf2_32af0896","updated":"2014-06-11 14:37:45.000000000","message":"Done","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":742,"context_line":"    def pop(self, queue_name, pop_limit, project\u003dNone):"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        query \u003d {"},{"line_number":745,"context_line":"            PROJ_QUEUE: utils.scope_queue_name(queue_name, project),"},{"line_number":746,"context_line":"        }"},{"line_number":747,"context_line":"        collection \u003d self._collection(queue_name, project)"},{"line_number":748,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_fd99f16e","line":745,"updated":"2014-06-10 20:35:49.000000000","message":"Bug: Perhaps I missed something, but don\u0027t we also need to filter out messages that are claimed (we don\u0027t want to pop messages that are already claimed)? This situation should also have a test...","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"80a0ddb90379067e604d1d24c5b23bebea8ada4b","unresolved":false,"context_lines":[{"line_number":742,"context_line":"    def pop(self, queue_name, pop_limit, project\u003dNone):"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        query \u003d {"},{"line_number":745,"context_line":"            PROJ_QUEUE: utils.scope_queue_name(queue_name, project),"},{"line_number":746,"context_line":"        }"},{"line_number":747,"context_line":"        collection \u003d self._collection(queue_name, project)"},{"line_number":748,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_46475a77","line":745,"in_reply_to":"1ae5cdf2_fd99f16e","updated":"2014-06-11 14:37:45.000000000","message":"Done","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        now \u003d timeutils.utcnow_ts()"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        messages \u003d [_basic_message(collection.find_and_modify(query,"},{"line_number":752,"context_line":"                                   remove\u003dTrue), now)"},{"line_number":753,"context_line":"                    for limit in range(pop_limit)]"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_9249bcd2","line":751,"updated":"2014-06-10 20:35:49.000000000","message":"Perf: Would adding a limit(pop_limit) clause be more performant? I am thinking that would give mongo a hint that we are only asking for X documents.\n\nAlso, are there any fields that will not be used by _basic_message, and can be filtered out using a projection?","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        now \u003d timeutils.utcnow_ts()"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        messages \u003d [_basic_message(collection.find_and_modify(query,"},{"line_number":752,"context_line":"                                   remove\u003dTrue), now)"},{"line_number":753,"context_line":"                    for limit in range(pop_limit)]"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return messages"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_bd5e89e7","line":752,"updated":"2014-06-10 20:35:49.000000000","message":"Q. If we have two simultaneous requests, does mongo guarantee that each set of messages will be disjoint?","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"c08081fb02c4363d1d2ef0ccfe28a69639e53670","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        now \u003d timeutils.utcnow_ts()"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        messages \u003d [_basic_message(collection.find_and_modify(query,"},{"line_number":752,"context_line":"                                   remove\u003dTrue), now)"},{"line_number":753,"context_line":"                    for limit in range(pop_limit)]"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return messages"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_998d46d6","line":752,"in_reply_to":"1ae5cdf2_bd5e89e7","updated":"2014-06-11 12:45:23.000000000","message":"I think since find and modify is atomic, we should be fine","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        messages \u003d [_basic_message(collection.find_and_modify(query,"},{"line_number":752,"context_line":"                                   remove\u003dTrue), now)"},{"line_number":753,"context_line":"                    for limit in range(pop_limit)]"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return messages"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_129a0c63","line":753,"updated":"2014-06-10 20:35:49.000000000","message":"Nit: naming the counter \"limit\" is a little confusing to me. Since it isn\u0027t used anywhere, how about just using a placeholder name, e.g.:\n\n    for _ in range(pop_limit)]","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"80a0ddb90379067e604d1d24c5b23bebea8ada4b","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        messages \u003d [_basic_message(collection.find_and_modify(query,"},{"line_number":752,"context_line":"                                   remove\u003dTrue), now)"},{"line_number":753,"context_line":"                    for limit in range(pop_limit)]"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        return messages"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0651d235","line":753,"in_reply_to":"1ae5cdf2_129a0c63","updated":"2014-06-11 14:37:45.000000000","message":"Done","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"6feabf1d91ed66054c3e21ed7b4037c4f7e9d393","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        collection \u003d self._collection(queue_name, project)"},{"line_number":753,"context_line":"        fields \u003d {\u0027_id\u0027: 1, \u0027t\u0027: 1, \u0027b\u0027: 1}"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        messages \u003d [_basic_message(collection.find_and_modify(query,"},{"line_number":756,"context_line":"                                   fields\u003dfields,"},{"line_number":757,"context_line":"                                   remove\u003dTrue,"},{"line_number":758,"context_line":"                                   limit\u003dpop_limit), now)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_8118d576","line":755,"updated":"2014-06-16 20:45:59.000000000","message":"PERF: I wish there were a way to get more than one message per query. It would have to be done in a way that a parallel request couldn\u0027t also return/modify any of the same messages. I think the best you can do is something ala ClaimController.create, which is not likely to be faster than just calling find_and_modify N times. May be worth benchmarking some time, but certainly not a blocker for this patch (perhaps file a bug so we remember to follow up?)","commit_id":"685c9e88e62f0a4ad3505c0e8d9c80731d9e9002"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"6feabf1d91ed66054c3e21ed7b4037c4f7e9d393","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        messages \u003d [_basic_message(collection.find_and_modify(query,"},{"line_number":756,"context_line":"                                   fields\u003dfields,"},{"line_number":757,"context_line":"                                   remove\u003dTrue,"},{"line_number":758,"context_line":"                                   limit\u003dpop_limit), now)"},{"line_number":759,"context_line":"                    for _ in range(pop_limit)]"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        return messages"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_1e2340bf","line":758,"updated":"2014-06-16 20:45:59.000000000","message":"BUG: Sorry, this one is my fault. I suggested adding a \"limit\" param to find_and_modify, but it turns out that find_and_modify will only ever operate on a single document, so the limit option is not needed (or even supported) in this call.","commit_id":"685c9e88e62f0a4ad3505c0e8d9c80731d9e9002"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"001f1b4cc8f962b6400dc36549953399c70ab82a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class MessageController(storage.Message):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \"\"\"Implements message resource operations using MongoDB."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    Messages are scoped by project + queue."}],"source_content_type":"text/x-python","patch_set":10,"id":"dab895d6_4dbb6b0e","line":112,"updated":"2014-06-30 08:08:54.000000000","message":"Is this change because hacking complained about a missing new line? I\u0027d like to avoid not related changes that could cause merge issues.","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"ee06f2906991973c13e761989999792feebe31c8","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class MessageController(storage.Message):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \"\"\"Implements message resource operations using MongoDB."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    Messages are scoped by project + queue."}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_4e2845e2","line":112,"in_reply_to":"dab895d6_4dbb6b0e","updated":"2014-07-03 17:59:39.000000000","message":"Done","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"001f1b4cc8f962b6400dc36549953399c70ab82a","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        messages \u003d [collection.find_and_modify(query,"},{"line_number":755,"context_line":"                                               fields\u003dfields,"},{"line_number":756,"context_line":"                                               remove\u003dTrue)"},{"line_number":757,"context_line":"                    for _ in range(limit)]"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        messages \u003d filter(None, messages)"},{"line_number":760,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dab895d6_2d1ab717","line":757,"updated":"2014-06-30 08:08:54.000000000","message":"Could you make this a generator instead of iterating over it right away?","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"ee06f2906991973c13e761989999792feebe31c8","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        messages \u003d [collection.find_and_modify(query,"},{"line_number":755,"context_line":"                                               fields\u003dfields,"},{"line_number":756,"context_line":"                                               remove\u003dTrue)"},{"line_number":757,"context_line":"                    for _ in range(limit)]"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        messages \u003d filter(None, messages)"},{"line_number":760,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_ce1455a2","line":757,"in_reply_to":"dab895d6_2d1ab717","updated":"2014-07-03 17:59:39.000000000","message":"not sure I understand that - since find_and_modify will return just one record, I am doing the query n times, to create a message list that will x number of elements.","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"001f1b4cc8f962b6400dc36549953399c70ab82a","unresolved":false,"context_lines":[{"line_number":756,"context_line":"                                               remove\u003dTrue)"},{"line_number":757,"context_line":"                    for _ in range(limit)]"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        messages \u003d filter(None, messages)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        if (messages is not None):"},{"line_number":762,"context_line":"            messages \u003d [_basic_message(messages[i], now)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab895d6_4d17ebed","line":759,"updated":"2014-06-30 08:08:54.000000000","message":"If you use `itertools.ifilter`, you get the same filter but an iterator in return.","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"001f1b4cc8f962b6400dc36549953399c70ab82a","unresolved":false,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        messages \u003d filter(None, messages)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        if (messages is not None):"},{"line_number":762,"context_line":"            messages \u003d [_basic_message(messages[i], now)"},{"line_number":763,"context_line":"                        for i in range(len(messages))]"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dab895d6_cdb93beb","line":761,"updated":"2014-06-30 08:08:54.000000000","message":"When is `messages` None? if the `filter` function filters out all items, it\u0027ll return an empty list, you probably want to check for emptiness.","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"}],"marconi/queues/storage/sqlalchemy/messages.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"            trans.execute(statement.where(sa.and_(*and_stmt)))"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def pop(self, queue_name, pop_limit, project\u003dNone):"},{"line_number":297,"context_line":"        if project is None:"},{"line_number":298,"context_line":"            project \u003d \u0027\u0027"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_bda129ab","line":296,"updated":"2014-06-10 20:35:49.000000000","message":"Bug: Perhaps I missed it, but this doesn\u0027t seem to filter out messages that are claimed?","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"80a0ddb90379067e604d1d24c5b23bebea8ada4b","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"            trans.execute(statement.where(sa.and_(*and_stmt)))"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def pop(self, queue_name, pop_limit, project\u003dNone):"},{"line_number":297,"context_line":"        if project is None:"},{"line_number":298,"context_line":"            project \u003d \u0027\u0027"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_914b5ab0","line":296,"in_reply_to":"1ae5cdf2_bda129ab","updated":"2014-06-11 14:37:45.000000000","message":"will fix this","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"b2c75ccac600bc6a2cf3d10390619f41bb0ab079","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            now \u003d timeutils.utcnow_ts()"},{"line_number":320,"context_line":"            messages \u003d []"},{"line_number":321,"context_line":"            message_ids \u003d []"},{"line_number":322,"context_line":"            for id, body, ttl, created in records:"},{"line_number":323,"context_line":"                messages.append({"},{"line_number":324,"context_line":"                    \u0027id\u0027: utils.msgid_encode(id),"},{"line_number":325,"context_line":"                    \u0027ttl\u0027: ttl,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_cb291c8b","line":322,"updated":"2014-06-16 19:22:54.000000000","message":"Suggestion : Could we do a list comprehension?\nI also see that bulk_get returns a generator, do we want to do the same?\nThoughts?","commit_id":"685c9e88e62f0a4ad3505c0e8d9c80731d9e9002"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"d85222f0b59b20fbfa08f32e578fb4192b7796af","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            now \u003d timeutils.utcnow_ts()"},{"line_number":320,"context_line":"            messages \u003d []"},{"line_number":321,"context_line":"            message_ids \u003d []"},{"line_number":322,"context_line":"            for id, body, ttl, created in records:"},{"line_number":323,"context_line":"                messages.append({"},{"line_number":324,"context_line":"                    \u0027id\u0027: utils.msgid_encode(id),"},{"line_number":325,"context_line":"                    \u0027ttl\u0027: ttl,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_5c005402","line":322,"in_reply_to":"1ae5cdf2_81ec55f5","updated":"2014-06-17 13:13:04.000000000","message":"Thanks for the reply Kurt! It makes sense.","commit_id":"685c9e88e62f0a4ad3505c0e8d9c80731d9e9002"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"6feabf1d91ed66054c3e21ed7b4037c4f7e9d393","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            now \u003d timeutils.utcnow_ts()"},{"line_number":320,"context_line":"            messages \u003d []"},{"line_number":321,"context_line":"            message_ids \u003d []"},{"line_number":322,"context_line":"            for id, body, ttl, created in records:"},{"line_number":323,"context_line":"                messages.append({"},{"line_number":324,"context_line":"                    \u0027id\u0027: utils.msgid_encode(id),"},{"line_number":325,"context_line":"                    \u0027ttl\u0027: ttl,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_81ec55f5","line":322,"in_reply_to":"1ae5cdf2_cb291c8b","updated":"2014-06-16 20:45:59.000000000","message":"IMO: The code as written is a little bit more terse than it would be if converted to list comprehensions or yield. The for loop approach let\u0027s us build up the result list of messages, as well as the list of ids to append, in a single pass through the collection of records. If using a generator, instead, we\u0027d have to do one pass to get the IDs and delete them, then do another pass to yield each message in turn to the caller.\n\nNote also that ClaimController.get and ClaimController.create return lists, not generators.\n\nTL;DR - I think either approach is OK. Given that the current approach is, by definition, already done, I\u0027d just run with it. :)","commit_id":"685c9e88e62f0a4ad3505c0e8d9c80731d9e9002"}],"marconi/queues/transport/validation.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"79b695cebefb273805803223aa9e01d5a7b7e5aa","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"            raise ValidationFailed(msg)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        pop_uplimit \u003d self._limits_conf.max_messages_per_claim"},{"line_number":199,"context_line":"        if pop is not None and not (0 \u003c pop \u003c\u003d pop_uplimit):"},{"line_number":200,"context_line":"            msg \u003d _(u\u0027Pop value must be at least 1 and may not \u0027"},{"line_number":201,"context_line":"                    \u0027be greater than {0}.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F4TY%3D","line":198,"updated":"2014-04-25 15:38:13.000000000","message":"If we are overloading this config setting, we better make sure to mention that in the documentation string for the setting.","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"7ba61b0893a8ff216d1da063f5dff75325fa21bc","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"            raise ValidationFailed(msg)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        pop_uplimit \u003d self._limits_conf.max_messages_per_claim"},{"line_number":199,"context_line":"        if pop is not None and not (0 \u003c pop \u003c\u003d pop_uplimit):"},{"line_number":200,"context_line":"            msg \u003d _(u\u0027Pop value must be at least 1 and may not \u0027"},{"line_number":201,"context_line":"                    \u0027be greater than {0}.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F2do%3D","line":198,"in_reply_to":"AAAAXX%2F%2F4TY%3D","updated":"2014-04-25 19:27:45.000000000","message":"Done","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"79b695cebefb273805803223aa9e01d5a7b7e5aa","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        delete_uplimit \u003d self._limits_conf.max_messages_per_page"},{"line_number":206,"context_line":"        if ids is not None and not (0 \u003c len(ids) \u003c\u003d delete_uplimit):"},{"line_number":207,"context_line":"            msg \u003d _(u\u0027ids parameter should have at least 1 and  not \u0027"},{"line_number":208,"context_line":"                    \u0027greater than {0} values.\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            raise ValidationFailed(msg, delete_uplimit)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F4T4%3D","line":207,"updated":"2014-04-25 15:38:13.000000000","message":"Remove extra space between \"and\" and \"not\"","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"7ba61b0893a8ff216d1da063f5dff75325fa21bc","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        delete_uplimit \u003d self._limits_conf.max_messages_per_page"},{"line_number":206,"context_line":"        if ids is not None and not (0 \u003c len(ids) \u003c\u003d delete_uplimit):"},{"line_number":207,"context_line":"            msg \u003d _(u\u0027ids parameter should have at least 1 and  not \u0027"},{"line_number":208,"context_line":"                    \u0027greater than {0} values.\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            raise ValidationFailed(msg, delete_uplimit)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F2dg%3D","line":207,"in_reply_to":"AAAAXX%2F%2F4T4%3D","updated":"2014-04-25 19:27:45.000000000","message":"Done","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2a434ced625be45ff2a016675a3ae178c5c6e476","unresolved":false,"context_lines":[{"line_number":32,"context_line":"               deprecated_name\u003d\u0027message_paging_uplimit\u0027,"},{"line_number":33,"context_line":"               deprecated_group\u003d\u0027limits:transport\u0027),"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027max_messages_per_claim\u0027, default\u003d20,"},{"line_number":36,"context_line":"               help\u003d\u0027The maximum number of messages that can be claimed (OR) \u0027"},{"line_number":37,"context_line":"                    \u0027popped in a single request\u0027),"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_87fe3304","line":35,"updated":"2014-05-21 12:11:13.000000000","message":"I\u0027d prefer to rename this option: `max_messages_per_claim_and_pop` or `max_messages_per_op` or something better than that.","commit_id":"ac2bac99021396f9cbc73f63bc47d93bc9b4739e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2a434ced625be45ff2a016675a3ae178c5c6e476","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        :raises: ValidationFailed if pop AND id params are present together"},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if pop and ids:"},{"line_number":195,"context_line":"            msg \u003d _(u\u0027pop and id params cannot be present together in the \u0027"},{"line_number":196,"context_line":"                    \u0027delete request.\u0027)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_6c7d8eb1","line":194,"updated":"2014-05-21 12:11:13.000000000","message":"if pop is not None and ids is not None","commit_id":"ac2bac99021396f9cbc73f63bc47d93bc9b4739e"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"6b4df985ba55085a20efb7008aee57c34ba40493","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        :raises: ValidationFailed if pop AND id params are present together"},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if pop is not None and ids is not None:"},{"line_number":196,"context_line":"            msg \u003d _(u\u0027pop and id params cannot be present together in the \u0027"},{"line_number":197,"context_line":"                    \u0027delete request.\u0027)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_efd3fb5c","line":195,"updated":"2014-06-10 19:19:20.000000000","message":"Thought:\nif pop and ids: would also work here","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"67b5be8ceb0e91da31bb8f473f9e5e117669939c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        :raises: ValidationFailed if pop AND id params are present together"},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if pop is not None and ids is not None:"},{"line_number":196,"context_line":"            msg \u003d _(u\u0027pop and id params cannot be present together in the \u0027"},{"line_number":197,"context_line":"                    \u0027delete request.\u0027)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_5221effa","line":195,"in_reply_to":"1ae5cdf2_d274249e","updated":"2014-06-10 22:18:43.000000000","message":"I see, thanks for enlightening :)","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        :raises: ValidationFailed if pop AND id params are present together"},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if pop is not None and ids is not None:"},{"line_number":196,"context_line":"            msg \u003d _(u\u0027pop and id params cannot be present together in the \u0027"},{"line_number":197,"context_line":"                    \u0027delete request.\u0027)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d274249e","line":195,"in_reply_to":"1ae5cdf2_efd3fb5c","updated":"2014-06-10 20:35:49.000000000","message":"OK: Not necessarily... we are checking for their presence in the request. They may be present, but be \u0027[]\u0027 and \u00270\u0027, respectively, in which case the simple \"if pop and ids\" statement would eval to true.\n\nI think this is best left as-is.","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"0891b19baec6516899cf3b79a26f8c4d74c29074","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        :param ids: message ids passed in by the delete request"},{"line_number":190,"context_line":"        :param pop: count of messages to be POPped"},{"line_number":191,"context_line":"        :raises: ValidationFailed if pop AND id params are present together"},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if pop is not None and ids is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_02e13afc","line":191,"updated":"2014-06-23 16:47:35.000000000","message":"NIT: It would be good to mention all the cases that ValidationFailed might be raised, OR just have a blanket statement, rather than calling out just one specific case.","commit_id":"04dff53a7a1590d13da835a919f4b9373d469ac0"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4347c8b4cbb681b206e3636f7f9a4b6215902a54","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        :param ids: message ids passed in by the delete request"},{"line_number":190,"context_line":"        :param pop: count of messages to be POPped"},{"line_number":191,"context_line":"        :raises: ValidationFailed if pop AND id params are present together"},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if pop is not None and ids is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_cfce962d","line":191,"in_reply_to":"1ae5cdf2_02e13afc","updated":"2014-06-23 18:30:51.000000000","message":"oops..tht was an oversight.Fixing this.","commit_id":"04dff53a7a1590d13da835a919f4b9373d469ac0"}],"marconi/queues/transport/wsgi/v1_1/messages.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"79b695cebefb273805803223aa9e01d5a7b7e5aa","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            LOG.debug(ex)"},{"line_number":236,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(six.text_type(ex))"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        if ids:"},{"line_number":239,"context_line":"            try:"},{"line_number":240,"context_line":"                self.message_controller.bulk_delete("},{"line_number":241,"context_line":"                    queue_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F4aE%3D","line":238,"updated":"2014-04-25 15:38:13.000000000","message":"I think it would be cleaner to factor out these two branches of the if statement into two helper methods.","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"7ba61b0893a8ff216d1da063f5dff75325fa21bc","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            LOG.debug(ex)"},{"line_number":236,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(six.text_type(ex))"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        if ids:"},{"line_number":239,"context_line":"            try:"},{"line_number":240,"context_line":"                self.message_controller.bulk_delete("},{"line_number":241,"context_line":"                    queue_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F2d0%3D","line":238,"in_reply_to":"AAAAXX%2F%2F4aE%3D","updated":"2014-04-25 19:27:45.000000000","message":"Will split these into helper functions","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"79b695cebefb273805803223aa9e01d5a7b7e5aa","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"                for message in messages:"},{"line_number":266,"context_line":"                    message_id \u003d message[\u0027id\u0027]"},{"line_number":267,"context_line":"                    self.message_controller.delete("},{"line_number":268,"context_line":"                        queue_name,"},{"line_number":269,"context_line":"                        message_id\u003dmessage_id,"},{"line_number":270,"context_line":"                        project\u003dproject_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F4X4%3D","line":267,"updated":"2014-04-25 15:38:13.000000000","message":"I think you could do this in one shot with bulk_delete, right?","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"7ba61b0893a8ff216d1da063f5dff75325fa21bc","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"                for message in messages:"},{"line_number":266,"context_line":"                    message_id \u003d message[\u0027id\u0027]"},{"line_number":267,"context_line":"                    self.message_controller.delete("},{"line_number":268,"context_line":"                        queue_name,"},{"line_number":269,"context_line":"                        message_id\u003dmessage_id,"},{"line_number":270,"context_line":"                        project\u003dproject_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F2d8%3D","line":267,"in_reply_to":"AAAAXX%2F%2F4X4%3D","updated":"2014-04-25 19:27:45.000000000","message":"Correct me if wrong - but I dont think we can pass in claim_id with bulk_delete.","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"79b695cebefb273805803223aa9e01d5a7b7e5aa","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        else:"},{"line_number":281,"context_line":"            title \u003d _(u\u0027Unable to delete\u0027)"},{"line_number":282,"context_line":"            description \u003d _(u\u0027The request should have either \"ids\" or \"pop\" \u0027"},{"line_number":283,"context_line":"                            u\u0027parameter in the request, to be able to delete.\u0027)"},{"line_number":284,"context_line":"            raise falcon.HTTPForbidden(title, description)"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F4aw%3D","line":282,"updated":"2014-04-25 15:38:13.000000000","message":"As of v1.1, ids is not required (https://review.openstack.org/#/c/76093/10/marconi/queues/transport/wsgi/v1_1/messages.py)","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"7ba61b0893a8ff216d1da063f5dff75325fa21bc","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        else:"},{"line_number":281,"context_line":"            title \u003d _(u\u0027Unable to delete\u0027)"},{"line_number":282,"context_line":"            description \u003d _(u\u0027The request should have either \"ids\" or \"pop\" \u0027"},{"line_number":283,"context_line":"                            u\u0027parameter in the request, to be able to delete.\u0027)"},{"line_number":284,"context_line":"            raise falcon.HTTPForbidden(title, description)"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F2dU%3D","line":282,"in_reply_to":"AAAAXX%2F%2F4aw%3D","updated":"2014-04-25 19:27:45.000000000","message":"Done","commit_id":"7af3ce1b4436c6487862944be8f7e6d2a4a202df"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2a434ced625be45ff2a016675a3ae178c5c6e476","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"            #pop \u003d claim + delete"},{"line_number":269,"context_line":"            metadata \u003d {\"ttl\": 300, \"grace\": 300}"},{"line_number":270,"context_line":"            cid, messages \u003d self.claim_controller.create("},{"line_number":271,"context_line":"                queue_name,"},{"line_number":272,"context_line":"                metadata\u003dmetadata,"},{"line_number":273,"context_line":"                project\u003dproject_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_478fcb75","line":270,"updated":"2014-05-21 12:11:13.000000000","message":"mmh, I think this belongs to the store driver. Doing a claim and then iterating over messages is not performant enough. If we move this to the store driver, we can get and delete messages in one shot for most of the stores. Some stores may require iterating but lets choose that in a per-store basis.","commit_id":"ac2bac99021396f9cbc73f63bc47d93bc9b4739e"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"cb5ce2741be7d2434ff9da8ac16c502a5a03c4e0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # status defaults to 200"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def on_delete(self, req, resp, project_id, queue_name):"},{"line_number":221,"context_line":"        LOG.debug(u\u0027Messages collection DELETE - queue: %(queue)s, \u0027"},{"line_number":222,"context_line":"                  u\u0027project: %(project)s\u0027,"},{"line_number":223,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_cf747f9e","line":221,"updated":"2014-06-10 19:13:54.000000000","message":"Just a Thought here, do we want to log after actually deleting the messages?","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"80a0ddb90379067e604d1d24c5b23bebea8ada4b","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # status defaults to 200"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def on_delete(self, req, resp, project_id, queue_name):"},{"line_number":221,"context_line":"        LOG.debug(u\u0027Messages collection DELETE - queue: %(queue)s, \u0027"},{"line_number":222,"context_line":"                  u\u0027project: %(project)s\u0027,"},{"line_number":223,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d1ea420e","line":221,"in_reply_to":"1ae5cdf2_cf747f9e","updated":"2014-06-11 14:37:45.000000000","message":"This appears to be the style followed in the rest of the code.\nAlso see on_post, on_get etc.\nIf you feel strongly about this, we can update all the log lines to be after the actual operation, in a separate patch","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"8f386434c2c6c0d22f1c633320e7c916cd698520","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # status defaults to 200"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def on_delete(self, req, resp, project_id, queue_name):"},{"line_number":221,"context_line":"        LOG.debug(u\u0027Messages collection DELETE - queue: %(queue)s, \u0027"},{"line_number":222,"context_line":"                  u\u0027project: %(project)s\u0027,"},{"line_number":223,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f1373efd","line":221,"in_reply_to":"1ae5cdf2_d1ea420e","updated":"2014-06-11 14:40:37.000000000","message":"Fair Enough :) , we can talk about this.","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"cb5ce2741be7d2434ff9da8ac16c502a5a03c4e0","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def _pop_messages(self, queue_name, project_id, pop_limit):"},{"line_number":262,"context_line":"        try:"},{"line_number":263,"context_line":"            LOG.debug(u\u0027POP messages - queue: %(queue)s, \u0027"},{"line_number":264,"context_line":"                      u\u0027project: %(project)s\u0027,"},{"line_number":265,"context_line":"                      {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_4f686fba","line":263,"updated":"2014-06-10 19:13:54.000000000","message":"Similarly here.","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"6feabf1d91ed66054c3e21ed7b4037c4f7e9d393","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                                                        project_id,"},{"line_number":241,"context_line":"                                                        pop_limit)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        else:"},{"line_number":244,"context_line":"            description \u003d _(u\u0027The request should have either \"ids\" or \"pop\" \u0027"},{"line_number":245,"context_line":"                            u\u0027parameter in the request, to be able to delete.\u0027)"},{"line_number":246,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(description)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_21f62191","line":243,"updated":"2014-06-16 20:45:59.000000000","message":"NIT: Seems like this check should go in the validation method, \"message_deletion\", called on L228. What do you think?","commit_id":"685c9e88e62f0a4ad3505c0e8d9c80731d9e9002"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"0891b19baec6516899cf3b79a26f8c4d74c29074","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            description \u003d _(u\u0027Messages could not be popped.\u0027)"},{"line_number":282,"context_line":"            raise wsgi_errors.HTTPServiceUnavailable(description)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        messages \u003d utils.to_json(messages)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return falcon.HTTP_200, messages"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_76e1df29","line":284,"updated":"2014-06-23 16:47:35.000000000","message":"BUG: Messages list should be wrapped in a JSON object (Python dict) per the spec:\n\nhttps://wiki.openstack.org/wiki/Marconi/specs/api/v1.1#Delete_Multiple_Messages\n\nThis provides consistency with other response bodies, and also mitigates a security vulnerability when parsing responses from an XHR in outdated browsers (this is in anticipation of introducing support for direct JavaScript queries to marconi).","commit_id":"04dff53a7a1590d13da835a919f4b9373d469ac0"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4347c8b4cbb681b206e3636f7f9a4b6215902a54","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            description \u003d _(u\u0027Messages could not be popped.\u0027)"},{"line_number":282,"context_line":"            raise wsgi_errors.HTTPServiceUnavailable(description)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        messages \u003d utils.to_json(messages)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return falcon.HTTP_200, messages"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_8fc48e0f","line":284,"in_reply_to":"1ae5cdf2_76e1df29","updated":"2014-06-23 18:30:51.000000000","message":"Done","commit_id":"04dff53a7a1590d13da835a919f4b9373d469ac0"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"001f1b4cc8f962b6400dc36549953399c70ab82a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        ids \u003d req.get_param_as_list(\u0027ids\u0027)"},{"line_number":238,"context_line":"        pop_limit \u003d req.get_param_as_int(\u0027pop\u0027)"},{"line_number":239,"context_line":"        try:"},{"line_number":240,"context_line":"            self._validate.message_deletion(ids, pop_limit)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dab895d6_0d79732f","line":238,"updated":"2014-06-30 08:08:54.000000000","message":"Should we raise a `400` error if `ids` and `pop` are both passed?","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"32b47bab15feba4cc64d124e54bd05cdd82fbfc6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        ids \u003d req.get_param_as_list(\u0027ids\u0027)"},{"line_number":238,"context_line":"        pop_limit \u003d req.get_param_as_int(\u0027pop\u0027)"},{"line_number":239,"context_line":"        try:"},{"line_number":240,"context_line":"            self._validate.message_deletion(ids, pop_limit)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_734da5c3","line":238,"in_reply_to":"dab895d6_0d79732f","updated":"2014-07-07 15:14:21.000000000","message":"That validation is done here https://review.openstack.org/#/c/90202/10/marconi/queues/transport/validation.py. See line #200","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"700c1ac9f0bdef9a6cdec4a1fa07529897ab8eaf","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            LOG.exception(ex)"},{"line_number":264,"context_line":"            description \u003d _(u\u0027Messages could not be deleted.\u0027)"},{"line_number":265,"context_line":"            raise wsgi_errors.HTTPServiceUnavailable(description)"},{"line_number":266,"context_line":"        return falcon.HTTP_204"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _pop_messages(self, queue_name, project_id, pop_limit):"},{"line_number":269,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_ff863ada","line":266,"updated":"2014-07-11 05:57:35.000000000","message":"how about an empty line here?","commit_id":"4b02857caba37ad13e8820d114919887f8170776"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"b387adce26cf37add783758405312c9a69607626","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            LOG.exception(ex)"},{"line_number":264,"context_line":"            description \u003d _(u\u0027Messages could not be deleted.\u0027)"},{"line_number":265,"context_line":"            raise wsgi_errors.HTTPServiceUnavailable(description)"},{"line_number":266,"context_line":"        return falcon.HTTP_204"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _pop_messages(self, queue_name, project_id, pop_limit):"},{"line_number":269,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_a9b8fb11","line":266,"in_reply_to":"baada198_ff863ada","updated":"2014-07-11 16:28:42.000000000","message":"Done","commit_id":"4b02857caba37ad13e8820d114919887f8170776"}],"tests/etc/functional-marconi.conf":[{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"700c1ac9f0bdef9a6cdec4a1fa07529897ab8eaf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Maximum number of messages per page when listing messages."},{"line_number":41,"context_line":";max_messages_per_page \u003d 20"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Maximum number of messages that can be claimed at a time."},{"line_number":44,"context_line":";max_messages_per_claim_or_pop \u003d 20"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Expiration limits; the minimal values are all 60 (seconds)"}],"source_content_type":"text/plain","patch_set":13,"id":"baada198_1fe76e13","line":43,"updated":"2014-07-11 05:57:35.000000000","message":"we may need to modify the comments to add \u0027pop\u0027","commit_id":"4b02857caba37ad13e8820d114919887f8170776"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"b387adce26cf37add783758405312c9a69607626","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Maximum number of messages per page when listing messages."},{"line_number":41,"context_line":";max_messages_per_page \u003d 20"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Maximum number of messages that can be claimed at a time."},{"line_number":44,"context_line":";max_messages_per_claim_or_pop \u003d 20"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Expiration limits; the minimal values are all 60 (seconds)"}],"source_content_type":"text/plain","patch_set":13,"id":"baada198_8969778e","line":43,"in_reply_to":"baada198_1fe76e13","updated":"2014-07-11 16:28:42.000000000","message":"Done","commit_id":"4b02857caba37ad13e8820d114919887f8170776"}],"tests/functional/wsgi/v1_1/test_messages.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ef2ce84873176178501068cc35b86e7cfcfb289c","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        messages \u003d result.json()[\u0027messages\u0027]"},{"line_number":325,"context_line":"        self.assertEqual(messages, [])"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    test_messages_pop_empty_queue.tags \u003d [\u0027smoke\u0027, \u0027negative\u0027]"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def test_message_partial_get(self):"},{"line_number":330,"context_line":"        \"\"\"Get Messages will be partially successful.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_ef341e4c","line":327,"updated":"2014-07-09 12:01:10.000000000","message":"Could you add a test where you pop 1 message out of the queue and verify that the remaining messages are still in the queue?","commit_id":"a3642c54b86464da78c2444f6d5845e2fa180509"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"b6c584246e4235af2abf9dc2e45c974d93d46132","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        messages \u003d result.json()[\u0027messages\u0027]"},{"line_number":324,"context_line":"        self.assertEqual(messages, [])"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    test_messages_pop_empty_queue.tags \u003d [\u0027smoke\u0027, \u0027negative\u0027]"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def test_messages_pop_one(self):"},{"line_number":329,"context_line":"        \"\"\"Pop single messages from a queue.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_cb2efc8b","line":326,"updated":"2014-07-11 20:17:43.000000000","message":"NIT: Should this be a \u0027positive\u0027 test, since it is testing whether popping from an empty queue *succeeds* as expected?","commit_id":"ff9b9c50d3e4c153f908a3253b80915dab26f8b1"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5e2c1a1191b354016e51335d84256f87ca7a48e1","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        messages \u003d result.json()[\u0027messages\u0027]"},{"line_number":324,"context_line":"        self.assertEqual(messages, [])"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    test_messages_pop_empty_queue.tags \u003d [\u0027smoke\u0027, \u0027negative\u0027]"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def test_messages_pop_one(self):"},{"line_number":329,"context_line":"        \"\"\"Pop single messages from a queue.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_1f001933","line":326,"in_reply_to":"baada198_cb2efc8b","updated":"2014-07-14 05:25:31.000000000","message":"+1","commit_id":"ff9b9c50d3e4c153f908a3253b80915dab26f8b1"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"b6c584246e4235af2abf9dc2e45c974d93d46132","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        actual_msg_count \u003d len(result.json()[\u0027messages\u0027])"},{"line_number":350,"context_line":"        self.assertEqual(expected_msg_count, actual_msg_count)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    test_messages_pop_one.tags \u003d [\u0027smoke\u0027, \u0027negative\u0027]"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def test_message_partial_get(self):"},{"line_number":355,"context_line":"        \"\"\"Get Messages will be partially successful.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_0b5474fd","line":352,"updated":"2014-07-11 20:17:43.000000000","message":"NIT: Should this be a \u0027positive\u0027 test, since it is testing whether popping a single message *succeeds* as expected?","commit_id":"ff9b9c50d3e4c153f908a3253b80915dab26f8b1"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5e2c1a1191b354016e51335d84256f87ca7a48e1","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        actual_msg_count \u003d len(result.json()[\u0027messages\u0027])"},{"line_number":350,"context_line":"        self.assertEqual(expected_msg_count, actual_msg_count)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    test_messages_pop_one.tags \u003d [\u0027smoke\u0027, \u0027negative\u0027]"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def test_message_partial_get(self):"},{"line_number":355,"context_line":"        \"\"\"Get Messages will be partially successful.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_3ff95d4e","line":352,"in_reply_to":"baada198_0b5474fd","updated":"2014-07-14 05:25:31.000000000","message":"+1","commit_id":"ff9b9c50d3e4c153f908a3253b80915dab26f8b1"}],"tests/unit/queues/transport/wsgi/test_v1_1.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"515dd46d6421324c0d1497d9f860d54975940df9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertEqual(response, [])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class TestDeprecated(wsgi.TestBase):"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    config_file \u003d \u0027wsgi_sqlalchemy.conf\u0027"},{"line_number":139,"context_line":"    queue_path \u003d \u0027/v1.1/queues/test-queue\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d89e03b8","line":136,"updated":"2014-06-10 20:35:49.000000000","message":"SCM: I think this test is not needed - looks like it was accidentally brought in from a rebase or something.","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"80a0ddb90379067e604d1d24c5b23bebea8ada4b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertEqual(response, [])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class TestDeprecated(wsgi.TestBase):"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    config_file \u003d \u0027wsgi_sqlalchemy.conf\u0027"},{"line_number":139,"context_line":"    queue_path \u003d \u0027/v1.1/queues/test-queue\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f1bc9ebd","line":136,"in_reply_to":"1ae5cdf2_d89e03b8","updated":"2014-06-11 14:37:45.000000000","message":"Done","commit_id":"c22614fff63f16ae2ac9ee79c073a996a5ef0959"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"0891b19baec6516899cf3b79a26f8c4d74c29074","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        result_doc \u003d json.loads(result[0])"},{"line_number":183,"context_line":"        self.assertEqual(len(result_doc), message_count)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self.simulate_get(target, self.project_id)"},{"line_number":186,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_404)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_d6b1d302","line":183,"updated":"2014-06-23 16:47:35.000000000","message":"I suppose we should also validate the schema of each message?","commit_id":"04dff53a7a1590d13da835a919f4b9373d469ac0"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4347c8b4cbb681b206e3636f7f9a4b6215902a54","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        result_doc \u003d json.loads(result[0])"},{"line_number":183,"context_line":"        self.assertEqual(len(result_doc), message_count)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self.simulate_get(target, self.project_id)"},{"line_number":186,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_404)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_6a5c901a","line":183,"in_reply_to":"1ae5cdf2_d6b1d302","updated":"2014-06-23 18:30:51.000000000","message":"I was planning on doing the schema validation in functional tests (once Alex\u0027s v1.1 functional tests patch is merged), since none of the unit tests do schema validation (unless I am missing something?)","commit_id":"04dff53a7a1590d13da835a919f4b9373d469ac0"},{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"3d03218e7b772eca3d9e9d4e92f3f04cc3c3f552","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                      query_string\u003dquery_string)"},{"line_number":180,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        result_doc \u003d json.loads(result[0])"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self.assertEqual(len(result_doc[\u0027messages\u0027]), message_count)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_9e5dbd4b","line":182,"updated":"2014-06-30 15:13:23.000000000","message":"for py3  support it is better to use jsonutils.loads for decoding body, since it py33 the result of simulate methods is bytes, not string. (You can see tests failing on py33)","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"3d03218e7b772eca3d9e9d4e92f3f04cc3c3f552","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                      query_string\u003dquery_string)"},{"line_number":201,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        result_doc \u003d json.loads(result[0])"},{"line_number":204,"context_line":"        self.assertEqual(result_doc[\u0027messages\u0027], [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_fe54f922","line":203,"updated":"2014-06-30 15:13:23.000000000","message":"same here","commit_id":"f540fec285ad873adcd52869ee1bc79425470e9a"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ef2ce84873176178501068cc35b86e7cfcfb289c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        result_doc \u003d jsonutils.loads(result[0])"},{"line_number":203,"context_line":"        self.assertEqual(result_doc[\u0027messages\u0027], [])"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_8f4ac2aa","line":203,"updated":"2014-07-09 12:01:10.000000000","message":"(same test request here)","commit_id":"a3642c54b86464da78c2444f6d5845e2fa180509"}]}
