)]}'
{".gitignore":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.bak"},{"line_number":2,"context_line":"*.DS_Store"},{"line_number":3,"context_line":"target/"},{"line_number":4,"context_line":".idea/"},{"line_number":5,"context_line":"*.pyc"},{"line_number":6,"context_line":"*.dat"},{"line_number":7,"context_line":"TAGS"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7adec928_ea561e05","line":4,"updated":"2014-05-19 13:45:18.000000000","message":"We don\u0027t need this change here.","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"}],"/COMMIT_MSG":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"62903f76fcd28270e7c8910bf35b0376ba70fca2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Added new json schemas"},{"line_number":12,"context_line":"Edited functional test base to support multiple schemas"},{"line_number":13,"context_line":"Change-Id: I35dfb92af22540609ecb50c1eb5c8fa65e6cadc8"},{"line_number":14,"context_line":"Implements: blueprint api-v1.1-functional-tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1ae5cdf2_a67a23ee","line":14,"updated":"2014-06-24 20:08:05.000000000","message":"NIT: Should be \"Partially-Implements\", e.g.: https://review.openstack.org/#/c/98777/3//COMMIT_MSG","commit_id":"1522c249640e5f61bf514a7c97e5e2ad3043713a"}],"marconi/queues/api/v1/response.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    \"properties\": {"},{"line_number":31,"context_line":"                        \"href\": {"},{"line_number":32,"context_line":"                            \"type\": \"string\","},{"line_number":33,"context_line":"                            \"pattern\": \"^v1/queues/[a-zA-Z0-9_-]{1,64}\""},{"line_number":34,"context_line":"                            \"/messages/[a-zA-Z0-9_-]+)$\""},{"line_number":35,"context_line":"                        },"},{"line_number":36,"context_line":"                        \"ttl\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_2a99e6c3","line":33,"updated":"2014-05-19 13:45:18.000000000","message":"why do you need to remove   (/  ?","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                },"},{"line_number":68,"context_line":"                                \u0027href\u0027: {"},{"line_number":69,"context_line":"                                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":70,"context_line":"                                    \"pattern\": \"/v[0-9]*(\\.[0-9]+)?/queues\\?\","},{"line_number":71,"context_line":"                                }"},{"line_number":72,"context_line":"                            },"},{"line_number":73,"context_line":"                            \u0027required\u0027: [\u0027rel\u0027, \u0027href\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_4a94728a","line":70,"updated":"2014-05-19 13:45:18.000000000","message":"We should keep this as /v1 , since this checks the responses from the v1 API.","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ResponseSchema(api.Api):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    \"\"\"Define validation schema for json response.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, limits):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_a484840b","line":20,"updated":"2014-06-12 01:49:53.000000000","message":"I am guessing you didn\u0027t intend to change this file?","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"}],"marconi/queues/api/v1_1/__init__.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"__author__ \u003d \u0027abettadapur\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_6a8f6e75","line":1,"updated":"2014-05-19 13:45:18.000000000","message":"We usually don\u0027t add the author in init files. Just leave this file empty","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"}],"marconi/queues/api/v1_1/request.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            },"},{"line_number":39,"context_line":"        },"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        \u0027queue_exists\u0027: {"},{"line_number":42,"context_line":"            \u0027ref\u0027: \u0027queues/{queue_name}\u0027,"},{"line_number":43,"context_line":"            \u0027method\u0027: \u0027HEAD\u0027,"},{"line_number":44,"context_line":"            \u0027required\u0027: [\u0027queue_name\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_64951c32","line":41,"updated":"2014-06-12 01:49:53.000000000","message":"With our recent decision, we\u0027ll no longer have this endpoint in v1.1","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            }"},{"line_number":110,"context_line":"        },"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        \u0027message_get\u0027: {"},{"line_number":113,"context_line":"            \u0027ref\u0027: \u0027queues/{queue_name}/messages/{message_id}\u0027,"},{"line_number":114,"context_line":"            \u0027method\u0027: \u0027GET\u0027,"},{"line_number":115,"context_line":"            \u0027required\u0027: [\u0027queue_name\u0027, \u0027message_id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_04d8d81c","line":112,"updated":"2014-06-12 01:49:53.000000000","message":"We\u0027ll no longer have get message by ids in v1.1","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \u0027message_get_many\u0027: {"},{"line_number":123,"context_line":"            \u0027ref\u0027: \u0027queues/{queue_name}/messages\u0027,"},{"line_number":124,"context_line":"            \u0027method\u0027: \u0027GET\u0027,"},{"line_number":125,"context_line":"            \u0027required\u0027: [\u0027queue_name\u0027, \u0027ids\u0027],"},{"line_number":126,"context_line":"            \u0027properties\u0027: {"},{"line_number":127,"context_line":"                \u0027queue_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":128,"context_line":"                \u0027ids\u0027: {\u0027type\u0027: \u0027array\u0027}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_c4f8b07e","line":125,"updated":"2014-06-12 01:49:53.000000000","message":"same here","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            \u0027properties\u0027: {"},{"line_number":137,"context_line":"                \u0027queue_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":138,"context_line":"                \u0027message_id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":139,"context_line":"                \u0027claim_id\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":140,"context_line":"            }"},{"line_number":141,"context_line":"        },"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_84adc886","line":139,"updated":"2014-06-12 01:49:53.000000000","message":"we\u0027ll also have pop.\n\u0027pop\u0027: {\u0027type\u0027: \u0027integer\u0027}","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"}],"marconi/queues/api/v1_1/response.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    \"properties\": {"},{"line_number":31,"context_line":"                        \"href\": {"},{"line_number":32,"context_line":"                            \"type\": \"string\","},{"line_number":33,"context_line":"                            \"pattern\": \"^v1/queues/[a-zA-Z0-9_-]{1,64}\""},{"line_number":34,"context_line":"                            \"/messages/[a-zA-Z0-9_-]+)$\""},{"line_number":35,"context_line":"                        },"},{"line_number":36,"context_line":"                        \"ttl\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_caefa21c","line":33,"updated":"2014-05-19 13:45:18.000000000","message":"This would be /v1.1","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                },"},{"line_number":68,"context_line":"                                \u0027href\u0027: {"},{"line_number":69,"context_line":"                                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":70,"context_line":"                                    \"pattern\": \"/v[0-9]*(\\.[0-9]+)?/queues\\?\","},{"line_number":71,"context_line":"                                }"},{"line_number":72,"context_line":"                            },"},{"line_number":73,"context_line":"                            \u0027required\u0027: [\u0027rel\u0027, \u0027href\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_eaf29e04","line":70,"updated":"2014-05-19 13:45:18.000000000","message":"v1.1 again","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class ResponseSchema(api.Api):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    \"\"\"Define validation schema for json response.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, limits):"},{"line_number":24,"context_line":"        self.limits \u003d limits"},{"line_number":25,"context_line":"        self.schema \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_241a34c6","line":22,"updated":"2014-06-12 01:49:53.000000000","message":"Can you also include the schema definitions for all the API\u0027s we currently have in https://github.com/openstack/marconi/blob/master/marconi/queues/api/v1/response.py ?","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"}],"marconi/tests/functional/base.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        validator \u003d validation.Validator(self.mconf)"},{"line_number":64,"context_line":"        self.limits \u003d validator._limits_conf"},{"line_number":65,"context_line":"        if self.cfg.marconi.version \u003d\u003d \"v1.1\":"},{"line_number":66,"context_line":"            self.response \u003d response_v1_1.ResponseSchema(self.limits)"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            self.response \u003d response.ResponseSchema(self.limits)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_8abe7aac","line":65,"updated":"2014-05-19 13:45:18.000000000","message":"We need to remove the marconi version from the cfg file.\nMaybe we could just move the version to the tests itself.\nOr have separate base classes for each version, \u0026 move the version specification to the base class?","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"910043235eded5549d4eb1c257e41904e0421adb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from marconi.openstack.common import timeutils"},{"line_number":24,"context_line":"from marconi.queues.api.v1 import response"},{"line_number":25,"context_line":"from marconi.queues.api.v1_1 import response as response_v1_1"},{"line_number":26,"context_line":"from marconi.queues import bootstrap"},{"line_number":27,"context_line":"# TODO(flaper87): This is necessary to register,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_7f1b07ca","line":24,"updated":"2014-06-03 14:46:18.000000000","message":"Let\u0027s import this one as response_v1","commit_id":"ab4acf3c54b8b0970042886ad3796e79bfeca1d6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"896fd1549633043bf602954c623954b8201bc45a","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        super(V1_1FunctionalTestBase, self).setUp()"},{"line_number":287,"context_line":"        self.response \u003d response_v1_1.ResponseSchema(self.limits)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def assertSchema(self, response, expectedSchemaName):"},{"line_number":290,"context_line":"        \"\"\"Compares the json response with the expected schema"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        :param response: response json returned by the API."}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_5f02cb0c","line":289,"updated":"2014-06-18 13:34:07.000000000","message":"Why do you need to duplicate this method? It looks the same as the one in V1FunctionalTestBase.","commit_id":"ecccd67fa0a301117d920d843ece1cb3c20f466b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ee389a5e569b88ddab08970b6db9b98c30953b7f","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        super(V1_1FunctionalTestBase, self).setUp()"},{"line_number":287,"context_line":"        self.response \u003d response_v1_1.ResponseSchema(self.limits)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def assertSchema(self, response, expectedSchemaName):"},{"line_number":290,"context_line":"        \"\"\"Compares the json response with the expected schema"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        :param response: response json returned by the API."}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_453e7eb9","line":289,"in_reply_to":"1ae5cdf2_5aff39ab","updated":"2014-06-18 13:52:36.000000000","message":"I guess you could use the v1 schema as the default and just override it in the V1_1 test. Another way is to not have any default and assume it\u0027ll be set by the children. If it\u0027s not set, you can skip the test.","commit_id":"ecccd67fa0a301117d920d843ece1cb3c20f466b"},{"author":{"_account_id":11399,"name":"Alex Bettadapur","email":"alexbettadapur@gmail.com","username":"abettadapur"},"change_message_id":"ab325a3382fbc3019273667252b80280b9edbe76","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        super(V1_1FunctionalTestBase, self).setUp()"},{"line_number":287,"context_line":"        self.response \u003d response_v1_1.ResponseSchema(self.limits)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def assertSchema(self, response, expectedSchemaName):"},{"line_number":290,"context_line":"        \"\"\"Compares the json response with the expected schema"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        :param response: response json returned by the API."}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_5aff39ab","line":289,"in_reply_to":"1ae5cdf2_5f02cb0c","updated":"2014-06-18 13:37:10.000000000","message":"We are using two different response schemas. Notice response_v1 and response_v1_1. Is there a better way to do this?","commit_id":"ecccd67fa0a301117d920d843ece1cb3c20f466b"}],"tests/etc/functional-marconi.conf":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Show more verbose log output (sets INFO log level output)"},{"line_number":3,"context_line":";verbose \u003d False"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Show debugging output in logs (sets DEBUG log level output)"}],"source_content_type":"text/plain","patch_set":3,"id":"7adec928_4af63290","line":2,"updated":"2014-05-19 13:45:18.000000000","message":"I guess you intended up submitting the conf file you used to run the tests.\nLets just keep the original conf file - unless you have any changes you want to submit.","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"}],"tests/etc/functional-tests.conf":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7adec928_2a29e6e5","updated":"2014-05-19 13:45:18.000000000","message":"Again, lets keep the original conf file","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"}],"tests/functional/wsgi/v1/test_claims.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        for i in range(10):"},{"line_number":50,"context_line":"            self.client.post(url, data\u003ddoc)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @ddt.data({\u0027limit\u0027: 10}, dict(limit\u003d2))"},{"line_number":53,"context_line":"    def test_claim_messages(self, params):"},{"line_number":54,"context_line":"        \"\"\"Claim messages.\"\"\""},{"line_number":55,"context_line":"        message_count \u003d params.get(\u0027limit\u0027, 10)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_4a24720c","line":52,"updated":"2014-05-19 13:45:18.000000000","message":"we need to keep the {}","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        Marconi allows a maximum of 20 messages per claim by default."},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.limits.max_messages_per_claim \u003d 20"},{"line_number":92,"context_line":"        params \u003d {\"limit\": self.limits.max_messages_per_claim + 1}"},{"line_number":93,"context_line":"        doc \u003d {\"ttl\": 300, \"grace\": 100}"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_aa7c16ed","line":91,"updated":"2014-05-19 13:45:18.000000000","message":"This value is read from the conf file. So you dont need to set it here","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"910043235eded5549d4eb1c257e41904e0421adb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        Marconi allows a maximum of 20 messages per claim by default."},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.limits.max_messages_per_claim \u003d 20"},{"line_number":92,"context_line":"        params \u003d {\"limit\": self.limits.max_messages_per_claim + 1}"},{"line_number":93,"context_line":"        doc \u003d {\"ttl\": 300, \"grace\": 100}"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_5ffacb43","line":91,"updated":"2014-06-03 14:46:18.000000000","message":"Lets not hard code this, since this is a configurable value.\nThis value comes from the functional-marconi.conf \u0026 will make it possible to run marconi against different installations","commit_id":"ab4acf3c54b8b0970042886ad3796e79bfeca1d6"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.queue \u003d uuid.uuid1()"},{"line_number":34,"context_line":"        self.queue_url \u003d (\"{url}/{version}/queues/{queue}\".format("},{"line_number":35,"context_line":"                          url\u003dself.cfg.marconi.url,"},{"line_number":36,"context_line":"                          version\u003d\"v1\","},{"line_number":37,"context_line":"                          queue\u003dself.queue))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.client.put(self.queue_url)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_a4d3a4d3","line":36,"updated":"2014-06-12 01:49:53.000000000","message":"Can you also remove the corresponding config option \nhttps://github.com/openstack/marconi/blob/master/tests/etc/functional-tests.conf#L13  (\u0026) \nhttps://github.com/openstack/marconi/blob/master/marconi/tests/functional/config.py#L36","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @ddt.data({}, dict(limit\u003d2))"},{"line_number":53,"context_line":"    def test_claim_messages(self, params):"},{"line_number":54,"context_line":"        \"\"\"Claim messages.\"\"\""},{"line_number":55,"context_line":"        message_count \u003d params.get(\u0027limit\u0027, 10)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        doc \u003d {\"ttl\": 300, \"grace\": 100}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_04e2989f","line":55,"updated":"2014-06-12 01:49:53.000000000","message":"Let\u0027s keep the self.limits.max_messages_per_claim , In case somebody has marconi running with max_messages_per_claim \u003c10","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"}],"tests/functional/wsgi/v1/test_messages.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    test_message_bulk_insert.tags \u003d [\u0027smoke\u0027, \u0027positive\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @ddt.data({\u0027limit\u0027: 10}, {\u0027limit\u0027: 5})"},{"line_number":141,"context_line":"    def test_get_message(self, params):"},{"line_number":142,"context_line":"        \"\"\"Get Messages.\"\"\""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_ca7fa2de","line":140,"updated":"2014-05-19 13:45:18.000000000","message":"lets keep the {}","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"910043235eded5549d4eb1c257e41904e0421adb","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    test_message_bulk_insert.tags \u003d [\u0027smoke\u0027, \u0027positive\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @ddt.data({\u0027limit\u0027: 10}, {\u0027limit\u0027: 5})"},{"line_number":141,"context_line":"    def test_get_message(self, params):"},{"line_number":142,"context_line":"        \"\"\"Get Messages.\"\"\""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_df397bf3","line":140,"updated":"2014-06-03 14:46:18.000000000","message":"Lets keep the {}","commit_id":"ab4acf3c54b8b0970042886ad3796e79bfeca1d6"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if result.status_code \u003d\u003d 200:"},{"line_number":162,"context_line":"                actual_msg_count \u003d len(result.json()[\u0027messages\u0027])"},{"line_number":163,"context_line":"                self.assertMessageCount(actual_msg_count, expected_msg_count)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"                href \u003d result.json()[\u0027links\u0027][0][\u0027href\u0027]"},{"line_number":166,"context_line":"                url \u003d self.cfg.marconi.url + href"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_a4eac471","line":163,"updated":"2014-06-12 01:49:53.000000000","message":"Any reason to get rid of the assertSchema?","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"4e40d5722678a3a2db7fbd594f482c0d6d535ff5","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        url \u003d self.cfg.marconi.url + location"},{"line_number":244,"context_line":"        url +\u003d \u0027,nonexisting\u0027"},{"line_number":245,"context_line":"        result \u003d self.client.get(url)"},{"line_number":246,"context_line":"        self.assertEqual(result.status_code, 200)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    test_message_partial_get.tags \u003d [\u0027negative\u0027]"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_c402703d","line":246,"updated":"2014-06-12 01:49:53.000000000","message":"ditto","commit_id":"5b488c4cda26fdbc3ab4428ac9a44b4b25883a5a"}],"tests/functional/wsgi/v1/test_queues.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"910043235eded5549d4eb1c257e41904e0421adb","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        super(TestQueueMetaData, self).setUp()"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if self.cfg.marconi.version !\u003d \"v1\":"},{"line_number":202,"context_line":"            self.skipTest(\"Not supported\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        self.base_url \u003d \u0027{0}/{1}\u0027.format(self.cfg.marconi.url,"},{"line_number":205,"context_line":"                                         self.cfg.marconi.version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_a514a2a0","line":202,"updated":"2014-06-03 14:46:18.000000000","message":"This will become harder to maintain as we have more versions.\nLet\u0027s remove the marconi.version out of the config file(functional-marconi.conf). It might be a lot easier to set the version in the actual test modules, since we have version specific test modules.","commit_id":"ab4acf3c54b8b0970042886ad3796e79bfeca1d6"}],"tests/functional/wsgi/v1_1/__init__.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"__author__ \u003d \u0027abettadapur\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_4a6b921d","line":1,"updated":"2014-05-19 13:45:18.000000000","message":"Empty init file, please","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"}],"tests/functional/wsgi/v1_1/test_messages.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"fc551e82367aac8302862b1035f2a19a0bef136f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        result \u003d self.client.get(self.message_url)"},{"line_number":103,"context_line":"        self.assertEqual(result.status_code, 204)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_message_pop_too_high(self):"},{"line_number":106,"context_line":"        url \u003d self.message_url+\u0027?pop\u003d21\u0027"},{"line_number":107,"context_line":"        result \u003d self.client.delete(url)"},{"line_number":108,"context_line":"        self.assertEqual(result.status_code, 400)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_4ab2af49","line":105,"updated":"2014-06-13 14:44:01.000000000","message":"Can you add a skiptest for this one as well?","commit_id":"2a31f112284ec395e35c0aded4549d2903a44d48"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"fc551e82367aac8302862b1035f2a19a0bef136f","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        params[\u0027echo\u0027] \u003d True"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # Follow the hrefs \u0026 perform GET, till the end of messages i.e. http"},{"line_number":218,"context_line":"        # 204"},{"line_number":219,"context_line":"        while result.status_code in [201, 200]:"},{"line_number":220,"context_line":"            result \u003d self.client.get(url, params\u003dparams)"},{"line_number":221,"context_line":"            self.assertIn(result.status_code, [200, 204])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_8a3117a4","line":218,"updated":"2014-06-13 14:44:01.000000000","message":"End of messages will no longer be 204 in v1.1\nIt\u0027ll be just a 200 with response body [].\nSo we\u0027ll need to update the check below.\nYu could just add a skiptest with the details in a comment - so we can address this when the feature patchset goes in.","commit_id":"2a31f112284ec395e35c0aded4549d2903a44d48"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"fc551e82367aac8302862b1035f2a19a0bef136f","unresolved":false,"context_lines":[{"line_number":431,"context_line":"    test_delete_non_existing_message.tags \u003d [\u0027negative\u0027]"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"\"\"\"@ddt.ddt"},{"line_number":435,"context_line":"class TestMessagesBadHeaders(base.FunctionalTestBase):"},{"line_number":436,"context_line":"    server_class \u003d base.MarconiServer"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_6a912b46","line":434,"updated":"2014-06-13 14:44:01.000000000","message":"Do you want to clean this up a bit \u0026 move to TestMessages class?","commit_id":"2a31f112284ec395e35c0aded4549d2903a44d48"}],"tox.ini~":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"8b1f7150bd279a700a64251183e5a49c3d93412f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7adec928_2a572659","updated":"2014-05-19 13:45:18.000000000","message":"Any reason the existing tox.ini is not sufficient.","commit_id":"fd33f92b287cb0f0c7910f49a6c27e98ce30fa49"}]}
