)]}'
{"marconi/queues/transport/wsgi/app.py":[{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"31bfe067b5e662ed04c421c1f7384d8955e070c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# to pick up common options from openstack.common.log, since"},{"line_number":35,"context_line":"# that module uses the global CONF instance exclusively."},{"line_number":36,"context_line":"conf \u003d cfg.CONF"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"app \u003d bootstrap.Bootstrap(conf).transport.app"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_0bb749d9","line":37,"updated":"2014-06-10 14:28:55.000000000","message":"Why was it removed?","commit_id":"cd115d159feac7a9bfe54cf5748c3dc8fe1464cf"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4fabb4f111c2bb84b6c52e04e42552c8c37e1783","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# that module uses the global CONF instance exclusively."},{"line_number":36,"context_line":"conf \u003d cfg.CONF"},{"line_number":37,"context_line":"conf(project\u003d\u0027marconi\u0027, prog\u003d\u0027marconi-queues\u0027, args\u003d[])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"app \u003d bootstrap.Bootstrap(conf).transport.app"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_32128409","side":"PARENT","line":38,"updated":"2014-06-11 15:38:00.000000000","message":"Could you please revert this change? It\u0027s unrelated.","commit_id":"32ff9d9d3c5815eb2d7348b52d1bc46dc64f109e"}],"marconi/tests/queues/transport/wsgi/base.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4fabb4f111c2bb84b6c52e04e42552c8c37e1783","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class V1Base(TestBase):"},{"line_number":112,"context_line":"    def setUp(self):"},{"line_number":113,"context_line":"        super(V1Base, self).setUp()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_9217d8ed","line":112,"updated":"2014-06-11 15:38:00.000000000","message":"These `setUp` methods are not doing anything. Mind removing them and adding docstrings instead?","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":11399,"name":"Alex Bettadapur","email":"alexbettadapur@gmail.com","username":"abettadapur"},"change_message_id":"5f6ebff8562f72576461ac96ee14e6f7bb7ace5a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class V1Base(TestBase):"},{"line_number":112,"context_line":"    def setUp(self):"},{"line_number":113,"context_line":"        super(V1Base, self).setUp()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_72240c0d","line":112,"in_reply_to":"1ae5cdf2_9217d8ed","updated":"2014-06-11 15:47:20.000000000","message":"Done","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4fabb4f111c2bb84b6c52e04e42552c8c37e1783","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class V1_1Base(TestBase):"},{"line_number":122,"context_line":"    def setUp(self):"},{"line_number":123,"context_line":"        super(V1_1Base, self).setUp()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def simulate_request(self, path, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d2d40022","line":122,"updated":"2014-06-11 15:38:00.000000000","message":"ditto","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":11399,"name":"Alex Bettadapur","email":"alexbettadapur@gmail.com","username":"abettadapur"},"change_message_id":"5f6ebff8562f72576461ac96ee14e6f7bb7ace5a","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class V1_1Base(TestBase):"},{"line_number":122,"context_line":"    def setUp(self):"},{"line_number":123,"context_line":"        super(V1_1Base, self).setUp()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def simulate_request(self, path, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_921d18c1","line":122,"in_reply_to":"1ae5cdf2_d2d40022","updated":"2014-06-11 15:47:20.000000000","message":"Done","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4fabb4f111c2bb84b6c52e04e42552c8c37e1783","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        super(V1_1Base, self).setUp()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def simulate_request(self, path, **kwargs):"},{"line_number":126,"context_line":"        \"\"\"Simulate a request."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        Simulates a WSGI request to the API for testing."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_92eef8eb","line":126,"updated":"2014-06-11 15:38:00.000000000","message":"Why does this method needs to be overwritten?","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":11399,"name":"Alex Bettadapur","email":"alexbettadapur@gmail.com","username":"abettadapur"},"change_message_id":"5f6ebff8562f72576461ac96ee14e6f7bb7ace5a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        super(V1_1Base, self).setUp()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def simulate_request(self, path, **kwargs):"},{"line_number":126,"context_line":"        \"\"\"Simulate a request."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        Simulates a WSGI request to the API for testing."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_52271012","line":126,"in_reply_to":"1ae5cdf2_92eef8eb","updated":"2014-06-11 15:47:20.000000000","message":"Because V1.1 requires headers, I removed the project-id parameter from the original method because it will be included in the headers anyway. Should I move the original method into V1Base?","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4fabb4f111c2bb84b6c52e04e42552c8c37e1783","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                        self.srmock)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class V1_1BaseFaulty(TestBaseFaulty):"},{"line_number":140,"context_line":"    def setUp(self):"},{"line_number":141,"context_line":"        super(V1_1BaseFaulty, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f2d9fc57","line":139,"updated":"2014-06-11 15:38:00.000000000","message":"ditto","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":11399,"name":"Alex Bettadapur","email":"alexbettadapur@gmail.com","username":"abettadapur"},"change_message_id":"5f6ebff8562f72576461ac96ee14e6f7bb7ace5a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                        self.srmock)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class V1_1BaseFaulty(TestBaseFaulty):"},{"line_number":140,"context_line":"    def setUp(self):"},{"line_number":141,"context_line":"        super(V1_1BaseFaulty, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b21a14c4","line":139,"in_reply_to":"1ae5cdf2_f2d9fc57","updated":"2014-06-11 15:47:20.000000000","message":"Done","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"}],"marconi/tests/queues/transport/wsgi/v1/test_auth.py":[{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"31bfe067b5e662ed04c421c1f7384d8955e070c4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import falcon"},{"line_number":20,"context_line":"from falcon import testing"},{"line_number":21,"context_line":"from keystoneclient.middleware import auth_token"},{"line_number":22,"context_line":"from marconi.tests.queues.transport.wsgi import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestAuth(base.V1Base):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_ebbf7da8","line":22,"updated":"2014-06-10 14:28:55.000000000","message":"Ordering of imports. I think local imports need to be separated using a new line.","commit_id":"cd115d159feac7a9bfe54cf5748c3dc8fe1464cf"}],"marconi/tests/queues/transport/wsgi/v1/test_claims.py":[{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"d059ecd09a77e08afd37ce2d0b28130d4fc2340d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import ddt"},{"line_number":21,"context_line":"import falcon"},{"line_number":22,"context_line":"from marconi.tests.queues.transport.wsgi import base"},{"line_number":23,"context_line":"import mock"},{"line_number":24,"context_line":"from testtools import matchers"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8154a7ca","line":22,"updated":"2014-06-05 14:53:51.000000000","message":"this import should be in the third group, next to other marconi imports.","commit_id":"8c79de2098e6a21540a3991d0e0568b51f7063a2"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"31bfe067b5e662ed04c421c1f7384d8955e070c4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"import falcon"},{"line_number":21,"context_line":"from marconi.tests.queues.transport.wsgi import base"},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"from testtools import matchers"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_abcc9562","line":21,"updated":"2014-06-10 14:28:55.000000000","message":"This would need to be moved lower along with marconi imports","commit_id":"cd115d159feac7a9bfe54cf5748c3dc8fe1464cf"}],"marconi/tests/queues/transport/wsgi/v1/test_messages.py":[{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"31bfe067b5e662ed04c421c1f7384d8955e070c4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"import falcon"},{"line_number":21,"context_line":"from marconi.tests.queues.transport.wsgi import base"},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":"from testtools import matchers"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_0b2ca901","line":21,"updated":"2014-06-10 14:28:55.000000000","message":"Moved lower","commit_id":"cd115d159feac7a9bfe54cf5748c3dc8fe1464cf"}],"marconi/tests/queues/transport/wsgi/v1/test_queue_lifecycle.py":[{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"31bfe067b5e662ed04c421c1f7384d8955e070c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import ddt"},{"line_number":16,"context_line":"import falcon"},{"line_number":17,"context_line":"from marconi.tests.queues.transport.wsgi import base"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from marconi.openstack.common import jsonutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_4b36b153","line":17,"updated":"2014-06-10 14:28:55.000000000","message":"moved lower","commit_id":"cd115d159feac7a9bfe54cf5748c3dc8fe1464cf"}],"marconi/tests/queues/transport/wsgi/v1_1/test_claims.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"1b85ab7f0ee3f341ec0a06e0aa47996d550b898d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(ClaimsBaseTest, self).setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.project_id \u003d \u00277378332832\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.headers \u003d {"},{"line_number":40,"context_line":"            \u0027Client-ID\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_4a24e2ae","line":37,"updated":"2014-06-10 17:38:22.000000000","message":"AFAIK, project ID does not need to be numeric. If you are going to change this anyway, perhaps throw in some non-numeric characters just to make sure no code is making an invalid assumption?","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4fabb4f111c2bb84b6c52e04e42552c8c37e1783","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(ClaimsBaseTest, self).setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.project_id \u003d \u00277378332832\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.headers \u003d {"},{"line_number":40,"context_line":"            \u0027Client-ID\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_128028f6","line":37,"in_reply_to":"1ae5cdf2_4a24e2ae","updated":"2014-06-11 15:38:00.000000000","message":"Why is this change needed?","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"1b85ab7f0ee3f341ec0a06e0aa47996d550b898d","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # Include claimed messages this time"},{"line_number":126,"context_line":"        body \u003d self.simulate_get(self.messages_path,"},{"line_number":127,"context_line":"                                 query_string\u003d\u0027include_claimed\u003dtrue\u0026echo\u003dtrue\u0027,"},{"line_number":128,"context_line":"                                 headers\u003dself.headers)"},{"line_number":129,"context_line":"        listed \u003d json.loads(body[0])"},{"line_number":130,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_cf53a437","line":127,"updated":"2014-06-10 17:38:22.000000000","message":"I think we need to test three different scenarios; this may belong in separate test methods, but let me enumerate them:\n\n1. Claiming messages when Client-ID is the same, and echo is false. In this case, no messages are returned.\n2. Claiming messages when Client-ID is the same, and echo is true. In this case, at least one message is claimed.\n3. Claiming a message when a different Client-ID is given, and echo is false. Should yield same result as (2).","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"32ddbcc75f77f1b2a7932fa7d6e9428995bdeddf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.claims_path \u003d self.queue_path + \u0027/claims\u0027"},{"line_number":45,"context_line":"        self.messages_path \u003d self.queue_path + \u0027/messages\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        doc \u003d \u0027{\"_ttl\": 60}\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.simulate_put(self.queue_path, body\u003ddoc, headers\u003dself.headers)"},{"line_number":50,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_201)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_b573d94c","line":47,"updated":"2014-06-11 18:46:53.000000000","message":"could we have these as json.dumps() or jsonutils.dumps() for consistency\u0027s sake?","commit_id":"45e61c6b4680e5e30fc36be3bf2285df2acda071"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e9aa33c29bf9b09f82bb8fa735bf8510e3285ebb","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_204)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        #List messages with a different client-id and echo\u003dfalse."},{"line_number":141,"context_line":"        # Should return some messages"},{"line_number":142,"context_line":"        headers \u003d self.headers.copy()"},{"line_number":143,"context_line":"        headers[\"Client-ID\"] \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_b5c11931","line":140,"updated":"2014-06-11 19:00:25.000000000","message":"Nit: Missing space after # (no reason to block merging this patch, but should be fixed at some point).","commit_id":"45e61c6b4680e5e30fc36be3bf2285df2acda071"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e9aa33c29bf9b09f82bb8fa735bf8510e3285ebb","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                                 headers\u003dheaders)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":150,"context_line":"        # Include claimed messages this time, and echo"},{"line_number":151,"context_line":"        body \u003d self.simulate_get(self.messages_path,"},{"line_number":152,"context_line":"                                 query_string\u003d\u0027include_claimed\u003dtrue\u0027"},{"line_number":153,"context_line":"                                              \u0027\u0026echo\u003dtrue\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_756eb130","line":150,"updated":"2014-06-11 19:00:25.000000000","message":"Nit: Could use a blank line above the comment","commit_id":"45e61c6b4680e5e30fc36be3bf2285df2acda071"}],"marconi/tests/queues/transport/wsgi/v1_1/test_default_limits.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"1b85ab7f0ee3f341ec0a06e0aa47996d550b898d","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        result \u003d self.simulate_get(self.messages_path,"},{"line_number":65,"context_line":"                                   headers\u003dself.headers,"},{"line_number":66,"context_line":"                                   query_string\u003d\u0027echo\u003dtrue\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_ea74ce9d","line":66,"updated":"2014-06-10 17:38:22.000000000","message":"The common case is that echo\u003dfalse. If we want to test echo\u003dtrue as well, that is fine, but we still need to test the other scenario.","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"}],"marconi/tests/queues/transport/wsgi/v1_1/test_home.py":[{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"96a87e25e68139653b7f71df3980aba134351712","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.assertEqual(content_type, \u0027application/json-home\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            json.loads(body[0])"},{"line_number":41,"context_line":"        except ValueError:"},{"line_number":42,"context_line":"            self.fail(\u0027Home document is not valid JSON\u0027)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8701456c","line":40,"updated":"2014-06-04 13:03:44.000000000","message":"Any reason why we are not using jsonutils here?","commit_id":"8c79de2098e6a21540a3991d0e0568b51f7063a2"},{"author":{"_account_id":11399,"name":"Alex Bettadapur","email":"alexbettadapur@gmail.com","username":"abettadapur"},"change_message_id":"46cfdf97d1d6fe39b533c155660a3655436f6b40","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.assertEqual(content_type, \u0027application/json-home\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            json.loads(body[0])"},{"line_number":41,"context_line":"        except ValueError:"},{"line_number":42,"context_line":"            self.fail(\u0027Home document is not valid JSON\u0027)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_a76e412d","line":40,"in_reply_to":"1ae5cdf2_8701456c","updated":"2014-06-05 14:56:47.000000000","message":"Actually, this looks to be the result of a merge from master. I removed the import, but i never touched the jsonutils.loads statements...","commit_id":"8c79de2098e6a21540a3991d0e0568b51f7063a2"}],"marconi/tests/queues/transport/wsgi/v1_1/test_messages.py":[{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"31bfe067b5e662ed04c421c1f7384d8955e070c4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"import falcon"},{"line_number":21,"context_line":"from marconi.tests.queues.transport.wsgi import base"},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":"from testtools import matchers"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_8b6d1935","line":21,"updated":"2014-06-10 14:28:55.000000000","message":"moved lower","commit_id":"cd115d159feac7a9bfe54cf5748c3dc8fe1464cf"}],"marconi/tests/queues/transport/wsgi/v1_1/test_queue_lifecycle.py":[{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"31bfe067b5e662ed04c421c1f7384d8955e070c4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"import falcon"},{"line_number":19,"context_line":"from marconi.tests.queues.transport.wsgi import base"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from marconi.openstack.common import jsonutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_eb721d10","line":19,"updated":"2014-06-10 14:28:55.000000000","message":"moved lower","commit_id":"cd115d159feac7a9bfe54cf5748c3dc8fe1464cf"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"1b85ab7f0ee3f341ec0a06e0aa47996d550b898d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class QueueLifecycleBaseTest(base.V1_1Base):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    config_file \u003d None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # NOTE(flaper87): This is temporary. Ideally, each version"},{"line_number":32,"context_line":"    # of the API should have its own lifecycle tests. The v1.1"},{"line_number":33,"context_line":"    # of our API removes the support for the API. Although most of"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_4a806246","line":30,"updated":"2014-06-10 17:38:22.000000000","message":"L31-38 can be removed (see my other comment, below)","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"1b85ab7f0ee3f341ec0a06e0aa47996d550b898d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_204)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Add metadata"},{"line_number":99,"context_line":"        if self.metadata_support:"},{"line_number":100,"context_line":"            doc \u003d \u0027{\"messages\": {\"ttl\": 600}}\u0027"},{"line_number":101,"context_line":"            self.simulate_put(gumshoe_queue_path_metadata,"},{"line_number":102,"context_line":"                              headers\u003dheaders, body\u003ddoc)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_cab47237","line":99,"updated":"2014-06-10 17:38:22.000000000","message":"We decided to keep metadata after all, so this if statement should be removed.","commit_id":"9799210d64d0b011b2c8afb9bd3fa39eab9475f3"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e9aa33c29bf9b09f82bb8fa735bf8510e3285ebb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class QueueLifecycleBaseTest(base.V1_1Base):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    config_file \u003d None"},{"line_number":30,"context_line":"    metadata_support \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(QueueLifecycleBaseTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_f59641ef","line":30,"updated":"2014-06-11 19:00:25.000000000","message":"Bug: Please remove this flag and associated \"if\" statements; metadata is not going to be deprecated in v1.1 after all.","commit_id":"45e61c6b4680e5e30fc36be3bf2285df2acda071"}]}
