)]}'
{"marconi/tests/queues/storage/base.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"bdc6c874b92e65927333f0db94fcbb45ea325cbc","unresolved":false,"context_lines":[{"line_number":874,"context_line":"    def setUp(self):"},{"line_number":875,"context_line":"        super(FlavorsControllerTest, self).setUp()"},{"line_number":876,"context_line":"        self.pools_controller \u003d self.driver.pools_controller"},{"line_number":877,"context_line":"        #import pdb; pdb.set_trace()"},{"line_number":878,"context_line":"        self.flavors_controller \u003d self.driver.flavors_controller"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        # Let\u0027s create one pool"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2b1c3377","line":877,"updated":"2014-06-17 03:25:40.000000000","message":"Let\u0027s remove the debug lines :)","commit_id":"89bb30be92948b388a658a6530aa0d4ab105e325"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"bdc6c874b92e65927333f0db94fcbb45ea325cbc","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                                       capabilities\u003d{})"},{"line_number":898,"context_line":"        self.flavors_controller.create(name, \u0027another_pool\u0027,"},{"line_number":899,"context_line":"                                       project\u003dself.project,"},{"line_number":900,"context_line":"                                       capabilities\u003d{})"},{"line_number":901,"context_line":"        entry \u003d self.flavors_controller.get(name, project\u003dself.project)"},{"line_number":902,"context_line":"        self._flavors_expects(entry, name, self.project, \u0027another_pool\u0027)"},{"line_number":903,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_a635dadc","line":900,"updated":"2014-06-17 03:25:40.000000000","message":"IMHO, the capabilities is the key of flavor, is it? So how about the capabilities after inserted a dup one?","commit_id":"89bb30be92948b388a658a6530aa0d4ab105e325"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df8e5cf51ed5d7cd34addd35ec8a4cee36fb8ec7","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                                       capabilities\u003d{})"},{"line_number":898,"context_line":"        self.flavors_controller.create(name, \u0027another_pool\u0027,"},{"line_number":899,"context_line":"                                       project\u003dself.project,"},{"line_number":900,"context_line":"                                       capabilities\u003d{})"},{"line_number":901,"context_line":"        entry \u003d self.flavors_controller.get(name, project\u003dself.project)"},{"line_number":902,"context_line":"        self._flavors_expects(entry, name, self.project, \u0027another_pool\u0027)"},{"line_number":903,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4bedb5ef","line":900,"in_reply_to":"1ae5cdf2_a635dadc","updated":"2014-06-18 11:45:32.000000000","message":"mmh, not sure I understand what you mean.\n\nCapabilities are important, they describe what the flavor is capable of but I don\u0027t believe they should be unique. You could have 2 different in-memory pools on top of different in-memory technologies.","commit_id":"89bb30be92948b388a658a6530aa0d4ab105e325"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"bdc6c874b92e65927333f0db94fcbb45ea325cbc","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                                       project\u003dself.project,"},{"line_number":973,"context_line":"                                       capabilities\u003d{})"},{"line_number":974,"context_line":"        self.flavors_controller.delete(name, project\u003dself.project)"},{"line_number":975,"context_line":"        self.assertFalse(self.flavors_controller.exists(name))"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    def test_delete_nonexistent_is_silent(self):"},{"line_number":978,"context_line":"        self.flavors_controller.delete(\u0027nonexisting\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_a63cfac0","line":975,"updated":"2014-06-17 03:25:40.000000000","message":"What\u0027s the behaviour if we try to get a deleted flavor instead of checking it by exists()?","commit_id":"89bb30be92948b388a658a6530aa0d4ab105e325"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df8e5cf51ed5d7cd34addd35ec8a4cee36fb8ec7","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                                       project\u003dself.project,"},{"line_number":973,"context_line":"                                       capabilities\u003d{})"},{"line_number":974,"context_line":"        self.flavors_controller.delete(name, project\u003dself.project)"},{"line_number":975,"context_line":"        self.assertFalse(self.flavors_controller.exists(name))"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    def test_delete_nonexistent_is_silent(self):"},{"line_number":978,"context_line":"        self.flavors_controller.delete(\u0027nonexisting\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8b889d23","line":975,"in_reply_to":"1ae5cdf2_a63cfac0","updated":"2014-06-18 11:45:32.000000000","message":"The test below should cover this case. It doesn\u0027t raise an exception but succeeds silently. I\u0027m starting to think it should probably raise a NotFound exception.","commit_id":"89bb30be92948b388a658a6530aa0d4ab105e325"},{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"a77ec27f5195f243dab2c73d1150c0c8f946cbc7","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                                       project\u003dself.project,"},{"line_number":967,"context_line":"                                       capabilities\u003d{})"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":"    def test_create_replaces_on_duplicate_insert(self):"},{"line_number":970,"context_line":"        name \u003d str(uuid.uuid1())"},{"line_number":971,"context_line":"        self.flavors_controller.create(name, self.pool,"},{"line_number":972,"context_line":"                                       project\u003dself.project,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_4dbb2475","line":969,"updated":"2014-07-17 13:35:32.000000000","message":"Replacing on duplicate might be dangerous.\nWe should probably support PATCH for updates","commit_id":"f41cb54e9442f589f33560d97b9d754243d18fd4"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"81eed7ba984057ea10280999b3b75d3f309123b0","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                                       project\u003dself.project,"},{"line_number":967,"context_line":"                                       capabilities\u003d{})"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":"    def test_create_replaces_on_duplicate_insert(self):"},{"line_number":970,"context_line":"        name \u003d str(uuid.uuid1())"},{"line_number":971,"context_line":"        self.flavors_controller.create(name, self.pool,"},{"line_number":972,"context_line":"                                       project\u003dself.project,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_d05b6b20","line":969,"in_reply_to":"baada198_4dbb2475","updated":"2014-07-30 08:18:22.000000000","message":"I agree, I basically followed the same logics behind pools here (as far as the API methods go). Would you agree on changing this behavior in a follow-up patch? I\u0027ll file a bug if you agree with this","commit_id":"f41cb54e9442f589f33560d97b9d754243d18fd4"}],"zaqar/queues/storage/mongodb/flavors.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"65e42d886721b95210aa8af8d0ef22162a4373de","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    (\u0027n\u0027, 1),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# NOTE(cpp-cabrera): used for get/list operations. There\u0027s no need to"},{"line_number":35,"context_line":"# show the marker or the _id - they\u0027re implementation details."},{"line_number":36,"context_line":"OMIT_FIELDS \u003d ((\u0027_id\u0027, False),)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_25482b89","line":34,"updated":"2014-08-12 15:09:35.000000000","message":"I am sure cpp-cabrera has trade marked his name ;)","commit_id":"962979a9221131336a8aa1610704527626e60120"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"5ce59125495a8e5df252d1768bc0a49fc679c58d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if not res:"},{"line_number":72,"context_line":"            raise errors.FlavorDoesNotExist(name)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return _normalize(res, detailed)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @utils.raises_conn_error"},{"line_number":77,"context_line":"    def create(self, name, pool, project\u003dNone, capabilities\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_e8444a49","line":74,"updated":"2014-08-12 16:39:05.000000000","message":"KUDO: Nice reuse of _normalize.","commit_id":"962979a9221131336a8aa1610704527626e60120"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"5ce59125495a8e5df252d1768bc0a49fc679c58d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return _normalize(res, detailed)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @utils.raises_conn_error"},{"line_number":77,"context_line":"    def create(self, name, pool, project\u003dNone, capabilities\u003dNone):"},{"line_number":78,"context_line":"        # TODO(flaper87): Verify storage exists"},{"line_number":79,"context_line":"        capabilities \u003d {} if capabilities is None else capabilities"},{"line_number":80,"context_line":"        self._col.update({\u0027n\u0027: name, \u0027p\u0027: project},"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_19770e09","line":77,"updated":"2014-08-12 16:39:05.000000000","message":"Q. Does the capabilities dict have a well-defined schema?","commit_id":"962979a9221131336a8aa1610704527626e60120"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"5ce59125495a8e5df252d1768bc0a49fc679c58d","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @utils.raises_conn_error"},{"line_number":85,"context_line":"    def exists(self, name, project\u003dNone):"},{"line_number":86,"context_line":"        return self._col.find_one({\u0027n\u0027: name, \u0027p\u0027: project}) is not None"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @utils.raises_conn_error"},{"line_number":89,"context_line":"    def update(self, name, project\u003dNone, pool\u003dNone, capabilities\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_39c85220","line":86,"updated":"2014-08-12 16:39:05.000000000","message":"PERF: Consider masking fields out that you don\u0027t need returned for this check.","commit_id":"962979a9221131336a8aa1610704527626e60120"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"5ce59125495a8e5df252d1768bc0a49fc679c58d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    @utils.raises_conn_error"},{"line_number":111,"context_line":"    def drop_all(self):"},{"line_number":112,"context_line":"        self._col.drop()"},{"line_number":113,"context_line":"        self._col.ensure_index(FLAVORS_INDEX, unique\u003dTrue)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def _normalize(pool, detailed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_f43fbfaf","line":113,"updated":"2014-08-12 16:39:05.000000000","message":"DRY: Factor out this and L49 to a helper method?","commit_id":"962979a9221131336a8aa1610704527626e60120"}],"zaqar/queues/storage/sqlalchemy/driver.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9aece6d58468135a5b65602e8a6aa8893c683a00","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @property"},{"line_number":159,"context_line":"    def flavors_controller(self):"},{"line_number":160,"context_line":"        # NOTE(flaper87): Needed to avoid `abc` errors."},{"line_number":161,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_4aa95c7b","line":161,"updated":"2014-08-06 21:45:07.000000000","message":"Given that this function is a syntactic requirement we should use the pass placeholder instead of raising an exception.","commit_id":"962979a9221131336a8aa1610704527626e60120"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"00a32ce4494875900889587c4fe06323cd7db019","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @property"},{"line_number":159,"context_line":"    def flavors_controller(self):"},{"line_number":160,"context_line":"        # NOTE(flaper87): Needed to avoid `abc` errors."},{"line_number":161,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_6f2d1290","line":161,"in_reply_to":"baada198_09b020db","updated":"2014-08-08 12:34:14.000000000","message":"Thanks for clearing it up :)","commit_id":"962979a9221131336a8aa1610704527626e60120"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a79c1a67582b5dc474c8adca96c25d831a929f46","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    @property"},{"line_number":159,"context_line":"    def flavors_controller(self):"},{"line_number":160,"context_line":"        # NOTE(flaper87): Needed to avoid `abc` errors."},{"line_number":161,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_09b020db","line":161,"in_reply_to":"baada198_4aa95c7b","updated":"2014-08-08 06:56:30.000000000","message":"I\u0027d prefer to keep `NotImplemented` to explicitly indicate this needs to be fixed. People sometimes read `pass` as: \"it\u0027s ok if it\u0027s not implemented\"","commit_id":"962979a9221131336a8aa1610704527626e60120"}],"zaqar/tests/queues/storage/base.py":[{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"77579fcff0f52faf3eac4f7166d2390fef2a9354","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        entry \u003d self.flavors_controller.get(name, project\u003dself.project)"},{"line_number":1030,"context_line":"        self._flavors_expects(entry, name, self.project, \u0027another_pool\u0027)"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"    def _flavors_expects(self, flavor, xname, xproject, xpool):"},{"line_number":1033,"context_line":"        self.assertIn(\u0027name\u0027, flavor)"},{"line_number":1034,"context_line":"        self.assertEqual(flavor[\u0027name\u0027], xname)"},{"line_number":1035,"context_line":"        self.assertIn(\u0027project\u0027, flavor)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_051051ff","line":1032,"updated":"2014-08-06 09:25:16.000000000","message":"STYLE: Maybe move this method to the down? After all tests? Or alternatively - place it before first usage. Now it is after first usage, but before all rest.","commit_id":"82b7a4edafa7210d22f8051e2354a297976dac03"}]}
