)]}'
{"zun_ui/api/client.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"1c7bb8d6b2a811849a07741e5fb63fa2a578ad5b","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def container_update(request, id, **kwargs):"},{"line_number":86,"context_line":"    args, run \u003d _cleanup_params(CONTAINER_CREATE_ATTRS, True, **kwargs)"},{"line_number":87,"context_line":"    name \u003d args[\"name\"]"},{"line_number":88,"context_line":"    del args[\"name\"]"},{"line_number":89,"context_line":"    zunclient(request).containers.rename(id, name)"},{"line_number":90,"context_line":"    return zunclient(request).containers.update(id, **args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_d70f09df","line":87,"updated":"2017-06-14 09:03:19.000000000","message":"Should we not check if the param is to update name or not? Everytime doing rename is not correct I think. So please consider the below option::\n  if args[\u0027name\u0027]:\n    zunclient.rename ...\n  else:\n    zunclient.update ...","commit_id":"b26f33a70c32c145d6ba1ee2e5e097fdf4cfde83"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"c592086d20b31d1ca0de29c2e4bba29f6a375b10","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def container_update(request, id, **kwargs):"},{"line_number":86,"context_line":"    args, run \u003d _cleanup_params(CONTAINER_CREATE_ATTRS, True, **kwargs)"},{"line_number":87,"context_line":"    name \u003d args[\"name\"]"},{"line_number":88,"context_line":"    del args[\"name\"]"},{"line_number":89,"context_line":"    zunclient(request).containers.rename(id, name)"},{"line_number":90,"context_line":"    return zunclient(request).containers.update(id, **args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_be3a08c9","line":87,"in_reply_to":"7f231b9d_d70f09df","updated":"2017-06-15 05:27:09.000000000","message":"I added some check process. Could you check them again?","commit_id":"b26f33a70c32c145d6ba1ee2e5e097fdf4cfde83"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"800b19b05b9183c27f6c053dde77a861b0305938","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def container_update(request, id, **kwargs):"},{"line_number":86,"context_line":"    args, run \u003d _cleanup_params(CONTAINER_CREATE_ATTRS, True, **kwargs)"},{"line_number":87,"context_line":"    name \u003d args[\"name\"]"},{"line_number":88,"context_line":"    del args[\"name\"]"},{"line_number":89,"context_line":"    zunclient(request).containers.rename(id, name)"},{"line_number":90,"context_line":"    return zunclient(request).containers.update(id, **args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_fa50ac0c","line":87,"in_reply_to":"7f231b9d_d70f09df","updated":"2017-06-14 09:26:46.000000000","message":"agree with Madhuri\n\nyou should use\n\n  name \u003d args.pop(\u0027name\u0027, None)\n\nto avoid exception here, and you do not need to call\n\n  del args[\u0027name\u0027]","commit_id":"b26f33a70c32c145d6ba1ee2e5e097fdf4cfde83"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"c592086d20b31d1ca0de29c2e4bba29f6a375b10","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def container_update(request, id, **kwargs):"},{"line_number":86,"context_line":"    args, run \u003d _cleanup_params(CONTAINER_CREATE_ATTRS, True, **kwargs)"},{"line_number":87,"context_line":"    name \u003d args[\"name\"]"},{"line_number":88,"context_line":"    del args[\"name\"]"},{"line_number":89,"context_line":"    zunclient(request).containers.rename(id, name)"},{"line_number":90,"context_line":"    return zunclient(request).containers.update(id, **args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_be11e854","line":87,"in_reply_to":"7f231b9d_fa50ac0c","updated":"2017-06-15 05:27:09.000000000","message":"Done","commit_id":"b26f33a70c32c145d6ba1ee2e5e097fdf4cfde83"}],"zun_ui/static/dashboard/container/containers/actions/update.service.js":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"800b19b05b9183c27f6c053dde77a861b0305938","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      // only \"cpu\" and \"memory\" fields are editable."},{"line_number":122,"context_line":"      for (var key in model) {"},{"line_number":123,"context_line":"        if (model.hasOwnProperty(key) \u0026\u0026 model[key] \u003d\u003d\u003d null || model[key] \u003d\u003d\u003d \"\" ||"},{"line_number":124,"context_line":"            (key !\u003d\u003d \"name\" \u0026\u0026 key !\u003d\u003d \"cpu\" \u0026\u0026 key !\u003d\u003d \"memory\")) {"},{"line_number":125,"context_line":"          delete model[key];"},{"line_number":126,"context_line":"        }"},{"line_number":127,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":1,"id":"7f231b9d_b7492d8c","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":64},"updated":"2017-06-14 09:26:46.000000000","message":"this group should be change to check index of key in array of cpu, name, and memory --\u003e will be easier to read","commit_id":"b26f33a70c32c145d6ba1ee2e5e097fdf4cfde83"}]}