)]}'
{"higgins/common/docker_utils.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"794b2a1c67e6124effda88bbfab66e460e5a63f3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def compare_version(v1, v2):"},{"line_number":25,"context_line":"    \"\"\"Compare docker versions"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \u003e\u003e\u003e v1 \u003d \u00271.9\u0027"},{"line_number":28,"context_line":"    \u003e\u003e\u003e v2 \u003d \u00271.10\u0027"},{"line_number":29,"context_line":"    \u003e\u003e\u003e compare_version(v1, v2)"},{"line_number":30,"context_line":"    1"},{"line_number":31,"context_line":"    \u003e\u003e\u003e compare_version(v2, v1)"},{"line_number":32,"context_line":"    -1"},{"line_number":33,"context_line":"    \u003e\u003e\u003e compare_version(v2, v2)"},{"line_number":34,"context_line":"    0"},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    s1 \u003d StrictVersion(v1)"},{"line_number":37,"context_line":"    s2 \u003d StrictVersion(v2)"},{"line_number":38,"context_line":"    if s1 \u003d\u003d s2:"},{"line_number":39,"context_line":"        return 0"},{"line_number":40,"context_line":"    elif s1 \u003e s2:"},{"line_number":41,"context_line":"        return -1"},{"line_number":42,"context_line":"    else:"},{"line_number":43,"context_line":"        return 1"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def is_docker_library_version_atleast(version):"},{"line_number":47,"context_line":"    if compare_version(docker.version, version) \u003c\u003d 0:"},{"line_number":48,"context_line":"        return True"},{"line_number":49,"context_line":"    return False"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def is_docker_api_version_atleast(docker, version):"},{"line_number":53,"context_line":"    if compare_version(docker.version()[\u0027ApiVersion\u0027], version) \u003c\u003d 0:"},{"line_number":54,"context_line":"        return True"},{"line_number":55,"context_line":"    return False"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def parse_docker_image(image):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_b56ff8fa","line":55,"range":{"start_line":24,"start_character":0,"end_line":55,"end_character":16},"updated":"2016-05-26 05:54:43.000000000","message":"better to move to utils","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"794b2a1c67e6124effda88bbfab66e460e5a63f3","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class DockerHTTPClient(client.Client):"},{"line_number":71,"context_line":"    def __init__(self, url\u003d\u0027unix://var/run/docker.sock\u0027,"},{"line_number":72,"context_line":"                 ver\u003d\u00271.20\u0027,"},{"line_number":73,"context_line":"                 timeout\u003d60,"},{"line_number":74,"context_line":"                 ca_cert\u003dNone,"},{"line_number":75,"context_line":"                 client_key\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_756910f9","line":72,"range":{"start_line":72,"start_character":17,"end_line":72,"end_character":28},"updated":"2016-05-26 05:54:43.000000000","message":"can we make this as a global variable","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"785c9d2aa08c711d1deb126a5a7e243189e111df","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class DockerHTTPClient(client.Client):"},{"line_number":71,"context_line":"    def __init__(self, url\u003d\u0027unix://var/run/docker.sock\u0027,"},{"line_number":72,"context_line":"                 ver\u003d\u00271.20\u0027,"},{"line_number":73,"context_line":"                 timeout\u003d60,"},{"line_number":74,"context_line":"                 ca_cert\u003dNone,"},{"line_number":75,"context_line":"                 client_key\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_db80edc1","line":72,"range":{"start_line":72,"start_character":17,"end_line":72,"end_character":28},"in_reply_to":"bab6814e_756910f9","updated":"2016-05-26 07:10:04.000000000","message":"For what reason?","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"794b2a1c67e6124effda88bbfab66e460e5a63f3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"class DockerHTTPClient(client.Client):"},{"line_number":71,"context_line":"    def __init__(self, url\u003d\u0027unix://var/run/docker.sock\u0027,"},{"line_number":72,"context_line":"                 ver\u003d\u00271.20\u0027,"},{"line_number":73,"context_line":"                 timeout\u003d60,"},{"line_number":74,"context_line":"                 ca_cert\u003dNone,"},{"line_number":75,"context_line":"                 client_key\u003dNone,"},{"line_number":76,"context_line":"                 client_cert\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_d56a7cec","line":73,"range":{"start_line":73,"start_character":17,"end_line":73,"end_character":27},"updated":"2016-05-26 05:54:43.000000000","message":"ditto","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"}],"higgins/conductor/api.py":[{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"612076d49eb307dd8312d50c664a5a367acdc88e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def container_delete(self, container_uuid):"},{"line_number":35,"context_line":"        return self._call(\u0027container_delete\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def container_show(self, container_uuid):"},{"line_number":38,"context_line":"        return self._call(\u0027container_show\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def container_reboot(self, container_uuid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_434bb62b","line":37,"updated":"2016-05-26 09:13:26.000000000","message":"Duplicate with container_get?","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"794b2a1c67e6124effda88bbfab66e460e5a63f3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(API, self).__init__(transport, context,"},{"line_number":29,"context_line":"                                  topic\u003dcfg.CONF.conductor.topic)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def container_create(self, container):"},{"line_number":32,"context_line":"        return self._call(\u0027container_create\u0027, container\u003dcontainer)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def container_delete(self, container_uuid):"},{"line_number":35,"context_line":"        return self._call(\u0027container_delete\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def container_show(self, container_uuid):"},{"line_number":38,"context_line":"        return self._call(\u0027container_show\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def container_reboot(self, container_uuid):"},{"line_number":41,"context_line":"        return self._call(\u0027container_reboot\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def container_stop(self, container_uuid):"},{"line_number":44,"context_line":"        return self._call(\u0027container_stop\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def container_start(self, container_uuid):"},{"line_number":47,"context_line":"        return self._call(\u0027container_start\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def container_pause(self, container_uuid):"},{"line_number":50,"context_line":"        return self._call(\u0027container_pause\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def container_unpause(self, container_uuid):"},{"line_number":53,"context_line":"        return self._call(\u0027container_unpause\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def container_logs(self, container_uuid):"},{"line_number":56,"context_line":"        return self._call(\u0027container_logs\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def container_exec(self, container_uuid, command):"},{"line_number":59,"context_line":"        return self._call(\u0027container_exec\u0027, container_uuid\u003dcontainer_uuid,"},{"line_number":60,"context_line":"                          command\u003dcommand)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def container_get(self, container_uuid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_b546d878","line":59,"range":{"start_line":31,"start_character":0,"end_line":59,"end_character":74},"updated":"2016-05-26 05:54:43.000000000","message":"are all rpc method call? I think some of them should be async method, maybe we need to add cast method.","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"87d85090c8dcd2f2be5733c94491283c0ef60d67","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(API, self).__init__(transport, context,"},{"line_number":29,"context_line":"                                  topic\u003dcfg.CONF.conductor.topic)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def container_create(self, container):"},{"line_number":32,"context_line":"        return self._call(\u0027container_create\u0027, container\u003dcontainer)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def container_delete(self, container_uuid):"},{"line_number":35,"context_line":"        return self._call(\u0027container_delete\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def container_show(self, container_uuid):"},{"line_number":38,"context_line":"        return self._call(\u0027container_show\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def container_reboot(self, container_uuid):"},{"line_number":41,"context_line":"        return self._call(\u0027container_reboot\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def container_stop(self, container_uuid):"},{"line_number":44,"context_line":"        return self._call(\u0027container_stop\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def container_start(self, container_uuid):"},{"line_number":47,"context_line":"        return self._call(\u0027container_start\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def container_pause(self, container_uuid):"},{"line_number":50,"context_line":"        return self._call(\u0027container_pause\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def container_unpause(self, container_uuid):"},{"line_number":53,"context_line":"        return self._call(\u0027container_unpause\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def container_logs(self, container_uuid):"},{"line_number":56,"context_line":"        return self._call(\u0027container_logs\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def container_exec(self, container_uuid, command):"},{"line_number":59,"context_line":"        return self._call(\u0027container_exec\u0027, container_uuid\u003dcontainer_uuid,"},{"line_number":60,"context_line":"                          command\u003dcommand)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def container_get(self, container_uuid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_e00c8296","line":59,"range":{"start_line":31,"start_character":0,"end_line":59,"end_character":74},"in_reply_to":"bab6814e_9b61453c","updated":"2016-05-28 06:56:20.000000000","message":"Right, for async(create/delete..) operations it needs to be changed to rpc cast.","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"785c9d2aa08c711d1deb126a5a7e243189e111df","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(API, self).__init__(transport, context,"},{"line_number":29,"context_line":"                                  topic\u003dcfg.CONF.conductor.topic)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def container_create(self, container):"},{"line_number":32,"context_line":"        return self._call(\u0027container_create\u0027, container\u003dcontainer)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def container_delete(self, container_uuid):"},{"line_number":35,"context_line":"        return self._call(\u0027container_delete\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def container_show(self, container_uuid):"},{"line_number":38,"context_line":"        return self._call(\u0027container_show\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def container_reboot(self, container_uuid):"},{"line_number":41,"context_line":"        return self._call(\u0027container_reboot\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def container_stop(self, container_uuid):"},{"line_number":44,"context_line":"        return self._call(\u0027container_stop\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def container_start(self, container_uuid):"},{"line_number":47,"context_line":"        return self._call(\u0027container_start\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def container_pause(self, container_uuid):"},{"line_number":50,"context_line":"        return self._call(\u0027container_pause\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def container_unpause(self, container_uuid):"},{"line_number":53,"context_line":"        return self._call(\u0027container_unpause\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def container_logs(self, container_uuid):"},{"line_number":56,"context_line":"        return self._call(\u0027container_logs\u0027, container_uuid\u003dcontainer_uuid)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def container_exec(self, container_uuid, command):"},{"line_number":59,"context_line":"        return self._call(\u0027container_exec\u0027, container_uuid\u003dcontainer_uuid,"},{"line_number":60,"context_line":"                          command\u003dcommand)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def container_get(self, container_uuid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_9b61453c","line":59,"range":{"start_line":31,"start_character":0,"end_line":59,"end_character":74},"in_reply_to":"bab6814e_b546d878","updated":"2016-05-26 07:10:04.000000000","message":"Agreed","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"}],"higgins/conductor/handlers/docker_conductor.py":[{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"785c9d2aa08c711d1deb126a5a7e243189e111df","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def wrap_container_exception(f):"},{"line_number":30,"context_line":"    def wrapped(self, *args, **kwargs):"},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return f(self, *args, **kwargs)"},{"line_number":33,"context_line":"        except Exception as e:"},{"line_number":34,"context_line":"            container_uuid \u003d None"},{"line_number":35,"context_line":"            if \u0027container_uuid\u0027 in kwargs:"},{"line_number":36,"context_line":"                container_uuid \u003d kwargs.get(\u0027container_uuid\u0027)"},{"line_number":37,"context_line":"            elif \u0027container\u0027 in kwargs:"},{"line_number":38,"context_line":"                container_uuid \u003d kwargs.get(\u0027container\u0027).uuid"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            LOG.exception(\"Error while connect to docker \""},{"line_number":41,"context_line":"                          \"container %s\", container_uuid)"},{"line_number":42,"context_line":"            raise Exception(\"Docker internal Error: %s\" % str(e))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    return functools.wraps(f)(wrapped)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class Handler(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_fbd971f4","line":44,"range":{"start_line":29,"start_character":0,"end_line":44,"end_character":38},"updated":"2016-05-26 07:10:04.000000000","message":"it is not kinda correct way to use functools.wraps decorator, you need to do next:\n\n     @functools.wraps(f)\n     def wrapped(self, *args, **kwargs):\n            ...\n\n     return wrapped","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"785c9d2aa08c711d1deb126a5a7e243189e111df","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class Handler(base.APIBase):"},{"line_number":48,"context_line":"    def __init__(self):"},{"line_number":49,"context_line":"        pass"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    _client \u003d None"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_dbe58da4","line":49,"updated":"2016-05-26 07:10:04.000000000","message":"if it does nothing, so what the reason to keep such placebo?","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"785c9d2aa08c711d1deb126a5a7e243189e111df","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if self._client is None:"},{"line_number":56,"context_line":"            self._client \u003d docker_utils.DockerHTTPClient("},{"line_number":57,"context_line":"                url\u003dos.getenv(\u0027DOCKER_HOST\u0027, \u0027unix://var/run/docker.sock\u0027))"},{"line_number":58,"context_line":"        yield self._client"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @staticmethod"},{"line_number":61,"context_line":"    def _find_container_by_name(docker, name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_fb87b1b2","line":58,"updated":"2016-05-26 07:10:04.000000000","message":"Disagree with it,  swarm cluster or single daemon should run on remote host, conductor should use API over TCP but not unix socket.","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"612076d49eb307dd8312d50c664a5a367acdc88e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                    LOG.exception(\"Can not find docker instance with %s,\""},{"line_number":129,"context_line":"                                  \"set it to Error status\","},{"line_number":130,"context_line":"                                  container_uuid)"},{"line_number":131,"context_line":"                    # container.status \u003d \u0027ERROR\u0027"},{"line_number":132,"context_line":"                    # container.save()"},{"line_number":133,"context_line":"                    # return container"},{"line_number":134,"context_line":"                result \u003d docker.inspect_container(docker_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_bbc7f096","line":131,"updated":"2016-05-26 09:13:26.000000000","message":"Please remove these commented code if they are not being used.","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"785c9d2aa08c711d1deb126a5a7e243189e111df","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    # container.save()"},{"line_number":153,"context_line":"                    # return container"},{"line_number":154,"context_line":"                    return"},{"line_number":155,"context_line":"                raise"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @wrap_container_exception"},{"line_number":158,"context_line":"    def _container_action(self, container_uuid, status, docker_func):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_db6aadec","line":155,"updated":"2016-05-26 07:10:04.000000000","message":"why there too much comments?","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"785c9d2aa08c711d1deb126a5a7e243189e111df","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        with self.docker_for_container() as docker:"},{"line_number":161,"context_line":"            docker_id \u003d self._find_container_by_name(docker,"},{"line_number":162,"context_line":"                                                     container_uuid)"},{"line_number":163,"context_line":"            result \u003d getattr(docker, docker_func)(docker_id)"},{"line_number":164,"context_line":"            # container \u003d objects.Container.get_by_uuid("},{"line_number":165,"context_line":"            #                                           container_uuid)"},{"line_number":166,"context_line":"            # container.status \u003d status"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_1b60b500","line":163,"updated":"2016-05-26 07:10:04.000000000","message":"what if there\u0027s no func?","commit_id":"ceff76458e3918d6812df74c723310c0b8d8ff89"}]}
