)]}'
{"tools/gen-config":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"355b49bd4549931e8dc4d1ff76fc800ba77b4140","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"oslo-config-generator --config-file\u003dtools/higgins-config-generator.conf"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9abb7d3a_3fd51343","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":71},"updated":"2016-05-27 18:25:18.000000000","message":"this should directly be used in tox.ini itself..","commit_id":"d6e4831cb00d38871188e0bad70cd2dbebfc7dfc"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"5744c0653e5a1798e7c9cf6a3b6bc5c06125717d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"oslo-config-generator --config-file\u003dtools/higgins-config-generator.conf"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9abb7d3a_5dba9524","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":71},"in_reply_to":"9abb7d3a_3fd51343","updated":"2016-05-28 04:16:38.000000000","message":"Hi, Sheel, thanks for your comment. Actually this patch is for providing admin/operator a individual tool to generate configuration file of Higgins service. IMHO, we may shouldn\u0027t enforce admin/operator to run \"tox\" or \"oslo-config-generator\" to generate the Higgins.conf since it\u0027s not their responsibility to understand tox and oslo(although developers(us) are very familiar with them). I know most projects invoke oslo-config-generator directly in tox.ini, but maybe we can provide user a better way for managing Higgins service:) Of course, I won\u0027t insist this change if you guys feel it is not necessary.","commit_id":"d6e4831cb00d38871188e0bad70cd2dbebfc7dfc"}],"tox.ini":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"355b49bd4549931e8dc4d1ff76fc800ba77b4140","unresolved":false,"context_lines":[{"line_number":93,"context_line":"[testenv:genconfig]"},{"line_number":94,"context_line":"envdir \u003d {toxworkdir}/venv"},{"line_number":95,"context_line":"commands \u003d"},{"line_number":96,"context_line":"  {toxinidir}/tools/gen-config"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9abb7d3a_1f912f9a","line":96,"range":{"start_line":96,"start_character":3,"end_line":96,"end_character":30},"updated":"2016-05-27 18:25:18.000000000","message":"we do not need to generat tool script for single command under tools/gen-config.\nI would suggest to add \"oslo-config-generator\" command here.\n\nRefer https://github.com/openstack/magnum/blob/master/tox.ini#L114","commit_id":"d6e4831cb00d38871188e0bad70cd2dbebfc7dfc"}]}
