)]}'
{"etc/zun/policy.json":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"9fb3e1e9d21e67d416305b52a53ab912d2419e44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\"zun-service:get_all\": \"rule:admin_api\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"9ad45d7e_3aef9288","side":"PARENT","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":1},"updated":"2016-08-10 09:00:42.000000000","message":"why removing this?","commit_id":"d7401499453d5ed19e88ec988ee35579b51f00a1"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"535e71cd03999ea0d1623ff414bdc37c4b3c5cf0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\"zun-service:get_all\": \"rule:admin_api\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"9ad45d7e_805ba7f5","side":"PARENT","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":1},"in_reply_to":"9ad45d7e_3aef9288","updated":"2016-08-10 12:24:38.000000000","message":"Done","commit_id":"d7401499453d5ed19e88ec988ee35579b51f00a1"}],"zun/api/controllers/types.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"9fb3e1e9d21e67d416305b52a53ab912d2419e44","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def __init__(self, type):"},{"line_number":154,"context_line":"        super(Dict, self).__init__()"},{"line_number":155,"context_line":"        self.type \u003d type"},{"line_number":156,"context_line":"        self.type_name \u003d \u0027Dict(%s)\u0027 % self.type.type_name"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @classmethod"},{"line_number":159,"context_line":"    def validate(self, value):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_1578a18e","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":57},"updated":"2016-08-10 09:00:42.000000000","message":"you have define type_name in #151, better to remove it to avoid confusing.","commit_id":"d31aa70407648f225ec414c45c0e670addaa16df"}],"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"9fb3e1e9d21e67d416305b52a53ab912d2419e44","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                \u0027max_length\u0027: 255,"},{"line_number":78,"context_line":"            },"},{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027memory\u0027: {"},{"line_number":81,"context_line":"            \u0027validate\u0027: types.String.validate,"},{"line_number":82,"context_line":"            \u0027validate_args\u0027: {"},{"line_number":83,"context_line":"                \u0027min_length\u0027: 0,"},{"line_number":84,"context_line":"                \u0027max_length\u0027: 255,"},{"line_number":85,"context_line":"            },"},{"line_number":86,"context_line":"        },"},{"line_number":87,"context_line":"        \u0027environment\u0027: {"},{"line_number":88,"context_line":"            \u0027validate\u0027: types.Dict.validate,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_15cb811f","line":85,"range":{"start_line":80,"start_character":0,"end_line":85,"end_character":14},"updated":"2016-08-10 09:00:42.000000000","message":"I don\u0027t think this validation is enough. Deep in my mind, memory should be such format \u0027100m\u0027 \u0027512k\u0027 etc, so user we really don\u0027t want to accept any type of string.","commit_id":"d31aa70407648f225ec414c45c0e670addaa16df"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"535e71cd03999ea0d1623ff414bdc37c4b3c5cf0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                \u0027max_length\u0027: 255,"},{"line_number":78,"context_line":"            },"},{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \u0027memory\u0027: {"},{"line_number":81,"context_line":"            \u0027validate\u0027: types.String.validate,"},{"line_number":82,"context_line":"            \u0027validate_args\u0027: {"},{"line_number":83,"context_line":"                \u0027min_length\u0027: 0,"},{"line_number":84,"context_line":"                \u0027max_length\u0027: 255,"},{"line_number":85,"context_line":"            },"},{"line_number":86,"context_line":"        },"},{"line_number":87,"context_line":"        \u0027environment\u0027: {"},{"line_number":88,"context_line":"            \u0027validate\u0027: types.Dict.validate,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e0fa6374","line":85,"range":{"start_line":80,"start_character":0,"end_line":85,"end_character":14},"in_reply_to":"9ad45d7e_15cb811f","updated":"2016-08-10 12:24:38.000000000","message":"Eli I have filed a bug for this.\nhttps://bugs.launchpad.net/zun/+bug/1611743","commit_id":"d31aa70407648f225ec414c45c0e670addaa16df"}],"zun/api/expose.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"9fb3e1e9d21e67d416305b52a53ab912d2419e44","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wsmeext.pecan as wsme_pecan"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def expose(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_35904543","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":34},"updated":"2016-08-10 09:00:42.000000000","message":"Are you sure you want to using wsme?\nit is not maintained for long time, see \nhttp://lists.openstack.org/pipermail/openstack-dev/2016-March/088662.html","commit_id":"d31aa70407648f225ec414c45c0e670addaa16df"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"535e71cd03999ea0d1623ff414bdc37c4b3c5cf0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wsmeext.pecan as wsme_pecan"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def expose(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e041c3aa","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":34},"in_reply_to":"9ad45d7e_35904543","updated":"2016-08-10 12:24:38.000000000","message":"I have removed it.","commit_id":"d31aa70407648f225ec414c45c0e670addaa16df"}]}
