)]}'
{"zun/common/exception.py":[{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    message \u003d _(\"Invalid configuration file. %(error_msg)s\")"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"class ContainerNotFound(ResourceNotFound):"},{"line_number":337,"context_line":"    message \u003d _(\"Container %(container)s could not be found.\")"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d3a466a7","line":336,"updated":"2016-06-13 02:39:13.000000000","message":"duplicated with InstanceNotFound(L319)? We only need one of them I guess.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    message \u003d _(\"Invalid configuration file. %(error_msg)s\")"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"class ContainerNotFound(ResourceNotFound):"},{"line_number":337,"context_line":"    message \u003d _(\"Container %(container)s could not be found.\")"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6fde5e12","line":336,"in_reply_to":"7aa08908_d3a466a7","updated":"2016-06-13 08:34:50.000000000","message":"Done","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    message \u003d _(\"Container %(container)s could not be found.\")"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"class ContainerAlreadyExists(Conflict):"},{"line_number":341,"context_line":"    message \u003d _(\"A container with UUID %(uuid)s already exists.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_73b2d2e6","line":340,"updated":"2016-06-13 02:39:13.000000000","message":"ResourceExists has been defined in L245, consider using it?","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    message \u003d _(\"Container %(container)s could not be found.\")"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"class ContainerAlreadyExists(Conflict):"},{"line_number":341,"context_line":"    message \u003d _(\"A container with UUID %(uuid)s already exists.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8fe90aba","line":340,"in_reply_to":"7aa08908_73b2d2e6","updated":"2016-06-13 08:34:50.000000000","message":"Done, made ContainerAlreadyExists a sub class of ResourceExists.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"}],"zun/db/__init__.py":[{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"cfg.CONF.register_opts(sql_opts, \u0027database\u0027)"},{"line_number":30,"context_line":"options.set_defaults(cfg.CONF)"},{"line_number":31,"context_line":"options.set_defaults(cfg.CONF, _DEFAULT_SQL_CONNECTION, \u0027zun.sqlite\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d340e6a7","line":31,"updated":"2016-06-13 02:39:13.000000000","message":"Hi, Wenzhi, could you please give some explanation for using zun.sqlite rather than mysql as default sql connection and why we need it here? Thank you so much.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"cfg.CONF.register_opts(sql_opts, \u0027database\u0027)"},{"line_number":30,"context_line":"options.set_defaults(cfg.CONF)"},{"line_number":31,"context_line":"options.set_defaults(cfg.CONF, _DEFAULT_SQL_CONNECTION, \u0027zun.sqlite\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_efdc0ee6","line":31,"in_reply_to":"7aa08908_d340e6a7","updated":"2016-06-13 08:34:50.000000000","message":"Hi Yanyan, this is not setting sqlite as the default sql connection. This is setting \u0027sqlite:////opt/stack/zun/zun.sqlite\u0027 as the sqlite disk file if user configure sqlite as the db backend. Please see [1] for detail info.\n\n[1]http://docs.openstack.org/developer/oslo.db/api/options.html","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"}],"zun/db/api.py":[{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\"Constructor.\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @abc.abstractmethod"},{"line_number":44,"context_line":"    def get_container_list(self, context, filters\u003dNone,"},{"line_number":45,"context_line":"                           limit\u003dNone, marker\u003dNone,"},{"line_number":46,"context_line":"                           sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Get matching containers."}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d3f90682","line":44,"updated":"2016-06-13 02:39:13.000000000","message":"Consider to use \u0027list_container\u0027?","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"}],"zun/db/sqlalchemy/models.py":[{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    report_count \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class Container(Base):"},{"line_number":119,"context_line":"    \"\"\"Represents a container.\"\"\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    __tablename__ \u003d \u0027container\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_337faae1","line":118,"updated":"2016-06-13 02:39:13.000000000","message":"consider to add a metadata field? Like what nova is doing for VM isntance.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"}],"zun/objects/container.py":[{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027user_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027image\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027command\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027bay_uuid\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027status\u0027: z_fields.ContainerStatusField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027memory\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027environment\u0027: fields.DictOfStringsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b3f71ad2","line":36,"updated":"2016-06-13 02:39:13.000000000","message":"I think this property is unnecessary for containers created in baremetal/VM host. For containers created by COEs in future, we\u0027d better consider to use a more generic name like \u0027physical_id\u0027 here.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027user_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027image\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027command\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027bay_uuid\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027status\u0027: z_fields.ContainerStatusField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027memory\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027environment\u0027: fields.DictOfStringsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4aa1d0f7","line":36,"in_reply_to":"7aa08908_b3f71ad2","updated":"2016-06-13 08:34:50.000000000","message":"Done","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027command\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027bay_uuid\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027status\u0027: z_fields.ContainerStatusField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027memory\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027environment\u0027: fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b3e55a0a","line":38,"updated":"2016-06-13 02:39:13.000000000","message":"I guess we don\u0027t need this property as well since cpu/memory should be specified by something like flavor(maybe flavor types of Zun)?","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027command\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027bay_uuid\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027status\u0027: z_fields.ContainerStatusField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027memory\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027environment\u0027: fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_aaa2f4f9","line":38,"in_reply_to":"7aa08908_b3e55a0a","updated":"2016-06-13 08:34:50.000000000","message":"Done","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self._from_db_object(self, db_container)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @base.remotable"},{"line_number":133,"context_line":"    def destroy(self, context\u003dNone):"},{"line_number":134,"context_line":"        \"\"\"Delete the Container from the DB."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param context: Security context. NOTE: This should only"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_53a236af","line":133,"updated":"2016-06-13 02:39:13.000000000","message":"Consider rename to delete as the verb used in dock string? Just a suggestion :)","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self._from_db_object(self, db_container)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @base.remotable"},{"line_number":133,"context_line":"    def destroy(self, context\u003dNone):"},{"line_number":134,"context_line":"        \"\"\"Delete the Container from the DB."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param context: Security context. NOTE: This should only"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ea97dc8d","line":133,"in_reply_to":"7aa08908_53a236af","updated":"2016-06-13 08:34:50.000000000","message":"Maybe we should leave this for now. And after the API code is ready we can then keep consistent with the API method name.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.obj_reset_changes()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @base.remotable"},{"line_number":147,"context_line":"    def save(self, context\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Save updates to this Container."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        Updates will be made column by column based on the result"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f399a27a","line":147,"updated":"2016-06-13 02:39:13.000000000","message":"ditto, consider to use name \u0027update\u0027?","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.obj_reset_changes()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @base.remotable"},{"line_number":147,"context_line":"    def save(self, context\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Save updates to this Container."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        Updates will be made column by column based on the result"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_aaf034fe","line":147,"in_reply_to":"7aa08908_f399a27a","updated":"2016-06-13 08:34:50.000000000","message":"ditto","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.obj_reset_changes()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @base.remotable"},{"line_number":166,"context_line":"    def refresh(self, context\u003dNone):"},{"line_number":167,"context_line":"        \"\"\"Loads updates for this Container."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        Loads a container with the same uuid from the database and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_338e8a2e","line":166,"updated":"2016-06-13 02:39:13.000000000","message":"load?","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.obj_reset_changes()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @base.remotable"},{"line_number":166,"context_line":"    def refresh(self, context\u003dNone):"},{"line_number":167,"context_line":"        \"\"\"Loads updates for this Container."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        Loads a container with the same uuid from the database and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cadb007b","line":166,"in_reply_to":"7aa08908_338e8a2e","updated":"2016-06-13 08:34:50.000000000","message":"ditto","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"}],"zun/objects/fields.py":[{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"c023ce5ad61f2aa1c62c1812385002bd40862944","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ContainerStatus(fields.Enum):"},{"line_number":17,"context_line":"    ALL \u003d ("},{"line_number":18,"context_line":"        ERROR, RUNNING, STOPPED, PAUSED, UNKNOWN,"},{"line_number":19,"context_line":"    ) \u003d ("},{"line_number":20,"context_line":"        \u0027Error\u0027, \u0027Running\u0027, \u0027Stopped\u0027, \u0027Paused\u0027, \u0027Unknown\u0027,"},{"line_number":21,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_735c927d","line":18,"updated":"2016-06-13 02:39:13.000000000","message":"I guess we may need more transient status like \u0027deleting/destroying\u0027, \u0027starting\u0027, \u0027stopping\u0027, etc.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"9ce8ee79eec1d11104d3b934c0090a2587b97506","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ContainerStatus(fields.Enum):"},{"line_number":17,"context_line":"    ALL \u003d ("},{"line_number":18,"context_line":"        ERROR, RUNNING, STOPPED, PAUSED, UNKNOWN,"},{"line_number":19,"context_line":"    ) \u003d ("},{"line_number":20,"context_line":"        \u0027Error\u0027, \u0027Running\u0027, \u0027Stopped\u0027, \u0027Paused\u0027, \u0027Unknown\u0027,"},{"line_number":21,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_aa55d4c2","line":18,"in_reply_to":"7aa08908_735c927d","updated":"2016-06-13 08:34:50.000000000","message":"Seems reasonable, but this patch just intend to add the basic container data model, maybe we can leave this for now and add the status we need in the future.","commit_id":"432bc6867bd7aabdf0231b0e2b5629d4cb4f5afe"}]}
