)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f49042e9818a344a625dcf0cd050123814439bf7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     aditi sharma \u003caditi.s@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-07 11:14:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for \"zun run\""},{"line_number":8,"context_line":"This patch will implement zun run command on zun server."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I86289cfff3bfa74a0c5c27e596728581e067274d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_c9c84925","line":7,"updated":"2016-10-07 14:15:45.000000000","message":"nit. According to the openstack guide [1], commit message should start with a single-line paragraph. Just put a empty line below will work.\n\n[1] http://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"29a0118539b403b7970db40a863fe05d1deb76df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     aditi sharma \u003caditi.s@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-07 11:14:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for \"zun run\""},{"line_number":8,"context_line":"This patch will implement zun run command on zun server."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I86289cfff3bfa74a0c5c27e596728581e067274d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_e691dc53","line":7,"in_reply_to":"1a95cdbc_2a3351ac","updated":"2016-10-13 03:48:25.000000000","message":"thnx, i will correct it","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b39d9f99a6f53d1954b31c7dcc007ba31876a3ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     aditi sharma \u003caditi.s@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-07 11:14:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for \"zun run\""},{"line_number":8,"context_line":"This patch will implement zun run command on zun server."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I86289cfff3bfa74a0c5c27e596728581e067274d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_2a3351ac","line":7,"in_reply_to":"1a95cdbc_c9c84925","updated":"2016-10-07 18:48:57.000000000","message":"+1","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"}],"zun/compute/manager.py":[{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"132d9354e6309c721024308786e62c2ff7d0fec1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                current_status \u003d new_container.status"},{"line_number":68,"context_line":"                if current_status \u003d\u003d \u0027Error\u0027:"},{"line_number":69,"context_line":"                    raise loopingcall.LoopingCallDone()"},{"line_number":70,"context_line":"                if current_status \u003d\u003d \u0027Stopped\u0027:"},{"line_number":71,"context_line":"                    self.container_start(context, new_container)"},{"line_number":72,"context_line":"                    raise loopingcall.LoopingCallDone()"},{"line_number":73,"context_line":"                timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_to_create)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_9ef562ee","line":70,"updated":"2016-10-10 08:11:15.000000000","message":"Should we handle PAUSE state as well ?","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f49042e9818a344a625dcf0cd050123814439bf7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                if current_status \u003d\u003d \u0027Stopped\u0027:"},{"line_number":71,"context_line":"                    self.container_start(context, new_container)"},{"line_number":72,"context_line":"                    raise loopingcall.LoopingCallDone()"},{"line_number":73,"context_line":"                timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_to_create)"},{"line_number":74,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_container_create(self, context, container):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_49a519a0","line":73,"updated":"2016-10-07 14:15:45.000000000","message":"I believe this will block the zun-compute process for a while, so it is better to spawn a thread to run it. In particular, in line #62, it spawns a thread to run \"_do_container_create\", so move this waiting to _do_container_create will possibly work.","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b39d9f99a6f53d1954b31c7dcc007ba31876a3ff","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                if current_status \u003d\u003d \u0027Stopped\u0027:"},{"line_number":71,"context_line":"                    self.container_start(context, new_container)"},{"line_number":72,"context_line":"                    raise loopingcall.LoopingCallDone()"},{"line_number":73,"context_line":"                timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_to_create)"},{"line_number":74,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_container_create(self, context, container):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_ca9d8d67","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":77},"updated":"2016-10-07 18:48:57.000000000","message":"I think the identation is also wrong.","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b39d9f99a6f53d1954b31c7dcc007ba31876a3ff","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                if current_status \u003d\u003d \u0027Stopped\u0027:"},{"line_number":71,"context_line":"                    self.container_start(context, new_container)"},{"line_number":72,"context_line":"                    raise loopingcall.LoopingCallDone()"},{"line_number":73,"context_line":"                timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_to_create)"},{"line_number":74,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_container_create(self, context, container):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_0a8a151b","line":73,"in_reply_to":"1a95cdbc_49a519a0","updated":"2016-10-07 18:48:57.000000000","message":"Agree","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"29a0118539b403b7970db40a863fe05d1deb76df","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                if current_status \u003d\u003d \u0027Stopped\u0027:"},{"line_number":71,"context_line":"                    self.container_start(context, new_container)"},{"line_number":72,"context_line":"                    raise loopingcall.LoopingCallDone()"},{"line_number":73,"context_line":"                timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_to_create)"},{"line_number":74,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_container_create(self, context, container):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_06789029","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":77},"in_reply_to":"1a95cdbc_befbfe77","updated":"2016-10-13 03:48:25.000000000","message":"agreed, i will move it to do_container_create","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"132d9354e6309c721024308786e62c2ff7d0fec1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                if current_status \u003d\u003d \u0027Stopped\u0027:"},{"line_number":71,"context_line":"                    self.container_start(context, new_container)"},{"line_number":72,"context_line":"                    raise loopingcall.LoopingCallDone()"},{"line_number":73,"context_line":"                timer \u003d loopingcall.FixedIntervalLoopingCall(_wait_to_create)"},{"line_number":74,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_container_create(self, context, container):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_befbfe77","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":77},"in_reply_to":"1a95cdbc_ca9d8d67","updated":"2016-10-10 08:11:15.000000000","message":"Agree. Moreover if it is done inside _do_container_create() then valid state check might not be required as we can start container when it is created and in valid state.","commit_id":"25fe954b2620ad5cf025e12a55d9f1d635513a22"}]}