)]}'
{"devstack/lib/zun":[{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"ea6138086149c7f7edfc6ff131c3564b7961d88e","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    setup_develop $ZUN_DIR"},{"line_number":253,"context_line":"}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"function configure_etcd {"},{"line_number":256,"context_line":"    sudo cp $ZUN_DIR/devstack/etcd.conf /etc/init/etcd.conf"},{"line_number":257,"context_line":"    # Delete any existing etcd database:"},{"line_number":258,"context_line":"    sudo rm -rf /var/etcd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6895a0_c7b5ea31","line":255,"updated":"2016-10-24 01:15:42.000000000","message":"This function is not being used now. Shall we remove it?","commit_id":"dbd6b9d8b974b45402f0875f687391d4ed14fcbd"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"457cc1cec680e622901ea8ad22b5a82571aad146","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    setup_develop $ZUN_DIR"},{"line_number":253,"context_line":"}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"function configure_etcd {"},{"line_number":256,"context_line":"    sudo cp $ZUN_DIR/devstack/etcd.conf /etc/init/etcd.conf"},{"line_number":257,"context_line":"    # Delete any existing etcd database:"},{"line_number":258,"context_line":"    sudo rm -rf /var/etcd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6895a0_4c5f2441","line":255,"in_reply_to":"da6895a0_c7b5ea31","updated":"2016-10-25 01:56:22.000000000","message":"Done, nice catch!","commit_id":"dbd6b9d8b974b45402f0875f687391d4ed14fcbd"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"ea6138086149c7f7edfc6ff131c3564b7961d88e","unresolved":false,"context_lines":[{"line_number":343,"context_line":"}"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"function stop_zun-etcd {"},{"line_number":346,"context_line":"    echo \"Start zun etcd...\""},{"line_number":347,"context_line":"    sudo docker stop etcd"},{"line_number":348,"context_line":"}"},{"line_number":349,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6895a0_e774ae9d","line":346,"updated":"2016-10-24 01:15:42.000000000","message":"s/Start/Stop/","commit_id":"dbd6b9d8b974b45402f0875f687391d4ed14fcbd"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"457cc1cec680e622901ea8ad22b5a82571aad146","unresolved":false,"context_lines":[{"line_number":343,"context_line":"}"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"function stop_zun-etcd {"},{"line_number":346,"context_line":"    echo \"Start zun etcd...\""},{"line_number":347,"context_line":"    sudo docker stop etcd"},{"line_number":348,"context_line":"}"},{"line_number":349,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6895a0_8c593c5d","line":346,"in_reply_to":"da6895a0_e774ae9d","updated":"2016-10-25 01:56:22.000000000","message":"Done","commit_id":"dbd6b9d8b974b45402f0875f687391d4ed14fcbd"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"ea6138086149c7f7edfc6ff131c3564b7961d88e","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    for serv in zun-api zun-compute; do"},{"line_number":364,"context_line":"        stop_process $serv"},{"line_number":365,"context_line":"    done"},{"line_number":366,"context_line":"    if is_service_enabled zun-etcd; then"},{"line_number":367,"context_line":"        stop_zun_etcd"},{"line_number":368,"context_line":"    fi"},{"line_number":369,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6895a0_079fe2b4","line":366,"updated":"2016-10-24 01:15:42.000000000","message":"IMHO ideally stop service should be in reverse order of service start i.e if service start order is like below :\nzun-api -\u003e zun-compute -\u003e zun-etcd\n\nThen stop should be as follows :\nzun-etcd -\u003e zun-compute -\u003e zun-api","commit_id":"dbd6b9d8b974b45402f0875f687391d4ed14fcbd"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"457cc1cec680e622901ea8ad22b5a82571aad146","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    for serv in zun-api zun-compute; do"},{"line_number":364,"context_line":"        stop_process $serv"},{"line_number":365,"context_line":"    done"},{"line_number":366,"context_line":"    if is_service_enabled zun-etcd; then"},{"line_number":367,"context_line":"        stop_zun_etcd"},{"line_number":368,"context_line":"    fi"},{"line_number":369,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6895a0_ac544021","line":366,"in_reply_to":"da6895a0_079fe2b4","updated":"2016-10-25 01:56:22.000000000","message":"Done","commit_id":"dbd6b9d8b974b45402f0875f687391d4ed14fcbd"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"f89dd1cfb001c59b54eca6b843c5cb0efb665e67","unresolved":false,"context_lines":[{"line_number":67,"context_line":"DOCKER_GROUP\u003ddocker"},{"line_number":68,"context_line":"DEFAULT_CONTAINER_DRIVER\u003ddocker"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"ETCD_VERSION\u003dv2.2.2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Functions"},{"line_number":73,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba5da102_e2ba17c0","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":19},"updated":"2016-10-26 11:57:08.000000000","message":"Could you please tell me what is the reason of downgrading the etcd version?","commit_id":"6ea525814beb15aeb64fda9d812d6da8952fe59b"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"c982e4671d12f4d63f6c23e9ea198ff095e5c471","unresolved":false,"context_lines":[{"line_number":67,"context_line":"DOCKER_GROUP\u003ddocker"},{"line_number":68,"context_line":"DEFAULT_CONTAINER_DRIVER\u003ddocker"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"ETCD_VERSION\u003dv2.2.2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Functions"},{"line_number":73,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba5da102_e6dd35e1","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":19},"in_reply_to":"ba5da102_5433f213","updated":"2016-11-02 06:22:43.000000000","message":"Per https://github.com/coreos/etcd/releases/, etcd team has released version 3.0.13, and the issue has been fixed.","commit_id":"6ea525814beb15aeb64fda9d812d6da8952fe59b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"074b183954d9fa573a130cdf11c0b4c46f08b164","unresolved":false,"context_lines":[{"line_number":67,"context_line":"DOCKER_GROUP\u003ddocker"},{"line_number":68,"context_line":"DEFAULT_CONTAINER_DRIVER\u003ddocker"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"ETCD_VERSION\u003dv2.2.2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Functions"},{"line_number":73,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba5da102_5433f213","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":19},"in_reply_to":"ba5da102_71cfa5b0","updated":"2016-11-01 21:32:14.000000000","message":"@Wenzhi, do you have a link to the issue?","commit_id":"6ea525814beb15aeb64fda9d812d6da8952fe59b"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"cc67079087ebeede2a8ca14281f6f65c4bd6a921","unresolved":false,"context_lines":[{"line_number":67,"context_line":"DOCKER_GROUP\u003ddocker"},{"line_number":68,"context_line":"DEFAULT_CONTAINER_DRIVER\u003ddocker"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"ETCD_VERSION\u003dv2.2.2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Functions"},{"line_number":73,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba5da102_71cfa5b0","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":19},"in_reply_to":"ba5da102_e2ba17c0","updated":"2016-10-27 00:52:59.000000000","message":"I saw someone claims he encountered some issue using the latest etcd from an internet post, so I downgraded the version.","commit_id":"6ea525814beb15aeb64fda9d812d6da8952fe59b"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"0255e9ab4cdbecb18d5ed00350ddd64bcfc9e169","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"function start_zun_etcd {"},{"line_number":317,"context_line":"    echo \"Start zun etcd...\""},{"line_number":318,"context_line":"    sudo docker start etcd"},{"line_number":319,"context_line":"}"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"function stop_zun-etcd {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba5da102_a63fbd85","line":318,"range":{"start_line":318,"start_character":4,"end_line":318,"end_character":26},"updated":"2016-11-02 05:46:03.000000000","message":"hi wenzhi, won\u0027t docker -d start a docker instance in #276","commit_id":"6ea525814beb15aeb64fda9d812d6da8952fe59b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f88336b4d2a1e589f2983778412bcca0813f2aa7","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"function start_zun_etcd {"},{"line_number":317,"context_line":"    echo \"Start zun etcd...\""},{"line_number":318,"context_line":"    sudo docker start etcd"},{"line_number":319,"context_line":"}"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"function stop_zun-etcd {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba5da102_2f342148","line":318,"range":{"start_line":318,"start_character":4,"end_line":318,"end_character":26},"in_reply_to":"ba5da102_a63fbd85","updated":"2016-11-03 13:22:14.000000000","message":"This seems to be fine since \"docker start\" is robust enough so it won\u0027t fail if the container is already started.","commit_id":"6ea525814beb15aeb64fda9d812d6da8952fe59b"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"c982e4671d12f4d63f6c23e9ea198ff095e5c471","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"function start_zun_etcd {"},{"line_number":317,"context_line":"    echo \"Start zun etcd...\""},{"line_number":318,"context_line":"    sudo docker start etcd"},{"line_number":319,"context_line":"}"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"function stop_zun-etcd {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba5da102_e604554b","line":318,"range":{"start_line":318,"start_character":4,"end_line":318,"end_character":26},"in_reply_to":"ba5da102_a63fbd85","updated":"2016-11-02 06:22:43.000000000","message":"Yes, a docker container named \u0027etcd\u0027 will be started there, and this function will start that container if it is stopped.","commit_id":"6ea525814beb15aeb64fda9d812d6da8952fe59b"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"1813d10fa1142d1ad0293c0b9aaa7e7d863d8135","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    create_api_paste_conf"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    if [[ ${DEFAULT_CONTAINER_DRIVER} \u003d\u003d \"docker\" ]]; then"},{"line_number":110,"context_line":"        check_docker || install_docker"},{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_7b7ddbb0","line":110,"updated":"2016-11-04 06:48:23.000000000","message":"Before configure_zun, init_zun is called which in-turn calls install_etcd_server inside which we run \"check_docker || install_docker\"\nSo, here we might not need this call again till the time we are running etcd in docker container. Just a thought!","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"1813d10fa1142d1ad0293c0b9aaa7e7d863d8135","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    sudo usermod -a -G ${DOCKER_GROUP} $(whoami)"},{"line_number":260,"context_line":"    newgrp ${DOCKER_GROUP}"},{"line_number":261,"context_line":"    if is_ubuntu; then"},{"line_number":262,"context_line":"        sudo service docker start || true"},{"line_number":263,"context_line":"    else"},{"line_number":264,"context_line":"        sudo systemctl enable docker.service"},{"line_number":265,"context_line":"        sudo systemctl start docker || true"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_58a9fd23","line":262,"updated":"2016-11-04 06:48:23.000000000","message":"Don\u0027t need enabling of service here? As per docker install guide for ubuntu :\nFor 15.04 and up, we should configure the docker daemon to start on boot using systemctl.\nFor 14.10 and below the above installation method automatically configures upstart to start the docker daemon on boot","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"137a503d319a4cb0fab5838b49786edf7f8e382b","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    sudo usermod -a -G ${DOCKER_GROUP} $(whoami)"},{"line_number":260,"context_line":"    newgrp ${DOCKER_GROUP}"},{"line_number":261,"context_line":"    if is_ubuntu; then"},{"line_number":262,"context_line":"        sudo service docker start || true"},{"line_number":263,"context_line":"    else"},{"line_number":264,"context_line":"        sudo systemctl enable docker.service"},{"line_number":265,"context_line":"        sudo systemctl start docker || true"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_fe0f1986","line":262,"in_reply_to":"ba5da102_58a9fd23","updated":"2016-11-04 07:48:06.000000000","message":"Done","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"1813d10fa1142d1ad0293c0b9aaa7e7d863d8135","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    check_docker || install_docker"},{"line_number":272,"context_line":"    # If there\u0027s a container named \u0027etcd\u0027 already exists, remove it."},{"line_number":273,"context_line":"    if [ $(sudo docker ps -a | awk \u0027{print $NF}\u0027 | grep -w etcd) ]; then"},{"line_number":274,"context_line":"        sudo docker rm -f etcd"},{"line_number":275,"context_line":"    fi"},{"line_number":276,"context_line":"    sudo docker run -d -v /usr/share/ca-certificates/:/etc/ssl/certs -p 4001:4001 -p 2380:2380 -p 2379:2379 \\"},{"line_number":277,"context_line":"                    --name etcd quay.io/coreos/etcd:${ETCD_VERSION} \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_7b45dbb1","line":274,"updated":"2016-11-04 06:48:23.000000000","message":"Since we are creating a container with name etcd0 so we should search and remove container with name \"etcd0\" only (from line#272 to line#274).","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"ca49dd2d227fd207fffe1c5f3bbaab52a6b7e966","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    check_docker || install_docker"},{"line_number":272,"context_line":"    # If there\u0027s a container named \u0027etcd\u0027 already exists, remove it."},{"line_number":273,"context_line":"    if [ $(sudo docker ps -a | awk \u0027{print $NF}\u0027 | grep -w etcd) ]; then"},{"line_number":274,"context_line":"        sudo docker rm -f etcd"},{"line_number":275,"context_line":"    fi"},{"line_number":276,"context_line":"    sudo docker run -d -v /usr/share/ca-certificates/:/etc/ssl/certs -p 4001:4001 -p 2380:2380 -p 2379:2379 \\"},{"line_number":277,"context_line":"                    --name etcd quay.io/coreos/etcd:${ETCD_VERSION} \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_fb71eba9","line":274,"range":{"start_line":274,"start_character":26,"end_line":274,"end_character":30},"updated":"2016-11-04 06:05:43.000000000","message":"should this be etcd0 per #278?","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8fc58cd0176f44bbfaac2418f2a203d0c0a4fe9a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    check_docker || install_docker"},{"line_number":272,"context_line":"    # If there\u0027s a container named \u0027etcd\u0027 already exists, remove it."},{"line_number":273,"context_line":"    if [ $(sudo docker ps -a | awk \u0027{print $NF}\u0027 | grep -w etcd) ]; then"},{"line_number":274,"context_line":"        sudo docker rm -f etcd"},{"line_number":275,"context_line":"    fi"},{"line_number":276,"context_line":"    sudo docker run -d -v /usr/share/ca-certificates/:/etc/ssl/certs -p 4001:4001 -p 2380:2380 -p 2379:2379 \\"},{"line_number":277,"context_line":"                    --name etcd quay.io/coreos/etcd:${ETCD_VERSION} \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_84223c00","line":274,"range":{"start_line":274,"start_character":26,"end_line":274,"end_character":30},"in_reply_to":"ba5da102_3b3b633a","updated":"2016-11-04 15:57:02.000000000","message":"I see","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"e7c3f59db80fc94be02c17b618a4ac91c38ec546","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    check_docker || install_docker"},{"line_number":272,"context_line":"    # If there\u0027s a container named \u0027etcd\u0027 already exists, remove it."},{"line_number":273,"context_line":"    if [ $(sudo docker ps -a | awk \u0027{print $NF}\u0027 | grep -w etcd) ]; then"},{"line_number":274,"context_line":"        sudo docker rm -f etcd"},{"line_number":275,"context_line":"    fi"},{"line_number":276,"context_line":"    sudo docker run -d -v /usr/share/ca-certificates/:/etc/ssl/certs -p 4001:4001 -p 2380:2380 -p 2379:2379 \\"},{"line_number":277,"context_line":"                    --name etcd quay.io/coreos/etcd:${ETCD_VERSION} \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_3b3b633a","line":274,"range":{"start_line":274,"start_character":26,"end_line":274,"end_character":30},"in_reply_to":"ba5da102_fb71eba9","updated":"2016-11-04 06:50:36.000000000","message":"Actually it should be \u0027etcd\u0027, in #279 I named the container as \u0027etcd\u0027, not \u0027etcd0\u0027.  And \u0027etcd0\u0027 is the name of the etcd node.\nI\u0027ll change the etcd node name to \u0027node0\u0027 to make it more clear.","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"06a14a159938ff2d538962ddfb0a49b9835396b3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    fi"},{"line_number":276,"context_line":"    sudo docker run -d -v /usr/share/ca-certificates/:/etc/ssl/certs -p 4001:4001 -p 2380:2380 -p 2379:2379 \\"},{"line_number":277,"context_line":"                    --name etcd quay.io/coreos/etcd:${ETCD_VERSION} \\"},{"line_number":278,"context_line":"\t\t    /usr/local/bin/etcd \\"},{"line_number":279,"context_line":"                    --name etcd0 \\"},{"line_number":280,"context_line":"                    --advertise-client-urls http://${HOST_IP}:2379,http://${HOST_IP}:4001 \\"},{"line_number":281,"context_line":"                    --listen-client-urls http://0.0.0.0:2379,http://0.0.0.0:4001 \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_cf1485ea","line":278,"range":{"start_line":278,"start_character":0,"end_line":278,"end_character":6},"updated":"2016-11-03 13:19:54.000000000","message":"nit: spaces instead of tab","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"e7c3f59db80fc94be02c17b618a4ac91c38ec546","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    fi"},{"line_number":276,"context_line":"    sudo docker run -d -v /usr/share/ca-certificates/:/etc/ssl/certs -p 4001:4001 -p 2380:2380 -p 2379:2379 \\"},{"line_number":277,"context_line":"                    --name etcd quay.io/coreos/etcd:${ETCD_VERSION} \\"},{"line_number":278,"context_line":"\t\t    /usr/local/bin/etcd \\"},{"line_number":279,"context_line":"                    --name etcd0 \\"},{"line_number":280,"context_line":"                    --advertise-client-urls http://${HOST_IP}:2379,http://${HOST_IP}:4001 \\"},{"line_number":281,"context_line":"                    --listen-client-urls http://0.0.0.0:2379,http://0.0.0.0:4001 \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_980395be","line":278,"range":{"start_line":278,"start_character":0,"end_line":278,"end_character":6},"in_reply_to":"ba5da102_cf1485ea","updated":"2016-11-04 06:50:36.000000000","message":"Done","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"06a14a159938ff2d538962ddfb0a49b9835396b3","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"function start_zun_etcd {"},{"line_number":318,"context_line":"    echo \"Start zun etcd...\""},{"line_number":319,"context_line":"    sudo docker start etcd"},{"line_number":320,"context_line":"}"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"function stop_zun-etcd {"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_cf99e57a","line":319,"range":{"start_line":319,"start_character":22,"end_line":319,"end_character":26},"updated":"2016-11-03 13:19:54.000000000","message":"Sorry I couldn\u0027t catch this in the previous reviews. It looks this should be \"etcd0\" (as you named it in line #279)","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"1813d10fa1142d1ad0293c0b9aaa7e7d863d8135","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"function start_zun_etcd {"},{"line_number":318,"context_line":"    echo \"Start zun etcd...\""},{"line_number":319,"context_line":"    sudo docker start etcd"},{"line_number":320,"context_line":"}"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"function stop_zun-etcd {"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_bb8bf31d","line":319,"range":{"start_line":319,"start_character":22,"end_line":319,"end_character":26},"in_reply_to":"ba5da102_cf99e57a","updated":"2016-11-04 06:48:23.000000000","message":"+1","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"e7c3f59db80fc94be02c17b618a4ac91c38ec546","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"function start_zun_etcd {"},{"line_number":318,"context_line":"    echo \"Start zun etcd...\""},{"line_number":319,"context_line":"    sudo docker start etcd"},{"line_number":320,"context_line":"}"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"function stop_zun-etcd {"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_78688188","line":319,"range":{"start_line":319,"start_character":22,"end_line":319,"end_character":26},"in_reply_to":"ba5da102_cf99e57a","updated":"2016-11-04 06:50:36.000000000","message":"Actually it should be \u0027etcd\u0027, in #279 I named the container as \u0027etcd\u0027, not \u0027etcd0\u0027.  And \u0027etcd0\u0027 is the name of the etcd node.\nI\u0027ll change the etcd node name to \u0027node0\u0027 to make it more clear.","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"06a14a159938ff2d538962ddfb0a49b9835396b3","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"function stop_zun-etcd {"},{"line_number":323,"context_line":"    echo \"Stop zun etcd...\""},{"line_number":324,"context_line":"    sudo docker stop etcd"},{"line_number":325,"context_line":"}"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"# start_zun() - Start running processes, including screen"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5da102_4f84f509","line":324,"range":{"start_line":324,"start_character":21,"end_line":324,"end_character":25},"updated":"2016-11-03 13:19:54.000000000","message":"ditto. etcd0","commit_id":"3d9d8459292c5dd54a458772447cf4ee00c75e5f"}]}