)]}'
{"zun/compute/manager.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"18755d5b30d84afaf484e051552fa53d28c7aa28","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            image_path \u003d image_driver.pull_image(context, container.image)"},{"line_number":73,"context_line":"        except exception.DockerError as e:"},{"line_number":74,"context_line":"            LOG.error(_LE(\"Error occured while calling docker image API: %s\"),"},{"line_number":75,"context_line":"                      six.text_type(e))"},{"line_number":76,"context_line":"            self._fail_container(container, six.text_type(e))"},{"line_number":77,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_013e65c0","line":74,"updated":"2016-11-03 04:08:24.000000000","message":"I have a basic concern, i may be wrong, \n1) IMHO manager should not handle errors and print errors only for docker runtime, i mean to say it should be something dependent on container runtime i.e. container driver, suppose i use rocket driver then this message doesn\u0027t make sense, \n2) Can we have different exceptions based on operation like ImagePullError or ContainerCreateError or something most appropriate, currently only DockerError is there.\n\nAny suggestions?","commit_id":"544c22e7e2eabcce32567136cb7eb6fe2b849fa5"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"29bb1b58a2ff5ff3c6ba55d1bb0a36dcd1080d19","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            image_path \u003d image_driver.pull_image(context, container.image)"},{"line_number":73,"context_line":"        except exception.DockerError as e:"},{"line_number":74,"context_line":"            LOG.error(_LE(\"Error occured while calling docker image API: %s\"),"},{"line_number":75,"context_line":"                      six.text_type(e))"},{"line_number":76,"context_line":"            self._fail_container(container, six.text_type(e))"},{"line_number":77,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_ab42f3ab","line":74,"in_reply_to":"ba5da102_013e65c0","updated":"2016-11-03 08:03:47.000000000","message":"Good point @Pradeep. It makes sense to log the operation failure instead of compute driver failure.\nIMO currently we can just modify the log message because we only have docker driver implemented at this time.","commit_id":"544c22e7e2eabcce32567136cb7eb6fe2b849fa5"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"5a66231e2c99b71ed7286965091a2489c08e6932","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            image_path \u003d image_driver.pull_image(context, container.image)"},{"line_number":73,"context_line":"        except exception.DockerError as e:"},{"line_number":74,"context_line":"            LOG.error(_LE(\"Error occured while calling docker image API: %s\"),"},{"line_number":75,"context_line":"                      six.text_type(e))"},{"line_number":76,"context_line":"            self._fail_container(container, six.text_type(e))"},{"line_number":77,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_d4c87baa","line":74,"in_reply_to":"ba5da102_ab42f3ab","updated":"2016-11-04 02:17:12.000000000","message":"Because currently only docker driver is supported, and only DockerError is caught here, it is reasonable to log errors like line74.\n\nIf other drivers are supported, it is time to change the exception handling and error message.","commit_id":"544c22e7e2eabcce32567136cb7eb6fe2b849fa5"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c8526867a679548e6eddcc042c3ce6e6d2ed5c95","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            image_path \u003d image_driver.pull_image(context, container.image)"},{"line_number":73,"context_line":"        except exception.DockerError as e:"},{"line_number":74,"context_line":"            LOG.error(_LE(\"Error occured while calling docker image API: %s\"),"},{"line_number":75,"context_line":"                      six.text_type(e))"},{"line_number":76,"context_line":"            self._fail_container(container, six.text_type(e))"},{"line_number":77,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_e0a91d7d","line":74,"in_reply_to":"ba5da102_d4c87baa","updated":"2016-11-04 19:03:19.000000000","message":"Agree. Created a bug for this: https://bugs.launchpad.net/zun/+bug/1639333 .","commit_id":"544c22e7e2eabcce32567136cb7eb6fe2b849fa5"}]}