)]}'
{"zun/image/docker/driver.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ec7cbada4d3572677758eaf35cb59286314b27e5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                      \u0027 context %s\u0027 % (image_name, context))"},{"line_number":49,"context_line":"            self._pull_image(image_name)"},{"line_number":50,"context_line":"            return {\u0027image\u0027: image_name, \u0027path\u0027: None}"},{"line_number":51,"context_line":"        except exception.ImageNotFound as e:"},{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_0d5ca1ec","line":51,"range":{"start_line":51,"start_character":39,"end_line":51,"end_character":43},"updated":"2016-11-04 09:44:40.000000000","message":"this is not required because you\u0027re not using it anywhere.","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"9599834c768aca2a9feb305f31b42054a7367ea1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                      \u0027 context %s\u0027 % (image_name, context))"},{"line_number":49,"context_line":"            self._pull_image(image_name)"},{"line_number":50,"context_line":"            return {\u0027image\u0027: image_name, \u0027path\u0027: None}"},{"line_number":51,"context_line":"        except exception.ImageNotFound as e:"},{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_4f3bca9c","line":51,"range":{"start_line":51,"start_character":39,"end_line":51,"end_character":43},"in_reply_to":"ba5da102_0d5ca1ec","updated":"2016-11-06 05:02:07.000000000","message":"Done","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ec7cbada4d3572677758eaf35cb59286314b27e5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            return {\u0027image\u0027: image_name, \u0027path\u0027: None}"},{"line_number":51,"context_line":"        except exception.ImageNotFound as e:"},{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"},{"line_number":55,"context_line":"            raise e"},{"line_number":56,"context_line":"        except errors.APIError as api_error:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_2df885c4","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":19},"updated":"2016-11-04 09:44:40.000000000","message":"Moreover it hides the actual line where exception was raised.","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"9599834c768aca2a9feb305f31b42054a7367ea1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            return {\u0027image\u0027: image_name, \u0027path\u0027: None}"},{"line_number":51,"context_line":"        except exception.ImageNotFound as e:"},{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"},{"line_number":55,"context_line":"            raise e"},{"line_number":56,"context_line":"        except errors.APIError as api_error:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_6f408e08","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":19},"in_reply_to":"ba5da102_2df885c4","updated":"2016-11-06 05:02:07.000000000","message":"Done","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ec7cbada4d3572677758eaf35cb59286314b27e5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        except exception.ImageNotFound as e:"},{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"},{"line_number":55,"context_line":"            raise e"},{"line_number":56,"context_line":"        except errors.APIError as api_error:"},{"line_number":57,"context_line":"            raise exception.ZunException(str(api_error))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_2d716578","line":54,"range":{"start_line":54,"start_character":36,"end_line":54,"end_character":41},"updated":"2016-11-04 09:44:40.000000000","message":"ditto","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"9599834c768aca2a9feb305f31b42054a7367ea1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        except exception.ImageNotFound as e:"},{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"},{"line_number":55,"context_line":"            raise e"},{"line_number":56,"context_line":"        except errors.APIError as api_error:"},{"line_number":57,"context_line":"            raise exception.ZunException(str(api_error))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8f45e218","line":54,"range":{"start_line":54,"start_character":36,"end_line":54,"end_character":41},"in_reply_to":"ba5da102_2d716578","updated":"2016-11-06 05:02:07.000000000","message":"Done","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ec7cbada4d3572677758eaf35cb59286314b27e5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"},{"line_number":55,"context_line":"            raise e"},{"line_number":56,"context_line":"        except errors.APIError as api_error:"},{"line_number":57,"context_line":"            raise exception.ZunException(str(api_error))"},{"line_number":58,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_6d027db6","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":19},"updated":"2016-11-04 09:44:40.000000000","message":"ditto","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"9599834c768aca2a9feb305f31b42054a7367ea1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            LOG.debug(\u0027Image %s was not found in docker repo\u0027 % image_name)"},{"line_number":53,"context_line":"            raise e"},{"line_number":54,"context_line":"        except exception.DockerError as e:"},{"line_number":55,"context_line":"            raise e"},{"line_number":56,"context_line":"        except errors.APIError as api_error:"},{"line_number":57,"context_line":"            raise exception.ZunException(str(api_error))"},{"line_number":58,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_af4aa625","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":19},"in_reply_to":"ba5da102_6d027db6","updated":"2016-11-06 05:02:07.000000000","message":"Done","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"}],"zun/image/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ef47a2122b619c866b542abc5a8d7c82e9bdd24e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return image"},{"line_number":106,"context_line":"    image_driver_list \u003d CONF.image_driver_list"},{"line_number":107,"context_line":"    count \u003d 0"},{"line_number":108,"context_line":"    for driver in image_driver_list:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            image_driver \u003d load_image_driver(driver)"},{"line_number":111,"context_line":"            image \u003d image_driver.pull_image(context, image_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_00cff1b3","line":108,"range":{"start_line":108,"start_character":4,"end_line":108,"end_character":36},"updated":"2016-11-04 18:54:52.000000000","message":"I think the following style is better:\n\n    for driver in image_driver_list:\n        try:\n            ...\n            image \u003d image_driver.pull_image(...)\n        except exception.ImageNotFound:\n            # maybe log a message\n            pass\n        except Exception as e:\n            ...\n\n    if not image:\n        raise exception.ImageNotFound(...)","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"9599834c768aca2a9feb305f31b42054a7367ea1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return image"},{"line_number":106,"context_line":"    image_driver_list \u003d CONF.image_driver_list"},{"line_number":107,"context_line":"    count \u003d 0"},{"line_number":108,"context_line":"    for driver in image_driver_list:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            image_driver \u003d load_image_driver(driver)"},{"line_number":111,"context_line":"            image \u003d image_driver.pull_image(context, image_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_efbd7e03","line":108,"range":{"start_line":108,"start_character":4,"end_line":108,"end_character":36},"in_reply_to":"ba5da102_00cff1b3","updated":"2016-11-06 05:02:07.000000000","message":"Done","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ec7cbada4d3572677758eaf35cb59286314b27e5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        except exception.ImageNotFound:"},{"line_number":115,"context_line":"            count +\u003d 1"},{"line_number":116,"context_line":"            if count \u003d\u003d len(image_driver_list):"},{"line_number":117,"context_line":"                LOG.error(_LE(\"Image %s not found\") % image_name)"},{"line_number":118,"context_line":"                raise exception.ImageNotFound("},{"line_number":119,"context_line":"                    \"Image %s not found\" % image_name)"},{"line_number":120,"context_line":"        except Exception as e:"},{"line_number":121,"context_line":"            LOG.exception(_LE(\u0027Unknown exception occured while loading\u0027"},{"line_number":122,"context_line":"                              \u0027 image : %s\u0027), str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_4d1cd913","line":119,"range":{"start_line":117,"start_character":16,"end_line":119,"end_character":54},"updated":"2016-11-04 09:44:40.000000000","message":"better to declare a error message string here.","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"9599834c768aca2a9feb305f31b42054a7367ea1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        except exception.ImageNotFound:"},{"line_number":115,"context_line":"            count +\u003d 1"},{"line_number":116,"context_line":"            if count \u003d\u003d len(image_driver_list):"},{"line_number":117,"context_line":"                LOG.error(_LE(\"Image %s not found\") % image_name)"},{"line_number":118,"context_line":"                raise exception.ImageNotFound("},{"line_number":119,"context_line":"                    \"Image %s not found\" % image_name)"},{"line_number":120,"context_line":"        except Exception as e:"},{"line_number":121,"context_line":"            LOG.exception(_LE(\u0027Unknown exception occured while loading\u0027"},{"line_number":122,"context_line":"                              \u0027 image : %s\u0027), str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_0fbb920f","line":119,"range":{"start_line":117,"start_character":16,"end_line":119,"end_character":54},"in_reply_to":"ba5da102_4d1cd913","updated":"2016-11-06 05:02:07.000000000","message":"Done","commit_id":"6c0a57cf4564dcead9a9235f79fab1e1c3ae7933"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"598568ba562198d777d972995ccf116db3482fff","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"image_driver_opts \u003d ["},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027image_driver_list\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027docker.driver.DockerDriver\u0027],"},{"line_number":34,"context_line":"                help\u003d\"\"\"Defines the list of image driver to use for downloading image."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_c6e7c0aa","line":32,"range":{"start_line":32,"start_character":17,"end_line":32,"end_character":34},"updated":"2016-11-06 16:53:18.000000000","message":"This is irrelevant to this patch, but this should be moved to zun/conf/...","commit_id":"38593ee6d30a66c26506f2203ce1271e0b5a8be8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"1b03515dc62ef8c3d9fa9181949574c785d35196","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"image_driver_opts \u003d ["},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027image_driver_list\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027docker.driver.DockerDriver\u0027],"},{"line_number":34,"context_line":"                help\u003d\"\"\"Defines the list of image driver to use for downloading image."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_5dc47991","line":32,"range":{"start_line":32,"start_character":17,"end_line":32,"end_character":34},"in_reply_to":"ba5da102_007c381f","updated":"2016-11-07 15:31:28.000000000","message":"For sure. BTW, I think this patch needs a rebase since it depends on another patch that was abandoned.","commit_id":"38593ee6d30a66c26506f2203ce1271e0b5a8be8"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"a7c9d2c352474acd446212f82a4bf25bd7a17960","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"image_driver_opts \u003d ["},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027image_driver_list\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027docker.driver.DockerDriver\u0027],"},{"line_number":34,"context_line":"                help\u003d\"\"\"Defines the list of image driver to use for downloading image."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_007c381f","line":32,"range":{"start_line":32,"start_character":17,"end_line":32,"end_character":34},"in_reply_to":"ba5da102_c6e7c0aa","updated":"2016-11-07 04:09:45.000000000","message":"I will move all the remaining conf option to central conf directory in next patch. From there we can restrict everyone to put the conf at central place. Is it ok?","commit_id":"38593ee6d30a66c26506f2203ce1271e0b5a8be8"}]}