)]}'
{"zun/compute/manager.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"986e5829cabdcdd8dbd8d5fd82f0ec4e0e46b70e","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        try:"},{"line_number":280,"context_line":"            repo_tag \u003d image.repo + \":\" + image.tag"},{"line_number":281,"context_line":"            image_driver.pull_image(context, repo_tag)"},{"line_number":282,"context_line":"            image_dict \u003d self.driver.inspect_image(repo_tag)"},{"line_number":283,"context_line":"            image.image_id \u003d image_dict[\u0027Id\u0027]"},{"line_number":284,"context_line":"            image.size \u003d image_dict[\u0027Size\u0027]"},{"line_number":285,"context_line":"            image.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_80168f53","line":282,"updated":"2016-11-06 14:56:49.000000000","message":"What if image driver is glance, then i don\u0027t think , driver.inspect_image is going to work, becoz image is not loaded yet via docker load call. \nSo i think before inspecting the image the image should be loaded if image is downloaded from glance. Am i right?","commit_id":"bbf2d4f77b424eb8cfef176c494138c488980dec"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"9de0553cc8b74f8cdc322b6a4d31c959a9e4ff79","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        try:"},{"line_number":280,"context_line":"            repo_tag \u003d image.repo + \":\" + image.tag"},{"line_number":281,"context_line":"            image_driver.pull_image(context, repo_tag)"},{"line_number":282,"context_line":"            image_dict \u003d self.driver.inspect_image(repo_tag)"},{"line_number":283,"context_line":"            image.image_id \u003d image_dict[\u0027Id\u0027]"},{"line_number":284,"context_line":"            image.size \u003d image_dict[\u0027Size\u0027]"},{"line_number":285,"context_line":"            image.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_865dc8ee","line":282,"in_reply_to":"ba5da102_80168f53","updated":"2016-11-06 15:18:36.000000000","message":"I believe that if image driver is glance then pull_image() should load it implicit instead of the caller of API doing it. For the caller driver is an abstracted layer and caller should not act/perform anything extra according to the driver type but the driver itself should do if any extra processing is required. I guess that will be handled in glance driver.","commit_id":"bbf2d4f77b424eb8cfef176c494138c488980dec"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"617466f8aba37dfd6c5bbeb3b7aa3e8011f9218c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        try:"},{"line_number":280,"context_line":"            repo_tag \u003d image.repo + \":\" + image.tag"},{"line_number":281,"context_line":"            image_driver.pull_image(context, repo_tag)"},{"line_number":282,"context_line":"            image_dict \u003d self.driver.inspect_image(repo_tag)"},{"line_number":283,"context_line":"            image.image_id \u003d image_dict[\u0027Id\u0027]"},{"line_number":284,"context_line":"            image.size \u003d image_dict[\u0027Size\u0027]"},{"line_number":285,"context_line":"            image.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_20921c58","line":282,"in_reply_to":"ba5da102_865dc8ee","updated":"2016-11-07 04:07:04.000000000","message":"I agree with you, actually image driver should be responsible for inspect_image call not container driver. But in current implementation if you pull the image from glance and inspect in docker driver without load , then i think its not going to work. So its better to handle docker load in inspect_image for now as we are doing in container create.\nIts necessary because glance driver knows nothing about container runtime, and load is specific to container driver. Am i right?  Any thoughts?","commit_id":"bbf2d4f77b424eb8cfef176c494138c488980dec"}]}