)]}'
{"zun/common/exception.py":[{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"695295882e014f50de0de5d1b69892a500833808","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            if http_error_code \u003e\u003d 500:"},{"line_number":118,"context_line":"                # log the error message with its associated"},{"line_number":119,"context_line":"                # correlation id"},{"line_number":120,"context_line":"                log_correlation_id \u003d str(uuidutils.generate_uuid())"},{"line_number":121,"context_line":"                LOG.error(_LE(\"%(correlation_id)s:%(excp)s\") %"},{"line_number":122,"context_line":"                          {\u0027correlation_id\u0027: log_correlation_id,"},{"line_number":123,"context_line":"                           \u0027excp\u0027: str(excp)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_91a2f5fb","line":120,"updated":"2016-11-10 06:56:57.000000000","message":"Ditto. Refer:  http://docs.openstack.org/developer/oslo.utils/api/uuidutils.html","commit_id":"8c12566b8cf37066c343e800ff100861016e7bd3"}],"zun/common/short_id.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"d7dee8e6f26f5c568dfd7825e9a74c74bb1aad7e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from zun.common.i18n import _"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def _to_byte_string(value, num_bits):"},{"line_number":27,"context_line":"    \"\"\"Convert an integer to a big-endian string of bytes with padding."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Padding is added at the end (i.e. after the least-significant bit) if"},{"line_number":30,"context_line":"    required."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    shifts \u003d six.moves.xrange(num_bits - 8, -8, -8)"},{"line_number":34,"context_line":"    byte_at \u003d lambda off: (value \u003e\u003e off if off \u003e\u003d 0 else value \u003c\u003c -off) \u0026 0xff"},{"line_number":35,"context_line":"    return \u0027\u0027.join(chr(byte_at(offset)) for offset in shifts)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_id(source_uuid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_9b8f7429","side":"PARENT","line":35,"range":{"start_line":22,"start_character":0,"end_line":35,"end_character":61},"updated":"2016-11-10 05:55:59.000000000","message":"is this change intended?","commit_id":"d8afdd5978b844a3d4b71a3ee3ed1393e3780a83"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"695295882e014f50de0de5d1b69892a500833808","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from zun.common.i18n import _"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def _to_byte_string(value, num_bits):"},{"line_number":27,"context_line":"    \"\"\"Convert an integer to a big-endian string of bytes with padding."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Padding is added at the end (i.e. after the least-significant bit) if"},{"line_number":30,"context_line":"    required."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    shifts \u003d six.moves.xrange(num_bits - 8, -8, -8)"},{"line_number":34,"context_line":"    byte_at \u003d lambda off: (value \u003e\u003e off if off \u003e\u003d 0 else value \u003c\u003c -off) \u0026 0xff"},{"line_number":35,"context_line":"    return \u0027\u0027.join(chr(byte_at(offset)) for offset in shifts)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_id(source_uuid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_36483fcc","side":"PARENT","line":35,"range":{"start_line":22,"start_character":0,"end_line":35,"end_character":61},"in_reply_to":"9a629dbe_9b8f7429","updated":"2016-11-10 06:56:57.000000000","message":"probably because the code that calls this function is removed too. https://review.openstack.org/#/c/395302/2/zun/common/short_id.py@a51","commit_id":"d8afdd5978b844a3d4b71a3ee3ed1393e3780a83"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"2a4ada2980bddddd760346f7e5fb4284efb213b1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    encoded \u003d base64.b32encode(six.b(source_uuid))[:12]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    if six.PY3:"},{"line_number":32,"context_line":"        return encoded.lower().decode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_7860e6a5","line":29,"updated":"2016-11-10 04:53:49.000000000","message":"@feng, i don\u0027t have much knowledge about the code this code, but would like to ask JFMI , why you have removed the extra code.\nI can see that  uuidutils.generate_uuid() is just returning str(uuid.uuid4())[https://github.com/openstack/oslo.utils/blob/master/oslo_utils/uuidutils.py]","commit_id":"8c12566b8cf37066c343e800ff100861016e7bd3"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"695295882e014f50de0de5d1b69892a500833808","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    encoded \u003d base64.b32encode(six.b(source_uuid))[:12]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    if six.PY3:"},{"line_number":32,"context_line":"        return encoded.lower().decode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_51477d4a","line":29,"in_reply_to":"9a629dbe_7860e6a5","updated":"2016-11-10 06:56:57.000000000","message":"+1 Curious to know.","commit_id":"8c12566b8cf37066c343e800ff100861016e7bd3"}],"zun/common/utils.py":[{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"695295882e014f50de0de5d1b69892a500833808","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def generate_uuid():"},{"line_number":74,"context_line":"    return str(uuidutils.generate_uuid())"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def spawn_n(func, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_113a65cc","line":74,"updated":"2016-11-10 06:56:57.000000000","message":"Do we really need type_casting to str here. As per spec generate_uuid() return string only.\nhttp://docs.openstack.org/developer/oslo.utils/api/uuidutils.html","commit_id":"8c12566b8cf37066c343e800ff100861016e7bd3"}]}