)]}'
{"zun/common/utils.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"ba204e4c2fb941d51039d778009ec3119d81ed18","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    return str(uuid.uuid4())"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def parse_image_tag(image):"},{"line_number":78,"context_line":"    image_parts \u003d image.split(\u0027:\u0027, 1)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    image_repo \u003d image_parts[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_25cacb4e","line":77,"updated":"2016-11-10 04:26:48.000000000","message":"Can we rename it to parse_image_name?","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"a6a2f2a0071c2f4a9421634f3a3f2ebe9fac1832","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    return str(uuid.uuid4())"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def parse_image_tag(image):"},{"line_number":78,"context_line":"    image_parts \u003d image.split(\u0027:\u0027, 1)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    image_repo \u003d image_parts[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_fb223051","line":77,"in_reply_to":"9a629dbe_25cacb4e","updated":"2016-11-10 05:50:23.000000000","message":"+1. Can be done.","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"07eb140d457f14225cf0ad1729481319fbcfcd06","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    return str(uuid.uuid4())"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def parse_image_tag(image):"},{"line_number":78,"context_line":"    image_parts \u003d image.split(\u0027:\u0027, 1)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    image_repo \u003d image_parts[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_711b8fca","line":77,"in_reply_to":"9a629dbe_fb223051","updated":"2016-11-10 13:29:36.000000000","message":"Done","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"}],"zun/compute/manager.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"eb3f1db8d5c9b76110f896d509707a3f8e9e2099","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    def image_create(self, context, image):"},{"line_number":280,"context_line":"        utils.spawn_n(self._do_image_create, context, image)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _do_image_create(self, context, image):"},{"line_number":283,"context_line":"        LOG.debug(\u0027Creating image...\u0027, context\u003dcontext,"},{"line_number":284,"context_line":"                  image\u003dimage)"},{"line_number":285,"context_line":"        repo_tag \u003d image.repo + \":\" + image.tag"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_026dc230","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":24},"updated":"2016-11-09 23:37:10.000000000","message":"This is unrelated to this patch but it is better to rename this method to \"_do_image_pull\" (rename method above to \"image_pull\"). That is because what it does is pulling an image instead of creating an image.\n\nHowever, let\u0027s discuss it later.","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"ba204e4c2fb941d51039d778009ec3119d81ed18","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    def image_create(self, context, image):"},{"line_number":280,"context_line":"        utils.spawn_n(self._do_image_create, context, image)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _do_image_create(self, context, image):"},{"line_number":283,"context_line":"        LOG.debug(\u0027Creating image...\u0027, context\u003dcontext,"},{"line_number":284,"context_line":"                  image\u003dimage)"},{"line_number":285,"context_line":"        repo_tag \u003d image.repo + \":\" + image.tag"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_45bdff00","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":24},"in_reply_to":"9a629dbe_026dc230","updated":"2016-11-10 04:26:48.000000000","message":"+1","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"}],"zun/image/docker/driver.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"ba204e4c2fb941d51039d778009ec3119d81ed18","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def __init__(self):"},{"line_number":33,"context_line":"        super(DockerDriver, self).__init__()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _pull_image(self, image_name, tag):"},{"line_number":36,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":37,"context_line":"            for line in docker.pull(image_name, tag\u003dtag, stream\u003dTrue):"},{"line_number":38,"context_line":"                error \u003d json.loads(line).get(\u0027errorDetail\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_05d14723","line":35,"updated":"2016-11-10 04:26:48.000000000","message":"better to rename image_name to repo?","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"07eb140d457f14225cf0ad1729481319fbcfcd06","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def __init__(self):"},{"line_number":33,"context_line":"        super(DockerDriver, self).__init__()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _pull_image(self, image_name, tag):"},{"line_number":36,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":37,"context_line":"            for line in docker.pull(image_name, tag\u003dtag, stream\u003dTrue):"},{"line_number":38,"context_line":"                error \u003d json.loads(line).get(\u0027errorDetail\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_3153d76c","line":35,"in_reply_to":"9a629dbe_05d14723","updated":"2016-11-10 13:29:36.000000000","message":"Done","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"}],"zun/image/driver.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"ba204e4c2fb941d51039d778009ec3119d81ed18","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    for driver in image_driver_list:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            image_driver \u003d load_image_driver(driver)"},{"line_number":111,"context_line":"            image \u003d image_driver.pull_image(context, image_name, tag)"},{"line_number":112,"context_line":"            if image:"},{"line_number":113,"context_line":"                break"},{"line_number":114,"context_line":"        except exception.ImageNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_257c8b1e","line":111,"updated":"2016-11-10 04:26:48.000000000","message":"image_name -\u003e repo","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"07eb140d457f14225cf0ad1729481319fbcfcd06","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    for driver in image_driver_list:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            image_driver \u003d load_image_driver(driver)"},{"line_number":111,"context_line":"            image \u003d image_driver.pull_image(context, image_name, tag)"},{"line_number":112,"context_line":"            if image:"},{"line_number":113,"context_line":"                break"},{"line_number":114,"context_line":"        except exception.ImageNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_11041348","line":111,"in_reply_to":"9a629dbe_257c8b1e","updated":"2016-11-10 13:29:36.000000000","message":"Done","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"ba204e4c2fb941d51039d778009ec3119d81ed18","unresolved":false,"context_lines":[{"line_number":125,"context_line":"class ContainerImageDriver(object):"},{"line_number":126,"context_line":"    \u0027\u0027\u0027Base class for container image driver.\u0027\u0027\u0027"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def pull_image(self, context, image, tag):"},{"line_number":129,"context_line":"        \"\"\"Create an image.\"\"\""},{"line_number":130,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_4575ff2f","line":128,"updated":"2016-11-10 04:26:48.000000000","message":"ditto","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"07eb140d457f14225cf0ad1729481319fbcfcd06","unresolved":false,"context_lines":[{"line_number":125,"context_line":"class ContainerImageDriver(object):"},{"line_number":126,"context_line":"    \u0027\u0027\u0027Base class for container image driver.\u0027\u0027\u0027"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def pull_image(self, context, image, tag):"},{"line_number":129,"context_line":"        \"\"\"Create an image.\"\"\""},{"line_number":130,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_71f70f59","line":128,"in_reply_to":"9a629dbe_4575ff2f","updated":"2016-11-10 13:29:36.000000000","message":"Done","commit_id":"75c8240fa15867e0e8b7788b981141b244effd4c"}]}
