)]}'
{"zun/compute/manager.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d5cf4ef5cedfcbb1bafdb81876ccce32b0813688","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            raise e"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @translate_exception"},{"line_number":211,"context_line":"    def container_start(self, context, container):"},{"line_number":212,"context_line":"        LOG.debug(\u0027Starting container...\u0027, context\u003dcontext,"},{"line_number":213,"context_line":"                  container\u003dcontainer.uuid)"},{"line_number":214,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_66546dc9","line":211,"range":{"start_line":211,"start_character":8,"end_line":211,"end_character":23},"updated":"2016-11-12 04:13:39.000000000","message":"It seems this method can call _do_container_start instead?","commit_id":"e7663dd9409dd137d21cae2a613fa1664c5772d2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"40a719082cc909dadcde506aaa526b2fa2936b49","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        created_container \u003d self._do_container_create(context,"},{"line_number":72,"context_line":"                                                      container,"},{"line_number":73,"context_line":"                                                      reraise\u003dTrue)"},{"line_number":74,"context_line":"        if created_container:"},{"line_number":75,"context_line":"            return self._do_container_start(context, created_container)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _do_container_create(self, context, container, reraise\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_1ef3b89f","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":28},"updated":"2016-11-15 21:01:53.000000000","message":"I think we should raise exception if created_container is None.","commit_id":"88e1f25c3b41d98e5b206550a61096c20b0af641"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"04355c4cfd4360e2bd870d96b84744b58bdb8d99","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        created_container \u003d self._do_container_create(context,"},{"line_number":72,"context_line":"                                                      container,"},{"line_number":73,"context_line":"                                                      reraise\u003dTrue)"},{"line_number":74,"context_line":"        if created_container:"},{"line_number":75,"context_line":"            return self._do_container_start(context, created_container)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _do_container_create(self, context, container, reraise\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_7bde706e","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":28},"in_reply_to":"7a77a97e_1ef3b89f","updated":"2016-11-16 05:08:19.000000000","message":"I think it would never be None, it can be None only when some exception is raised, and i am always raising exception due to  reraise flag not handling that exception so exception will be passed to upper level function. What do you think?","commit_id":"88e1f25c3b41d98e5b206550a61096c20b0af641"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d7c2231eaaef1bcbc5a377a4b2e59e7a43410fd2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        created_container \u003d self._do_container_create(context,"},{"line_number":72,"context_line":"                                                      container,"},{"line_number":73,"context_line":"                                                      reraise\u003dTrue)"},{"line_number":74,"context_line":"        if created_container:"},{"line_number":75,"context_line":"            return self._do_container_start(context, created_container)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _do_container_create(self, context, container, reraise\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_aa3fa5d4","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":28},"in_reply_to":"7a77a97e_7bde706e","updated":"2016-11-16 20:26:30.000000000","message":"OK. Get your points. Perhaps I am thinking from the code reader point of view. If we are confident that it cannot be None, then how about removing the \"if\" check. On the other side, if we are not that confident or we want to be robust to handle unexpected cases, then how about doing the check and raising an exception if it is None?","commit_id":"88e1f25c3b41d98e5b206550a61096c20b0af641"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"4dbc369e491fcf1787350ea28d8886e175f52c8f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        created_container \u003d self._do_container_create(context,"},{"line_number":72,"context_line":"                                                      container,"},{"line_number":73,"context_line":"                                                      reraise\u003dTrue)"},{"line_number":74,"context_line":"        if created_container:"},{"line_number":75,"context_line":"            return self._do_container_start(context, created_container)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _do_container_create(self, context, container, reraise\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_601e7e60","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":28},"in_reply_to":"7a77a97e_aa3fa5d4","updated":"2016-11-17 04:03:50.000000000","message":"Done","commit_id":"88e1f25c3b41d98e5b206550a61096c20b0af641"}]}
