)]}'
{"specs/container-interactive-mode.rst":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ead786679ad8cae58fbfb219bafad411eb3842ec","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/zun/+spec/support-interactive-mode"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Zun needs to support the function that the interactive mode which is the "},{"line_number":15,"context_line":"basic function in Docker and rkt. With interactive mode, user can do run "},{"line_number":16,"context_line":"command then user can do interactive operation in Zun. "},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_80fb1747","line":14,"range":{"start_line":14,"start_character":72,"end_line":14,"end_character":73},"updated":"2016-11-14 03:12:00.000000000","message":"nit: extra space","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/zun/+spec/support-interactive-mode"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Zun needs to support the function that the interactive mode which is the "},{"line_number":15,"context_line":"basic function in Docker and rkt. With interactive mode, user can do run "},{"line_number":16,"context_line":"command then user can do interactive operation in Zun. "},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_10b9622e","line":14,"range":{"start_line":14,"start_character":72,"end_line":14,"end_character":73},"in_reply_to":"9a629dbe_80fb1747","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/zun/+spec/support-interactive-mode"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Zun needs to support the function that the interactive mode which is the "},{"line_number":15,"context_line":"basic function in Docker and rkt. With interactive mode, user can do run "},{"line_number":16,"context_line":"command then user can do interactive operation in Zun. "},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The implementation of interactive mode is driver-specific. Each driver needs to"},{"line_number":19,"context_line":"implement this function need to do different thing about API command and "}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_96519ddb","line":16,"range":{"start_line":15,"start_character":34,"end_line":16,"end_character":53},"updated":"2016-11-14 04:42:02.000000000","message":"Can we modify this statement as below for better understanding ?:\nCurrently user can run commands inside a container using zun. With interactive mode, users will be able to perform interactive operations on these containers using Zun APIs.","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/zun/+spec/support-interactive-mode"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Zun needs to support the function that the interactive mode which is the "},{"line_number":15,"context_line":"basic function in Docker and rkt. With interactive mode, user can do run "},{"line_number":16,"context_line":"command then user can do interactive operation in Zun. "},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The implementation of interactive mode is driver-specific. Each driver needs to"},{"line_number":19,"context_line":"implement this function need to do different thing about API command and "}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_30b49e33","line":16,"range":{"start_line":15,"start_character":34,"end_line":16,"end_character":53},"in_reply_to":"9a629dbe_96519ddb","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ead786679ad8cae58fbfb219bafad411eb3842ec","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The implementation of interactive mode is driver-specific. Each driver needs to"},{"line_number":19,"context_line":"implement this function need to do different thing about API command and "},{"line_number":20,"context_line":"interactive interface.Take docker driver as the first container driver."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_20a32b51","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":26},"updated":"2016-11-14 03:12:00.000000000","message":"nit: space in before.","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The implementation of interactive mode is driver-specific. Each driver needs to"},{"line_number":19,"context_line":"implement this function need to do different thing about API command and "},{"line_number":20,"context_line":"interactive interface.Take docker driver as the first container driver."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_50859a57","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":26},"in_reply_to":"9a629dbe_20a32b51","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"Zun containers now take Docker as the first container driver. Docker can use"},{"line_number":25,"context_line":"\"docker run -it\" to enter into the interactive mode , where user can do operation"},{"line_number":26,"context_line":"looks like chroot. Zun use docker.py as the interface to get access the docker "},{"line_number":27,"context_line":"deamon."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_569f0550","line":25,"range":{"start_line":25,"start_character":72,"end_line":25,"end_character":81},"updated":"2016-11-14 04:42:02.000000000","message":"Can we change it as given below? \ns/operation/operations that/","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"Zun containers now take Docker as the first container driver. Docker can use"},{"line_number":25,"context_line":"\"docker run -it\" to enter into the interactive mode , where user can do operation"},{"line_number":26,"context_line":"looks like chroot. Zun use docker.py as the interface to get access the docker "},{"line_number":27,"context_line":"deamon."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_7088d671","line":25,"range":{"start_line":25,"start_character":72,"end_line":25,"end_character":81},"in_reply_to":"9a629dbe_569f0550","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"Zun containers now take Docker as the first container driver. Docker can use"},{"line_number":25,"context_line":"\"docker run -it\" to enter into the interactive mode , where user can do operation"},{"line_number":26,"context_line":"looks like chroot. Zun use docker.py as the interface to get access the docker "},{"line_number":27,"context_line":"deamon."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_9668bd89","line":26,"range":{"start_line":26,"start_character":27,"end_line":26,"end_character":36},"updated":"2016-11-14 04:42:02.000000000","message":"You meant docker-py here?","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"Zun containers now take Docker as the first container driver. Docker can use"},{"line_number":25,"context_line":"\"docker run -it\" to enter into the interactive mode , where user can do operation"},{"line_number":26,"context_line":"looks like chroot. Zun use docker.py as the interface to get access the docker "},{"line_number":27,"context_line":"deamon."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_907bb27a","line":26,"range":{"start_line":26,"start_character":27,"end_line":26,"end_character":36},"in_reply_to":"9a629dbe_9668bd89","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deamon."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"},{"line_number":30,"context_line":"correct the parameters when create container and start container at the time"},{"line_number":31,"context_line":"it has been created, so that a tty will be created inside the container.User "},{"line_number":32,"context_line":"can connect the stdin, stdout, stderr to get a pseudo tty in local client.Then"},{"line_number":33,"context_line":"will realize the interactive mode."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_36c9b15b","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":11},"updated":"2016-11-14 04:42:02.000000000","message":"I guess you meant \"tty\" here?","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ead786679ad8cae58fbfb219bafad411eb3842ec","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deamon."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"},{"line_number":30,"context_line":"correct the parameters when create container and start container at the time"},{"line_number":31,"context_line":"it has been created, so that a tty will be created inside the container.User "},{"line_number":32,"context_line":"can connect the stdin, stdout, stderr to get a pseudo tty in local client.Then"},{"line_number":33,"context_line":"will realize the interactive mode."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_a0a65b51","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":11},"updated":"2016-11-14 03:12:00.000000000","message":"remove the","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ead786679ad8cae58fbfb219bafad411eb3842ec","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":"1. Realize the interactive pty code ,zunclient can call this function to "},{"line_number":38,"context_line":"   realize the pseudo tty. Since that it has no update and no one maintain"},{"line_number":39,"context_line":"   this code for a long time, I will take this just for reference and realize"},{"line_number":40,"context_line":"   more suitable function for Zun client."},{"line_number":41,"context_line":"2. For docker container, the new two paramaters about tty and stdin_open should "},{"line_number":42,"context_line":"   be added to the container field and corresponding database."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_a07d7bb3","line":39,"range":{"start_line":39,"start_character":3,"end_line":39,"end_character":12},"updated":"2016-11-14 03:12:00.000000000","message":"link?","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":"1. Realize the interactive pty code ,zunclient can call this function to "},{"line_number":38,"context_line":"   realize the pseudo tty. Since that it has no update and no one maintain"},{"line_number":39,"context_line":"   this code for a long time, I will take this just for reference and realize"},{"line_number":40,"context_line":"   more suitable function for Zun client."},{"line_number":41,"context_line":"2. For docker container, the new two paramaters about tty and stdin_open should "},{"line_number":42,"context_line":"   be added to the container field and corresponding database."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_30157ee4","line":39,"range":{"start_line":39,"start_character":3,"end_line":39,"end_character":12},"in_reply_to":"9a629dbe_a07d7bb3","updated":"2016-11-28 14:40:01.000000000","message":"Turn to refer to Kubernetes :-)","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ead786679ad8cae58fbfb219bafad411eb3842ec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"2. For docker container, the new two paramaters about tty and stdin_open should "},{"line_number":42,"context_line":"   be added to the container field and corresponding database."},{"line_number":43,"context_line":"3. The python-zunclient will filter the parameters and pick up the correct "},{"line_number":44,"context_line":"   for interactive mode. Then will Open the connection to container at local "},{"line_number":45,"context_line":"   terminal after the \"zun run\" command return."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The diagram below offers an overview of the interactive mode architecture."},{"line_number":48,"context_line":"E.g : zun run -it --name test --image cirros --command \"/bin/sh\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_c3fd190a","line":45,"range":{"start_line":44,"start_character":71,"end_line":45,"end_character":11},"updated":"2016-11-14 03:12:00.000000000","message":"To make sure, will this work if python-zunclient, zun-api, zun-compute are all in different hosts? For example, end-users is using python-zunclient at host A, zun-api is at host B, zun-compute is at host C.","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":41,"context_line":"2. For docker container, the new two paramaters about tty and stdin_open should "},{"line_number":42,"context_line":"   be added to the container field and corresponding database."},{"line_number":43,"context_line":"3. The python-zunclient will filter the parameters and pick up the correct "},{"line_number":44,"context_line":"   for interactive mode. Then will Open the connection to container at local "},{"line_number":45,"context_line":"   terminal after the \"zun run\" command return."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The diagram below offers an overview of the interactive mode architecture."},{"line_number":48,"context_line":"E.g : zun run -it --name test --image cirros --command \"/bin/sh\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_76c32939","line":45,"range":{"start_line":44,"start_character":71,"end_line":45,"end_character":11},"in_reply_to":"9a629dbe_c3fd190a","updated":"2016-11-14 04:42:02.000000000","message":"+1","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"2. For docker container, the new two paramaters about tty and stdin_open should "},{"line_number":42,"context_line":"   be added to the container field and corresponding database."},{"line_number":43,"context_line":"3. The python-zunclient will filter the parameters and pick up the correct "},{"line_number":44,"context_line":"   for interactive mode. Then will Open the connection to container at local "},{"line_number":45,"context_line":"   terminal after the \"zun run\" command return."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The diagram below offers an overview of the interactive mode architecture."},{"line_number":48,"context_line":"E.g : zun run -it --name test --image cirros --command \"/bin/sh\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_f094e68b","line":45,"range":{"start_line":44,"start_character":71,"end_line":45,"end_character":11},"in_reply_to":"9a629dbe_c3fd190a","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ead786679ad8cae58fbfb219bafad411eb3842ec","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          |     zun start       |        |                  |        |  connect stdin  |"},{"line_number":81,"context_line":"          |     container       +--------+     Notify CLI   +--------+  stdout stderr  +"},{"line_number":82,"context_line":"          |                     |        |                  |        |  in container   |"},{"line_number":83,"context_line":"          +----------+----------+        +------------------+        +-----------------+"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Design Principles"},{"line_number":86,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_c016ef57","line":83,"updated":"2016-11-14 03:12:00.000000000","message":"I think using a sequence diagram might be more clear....","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          |     zun start       |        |                  |        |  connect stdin  |"},{"line_number":81,"context_line":"          |     container       +--------+     Notify CLI   +--------+  stdout stderr  +"},{"line_number":82,"context_line":"          |                     |        |                  |        |  in container   |"},{"line_number":83,"context_line":"          +----------+----------+        +------------------+        +-----------------+"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Design Principles"},{"line_number":86,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_969b5d72","line":83,"in_reply_to":"9a629dbe_c016ef57","updated":"2016-11-14 04:42:02.000000000","message":"+1","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          |     zun start       |        |                  |        |  connect stdin  |"},{"line_number":81,"context_line":"          |     container       +--------+     Notify CLI   +--------+  stdout stderr  +"},{"line_number":82,"context_line":"          |                     |        |                  |        |  in container   |"},{"line_number":83,"context_line":"          +----------+----------+        +------------------+        +-----------------+"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Design Principles"},{"line_number":86,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_50ecba29","line":83,"in_reply_to":"9a629dbe_c016ef57","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":86,"context_line":"-----------------"},{"line_number":87,"context_line":"1. Keep commonality for Docker and other container driver. Easy for other driver"},{"line_number":88,"context_line":"   integration."},{"line_number":89,"context_line":"2. Take into accout all the interactive conditions."},{"line_number":90,"context_line":"3. Pty connection functions need to be independence and extensibility"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_96ffdda9","line":89,"range":{"start_line":89,"start_character":13,"end_line":89,"end_character":19},"updated":"2016-11-14 04:42:02.000000000","message":"s/accout/account","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"-----------------"},{"line_number":87,"context_line":"1. Keep commonality for Docker and other container driver. Easy for other driver"},{"line_number":88,"context_line":"   integration."},{"line_number":89,"context_line":"2. Take into accout all the interactive conditions."},{"line_number":90,"context_line":"3. Pty connection functions need to be independence and extensibility"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_70eff61d","line":89,"range":{"start_line":89,"start_character":13,"end_line":89,"end_character":19},"in_reply_to":"9a629dbe_96ffdda9","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":87,"context_line":"1. Keep commonality for Docker and other container driver. Easy for other driver"},{"line_number":88,"context_line":"   integration."},{"line_number":89,"context_line":"2. Take into accout all the interactive conditions."},{"line_number":90,"context_line":"3. Pty connection functions need to be independence and extensibility"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_162aed2c","line":90,"range":{"start_line":90,"start_character":39,"end_line":90,"end_character":51},"updated":"2016-11-14 04:42:02.000000000","message":"s/independence/independent and s/extensibility/extensible","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"1. Keep commonality for Docker and other container driver. Easy for other driver"},{"line_number":88,"context_line":"   integration."},{"line_number":89,"context_line":"2. Take into accout all the interactive conditions."},{"line_number":90,"context_line":"3. Pty connection functions need to be independence and extensibility"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_90f2d204","line":90,"range":{"start_line":90,"start_character":39,"end_line":90,"end_character":51},"in_reply_to":"9a629dbe_162aed2c","updated":"2016-11-28 14:40:01.000000000","message":"Done","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ead786679ad8cae58fbfb219bafad411eb3842ec","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"REST API impact"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":"Add an new API for \"zun run\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Security impact"},{"line_number":105,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_a33025ea","line":102,"updated":"2016-11-14 03:12:00.000000000","message":"How about the terminal connection. I guess you need to add something to the REST API to support that?","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"REST API impact"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":"Add an new API for \"zun run\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Security impact"},{"line_number":105,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_1055e2c4","line":102,"in_reply_to":"9a629dbe_16af4d95","updated":"2016-11-28 14:40:01.000000000","message":"Zun run will not impact another command in another terminal","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":12407,"name":"Shubham Kumar Sharma","email":"shubham.git@gmail.com","username":"shubham.git"},"change_message_id":"3007aad7aa7a16470722c7150c96a6da7a0de673","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"REST API impact"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":"Add an new API for \"zun run\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Security impact"},{"line_number":105,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_16af4d95","line":102,"in_reply_to":"9a629dbe_a33025ea","updated":"2016-11-14 04:42:02.000000000","message":"I am not sure about impact on other zun clis while \"zun run\" is being executed. Could you clarify: If \"zun run\" is running then can we execute other zun clis as well?","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3c796ffe13200e1ba663a9f4a8359e7e7b2a2ab2","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"REST API impact"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":"Add an new API for \"zun run\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Security impact"},{"line_number":105,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_f0494632","line":102,"in_reply_to":"9a629dbe_a33025ea","updated":"2016-11-28 14:40:01.000000000","message":"I think both the \"run\" and \"attach\" command could be added. I will add the details after discussion","commit_id":"dcb22776613215dfd0ee1ab426b0a75c851eba21"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d2574710ccb2ad0cbabf7a9da2025f42eca65251","unresolved":false,"context_lines":[{"line_number":27,"context_line":"looks like chroot. Zun use docker-py as the interface to get access the docker"},{"line_number":28,"context_line":"deamon."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"},{"line_number":31,"context_line":"correct parameters when create container and start container at the time"},{"line_number":32,"context_line":"it has been created, so that a tty will be created inside the container.User"},{"line_number":33,"context_line":"can connect the stdin, stdout, stderr to get a pseudo tty in local client.Then"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_56ed8db5","line":30,"range":{"start_line":30,"start_character":62,"end_line":30,"end_character":66},"updated":"2016-11-28 18:58:10.000000000","message":"needs","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"43319da7ce753a82a792f28c5aa934f5dd8c8feb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"looks like chroot. Zun use docker-py as the interface to get access the docker"},{"line_number":28,"context_line":"deamon."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"},{"line_number":31,"context_line":"correct parameters when create container and start container at the time"},{"line_number":32,"context_line":"it has been created, so that a tty will be created inside the container.User"},{"line_number":33,"context_line":"can connect the stdin, stdout, stderr to get a pseudo tty in local client.Then"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_08fefc6a","line":30,"range":{"start_line":30,"start_character":62,"end_line":30,"end_character":66},"in_reply_to":"5a74a57a_56ed8db5","updated":"2016-12-01 07:19:08.000000000","message":"Done","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d2574710ccb2ad0cbabf7a9da2025f42eca65251","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"},{"line_number":31,"context_line":"correct parameters when create container and start container at the time"},{"line_number":32,"context_line":"it has been created, so that a tty will be created inside the container.User"},{"line_number":33,"context_line":"can connect the stdin, stdout, stderr to get a pseudo tty in local client.Then"},{"line_number":34,"context_line":"will realize the interactive mode. Since Kubernetes realize this function, refer"},{"line_number":35,"context_line":"to Kubernetes realization is a feasible way."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_f64219ad","line":32,"range":{"start_line":32,"start_character":72,"end_line":32,"end_character":76},"updated":"2016-11-28 18:58:10.000000000","message":"Space before","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"43319da7ce753a82a792f28c5aa934f5dd8c8feb","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To reach the goal of realizing the container interactive, zun need to pass the"},{"line_number":31,"context_line":"correct parameters when create container and start container at the time"},{"line_number":32,"context_line":"it has been created, so that a tty will be created inside the container.User"},{"line_number":33,"context_line":"can connect the stdin, stdout, stderr to get a pseudo tty in local client.Then"},{"line_number":34,"context_line":"will realize the interactive mode. Since Kubernetes realize this function, refer"},{"line_number":35,"context_line":"to Kubernetes realization is a feasible way."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_a8d6e8ee","line":32,"range":{"start_line":32,"start_character":72,"end_line":32,"end_character":76},"in_reply_to":"5a74a57a_f64219ad","updated":"2016-12-01 07:19:08.000000000","message":"Done","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d2574710ccb2ad0cbabf7a9da2025f42eca65251","unresolved":false,"context_lines":[{"line_number":44,"context_line":"1. Since cli can\u0027t connect to the compute node directly, we should enable zun api"},{"line_number":45,"context_line":"   node support proxy function, which will forward the http request to zun-compute"},{"line_number":46,"context_line":"   node and forward the stream to zun-compute. Just like kube-proxy service."},{"line_number":47,"context_line":"2. In Zun-compute node, call docker-py to \"execute\" or \"attach\" to a container, while"},{"line_number":48,"context_line":"   the stdout, stdin, stderr and tty need to be set properly."},{"line_number":49,"context_line":"3. On connection, update the connect from HTTP to HTTP2 or SPDY, for bidirection"},{"line_number":50,"context_line":"   stream."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_1b4a5626","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":17},"updated":"2016-11-28 18:58:10.000000000","message":"I have an alternative suggestion for you to consider. Consider bypass zun-compute, and let zun-api directly interact with Docker Daemon. What you need to do is to have each docker daemon listen to 0.0.0.0 , so that both zun-api and zun-compute can communicate with docker. This might reduce the load on zun-compute a bit and let zun-compute have more rooms to serve other workload.\n\nPer my understanding, here is what you proposed:\n\n  zunclient -\u003e zun-api -\u003e zun-compute -\u003e docker daemon\n\nI suggested to change it to the following (for interactive mode only):\n\n  zunclient -\u003e zun-api -\u003e docker daemon\n\nWhat do you think?","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"43319da7ce753a82a792f28c5aa934f5dd8c8feb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"1. Since cli can\u0027t connect to the compute node directly, we should enable zun api"},{"line_number":45,"context_line":"   node support proxy function, which will forward the http request to zun-compute"},{"line_number":46,"context_line":"   node and forward the stream to zun-compute. Just like kube-proxy service."},{"line_number":47,"context_line":"2. In Zun-compute node, call docker-py to \"execute\" or \"attach\" to a container, while"},{"line_number":48,"context_line":"   the stdout, stdin, stderr and tty need to be set properly."},{"line_number":49,"context_line":"3. On connection, update the connect from HTTP to HTTP2 or SPDY, for bidirection"},{"line_number":50,"context_line":"   stream."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_483f1425","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":17},"in_reply_to":"5a74a57a_1b4a5626","updated":"2016-12-01 07:19:08.000000000","message":"Hi Hongbin,\n   Thanks~ I have modified the sequence diagram and modify the process, let zun-api talk with docker daemon directly","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d2574710ccb2ad0cbabf7a9da2025f42eca65251","unresolved":false,"context_lines":[{"line_number":66,"context_line":"First, ask api-server for authorization and get a token;"},{"line_number":67,"context_line":"Second, use the token to connect the port at the websocket node."},{"line_number":68,"context_line":"https://docs.docker.com/engine/reference/api/docker_remote_api_v1.24/#/attach-to-a-container-websocket"},{"line_number":69,"context_line":"It is feasible?"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Design Principles"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_1be6d614","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":15},"updated":"2016-11-28 18:58:10.000000000","message":"I think yes. It is feasible. Maybe you don\u0027t need to worry the authentication for now. Consider getting the basic functionality ready for the first iteration, and adding security feature in a follow-up bug/bp.","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"43319da7ce753a82a792f28c5aa934f5dd8c8feb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"First, ask api-server for authorization and get a token;"},{"line_number":67,"context_line":"Second, use the token to connect the port at the websocket node."},{"line_number":68,"context_line":"https://docs.docker.com/engine/reference/api/docker_remote_api_v1.24/#/attach-to-a-container-websocket"},{"line_number":69,"context_line":"It is feasible?"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Design Principles"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a74a57a_c81164b1","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":15},"in_reply_to":"5a74a57a_1be6d614","updated":"2016-12-01 07:19:08.000000000","message":"Cool, that will be easy realization.\nI have modified in patch set 7","commit_id":"85da9f3bbb53d4e5a7c18dcf3d8708100522bf6f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"66d32e5fa2f047012cefe8fc39de5c48e6b7770b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"Zun containers now take Docker as the first container driver. Docker can use"},{"line_number":26,"context_line":"\"docker run -it\" to enter into the interactive mode , where user can do operations"},{"line_number":27,"context_line":"looks like chroot. Zun use docker-py as the interface to get access the docker"},{"line_number":28,"context_line":"deamon."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a71b18c_97f50985","line":26,"range":{"start_line":26,"start_character":51,"end_line":26,"end_character":52},"updated":"2016-12-01 16:36:27.000000000","message":"nit: no space","commit_id":"37f7d710d8adfa73861db80cf46f905693f6ae8b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"66d32e5fa2f047012cefe8fc39de5c48e6b7770b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":"1. Since cli can\u0027t connect to the compute node directly, we should enable zun api"},{"line_number":44,"context_line":"   node support proxy function, which will forward the http request to zun-compute"},{"line_number":45,"context_line":"   node and forward the stream to zun-compute. Just like kube-proxy service."},{"line_number":46,"context_line":"2. Let each Docker daemon listens to 0.0.0.0:port, so that zun-api will easily talk"},{"line_number":47,"context_line":"   with Docker deamon. This might reduce the load on zun-compute a bit and let"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a71b18c_7c8934ca","line":44,"range":{"start_line":44,"start_character":71,"end_line":44,"end_character":82},"updated":"2016-12-01 16:36:27.000000000","message":"This needs an update. In #2, you mentioned that zun-api will directly talk to docker daemon. Then, I guess zun-compute has nothing to do with the interactive mode.","commit_id":"37f7d710d8adfa73861db80cf46f905693f6ae8b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"66d32e5fa2f047012cefe8fc39de5c48e6b7770b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   node and forward the stream to zun-compute. Just like kube-proxy service."},{"line_number":46,"context_line":"2. Let each Docker daemon listens to 0.0.0.0:port, so that zun-api will easily talk"},{"line_number":47,"context_line":"   with Docker deamon. This might reduce the load on zun-compute a bit and let"},{"line_number":48,"context_line":"   zun-compute have more rooms to serve other workload. "},{"line_number":49,"context_line":"3. In zun-compute node, call docker-py to \"execute\" or \"attach\" to a container, while"},{"line_number":50,"context_line":"   the stdout, stdin, stderr and tty need to be set properly."},{"line_number":51,"context_line":"4. On connection, update the connect from HTTP to HTTP2 or SPDY, for bidirection"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a71b18c_d74b01af","line":48,"range":{"start_line":48,"start_character":55,"end_line":48,"end_character":56},"updated":"2016-12-01 16:36:27.000000000","message":"nit: no space","commit_id":"37f7d710d8adfa73861db80cf46f905693f6ae8b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"66d32e5fa2f047012cefe8fc39de5c48e6b7770b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"2. Let each Docker daemon listens to 0.0.0.0:port, so that zun-api will easily talk"},{"line_number":47,"context_line":"   with Docker deamon. This might reduce the load on zun-compute a bit and let"},{"line_number":48,"context_line":"   zun-compute have more rooms to serve other workload. "},{"line_number":49,"context_line":"3. In zun-compute node, call docker-py to \"execute\" or \"attach\" to a container, while"},{"line_number":50,"context_line":"   the stdout, stdin, stderr and tty need to be set properly."},{"line_number":51,"context_line":"4. On connection, update the connect from HTTP to HTTP2 or SPDY, for bidirection"},{"line_number":52,"context_line":"   stream."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a71b18c_976509e3","line":49,"range":{"start_line":49,"start_character":6,"end_line":49,"end_character":17},"updated":"2016-12-01 16:36:27.000000000","message":"Ditto. Zun-compute is not used anymore. Zun-api will use docker-py to \"execute\" or \"attach\" to a container remotely.","commit_id":"37f7d710d8adfa73861db80cf46f905693f6ae8b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"66d32e5fa2f047012cefe8fc39de5c48e6b7770b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"5. For docker container, the new two paramaters about tty and stdin_open should"},{"line_number":54,"context_line":"   be added to the container field and corresponding database."},{"line_number":55,"context_line":"6. The python-zunclient will filter the parameters and pick up the correct"},{"line_number":56,"context_line":"   for interactive mode. Then will Open the connection to container at local"},{"line_number":57,"context_line":"   terminal after the \"zun run\" command return. Zun clis will directly connect the"},{"line_number":58,"context_line":"   websocket link from Docker daemon(for authorization problem, will fix it in the"},{"line_number":59,"context_line":"   follow bp/bug)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a71b18c_57bb7172","line":56,"range":{"start_line":56,"start_character":35,"end_line":56,"end_character":39},"updated":"2016-12-01 16:36:27.000000000","message":"nit: no capital.","commit_id":"37f7d710d8adfa73861db80cf46f905693f6ae8b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"66d32e5fa2f047012cefe8fc39de5c48e6b7770b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"6. The python-zunclient will filter the parameters and pick up the correct"},{"line_number":56,"context_line":"   for interactive mode. Then will Open the connection to container at local"},{"line_number":57,"context_line":"   terminal after the \"zun run\" command return. Zun clis will directly connect the"},{"line_number":58,"context_line":"   websocket link from Docker daemon(for authorization problem, will fix it in the"},{"line_number":59,"context_line":"   follow bp/bug)."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The diagram below offers an overview of the interactive mode architecture."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a71b18c_174f3993","line":58,"range":{"start_line":58,"start_character":36,"end_line":58,"end_character":37},"updated":"2016-12-01 16:36:27.000000000","message":"nit: space between \"daemon\" and \"(\"","commit_id":"37f7d710d8adfa73861db80cf46f905693f6ae8b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"66d32e5fa2f047012cefe8fc39de5c48e6b7770b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"zun clis with the attach url. Zun clis will attach its stdin ,stdout and stderr to"},{"line_number":89,"context_line":"the container."},{"line_number":90,"context_line":"Since zun clis connect with the websocket in Docker daemon, so that will not hijack HTTP"},{"line_number":91,"context_line":"request(from zun clis to zun api), user can do another zun api command in another terminal."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a71b18c_d2486f5e","line":91,"range":{"start_line":91,"start_character":7,"end_line":91,"end_character":8},"updated":"2016-12-01 16:36:27.000000000","message":"nit: space between \"request\" and \"(\"","commit_id":"37f7d710d8adfa73861db80cf46f905693f6ae8b"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"651ef9eff8804a8cef8e29e8814afb15c81a6869","unresolved":false,"context_lines":[{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_3aeba079","line":73,"updated":"2016-12-06 05:39:15.000000000","message":"We are adding some fields to database, do we need to mention it here?","commit_id":"31345579a1ff2c72dd7140ce72c0be952217dafb"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"f37ebc2908bd7a6078dc2d50f90822ae2bead193","unresolved":false,"context_lines":[{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_f505b910","line":73,"in_reply_to":"3a71b18c_3aeba079","updated":"2016-12-06 05:51:30.000000000","message":"Thanks~\nYeah you are right, I will add the here.","commit_id":"31345579a1ff2c72dd7140ce72c0be952217dafb"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"651ef9eff8804a8cef8e29e8814afb15c81a6869","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":"Add an new API for \"zun run\""},{"line_number":79,"context_line":"Add an new API for \"zun attach\""},{"line_number":80,"context_line":"Zun clis will first send the message to zun-api, zun-api will directly talk with Docker"},{"line_number":81,"context_line":"daemon. Then after the container is successfully started, zun-api notify"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_1a9d040a","line":78,"updated":"2016-12-06 05:39:15.000000000","message":"I think its already implemented. Do you want to add anything more to the api?","commit_id":"31345579a1ff2c72dd7140ce72c0be952217dafb"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"f37ebc2908bd7a6078dc2d50f90822ae2bead193","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":"Add an new API for \"zun run\""},{"line_number":79,"context_line":"Add an new API for \"zun attach\""},{"line_number":80,"context_line":"Zun clis will first send the message to zun-api, zun-api will directly talk with Docker"},{"line_number":81,"context_line":"daemon. Then after the container is successfully started, zun-api notify"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_55158d3d","line":78,"in_reply_to":"3a71b18c_1a9d040a","updated":"2016-12-06 05:51:30.000000000","message":"Just need to tweak the code for \"zun run -it\" , that will go another work through for interactive.","commit_id":"31345579a1ff2c72dd7140ce72c0be952217dafb"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"651ef9eff8804a8cef8e29e8814afb15c81a6869","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Dependencies"},{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":137,"context_line":"The bug fix of #1627589 will add the command \"zun run\"."},{"line_number":138,"context_line":"Partily depend on this."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_baa5f047","line":137,"updated":"2016-12-06 05:39:15.000000000","message":"Its already Fixed, may be we can remove it now.","commit_id":"31345579a1ff2c72dd7140ce72c0be952217dafb"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"f37ebc2908bd7a6078dc2d50f90822ae2bead193","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Dependencies"},{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":137,"context_line":"The bug fix of #1627589 will add the command \"zun run\"."},{"line_number":138,"context_line":"Partily depend on this."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_f52cd99a","line":137,"in_reply_to":"3a71b18c_baa5f047","updated":"2016-12-06 05:51:30.000000000","message":"I will remove it now~ Thanks~","commit_id":"31345579a1ff2c72dd7140ce72c0be952217dafb"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"18d31771a59a4518b79dfb90a9f70ec69ec01fd6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   zun-compute have more rooms to serve other workload."},{"line_number":46,"context_line":"2. For docker daemon, the new two paramaters about tty and stdin_open should"},{"line_number":47,"context_line":"   be added to the container field and corresponding database."},{"line_number":48,"context_line":"3. Zun api will wait for the container start and get the websocket link to zun clis."},{"line_number":49,"context_line":"4. For python-zunclient, it will filter the parameters and pick up the correct"},{"line_number":50,"context_line":"   for interactive mode. Then will open the connection to container at local"},{"line_number":51,"context_line":"   terminal after the \"zun run\" command return. Zun clis will directly connect the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_528bdc1e","line":48,"range":{"start_line":48,"start_character":79,"end_line":48,"end_character":84},"updated":"2016-12-06 09:06:29.000000000","message":"CLIs","commit_id":"f5a2ed3fc202809c20effd2a87f4091d06ed89e3"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"e344fc8091b11766bb212ae55eff565701dc8a1a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   zun-compute have more rooms to serve other workload."},{"line_number":46,"context_line":"2. For docker daemon, the new two paramaters about tty and stdin_open should"},{"line_number":47,"context_line":"   be added to the container field and corresponding database."},{"line_number":48,"context_line":"3. Zun api will wait for the container start and get the websocket link to zun clis."},{"line_number":49,"context_line":"4. For python-zunclient, it will filter the parameters and pick up the correct"},{"line_number":50,"context_line":"   for interactive mode. Then will open the connection to container at local"},{"line_number":51,"context_line":"   terminal after the \"zun run\" command return. Zun clis will directly connect the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_a1f720f4","line":48,"range":{"start_line":48,"start_character":79,"end_line":48,"end_character":84},"in_reply_to":"3a71b18c_528bdc1e","updated":"2016-12-08 01:45:18.000000000","message":"Thanks Eli,\nI\u0027ve changed all the clis to CLIs","commit_id":"f5a2ed3fc202809c20effd2a87f4091d06ed89e3"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"18d31771a59a4518b79dfb90a9f70ec69ec01fd6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":"Add some fields to database, including \"tty\" \"stdin_open\" and another to show whether the"},{"line_number":75,"context_line":"container has been attached."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_d2428cad","line":74,"range":{"start_line":74,"start_character":19,"end_line":74,"end_character":27},"updated":"2016-12-06 09:06:29.000000000","message":"I think you mean container object.","commit_id":"f5a2ed3fc202809c20effd2a87f4091d06ed89e3"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"18d31771a59a4518b79dfb90a9f70ec69ec01fd6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":"Add some fields to database, including \"tty\" \"stdin_open\" and another to show whether the"},{"line_number":75,"context_line":"container has been attached."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_7231b859","line":74,"range":{"start_line":74,"start_character":62,"end_line":74,"end_character":69},"updated":"2016-12-06 09:06:29.000000000","message":"maybe \"attached\"\u003d \"true\"/\u0027false\u0027 right?","commit_id":"f5a2ed3fc202809c20effd2a87f4091d06ed89e3"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"e344fc8091b11766bb212ae55eff565701dc8a1a","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":"Add some fields to database, including \"tty\" \"stdin_open\" and another to show whether the"},{"line_number":75,"context_line":"container has been attached."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_c1dc1c77","line":74,"range":{"start_line":74,"start_character":62,"end_line":74,"end_character":69},"in_reply_to":"3a71b18c_7231b859","updated":"2016-12-08 01:45:18.000000000","message":"Yeah it is","commit_id":"f5a2ed3fc202809c20effd2a87f4091d06ed89e3"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"e344fc8091b11766bb212ae55eff565701dc8a1a","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":"Add some fields to database, including \"tty\" \"stdin_open\" and another to show whether the"},{"line_number":75,"context_line":"container has been attached."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_e1d91885","line":74,"range":{"start_line":74,"start_character":19,"end_line":74,"end_character":27},"in_reply_to":"3a71b18c_d2428cad","updated":"2016-12-08 01:45:18.000000000","message":"Done","commit_id":"f5a2ed3fc202809c20effd2a87f4091d06ed89e3"}]}