)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"93d91c6d23dae80268679bc9a698ce09c9f7efc9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            \u0027validate\u0027: types.EnumType.validate,"},{"line_number":125,"context_line":"            \u0027validate_args\u0027: {"},{"line_number":126,"context_line":"                \u0027name\u0027: \u0027image_pull_policy\u0027,"},{"line_number":127,"context_line":"                \u0027values\u0027: [\u0027never\u0027, \u0027always\u0027, \u0027ifnotpresent\u0027]"},{"line_number":128,"context_line":"            }"},{"line_number":129,"context_line":"        }"},{"line_number":130,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_d3e392d7","line":127,"range":{"start_line":127,"start_character":28,"end_line":127,"end_character":33},"updated":"2016-11-17 16:09:00.000000000","message":"@Pradeep,\n\nI am not sure if we have use cases for \u0027never\u0027. It means failing the container creation if the image is not present locally. Does it mean operators need to pull down all the images into each compute host?","commit_id":"2c6ad5a119b97bc127d7ad3945adfd805c3ce4ba"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"75adbb5c1455d6b3bbe7985a38ef5314120a1819","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            \u0027validate\u0027: types.EnumType.validate,"},{"line_number":125,"context_line":"            \u0027validate_args\u0027: {"},{"line_number":126,"context_line":"                \u0027name\u0027: \u0027image_pull_policy\u0027,"},{"line_number":127,"context_line":"                \u0027values\u0027: [\u0027never\u0027, \u0027always\u0027, \u0027ifnotpresent\u0027]"},{"line_number":128,"context_line":"            }"},{"line_number":129,"context_line":"        }"},{"line_number":130,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_5cd91c56","line":127,"range":{"start_line":127,"start_character":28,"end_line":127,"end_character":33},"in_reply_to":"7a77a97e_84746e36","updated":"2016-11-18 16:57:13.000000000","message":"OK. I still think \u0027ifnotpresent\u0027 can cover all the use cases of \u0027never\u0027, so \u0027never\u0027 might not need to be exposed to end-users. However, let\u0027s merge this patch first and refine it later.","commit_id":"2c6ad5a119b97bc127d7ad3945adfd805c3ce4ba"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"86e03b684a80d2de6d5f4e0442c49d450a8eb95c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            \u0027validate\u0027: types.EnumType.validate,"},{"line_number":125,"context_line":"            \u0027validate_args\u0027: {"},{"line_number":126,"context_line":"                \u0027name\u0027: \u0027image_pull_policy\u0027,"},{"line_number":127,"context_line":"                \u0027values\u0027: [\u0027never\u0027, \u0027always\u0027, \u0027ifnotpresent\u0027]"},{"line_number":128,"context_line":"            }"},{"line_number":129,"context_line":"        }"},{"line_number":130,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_84746e36","line":127,"range":{"start_line":127,"start_character":28,"end_line":127,"end_character":33},"in_reply_to":"7a77a97e_d3e392d7","updated":"2016-11-17 16:35:16.000000000","message":"@hongbin, yes u r right. It is applicable for pre pulling. It can be used to preload certain images for speed, or an alternative option to authenticating to private registry. But it may not work in the systems where modes are added and deleted automatically.","commit_id":"2c6ad5a119b97bc127d7ad3945adfd805c3ce4ba"}],"zun/image/glance/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"93d91c6d23dae80268679bc9a698ce09c9f7efc9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(GlanceDriver, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _search_image_on_host(self, context, repo):"},{"line_number":39,"context_line":"        LOG.debug(\u0027Searching for image %s locally\u0027 % repo)"},{"line_number":40,"context_line":"        images_directory \u003d CONF.glance.images_directory"},{"line_number":41,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_3e564d5c","line":38,"range":{"start_line":38,"start_character":45,"end_line":38,"end_character":49},"updated":"2016-11-17 16:09:00.000000000","message":"In the Docker image driver, I saw the image was searched by using both repo and tag. In here, the image is searched by repo only. Do we drop the tag for some reasons?","commit_id":"2c6ad5a119b97bc127d7ad3945adfd805c3ce4ba"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"86e03b684a80d2de6d5f4e0442c49d450a8eb95c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(GlanceDriver, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _search_image_on_host(self, context, repo):"},{"line_number":39,"context_line":"        LOG.debug(\u0027Searching for image %s locally\u0027 % repo)"},{"line_number":40,"context_line":"        images_directory \u003d CONF.glance.images_directory"},{"line_number":41,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_c4de6610","line":38,"range":{"start_line":38,"start_character":45,"end_line":38,"end_character":49},"in_reply_to":"7a77a97e_3e564d5c","updated":"2016-11-17 16:35:16.000000000","message":"As per comment at Line #56 in this file below, i think glance dont support the tag yet.","commit_id":"2c6ad5a119b97bc127d7ad3945adfd805c3ce4ba"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b6c0f6ffbccc3e31de2c32856d16b55473210d1b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(GlanceDriver, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _search_image_on_host(self, context, repo):"},{"line_number":39,"context_line":"        LOG.debug(\u0027Searching for image %s locally\u0027 % repo)"},{"line_number":40,"context_line":"        images_directory \u003d CONF.glance.images_directory"},{"line_number":41,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_1accebb9","line":38,"range":{"start_line":38,"start_character":45,"end_line":38,"end_character":49},"in_reply_to":"7a77a97e_bcea30d9","updated":"2016-11-20 09:57:06.000000000","message":"Glance doesn\u0027t support tags. But we can try to store tag info in image metadata.","commit_id":"2c6ad5a119b97bc127d7ad3945adfd805c3ce4ba"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"75adbb5c1455d6b3bbe7985a38ef5314120a1819","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(GlanceDriver, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _search_image_on_host(self, context, repo):"},{"line_number":39,"context_line":"        LOG.debug(\u0027Searching for image %s locally\u0027 % repo)"},{"line_number":40,"context_line":"        images_directory \u003d CONF.glance.images_directory"},{"line_number":41,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_bcea30d9","line":38,"range":{"start_line":38,"start_character":45,"end_line":38,"end_character":49},"in_reply_to":"7a77a97e_c4de6610","updated":"2016-11-18 16:57:13.000000000","message":"I see.","commit_id":"2c6ad5a119b97bc127d7ad3945adfd805c3ce4ba"}]}