)]}'
{"nova/virt/docker/vifs.py":[{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"084e5740999709ff6109c7f30f30e2b7bfe421a8","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                \u0027ip\u0027, \u0027link\u0027, \u0027delete\u0027, if_local_name, run_as_root\u003dTrue))"},{"line_number":367,"context_line":"            # NOTE(samalba): Deleting the interface will delete all"},{"line_number":368,"context_line":"            # associated resources (remove from the bridge, its pair, etc...)"},{"line_number":369,"context_line":"            utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, if_local_name, \u0027address\u0027,"},{"line_number":370,"context_line":"                          self._fe_random_mac(), run_as_root\u003dTrue)"},{"line_number":371,"context_line":"            utils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, if_local_name,"},{"line_number":372,"context_line":"                          run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_4b8840c7","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":72},"updated":"2016-12-19 02:05:37.000000000","message":"Sorry I\u0027m not familiar with these VIF operation commands, but I noticed in the former \u0027plug_ovs_hybrid\u0027 method, this mac address setting command was not executed. Will it affect the behavior of the veth pair created?","commit_id":"e41c54b1752d48f69baa92a64b20eb71d0f37c17"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"d196fec273276ca524e64117d07c011229398ab9","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                \u0027ip\u0027, \u0027link\u0027, \u0027delete\u0027, if_local_name, run_as_root\u003dTrue))"},{"line_number":367,"context_line":"            # NOTE(samalba): Deleting the interface will delete all"},{"line_number":368,"context_line":"            # associated resources (remove from the bridge, its pair, etc...)"},{"line_number":369,"context_line":"            utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, if_local_name, \u0027address\u0027,"},{"line_number":370,"context_line":"                          self._fe_random_mac(), run_as_root\u003dTrue)"},{"line_number":371,"context_line":"            utils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, if_local_name,"},{"line_number":372,"context_line":"                          run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_652448c6","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":72},"in_reply_to":"1a6eadb0_2543306e","updated":"2016-12-19 04:46:09.000000000","message":"+1","commit_id":"e41c54b1752d48f69baa92a64b20eb71d0f37c17"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"45dc4a345a8d5a0f2405338e9d6066ca7ebabd4d","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                \u0027ip\u0027, \u0027link\u0027, \u0027delete\u0027, if_local_name, run_as_root\u003dTrue))"},{"line_number":367,"context_line":"            # NOTE(samalba): Deleting the interface will delete all"},{"line_number":368,"context_line":"            # associated resources (remove from the bridge, its pair, etc...)"},{"line_number":369,"context_line":"            utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, if_local_name, \u0027address\u0027,"},{"line_number":370,"context_line":"                          self._fe_random_mac(), run_as_root\u003dTrue)"},{"line_number":371,"context_line":"            utils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, if_local_name,"},{"line_number":372,"context_line":"                          run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_2543306e","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":72},"in_reply_to":"1a6eadb0_4b8840c7","updated":"2016-12-19 04:44:00.000000000","message":"I tested it, it should be fine. Per my understanding, this is just setting a random mac address, which should be fine for OVS.","commit_id":"e41c54b1752d48f69baa92a64b20eb71d0f37c17"}]}