)]}'
{"zun/common/nova.py":[{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"06418914a83232565b52290f1d173f918323c5ce","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def stop_server(self, server):"},{"line_number":194,"context_line":"        server_id \u003d self.get_server_id(server, raise_on_error\u003dFalse)"},{"line_number":195,"context_line":"        if server_id:"},{"line_number":196,"context_line":"            self.client().servers.stop(server_id)"},{"line_number":197,"context_line":"            return server_id"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def check_delete_server_complete(self, server_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_acf02268","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":12},"updated":"2016-12-07 09:41:09.000000000","message":"do you think is it right approach to self.client()\nI think constructor class variable should be self.client instead self.client()","commit_id":"7ea0d85bf4b278e93d85d57aa84fc758b47eaf10"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c8d0af7b336311654b60145c394b5591a2ad0b7a","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def stop_server(self, server):"},{"line_number":194,"context_line":"        server_id \u003d self.get_server_id(server, raise_on_error\u003dFalse)"},{"line_number":195,"context_line":"        if server_id:"},{"line_number":196,"context_line":"            self.client().servers.stop(server_id)"},{"line_number":197,"context_line":"            return server_id"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def check_delete_server_complete(self, server_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_b8c138e6","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":12},"in_reply_to":"3a71b18c_7d4872b3","updated":"2016-12-07 11:02:32.000000000","message":"Yes, I saw this, look ok for me","commit_id":"7ea0d85bf4b278e93d85d57aa84fc758b47eaf10"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"cd70e97230ba410ad4b29e877b359099094af96f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def stop_server(self, server):"},{"line_number":194,"context_line":"        server_id \u003d self.get_server_id(server, raise_on_error\u003dFalse)"},{"line_number":195,"context_line":"        if server_id:"},{"line_number":196,"context_line":"            self.client().servers.stop(server_id)"},{"line_number":197,"context_line":"            return server_id"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def check_delete_server_complete(self, server_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_7d4872b3","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":12},"in_reply_to":"3a71b18c_acf02268","updated":"2016-12-07 10:41:39.000000000","message":"client is method.Plz see line number 52.","commit_id":"7ea0d85bf4b278e93d85d57aa84fc758b47eaf10"}],"zun/compute/manager.py":[{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"18e43fd834c8fbbcbff2b711af0538404c78f026","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                self._fail_container(container, six.text_type(e))"},{"line_number":157,"context_line":"            return"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _do_container_start(self, context, container):"},{"line_number":160,"context_line":"        LOG.debug(\u0027Starting container...\u0027, context\u003dcontext,"},{"line_number":161,"context_line":"                  container\u003dcontainer.uuid)"},{"line_number":162,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_2b707fa3","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":27},"updated":"2016-12-07 06:24:01.000000000","message":"Since the sandbox would be stopped when stopping the container, do we need to start the sandbox when we do container start?","commit_id":"045cf8f908c346e8a2934ee270304f9ff247d554"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"18e43fd834c8fbbcbff2b711af0538404c78f026","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        except Exception as e:"},{"line_number":266,"context_line":"            LOG.exception(_LE(\"Unexpected exception: %s\"), str(e))"},{"line_number":267,"context_line":"            raise e"},{"line_number":268,"context_line":"        sandbox_id \u003d self.driver.get_sandbox_id(container)"},{"line_number":269,"context_line":"        if sandbox_id:"},{"line_number":270,"context_line":"            try:"},{"line_number":271,"context_line":"                self.driver.stop_sandbox(context, sandbox_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_882ef9a2","line":268,"updated":"2016-12-07 06:24:01.000000000","message":"These code would never been called, seems you should move them into the try block?","commit_id":"045cf8f908c346e8a2934ee270304f9ff247d554"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"18d78fc1a21b2fc7e43be10a859e133c3a166b23","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_sandbox_cleanup(self, context, sandbox_id):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.driver.stop_sandbox(context, sandbox_id)"},{"line_number":79,"context_line":"        except Exception as e:"},{"line_number":80,"context_line":"            LOG.error(_LE(\"Error occured while stopping sandbox: %s\"),"},{"line_number":81,"context_line":"                      six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_fc6c8bd1","line":78,"range":{"start_line":78,"start_character":24,"end_line":78,"end_character":36},"updated":"2016-12-07 08:12:07.000000000","message":"I think we should delete the sandbox rather than stopping it.","commit_id":"ff69e5f8dbae68d5443711b20f169a4ad018dc7f"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"054200048475501ba4c775528d02a301ee67d88f","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_sandbox_cleanup(self, context, sandbox_id):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.driver.stop_sandbox(context, sandbox_id)"},{"line_number":79,"context_line":"        except Exception as e:"},{"line_number":80,"context_line":"            LOG.error(_LE(\"Error occured while stopping sandbox: %s\"),"},{"line_number":81,"context_line":"                      six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_1c5ce77b","line":78,"range":{"start_line":78,"start_character":24,"end_line":78,"end_character":36},"in_reply_to":"3a71b18c_fc6c8bd1","updated":"2016-12-07 08:25:41.000000000","message":"Done","commit_id":"ff69e5f8dbae68d5443711b20f169a4ad018dc7f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"0c7c954e05779dccbcc12a346fba277957c386cf","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _do_sandbox_cleanup(self, context, sandbox_id):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.driver.delete_sandbox(context, sandbox_id)"},{"line_number":79,"context_line":"        except Exception as e:"},{"line_number":80,"context_line":"            LOG.error(_LE(\"Error occured while deleting sandbox: %s\"),"},{"line_number":81,"context_line":"                      six.text_type(e))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_8ca4464b","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":30},"updated":"2016-12-07 09:42:51.000000000","message":"Please handle propoer exception, instead of exception as e","commit_id":"7ea0d85bf4b278e93d85d57aa84fc758b47eaf10"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c8d0af7b336311654b60145c394b5591a2ad0b7a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _do_sandbox_cleanup(self, context, sandbox_id):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.driver.delete_sandbox(context, sandbox_id)"},{"line_number":79,"context_line":"        except Exception as e:"},{"line_number":80,"context_line":"            LOG.error(_LE(\"Error occured while deleting sandbox: %s\"),"},{"line_number":81,"context_line":"                      six.text_type(e))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_1805cc44","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":30},"in_reply_to":"3a71b18c_3d00ba33","updated":"2016-12-07 11:02:32.000000000","message":"Okay","commit_id":"7ea0d85bf4b278e93d85d57aa84fc758b47eaf10"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"cd70e97230ba410ad4b29e877b359099094af96f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _do_sandbox_cleanup(self, context, sandbox_id):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.driver.delete_sandbox(context, sandbox_id)"},{"line_number":79,"context_line":"        except Exception as e:"},{"line_number":80,"context_line":"            LOG.error(_LE(\"Error occured while deleting sandbox: %s\"),"},{"line_number":81,"context_line":"                      six.text_type(e))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_3d00ba33","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":30},"in_reply_to":"3a71b18c_8ca4464b","updated":"2016-12-07 10:41:39.000000000","message":"I totally agree with you, the same pattern is followed currently at many places. I will add some exception class during the fix of https://bugs.launchpad.net/zun/+bug/1639333 and modify the same. Is it seems ok to you?","commit_id":"7ea0d85bf4b278e93d85d57aa84fc758b47eaf10"}],"zun/container/docker/driver.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"18d78fc1a21b2fc7e43be10a859e133c3a166b23","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def stop_sandbox(self, context, sandbox_id):"},{"line_number":234,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":235,"context_line":"            docker.stop(sandbox_id)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_sandbox_id(self, container):"},{"line_number":238,"context_line":"        if container.meta:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_3c99a3c4","line":235,"range":{"start_line":235,"start_character":19,"end_line":235,"end_character":23},"updated":"2016-12-07 08:12:07.000000000","message":"I think we should delete the sandbox rather than stopping it.","commit_id":"ff69e5f8dbae68d5443711b20f169a4ad018dc7f"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"054200048475501ba4c775528d02a301ee67d88f","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def stop_sandbox(self, context, sandbox_id):"},{"line_number":234,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":235,"context_line":"            docker.stop(sandbox_id)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_sandbox_id(self, container):"},{"line_number":238,"context_line":"        if container.meta:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_bcc93328","line":235,"range":{"start_line":235,"start_character":19,"end_line":235,"end_character":23},"in_reply_to":"3a71b18c_3c99a3c4","updated":"2016-12-07 08:25:41.000000000","message":"Not needed here.","commit_id":"ff69e5f8dbae68d5443711b20f169a4ad018dc7f"}]}