)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5c2faabc795cb9d7c2062cbc1fe431240fd4a1fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default return value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Defalut variablies is not used in function, I think they were"},{"line_number":10,"context_line":"setted to be returned as default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iccc097d9f15b1b8240f4eb75a4d32619b26ed777"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_36125063","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":30},"updated":"2016-12-08 17:03:57.000000000","message":"If the variable is not used, I think the right fix is simply remove this variable.","commit_id":"4db132a6bd225bf3aeaba989d9bcaf8839a3af56"}],"zun/api/controllers/types.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5c2faabc795cb9d7c2062cbc1fe431240fd4a1fa","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    type_name \u003d \u0027Uuid\u0027"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    @classmethod"},{"line_number":227,"context_line":"    def validate(cls, value, default\u003dNone):"},{"line_number":228,"context_line":"        if value is None:"},{"line_number":229,"context_line":"            return default"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_31097a2d","line":227,"range":{"start_line":227,"start_character":29,"end_line":227,"end_character":36},"updated":"2016-12-08 17:03:57.000000000","message":"I think you can simply remove the default. It doesn\u0027t make sense to allow a default value for UUID.","commit_id":"4db132a6bd225bf3aeaba989d9bcaf8839a3af56"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"81d981f3a85781b95d5849d9781d6894a856c7af","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    @classmethod"},{"line_number":227,"context_line":"    def validate(cls, value, default\u003dNone):"},{"line_number":228,"context_line":"        if value is None:"},{"line_number":229,"context_line":"            return default"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if not uuidutils.is_uuid_like(value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_44962195","line":228,"updated":"2016-12-09 05:14:37.000000000","message":"This line seems to check if value is none and return default, while default itself is an optional parameter. Not the right way of doing things.","commit_id":"4db132a6bd225bf3aeaba989d9bcaf8839a3af56"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5c2faabc795cb9d7c2062cbc1fe431240fd4a1fa","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    type_name \u003d \"DateTime\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @classmethod"},{"line_number":279,"context_line":"    def validate(cls, value, default\u003dNone):"},{"line_number":280,"context_line":"        if value is None:"},{"line_number":281,"context_line":"            return default"},{"line_number":282,"context_line":"        elif isinstance(value, datetime.datetime):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_7113f25c","line":279,"range":{"start_line":279,"start_character":29,"end_line":279,"end_character":36},"updated":"2016-12-08 17:03:57.000000000","message":"ditto","commit_id":"4db132a6bd225bf3aeaba989d9bcaf8839a3af56"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5c2faabc795cb9d7c2062cbc1fe431240fd4a1fa","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    type_name \u003d \u0027MemoryType\u0027"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @classmethod"},{"line_number":292,"context_line":"    def validate(cls, value, default\u003dNone):"},{"line_number":293,"context_line":"        if value is None:"},{"line_number":294,"context_line":"            return default"},{"line_number":295,"context_line":"        elif value.isdigit() and int(value) \u003e\u003d MIN_MEMORY_SIZE:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d1184678","line":292,"range":{"start_line":292,"start_character":29,"end_line":292,"end_character":36},"updated":"2016-12-08 17:03:57.000000000","message":"ditto","commit_id":"4db132a6bd225bf3aeaba989d9bcaf8839a3af56"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5c2faabc795cb9d7c2062cbc1fe431240fd4a1fa","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    type_name \u003d \u0027ImageSize\u0027"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    @classmethod"},{"line_number":314,"context_line":"    def validate(cls, value, default\u003dNone):"},{"line_number":315,"context_line":"        if value is None:"},{"line_number":316,"context_line":"            return default"},{"line_number":317,"context_line":"        elif value.isdigit():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f12542ae","line":314,"range":{"start_line":314,"start_character":29,"end_line":314,"end_character":36},"updated":"2016-12-08 17:03:57.000000000","message":"ditto","commit_id":"4db132a6bd225bf3aeaba989d9bcaf8839a3af56"}]}