)]}'
{"zun/container/docker/driver.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"dae9d854997241c49e1098232fc636d40b1a0d80","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":235,"context_line":"            name \u003d self.get_sandbox_name(container)"},{"line_number":236,"context_line":"            response \u003d docker.create_container(image, name\u003dname,"},{"line_number":237,"context_line":"                                               hostname\u003dname)"},{"line_number":238,"context_line":"            sandbox_id \u003d response[\u0027Id\u0027]"},{"line_number":239,"context_line":"            docker.start(sandbox_id)"},{"line_number":240,"context_line":"            return sandbox_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_b29d300c","line":237,"updated":"2016-12-27 04:22:29.000000000","message":"@Hongbin i found a problem here, our limit for container name is 255 chars, but it seems hostname length is just 64 chars,  as it seems from my testing http://paste.openstack.org/show/593412/. May be its dependent on OS, i am using ubuntu. Maybe we can add a TODO here and revisit it latter.","commit_id":"10e11a8085fb0b3bd6d31799532e5643d02a2436"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b1ab5b7e9b79bd2fbdf10a9cee818e5402360b93","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":235,"context_line":"            name \u003d self.get_sandbox_name(container)"},{"line_number":236,"context_line":"            response \u003d docker.create_container(image, name\u003dname,"},{"line_number":237,"context_line":"                                               hostname\u003dname)"},{"line_number":238,"context_line":"            sandbox_id \u003d response[\u0027Id\u0027]"},{"line_number":239,"context_line":"            docker.start(sandbox_id)"},{"line_number":240,"context_line":"            return sandbox_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_957bb68b","line":237,"in_reply_to":"da4df55a_b29d300c","updated":"2016-12-27 04:34:34.000000000","message":"Good point. It looks the valid hostname is between 1 and 63 chars [1]. Will cut it to 63 chars later.\n\n[1] https://en.wikipedia.org/wiki/Hostname","commit_id":"10e11a8085fb0b3bd6d31799532e5643d02a2436"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"dae9d854997241c49e1098232fc636d40b1a0d80","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                       nics\u003d\u0027auto\u0027):"},{"line_number":293,"context_line":"        name \u003d self.get_sandbox_name(container)"},{"line_number":294,"context_line":"        novaclient \u003d nova.NovaClient(context)"},{"line_number":295,"context_line":"        sandbox \u003d novaclient.create_server(name\u003dname, image\u003dimage,"},{"line_number":296,"context_line":"                                           flavor\u003dflavor, key_name\u003dkey_name,"},{"line_number":297,"context_line":"                                           nics\u003dnics)"},{"line_number":298,"context_line":"        self._ensure_active(novaclient, sandbox)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_b239b0f4","line":295,"updated":"2016-12-27 04:22:29.000000000","message":"How hostname will be set here?","commit_id":"10e11a8085fb0b3bd6d31799532e5643d02a2436"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b1ab5b7e9b79bd2fbdf10a9cee818e5402360b93","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                       nics\u003d\u0027auto\u0027):"},{"line_number":293,"context_line":"        name \u003d self.get_sandbox_name(container)"},{"line_number":294,"context_line":"        novaclient \u003d nova.NovaClient(context)"},{"line_number":295,"context_line":"        sandbox \u003d novaclient.create_server(name\u003dname, image\u003dimage,"},{"line_number":296,"context_line":"                                           flavor\u003dflavor, key_name\u003dkey_name,"},{"line_number":297,"context_line":"                                           nics\u003dnics)"},{"line_number":298,"context_line":"        self._ensure_active(novaclient, sandbox)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_1568a6b8","line":295,"in_reply_to":"da4df55a_b239b0f4","updated":"2016-12-27 04:34:34.000000000","message":"In here: https://github.com/openstack/zun/blob/master/nova/virt/docker/driver.py#L492","commit_id":"10e11a8085fb0b3bd6d31799532e5643d02a2436"}]}