)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"959b6dc129661379a8075e4bfab490f221c861c5","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        context \u003d pecan.request.context"},{"line_number":334,"context_line":"        pecan.request.rpcapi.container_delete(context, container, force)"},{"line_number":335,"context_line":"        container.destroy()"},{"line_number":336,"context_line":"        pecan.response.status \u003d 204"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":339,"context_line":"    @exception.wrap_pecan_controller_exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b289a377","line":336,"range":{"start_line":336,"start_character":14,"end_line":336,"end_character":22},"updated":"2017-01-05 09:54:15.000000000","message":"IMHO delete operation can also return 202, opinions??","commit_id":"bf9ccc193425b0e51aa612399fe6beae16af1c4a"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"bcd1e2f462676f2a0d200e945020ed62bca42c18","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        context \u003d pecan.request.context"},{"line_number":334,"context_line":"        pecan.request.rpcapi.container_delete(context, container, force)"},{"line_number":335,"context_line":"        container.destroy()"},{"line_number":336,"context_line":"        pecan.response.status \u003d 204"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":339,"context_line":"    @exception.wrap_pecan_controller_exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_ad6a28ec","line":336,"range":{"start_line":336,"start_character":14,"end_line":336,"end_character":22},"in_reply_to":"ba5201f7_ad0ce8ed","updated":"2017-01-05 10:49:10.000000000","message":"Ok, lets discuss this in team.","commit_id":"bf9ccc193425b0e51aa612399fe6beae16af1c4a"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"54f3c21dd0a16745adb3652e51b3d789f1c6526c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        context \u003d pecan.request.context"},{"line_number":334,"context_line":"        pecan.request.rpcapi.container_delete(context, container, force)"},{"line_number":335,"context_line":"        container.destroy()"},{"line_number":336,"context_line":"        pecan.response.status \u003d 204"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":339,"context_line":"    @exception.wrap_pecan_controller_exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_ad0ce8ed","line":336,"range":{"start_line":336,"start_character":14,"end_line":336,"end_character":22},"in_reply_to":"ba5201f7_b289a377","updated":"2017-01-05 10:30:20.000000000","message":"yes delete is sync can\u0027t we make it async as well, i have seen it in other openstack project as well","commit_id":"bf9ccc193425b0e51aa612399fe6beae16af1c4a"}],"zun/tests/tempest/api/test_containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"97712416c0a66ab3fd38f6b5b5313aee0a8083b1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        # TODO(pksingh) Before reboot the container is in running state"},{"line_number":133,"context_line":"        # and after reboot its in running state, so need to find how to"},{"line_number":134,"context_line":"        # add a wait for reboot, for now adding a sleep of 10 seconds"},{"line_number":135,"context_line":"        time.sleep(10)"},{"line_number":136,"context_line":"        self.assertEqual(\u0027Running\u0027, self._get_container_state(model.uuid))"},{"line_number":137,"context_line":"        # assert pid is changed"},{"line_number":138,"context_line":"        container \u003d self.docker_client.get_container(model.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_7d7e151a","line":135,"range":{"start_line":135,"start_character":19,"end_line":135,"end_character":21},"updated":"2017-01-05 21:16:02.000000000","message":"It looks the gate has random failure of waiting for reboot, so 10 second doesn\u0027t seem to be reliable. How about waiting for the change of the docker\u0027s pid/time-stamp?","commit_id":"c23986314f121690b400a94323913e0f2f5cd3d4"}]}
