)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"8d23c368191f5b3969c0a416a852cb8a4619e0b6","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if container_dict.get(\u0027restart_policy\u0027):"},{"line_number":249,"context_line":"            self._check_for_restart_policy(container_dict)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        auto_remove \u003d container_dict.pop(\u0027auto_remove\u0027, None)"},{"line_number":252,"context_line":"        if auto_remove is not None:"},{"line_number":253,"context_line":"            req_version \u003d pecan.request.version"},{"line_number":254,"context_line":"            min_version \u003d versions.Version(\u0027\u0027, \u0027\u0027, \u0027\u0027, \u00271.2\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_12bd8bd7","line":251,"updated":"2017-07-04 07:00:23.000000000","message":"Why pop()? If use pop(), it will remove `auto_remove` from container_dict. Is this right?","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"89b7065e464b40cd83e97dc49c2c29576ddcffed","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if container_dict.get(\u0027restart_policy\u0027):"},{"line_number":249,"context_line":"            self._check_for_restart_policy(container_dict)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        auto_remove \u003d container_dict.pop(\u0027auto_remove\u0027, None)"},{"line_number":252,"context_line":"        if auto_remove is not None:"},{"line_number":253,"context_line":"            req_version \u003d pecan.request.version"},{"line_number":254,"context_line":"            min_version \u003d versions.Version(\u0027\u0027, \u0027\u0027, \u0027\u0027, \u00271.2\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_441a136f","line":251,"in_reply_to":"3f1d235d_12bd8bd7","updated":"2017-07-04 15:28:42.000000000","message":"It is being set at line #256 below.","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"6bedc6377abaf335aa466be9aa2b3a87deb749dd","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if auto_remove is not None:"},{"line_number":253,"context_line":"            req_version \u003d pecan.request.version"},{"line_number":254,"context_line":"            min_version \u003d versions.Version(\u0027\u0027, \u0027\u0027, \u0027\u0027, \u00271.2\u0027)"},{"line_number":255,"context_line":"            if req_version \u003e\u003d min_version:"},{"line_number":256,"context_line":"                container_dict[\u0027auto_remove\u0027] \u003d strutils.bool_from_string("},{"line_number":257,"context_line":"                    auto_remove, strict\u003dTrue)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f1d235d_5b53d739","line":255,"range":{"start_line":255,"start_character":11,"end_line":255,"end_character":42},"updated":"2017-07-06 06:23:59.000000000","message":"Should we through an InvalidParam exception when the version \u003c 1.2?","commit_id":"49be8b91019359a55b227078d755c328ebd9f45b"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"467b0238d48d8ec7f88a47316e254d04f13ee25c","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if auto_remove is not None:"},{"line_number":253,"context_line":"            req_version \u003d pecan.request.version"},{"line_number":254,"context_line":"            min_version \u003d versions.Version(\u0027\u0027, \u0027\u0027, \u0027\u0027, \u00271.2\u0027)"},{"line_number":255,"context_line":"            if req_version \u003e\u003d min_version:"},{"line_number":256,"context_line":"                container_dict[\u0027auto_remove\u0027] \u003d strutils.bool_from_string("},{"line_number":257,"context_line":"                    auto_remove, strict\u003dTrue)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f1d235d_67014a38","line":255,"range":{"start_line":255,"start_character":11,"end_line":255,"end_character":42},"in_reply_to":"3f1d235d_5b53d739","updated":"2017-07-06 11:50:36.000000000","message":"+1","commit_id":"49be8b91019359a55b227078d755c328ebd9f45b"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"467b0238d48d8ec7f88a47316e254d04f13ee25c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            req_version \u003d pecan.request.version"},{"line_number":254,"context_line":"            min_version \u003d versions.Version(\u0027\u0027, \u0027\u0027, \u0027\u0027, \u00271.2\u0027)"},{"line_number":255,"context_line":"            if req_version \u003e\u003d min_version:"},{"line_number":256,"context_line":"                container_dict[\u0027auto_remove\u0027] \u003d strutils.bool_from_string("},{"line_number":257,"context_line":"                    auto_remove, strict\u003dTrue)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        container_dict[\u0027status\u0027] \u003d consts.CREATING"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f1d235d_27deb2d9","line":256,"range":{"start_line":256,"start_character":48,"end_line":256,"end_character":73},"updated":"2017-07-06 11:50:36.000000000","message":"may be better to catch ValueError?","commit_id":"49be8b91019359a55b227078d755c328ebd9f45b"}],"zun/api/rest_api_version_history.rst":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"6bedc6377abaf335aa466be9aa2b3a87deb749dd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"1.2"},{"line_number":26,"context_line":"---"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  Add \u0027auto_remove\u0027 field for creating a container"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f1d235d_fb12a361","line":28,"updated":"2017-07-06 06:23:59.000000000","message":"I would suggest to add a line about what this field does.","commit_id":"49be8b91019359a55b227078d755c328ebd9f45b"}],"zun/container/docker/driver.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"80ade2e0bb7fb151d5411aba1adf2e8366a23045","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def handle_not_found(e, context, container, do_not_raise\u003dFalse):"},{"line_number":49,"context_line":"    if container.auto_remove is True:"},{"line_number":50,"context_line":"        container.status \u003d consts.DELETED"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        container.status \u003d consts.ERROR"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_2f726412","line":49,"updated":"2017-07-04 06:54:23.000000000","message":"Maybe only `if container.auto_remove:`? I think `is True` is unnecessary.","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"89b7065e464b40cd83e97dc49c2c29576ddcffed","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def handle_not_found(e, context, container, do_not_raise\u003dFalse):"},{"line_number":49,"context_line":"    if container.auto_remove is True:"},{"line_number":50,"context_line":"        container.status \u003d consts.DELETED"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        container.status \u003d consts.ERROR"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_643f4fb4","line":49,"in_reply_to":"3f1d235d_2f726412","updated":"2017-07-04 15:28:42.000000000","message":"+1, because its converted to boolean at api. so just\n \u0027if container.auto_remove:\u0027 should be ok.","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"881d44501c855b1e5d8d58e4074209676f330d0b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def handle_not_found(e, context, container, do_not_raise\u003dFalse):"},{"line_number":49,"context_line":"    if container.auto_remove is True:"},{"line_number":50,"context_line":"        container.status \u003d consts.DELETED"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        container.status \u003d consts.ERROR"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_f0531516","line":49,"in_reply_to":"3f1d235d_2f726412","updated":"2017-07-04 18:05:18.000000000","message":"Done","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"80ade2e0bb7fb151d5411aba1adf2e8366a23045","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            # host_config[\u0027pid_mode\u0027] \u003d \u0027container:%s\u0027 % sandbox_id"},{"line_number":131,"context_line":"            host_config[\u0027ipc_mode\u0027] \u003d \u0027container:%s\u0027 % sandbox_id"},{"line_number":132,"context_line":"            host_config[\u0027volumes_from\u0027] \u003d sandbox_id"},{"line_number":133,"context_line":"            if container.auto_remove is True:"},{"line_number":134,"context_line":"                host_config[\u0027auto_remove\u0027] \u003d container.auto_remove"},{"line_number":135,"context_line":"            if container.memory is not None:"},{"line_number":136,"context_line":"                host_config[\u0027mem_limit\u0027] \u003d container.memory"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_0f632844","line":133,"updated":"2017-07-04 06:54:23.000000000","message":"ditto","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"881d44501c855b1e5d8d58e4074209676f330d0b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            # host_config[\u0027pid_mode\u0027] \u003d \u0027container:%s\u0027 % sandbox_id"},{"line_number":131,"context_line":"            host_config[\u0027ipc_mode\u0027] \u003d \u0027container:%s\u0027 % sandbox_id"},{"line_number":132,"context_line":"            host_config[\u0027volumes_from\u0027] \u003d sandbox_id"},{"line_number":133,"context_line":"            if container.auto_remove is True:"},{"line_number":134,"context_line":"                host_config[\u0027auto_remove\u0027] \u003d container.auto_remove"},{"line_number":135,"context_line":"            if container.memory is not None:"},{"line_number":136,"context_line":"                host_config[\u0027mem_limit\u0027] \u003d container.memory"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_d0549900","line":133,"in_reply_to":"3f1d235d_0f632844","updated":"2017-07-04 18:05:18.000000000","message":"Done","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"80ade2e0bb7fb151d5411aba1adf2e8366a23045","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            container_id \u003d db_container.container_id"},{"line_number":180,"context_line":"            docker_container \u003d id_to_container_map.get(container_id)"},{"line_number":181,"context_line":"            if not docker_container:"},{"line_number":182,"context_line":"                if db_container.auto_remove is True:"},{"line_number":183,"context_line":"                    db_container.status \u003d consts.DELETED"},{"line_number":184,"context_line":"                    db_container.save(context)"},{"line_number":185,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_ef658c46","line":182,"updated":"2017-07-04 06:54:23.000000000","message":"ditto","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"881d44501c855b1e5d8d58e4074209676f330d0b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            container_id \u003d db_container.container_id"},{"line_number":180,"context_line":"            docker_container \u003d id_to_container_map.get(container_id)"},{"line_number":181,"context_line":"            if not docker_container:"},{"line_number":182,"context_line":"                if db_container.auto_remove is True:"},{"line_number":183,"context_line":"                    db_container.status \u003d consts.DELETED"},{"line_number":184,"context_line":"                    db_container.save(context)"},{"line_number":185,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_b0591d36","line":182,"in_reply_to":"3f1d235d_ef658c46","updated":"2017-07-04 18:05:18.000000000","message":"Done","commit_id":"c3e82152347e0f5d52766f9015ceb69bd8f70929"}]}