)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b9e54b90a9bc0dc86bed7ce101ef3d4aee1a3717","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        new_container \u003d objects.Container(context, **container_dict)"},{"line_number":285,"context_line":"        new_container.create(context)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        run \u003d strutils.bool_from_string(run, strict\u003dTrue)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if run:"},{"line_number":290,"context_line":"            compute_api.container_run(context, new_container)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_e4aa2085","line":287,"updated":"2017-01-12 10:38:01.000000000","message":"method bool_from_string returns exception when strict is true and value is not in acceptable values(https://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L146), so if someone passes run\u003d\u0027xyz\u0027 then ValueError is raised and user will see 500 error code.\nShould we handle that exception and raise InvalidValue exception?\nWhat do you think?","commit_id":"05b661ccf383d21c3afdc635c36b61b959ea601c"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7c137056647d13af080262e9afc1a2f1666446b2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        new_container \u003d objects.Container(context, **container_dict)"},{"line_number":285,"context_line":"        new_container.create(context)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        run \u003d strutils.bool_from_string(run, strict\u003dTrue)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if run:"},{"line_number":290,"context_line":"            compute_api.container_run(context, new_container)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_4de85e7d","line":287,"in_reply_to":"9a57fde8_e4aa2085","updated":"2017-01-12 16:12:32.000000000","message":"Agree that it is better to wrap the ValueError to avoid 500 response.","commit_id":"05b661ccf383d21c3afdc635c36b61b959ea601c"}]}