)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e9d85f9f61dac8ba0654979e1d4064dbc86211ac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support the command \"zun get-archive\" and \"zun put-archive\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c4072368874f660aeff651ae6dd77236e3a5724"},{"line_number":10,"context_line":"Partially-Implements: blueprint support-get-put-archive"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_1cc8a8a7","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":55},"updated":"2017-01-17 19:16:01.000000000","message":"This BP hasn\u0027t been approved yet. Will discuss it in the next team meeting.","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"005ea2a25af65116770ed91f2877e26163955132","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support the command \"zun get-archive\" and \"zun put-archive\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c4072368874f660aeff651ae6dd77236e3a5724"},{"line_number":10,"context_line":"Partially-Implements: blueprint support-get-put-archive"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_d157dbc7","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":55},"in_reply_to":"7a3c09a3_1cc8a8a7","updated":"2017-01-18 01:25:41.000000000","message":"ok. I was going to implement \"zun copy\", but the docker.copy is deprecated for docker-py version \u003e \u003d 1.20, we should use get_archive instead.","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9d36bd3b0cc14fb176fdbcdf74da2d31eed3acd4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support the command \"zun get-archive\" and \"zun put-archive\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c4072368874f660aeff651ae6dd77236e3a5724"},{"line_number":10,"context_line":"Partially-Implements: blueprint support-get-put-archive"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_aeb80512","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":55},"in_reply_to":"7a3c09a3_d157dbc7","updated":"2017-01-18 22:06:19.000000000","message":"I see.","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"}],"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0577a3e7758eb93306fbea7a412f66b37fc5e581","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                  % (container.uuid, kw[\u0027path\u0027]))"},{"line_number":478,"context_line":"        context \u003d pecan.request.context"},{"line_number":479,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":480,"context_line":"        compute_api.container_get_archive(context, container, kw[\u0027path\u0027])"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":483,"context_line":"    @exception.wrap_pecan_controller_exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_9d956c34","line":480,"updated":"2017-03-03 22:47:10.000000000","message":"I think get_archive will return the archived file, so we should return the value here.","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"4cd929011b09ac0fa6d3e068079216465bfbcd5f","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                  % (container.uuid, kw[\u0027path\u0027]))"},{"line_number":478,"context_line":"        context \u003d pecan.request.context"},{"line_number":479,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":480,"context_line":"        compute_api.container_get_archive(context, container, kw[\u0027path\u0027])"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":483,"context_line":"    @exception.wrap_pecan_controller_exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_db94458c","line":480,"in_reply_to":"ba2be162_9d956c34","updated":"2017-03-04 08:23:41.000000000","message":"Done","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e9d85f9f61dac8ba0654979e1d4064dbc86211ac","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            return res"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    @check_container_id"},{"line_number":235,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":236,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":237,"context_line":"            command \u003d \u0027mkdir -p \u0027 + path"},{"line_number":238,"context_line":"            create_res \u003d docker.exec_create("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_7cdc4c73","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":19},"updated":"2017-01-17 19:16:01.000000000","message":"@Feng, could you elaborate what are the use cases of this feature?","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"2e2acf30b9b139e95dc77f1f83ea22d9b939c1c0","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            return res"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    @check_container_id"},{"line_number":235,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":236,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":237,"context_line":"            command \u003d \u0027mkdir -p \u0027 + path"},{"line_number":238,"context_line":"            create_res \u003d docker.exec_create("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_8c7c58ed","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":19},"in_reply_to":"7a3c09a3_7cdc4c73","updated":"2017-01-18 01:37:51.000000000","message":"(res1, res2) \u003d docker.get_archive(container.container_id, path)\nres1 may get the value, such as \u003crequests.packages.urllib3.response.HTTPResponse object at 0x55ac710\u003e\nIn fact, the result is not friendly for users. So I didn\u0027t return the result to users. I\u0027m glad to get your opinions.","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"005ea2a25af65116770ed91f2877e26163955132","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            return res"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    @check_container_id"},{"line_number":235,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":236,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":237,"context_line":"            command \u003d \u0027mkdir -p \u0027 + path"},{"line_number":238,"context_line":"            create_res \u003d docker.exec_create("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_6c464c50","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":19},"in_reply_to":"7a3c09a3_7cdc4c73","updated":"2017-01-18 01:25:41.000000000","message":"/home/tt (the path in container)\n/home/1.tar (the path of tar in host)\n$zun put-archive test /home/tt /home/1.tar\n$nsenter  -m -u -i -n -p -t $pid\nentering the container, we can find tar file has been extracted to the specified path\n$pwd\n/home/tt/1","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9d36bd3b0cc14fb176fdbcdf74da2d31eed3acd4","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    @check_container_id"},{"line_number":235,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":236,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":237,"context_line":"            command \u003d \u0027mkdir -p \u0027 + path"},{"line_number":238,"context_line":"            create_res \u003d docker.exec_create("},{"line_number":239,"context_line":"                container.container_id, command, True, True, False)"},{"line_number":240,"context_line":"            docker.exec_start(create_res, False, False, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_1f484c87","line":237,"range":{"start_line":237,"start_character":12,"end_line":237,"end_character":19},"updated":"2017-01-18 22:06:19.000000000","message":"I don\u0027t think you need to create this folder. I guess docker will throw an exception if the folder was not created? If yes, simply re-raise the exception should be enough.","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"d1345da36af30702e04418e0d1d5dece38d189f7","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    @check_container_id"},{"line_number":235,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":236,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":237,"context_line":"            command \u003d \u0027mkdir -p \u0027 + path"},{"line_number":238,"context_line":"            create_res \u003d docker.exec_create("},{"line_number":239,"context_line":"                container.container_id, command, True, True, False)"},{"line_number":240,"context_line":"            docker.exec_start(create_res, False, False, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ac6fcfc3","line":237,"range":{"start_line":237,"start_character":12,"end_line":237,"end_character":19},"in_reply_to":"7a3c09a3_1f484c87","updated":"2017-03-02 08:17:51.000000000","message":"Done","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9d36bd3b0cc14fb176fdbcdf74da2d31eed3acd4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            docker.exec_start(create_res, False, False, False)"},{"line_number":241,"context_line":"            f \u003d open(data, \u0027rb\u0027)"},{"line_number":242,"context_line":"            filedata \u003d f.read()"},{"line_number":243,"context_line":"            docker.put_archive(container.container_id, path, filedata)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def _encode_utf8(self, value):"},{"line_number":246,"context_line":"        if six.PY2 and not isinstance(value, unicode):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_ff9d400b","line":243,"range":{"start_line":243,"start_character":61,"end_line":243,"end_character":69},"updated":"2017-01-18 22:06:19.000000000","message":"How about directly passing tarball data to here (instead of opening and reading from file)?","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"d1345da36af30702e04418e0d1d5dece38d189f7","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            docker.exec_start(create_res, False, False, False)"},{"line_number":241,"context_line":"            f \u003d open(data, \u0027rb\u0027)"},{"line_number":242,"context_line":"            filedata \u003d f.read()"},{"line_number":243,"context_line":"            docker.put_archive(container.container_id, path, filedata)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def _encode_utf8(self, value):"},{"line_number":246,"context_line":"        if six.PY2 and not isinstance(value, unicode):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ecb0e745","line":243,"range":{"start_line":243,"start_character":61,"end_line":243,"end_character":69},"in_reply_to":"7a3c09a3_ff9d400b","updated":"2017-03-02 08:17:51.000000000","message":"The data should be binary stream, so I open and read from file.","commit_id":"a533df71b66999a3699acb34e089ec65f2c90280"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0577a3e7758eb93306fbea7a412f66b37fc5e581","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    def get_archive(self, container, path):"},{"line_number":355,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":356,"context_line":"            try:"},{"line_number":357,"context_line":"                res, _ \u003d docker.get_archive(container.container_id, path)"},{"line_number":358,"context_line":"                return res"},{"line_number":359,"context_line":"            except errors.APIError:"},{"line_number":360,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_20c3778a","line":357,"range":{"start_line":357,"start_character":21,"end_line":357,"end_character":22},"updated":"2017-03-03 22:47:10.000000000","message":"I think it would be better to return the second value as well, which contains the stat of the archive.","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"4cd929011b09ac0fa6d3e068079216465bfbcd5f","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    def get_archive(self, container, path):"},{"line_number":355,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":356,"context_line":"            try:"},{"line_number":357,"context_line":"                res, _ \u003d docker.get_archive(container.container_id, path)"},{"line_number":358,"context_line":"                return res"},{"line_number":359,"context_line":"            except errors.APIError:"},{"line_number":360,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_3bec8129","line":357,"range":{"start_line":357,"start_character":21,"end_line":357,"end_character":22},"in_reply_to":"ba2be162_20c3778a","updated":"2017-03-04 08:23:41.000000000","message":"Done","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0577a3e7758eb93306fbea7a412f66b37fc5e581","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":356,"context_line":"            try:"},{"line_number":357,"context_line":"                res, _ \u003d docker.get_archive(container.container_id, path)"},{"line_number":358,"context_line":"                return res"},{"line_number":359,"context_line":"            except errors.APIError:"},{"line_number":360,"context_line":"                raise"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_e0115f05","line":358,"range":{"start_line":358,"start_character":23,"end_line":358,"end_character":26},"updated":"2017-03-03 22:47:10.000000000","message":"I have tested it. It looks you need to do \u0027res.read()\u0027 to get the data instead.","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0577a3e7758eb93306fbea7a412f66b37fc5e581","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":364,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":365,"context_line":"            try:"},{"line_number":366,"context_line":"                f \u003d open(data, \u0027rb\u0027)"},{"line_number":367,"context_line":"                filedata \u003d f.read()"},{"line_number":368,"context_line":"                docker.put_archive(container.container_id, path, filedata)"},{"line_number":369,"context_line":"            except errors.APIError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_c0253b5c","line":366,"range":{"start_line":366,"start_character":25,"end_line":366,"end_character":29},"updated":"2017-03-03 22:47:10.000000000","message":"It seems you consider \u0027data\u0027 as a filename and open it in zun-server. I don\u0027t think this will work if client and server are in different machine. I think we should pass \u0027data\u0027 as the raw filedata (read file in CLI and send the data to server), and directly pass it to put_archive instead. That is removing line #366-#367 and change #368 to:\n\n  docker.put_archive(container.container_id, path, data)","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"abec04ddeb82eb922e2a112f7db5a20781a773a8","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":364,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":365,"context_line":"            try:"},{"line_number":366,"context_line":"                f \u003d open(data, \u0027rb\u0027)"},{"line_number":367,"context_line":"                filedata \u003d f.read()"},{"line_number":368,"context_line":"                docker.put_archive(container.container_id, path, filedata)"},{"line_number":369,"context_line":"            except errors.APIError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_e1023ab3","line":366,"range":{"start_line":366,"start_character":25,"end_line":366,"end_character":29},"in_reply_to":"ba2be162_7bf27907","updated":"2017-03-04 14:05:05.000000000","message":"It seems you got this error because you send the data in the URI? I guess you can send the data in the request body instead?","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"4cd929011b09ac0fa6d3e068079216465bfbcd5f","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    def put_archive(self, container, path, data):"},{"line_number":364,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":365,"context_line":"            try:"},{"line_number":366,"context_line":"                f \u003d open(data, \u0027rb\u0027)"},{"line_number":367,"context_line":"                filedata \u003d f.read()"},{"line_number":368,"context_line":"                docker.put_archive(container.container_id, path, filedata)"},{"line_number":369,"context_line":"            except errors.APIError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_7bf27907","line":366,"range":{"start_line":366,"start_character":25,"end_line":366,"end_character":29},"in_reply_to":"ba2be162_c0253b5c","updated":"2017-03-04 08:23:41.000000000","message":"I have tried. If I read file in CLI and send the data to server，I get a request error, such as \"Request-URI Too Long (HTTP 414)\"","commit_id":"4d04769ddf07ec2a79efb98e6a4a9fae525cac6d"}]}
