)]}'
{"zun/api/controllers/v1/schemas/containers.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"411121f2010f2aa5db4d34a5640326ed9d6bfcf2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027labels\u0027: parameter_types.labels,"},{"line_number":26,"context_line":"    \u0027environment\u0027: parameter_types.environment,"},{"line_number":27,"context_line":"    \u0027restart_policy\u0027: parameter_types.restart_policy,"},{"line_number":28,"context_line":"    \u0027tty\u0027: parameter_types.boolean,"},{"line_number":29,"context_line":"    \u0027stdin_open\u0027: parameter_types.boolean,"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_abe697ad","line":28,"updated":"2017-01-22 07:13:54.000000000","message":"boolean type can accept more parameters than just simple True or False, (plz see https://github.com/openstack/zun/blob/master/zun/common/validation/parameter_types.py#L21). I think this option just need True/False not 1 or on or off. So better would be after validation convert it to boolean like https://github.com/openstack/zun/blob/master/zun/common/validation/parameter_types.py#L21 or i would suggest rename current boolean to boolean_extended  and add one more type boolean, which handles just [True, False, \u0027True\u0027, \u0027False\u0027, \u0027true\u0027, \u0027false\u0027], what do you think?","commit_id":"675b51c21141a6aed5b1a6cfdf00c1c0214ad89f"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"e827d14f37c4f4e85d757001db08df5bed4aa5bf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027labels\u0027: parameter_types.labels,"},{"line_number":26,"context_line":"    \u0027environment\u0027: parameter_types.environment,"},{"line_number":27,"context_line":"    \u0027restart_policy\u0027: parameter_types.restart_policy,"},{"line_number":28,"context_line":"    \u0027tty\u0027: parameter_types.boolean,"},{"line_number":29,"context_line":"    \u0027stdin_open\u0027: parameter_types.boolean,"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_4e7d41b0","line":28,"in_reply_to":"5a3905b3_abe697ad","updated":"2017-01-22 08:52:23.000000000","message":"Hi Pradeep,\n   Thanks~ I prefer to rename currnet boolean to boolean_extended and add one more boolean. I will finish this on this patch.","commit_id":"675b51c21141a6aed5b1a6cfdf00c1c0214ad89f"}],"zun/db/sqlalchemy/alembic/versions/d1ef05fd92c8_add_tty_stdin_open.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"817c906213c6a89477c23e085a297330b0fca1b4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                  sa.Column(\u0027stdin_open\u0027, sa.Boolean,"},{"line_number":37,"context_line":"                            nullable\u003dTrue))"},{"line_number":38,"context_line":"    op.add_column(\u0027container\u0027,"},{"line_number":39,"context_line":"                  sa.Column(\u0027attached\u0027, sa.Boolean,"},{"line_number":40,"context_line":"                            nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_cee17a9c","line":39,"range":{"start_line":39,"start_character":29,"end_line":39,"end_character":37},"updated":"2017-01-20 04:15:07.000000000","message":"@Kevin,\n\nI think tty and stdin_open are good, but \u0027attached\u0027 doesn\u0027t seem to be necessary. I couldn\u0027t think of any use case of using this attribute, since it is possible for multiple users to attach a container at the same time. I don\u0027t think it is necessary to track a container has been attached or not.","commit_id":"ae8eca8ca9ece8d4be85255167aa5d139fc87b2e"}]}