)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6581381ef812b7271c0cd1cdab5fb0660d1705f7","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def __init__(self, **kwargs):"},{"line_number":68,"context_line":"        self._type \u003d \u0027containers\u0027"},{"line_number":69,"context_line":"        self.container_remote_api_port \u003d CONF.container_driver"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @staticmethod"},{"line_number":72,"context_line":"    def convert_with_links(rpc_containers, limit, url\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_3ca60bae","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":62},"updated":"2017-01-24 15:30:58.000000000","message":"It looks you assign a driver to a port here. This doesn\u0027t seem to be correct.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def __init__(self, **kwargs):"},{"line_number":68,"context_line":"        self._type \u003d \u0027containers\u0027"},{"line_number":69,"context_line":"        self.container_remote_api_port \u003d CONF.container_driver"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @staticmethod"},{"line_number":72,"context_line":"    def convert_with_links(rpc_containers, limit, url\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_600df336","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":62},"in_reply_to":"5a3905b3_072b9734","updated":"2017-02-07 02:52:36.000000000","message":"Sorry, Make a mistake here.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def __init__(self, **kwargs):"},{"line_number":68,"context_line":"        self._type \u003d \u0027containers\u0027"},{"line_number":69,"context_line":"        self.container_remote_api_port \u003d CONF.container_driver"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @staticmethod"},{"line_number":72,"context_line":"    def convert_with_links(rpc_containers, limit, url\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_072b9734","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":62},"in_reply_to":"5a3905b3_3ca60bae","updated":"2017-01-25 04:15:12.000000000","message":"+1, \u0026 what is the purpose of putting it in collection class?","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def __init__(self, **kwargs):"},{"line_number":68,"context_line":"        self._type \u003d \u0027containers\u0027"},{"line_number":69,"context_line":"        self.container_remote_api_port \u003d CONF.container_driver"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @staticmethod"},{"line_number":72,"context_line":"    def convert_with_links(rpc_containers, limit, url\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_0000af00","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":62},"in_reply_to":"5a3905b3_3ca60bae","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6581381ef812b7271c0cd1cdab5fb0660d1705f7","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        check_policy_on_container(container.as_dict(), \"container:attach\")"},{"line_number":413,"context_line":"        context \u003d pecan.request.context"},{"line_number":414,"context_line":"        db_services \u003d dbapi.list_zun_service(context)"},{"line_number":415,"context_line":"        host \u003d db_services[0].host"},{"line_number":416,"context_line":"        remote_api_port \u003d CONF.container_remote_api_port"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        LOG.debug(\u0027Checking the status for attach with %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_5cf6778f","line":415,"range":{"start_line":415,"start_character":30,"end_line":415,"end_character":34},"updated":"2017-01-24 15:30:58.000000000","message":"@Kevin,\n\nI don\u0027t think this will work in multi-host scenario, because the container is not necessary running at db_services[0] (it might run at [1], [2], etc.).","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        check_policy_on_container(container.as_dict(), \"container:attach\")"},{"line_number":413,"context_line":"        context \u003d pecan.request.context"},{"line_number":414,"context_line":"        db_services \u003d dbapi.list_zun_service(context)"},{"line_number":415,"context_line":"        host \u003d db_services[0].host"},{"line_number":416,"context_line":"        remote_api_port \u003d CONF.container_remote_api_port"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        LOG.debug(\u0027Checking the status for attach with %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_f1e9b31b","line":415,"range":{"start_line":415,"start_character":30,"end_line":415,"end_character":34},"in_reply_to":"5a3905b3_5cf6778f","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        check_policy_on_container(container.as_dict(), \"container:attach\")"},{"line_number":413,"context_line":"        context \u003d pecan.request.context"},{"line_number":414,"context_line":"        db_services \u003d dbapi.list_zun_service(context)"},{"line_number":415,"context_line":"        host \u003d db_services[0].host"},{"line_number":416,"context_line":"        remote_api_port \u003d CONF.container_remote_api_port"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        LOG.debug(\u0027Checking the status for attach with %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_e7168bf0","line":415,"range":{"start_line":415,"start_character":30,"end_line":415,"end_character":34},"in_reply_to":"5a3905b3_5cf6778f","updated":"2017-01-25 04:15:12.000000000","message":"I think we can get this information from container.host, plz check.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        check_policy_on_container(container.as_dict(), \"container:attach\")"},{"line_number":413,"context_line":"        context \u003d pecan.request.context"},{"line_number":414,"context_line":"        db_services \u003d dbapi.list_zun_service(context)"},{"line_number":415,"context_line":"        host \u003d db_services[0].host"},{"line_number":416,"context_line":"        remote_api_port \u003d CONF.container_remote_api_port"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        LOG.debug(\u0027Checking the status for attach with %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_d18cb781","line":415,"range":{"start_line":415,"start_character":30,"end_line":415,"end_character":34},"in_reply_to":"5a3905b3_e7168bf0","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                # TODO(kevinz): Add docker remote api version"},{"line_number":423,"context_line":"                context \u003d pecan.request.context"},{"line_number":424,"context_line":"                compute_api \u003d pecan.request.compute_api"},{"line_number":425,"context_line":"                version \u003d compute_api.container_attach(context, container)"},{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_67e1bbfe","line":425,"range":{"start_line":425,"start_character":16,"end_line":425,"end_character":23},"updated":"2017-01-25 04:15:12.000000000","message":"I think version is already there in https://github.com/openstack/zun/blob/d73d54a934e49220b7e304164bee851bb322e9f3/zun/conf/docker.py#L20, why can\u0027t we reuse it?\nAnd why we are calling it attach, its simply getting the version, can\u0027t we simply call it get_version?","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                # TODO(kevinz): Add docker remote api version"},{"line_number":423,"context_line":"                context \u003d pecan.request.context"},{"line_number":424,"context_line":"                compute_api \u003d pecan.request.compute_api"},{"line_number":425,"context_line":"                version \u003d compute_api.container_attach(context, container)"},{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_31597bff","line":425,"range":{"start_line":425,"start_character":16,"end_line":425,"end_character":23},"in_reply_to":"5a3905b3_67e1bbfe","updated":"2017-02-07 02:52:36.000000000","message":"Hi Pradeep,\n   Thanks~\n   I\u0027ve changed the attach function from just get version to get url now","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6581381ef812b7271c0cd1cdab5fb0660d1705f7","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                context \u003d pecan.request.context"},{"line_number":424,"context_line":"                compute_api \u003d pecan.request.compute_api"},{"line_number":425,"context_line":"                version \u003d compute_api.container_attach(context, container)"},{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_9c8d3fd5","line":426,"range":{"start_line":426,"start_character":16,"end_line":426,"end_character":19},"updated":"2017-01-24 15:30:58.000000000","message":"@Kevin,\n\nIt looks this url is docker-specific, so it is better to move this to the docker driver. In the future, there might be another container runtime that generate a different url so moving this logic out of controller seems to be more flexible.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                context \u003d pecan.request.context"},{"line_number":424,"context_line":"                compute_api \u003d pecan.request.compute_api"},{"line_number":425,"context_line":"                version \u003d compute_api.container_attach(context, container)"},{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_e7edabf0","line":426,"range":{"start_line":426,"start_character":16,"end_line":426,"end_character":19},"in_reply_to":"5a3905b3_9c8d3fd5","updated":"2017-01-25 04:15:12.000000000","message":"+1","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                context \u003d pecan.request.context"},{"line_number":424,"context_line":"                compute_api \u003d pecan.request.compute_api"},{"line_number":425,"context_line":"                version \u003d compute_api.container_attach(context, container)"},{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_71730381","line":426,"range":{"start_line":426,"start_character":16,"end_line":426,"end_character":19},"in_reply_to":"5a3905b3_9c8d3fd5","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                context \u003d pecan.request.context"},{"line_number":424,"context_line":"                compute_api \u003d pecan.request.compute_api"},{"line_number":425,"context_line":"                version \u003d compute_api.container_attach(context, container)"},{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_916eaf94","line":426,"range":{"start_line":426,"start_character":16,"end_line":426,"end_character":19},"in_reply_to":"5a3905b3_e7edabf0","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""},{"line_number":430,"context_line":"        return \"Container doesn\u0027t support to be attached, \" \\"},{"line_number":431,"context_line":"               \"please check the tty and stdin_open\""},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_8794e744","line":429,"updated":"2017-01-25 04:15:12.000000000","message":"I think its better to use validate_container_state from https://github.com/openstack/zun/blob/d73d54a934e49220b7e304164bee851bb322e9f3/zun/conf/docker.py#L20 after getting the container detail.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                url \u003d \"ws://\" + host + \":\" + remote_api_port + \"/\" + version + \"/containers/\" + \\"},{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""},{"line_number":430,"context_line":"        return \"Container doesn\u0027t support to be attached, \" \\"},{"line_number":431,"context_line":"               \"please check the tty and stdin_open\""},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_1521ca4d","line":429,"in_reply_to":"5a3905b3_8794e744","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""},{"line_number":430,"context_line":"        return \"Container doesn\u0027t support to be attached, \" \\"},{"line_number":431,"context_line":"               \"please check the tty and stdin_open\""},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @pecan.expose(\u0027json\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_87a22799","line":430,"updated":"2017-01-25 04:15:12.000000000","message":"I think we can raise some exception here too, I am not sure about the code, but may 409 conflict would be appropriate.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                    container.container_id + ATTACH_FLAG"},{"line_number":428,"context_line":"                return url"},{"line_number":429,"context_line":"            return \"Container is not running\""},{"line_number":430,"context_line":"        return \"Container doesn\u0027t support to be attached, \" \\"},{"line_number":431,"context_line":"               \"please check the tty and stdin_open\""},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @pecan.expose(\u0027json\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_b585565a","line":430,"in_reply_to":"5a3905b3_87a22799","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":440,"context_line":"#        db_services \u003d dbapi.list_zun_service(context)"},{"line_number":441,"context_line":"#        host \u003d db_services[0].host"},{"line_number":442,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":443,"context_line":"        compute_api.container_resize(context, container, kw.get(\u0027h\u0027, None),"},{"line_number":444,"context_line":"                                     kw.get(\u0027w\u0027, None))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_67eb7bb1","line":444,"range":{"start_line":443,"start_character":57,"end_line":444,"end_character":55},"updated":"2017-01-25 04:15:12.000000000","message":"I have no strong objection to this, but i would suggest please add h and w as query parameters like /v1/containers/resize?h\u003d1\u0026w\u003d2, and please add the validation for that too because i think h and w can be integer only, am i correct?","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":440,"context_line":"#        db_services \u003d dbapi.list_zun_service(context)"},{"line_number":441,"context_line":"#        host \u003d db_services[0].host"},{"line_number":442,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":443,"context_line":"        compute_api.container_resize(context, container, kw.get(\u0027h\u0027, None),"},{"line_number":444,"context_line":"                                     kw.get(\u0027w\u0027, None))"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_f5443e1c","line":444,"range":{"start_line":443,"start_character":57,"end_line":444,"end_character":55},"in_reply_to":"5a3905b3_67eb7bb1","updated":"2017-02-07 02:52:36.000000000","message":"Thanks Pradeep, this is a good advice, I\u0027ll added.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"}],"zun/api/controllers/v1/schemas/containers.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b93975ac60c48426a9d05fa70b1c6ecfe15c4786","unresolved":false,"context_lines":[{"line_number":85,"context_line":"query_param_resize \u003d {"},{"line_number":86,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":87,"context_line":"    \u0027properties\u0027: {"},{"line_number":88,"context_line":"        \u0027h\u0027: parameter_types.non_negative_integer,"},{"line_number":89,"context_line":"        \u0027w\u0027: parameter_types.non_negative_integer"},{"line_number":90,"context_line":"    },"},{"line_number":91,"context_line":"    \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_8dcd3d33","line":88,"updated":"2017-02-08 13:00:37.000000000","message":"can height and width be zero? if not then do we need to introduce  another type positive_integer?","commit_id":"17c07a22e6ea3c217a07bf79111e8322732a7ad4"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"921d6093a2a0ef84f599e5ebbdcee40c73af4259","unresolved":false,"context_lines":[{"line_number":85,"context_line":"query_param_resize \u003d {"},{"line_number":86,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":87,"context_line":"    \u0027properties\u0027: {"},{"line_number":88,"context_line":"        \u0027h\u0027: parameter_types.non_negative_integer,"},{"line_number":89,"context_line":"        \u0027w\u0027: parameter_types.non_negative_integer"},{"line_number":90,"context_line":"    },"},{"line_number":91,"context_line":"    \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_f5e0432b","line":88,"in_reply_to":"1a430d35_8dcd3d33","updated":"2017-02-08 14:13:55.000000000","message":"Thanks~ I will modify here","commit_id":"17c07a22e6ea3c217a07bf79111e8322732a7ad4"}],"zun/compute/manager.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        return container"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def container_resize(self, context, container, height, weight):"},{"line_number":373,"context_line":"        utils.spawn_n(self._do_container_resize, context,"},{"line_number":374,"context_line":"                      container, height, weight)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def image_pull(self, context, image):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_e773eb13","line":373,"updated":"2017-01-25 04:15:12.000000000","message":"I think you dont need to put in thread because resize is call operation not cast, am i correct?","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        return container"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def container_resize(self, context, container, height, weight):"},{"line_number":373,"context_line":"        utils.spawn_n(self._do_container_resize, context,"},{"line_number":374,"context_line":"                      container, height, weight)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def image_pull(self, context, image):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_581b871b","line":373,"in_reply_to":"5a3905b3_e773eb13","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"}],"zun/compute/rpcapi.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        return self._call(container.host, \u0027container_attach\u0027,"},{"line_number":87,"context_line":"                          container\u003dcontainer)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def container_resize(self, context, container, height, weight):"},{"line_number":90,"context_line":"        return self._call(container.host, \u0027container_resize\u0027,"},{"line_number":91,"context_line":"                          container\u003dcontainer, height\u003dheight, weight\u003dweight)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_8753076c","line":89,"range":{"start_line":89,"start_character":59,"end_line":89,"end_character":65},"updated":"2017-01-25 04:15:12.000000000","message":"i think its width?","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        return self._call(container.host, \u0027container_attach\u0027,"},{"line_number":87,"context_line":"                          container\u003dcontainer)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def container_resize(self, context, container, height, weight):"},{"line_number":90,"context_line":"        return self._call(container.host, \u0027container_resize\u0027,"},{"line_number":91,"context_line":"                          container\u003dcontainer, height\u003dheight, weight\u003dweight)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_efbab4e0","line":89,"range":{"start_line":89,"start_character":59,"end_line":89,"end_character":65},"in_reply_to":"5a3905b3_8753076c","updated":"2017-02-07 02:52:36.000000000","message":"Sorry I make a mistake here. Thanks","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def container_resize(self, context, container, height, weight):"},{"line_number":90,"context_line":"        return self._call(container.host, \u0027container_resize\u0027,"},{"line_number":91,"context_line":"                          container\u003dcontainer, height\u003dheight, weight\u003dweight)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def image_show(self, context, image):"},{"line_number":94,"context_line":"        # NOTE(hongbin): Image API doesn\u0027t support multiple compute nodes"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_a7500360","line":91,"range":{"start_line":91,"start_character":62,"end_line":91,"end_character":75},"updated":"2017-01-25 04:15:12.000000000","message":"ditto","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def container_resize(self, context, container, height, weight):"},{"line_number":90,"context_line":"        return self._call(container.host, \u0027container_resize\u0027,"},{"line_number":91,"context_line":"                          container\u003dcontainer, height\u003dheight, weight\u003dweight)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def image_show(self, context, image):"},{"line_number":94,"context_line":"        # NOTE(hongbin): Image API doesn\u0027t support multiple compute nodes"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_0fbe20d4","line":91,"range":{"start_line":91,"start_character":62,"end_line":91,"end_character":75},"in_reply_to":"5a3905b3_a7500360","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"}],"zun/conf/container_driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6581381ef812b7271c0cd1cdab5fb0660d1705f7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003d\u0027Time to sleep (in seconds) during waiting for an event.\u0027),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027default_timeout\u0027, default\u003d60 * 10,"},{"line_number":36,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for an event.\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027container_remote_api_port\u0027,"},{"line_number":38,"context_line":"               default\u003d\u00272375\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Defines the remote api port for the container.\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_9017e343","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":41},"updated":"2017-01-24 15:30:58.000000000","message":"It looks this is a docker port? If yes, how about moving this config to here: https://github.com/openstack/zun/blob/master/zun/conf/docker.py .","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003d\u0027Time to sleep (in seconds) during waiting for an event.\u0027),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027default_timeout\u0027, default\u003d60 * 10,"},{"line_number":36,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for an event.\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027container_remote_api_port\u0027,"},{"line_number":38,"context_line":"               default\u003d\u00272375\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Defines the remote api port for the container.\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_e74a0bac","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":41},"in_reply_to":"5a3905b3_9017e343","updated":"2017-01-25 04:15:12.000000000","message":"+1","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               help\u003d\u0027Time to sleep (in seconds) during waiting for an event.\u0027),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027default_timeout\u0027, default\u003d60 * 10,"},{"line_number":36,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for an event.\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027container_remote_api_port\u0027,"},{"line_number":38,"context_line":"               default\u003d\u00272375\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Defines the remote api port for the container.\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_95c77a11","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":41},"in_reply_to":"5a3905b3_9017e343","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6581381ef812b7271c0cd1cdab5fb0660d1705f7","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    def attach(self, container):"},{"line_number":304,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":305,"context_line":"            version \u003d \u0027v\u0027 + docker.version().get(\u0027ApiVersion\u0027, \"1.22\")"},{"line_number":306,"context_line":"            return version"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @check_container_id"},{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_30446f48","line":306,"range":{"start_line":306,"start_character":19,"end_line":306,"end_character":26},"updated":"2017-01-24 15:30:58.000000000","message":"As my previous comment, it is better to return the entire url here instead.","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    def attach(self, container):"},{"line_number":304,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":305,"context_line":"            version \u003d \u0027v\u0027 + docker.version().get(\u0027ApiVersion\u0027, \"1.22\")"},{"line_number":306,"context_line":"            return version"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @check_container_id"},{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_47d03fca","line":306,"range":{"start_line":306,"start_character":19,"end_line":306,"end_character":26},"in_reply_to":"5a3905b3_30446f48","updated":"2017-01-25 04:15:12.000000000","message":"+1, may be rename it to get_url or something else instead of attach?","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    def attach(self, container):"},{"line_number":304,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":305,"context_line":"            version \u003d \u0027v\u0027 + docker.version().get(\u0027ApiVersion\u0027, \"1.22\")"},{"line_number":306,"context_line":"            return version"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @check_container_id"},{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_75f84e4a","line":306,"range":{"start_line":306,"start_character":19,"end_line":306,"end_character":26},"in_reply_to":"5a3905b3_30446f48","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    def attach(self, container):"},{"line_number":304,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":305,"context_line":"            version \u003d \u0027v\u0027 + docker.version().get(\u0027ApiVersion\u0027, \"1.22\")"},{"line_number":306,"context_line":"            return version"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @check_container_id"},{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_9595bae5","line":306,"range":{"start_line":306,"start_character":19,"end_line":306,"end_character":26},"in_reply_to":"5a3905b3_47d03fca","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            return version"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @check_container_id"},{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"},{"line_number":310,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":311,"context_line":"            height \u003d int(height)"},{"line_number":312,"context_line":"            weight \u003d int(weight)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_07ed578e","line":309,"range":{"start_line":309,"start_character":45,"end_line":309,"end_character":51},"updated":"2017-01-25 04:15:12.000000000","message":"width","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            return version"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @check_container_id"},{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"},{"line_number":310,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":311,"context_line":"            height \u003d int(height)"},{"line_number":312,"context_line":"            weight \u003d int(weight)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_35d7a6c0","line":309,"range":{"start_line":309,"start_character":45,"end_line":309,"end_character":51},"in_reply_to":"5a3905b3_07ed578e","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"},{"line_number":310,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":311,"context_line":"            height \u003d int(height)"},{"line_number":312,"context_line":"            weight \u003d int(weight)"},{"line_number":313,"context_line":"            docker.resize(container.container_id, height, weight)"},{"line_number":314,"context_line":"            return container"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_27f25370","line":312,"range":{"start_line":312,"start_character":25,"end_line":312,"end_character":31},"updated":"2017-01-25 04:15:12.000000000","message":"ditto","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def resize(self, container, height\u003dNone, weight\u003dNone):"},{"line_number":310,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":311,"context_line":"            height \u003d int(height)"},{"line_number":312,"context_line":"            weight \u003d int(weight)"},{"line_number":313,"context_line":"            docker.resize(container.container_id, height, weight)"},{"line_number":314,"context_line":"            return container"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_55e6f2b4","line":312,"range":{"start_line":312,"start_character":25,"end_line":312,"end_character":31},"in_reply_to":"5a3905b3_27f25370","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":311,"context_line":"            height \u003d int(height)"},{"line_number":312,"context_line":"            weight \u003d int(weight)"},{"line_number":313,"context_line":"            docker.resize(container.container_id, height, weight)"},{"line_number":314,"context_line":"            return container"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def _encode_utf8(self, value):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_67ec5b90","line":313,"range":{"start_line":313,"start_character":58,"end_line":313,"end_character":64},"updated":"2017-01-25 04:15:12.000000000","message":"ditto","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":311,"context_line":"            height \u003d int(height)"},{"line_number":312,"context_line":"            weight \u003d int(weight)"},{"line_number":313,"context_line":"            docker.resize(container.container_id, height, weight)"},{"line_number":314,"context_line":"            return container"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def _encode_utf8(self, value):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_95ee9a89","line":313,"range":{"start_line":313,"start_character":58,"end_line":313,"end_character":64},"in_reply_to":"5a3905b3_67ec5b90","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b93975ac60c48426a9d05fa70b1c6ecfe15c4786","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            except errors.APIError:"},{"line_number":301,"context_line":"                raise"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @check_container_id"},{"line_number":304,"context_line":"    def get_websocket_url(self, container):"},{"line_number":305,"context_line":"        version \u003d CONF.docker.docker_remote_api_version"},{"line_number":306,"context_line":"        remote_api_port \u003d CONF.docker.docker_remote_api_port"},{"line_number":307,"context_line":"        url \u003d \"ws://\" + container.host + \":\" + remote_api_port + \\"},{"line_number":308,"context_line":"              \"/v\" + version + \"/containers/\" + container.container_id \\"},{"line_number":309,"context_line":"              + ATTACH_FLAG"},{"line_number":310,"context_line":"        return url"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @check_container_id"},{"line_number":313,"context_line":"    def resize(self, container, height\u003dNone, width\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_adaaf982","line":310,"range":{"start_line":303,"start_character":4,"end_line":310,"end_character":18},"updated":"2017-02-08 13:00:37.000000000","message":"@Kevin, I still wonder, whether we need this code in compute service, because it\u0027s doing nothing except just returning some constants and db entries.  Can we move this code to API? Thoughts?","commit_id":"17c07a22e6ea3c217a07bf79111e8322732a7ad4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7b03a58de412cf53b398a667243e559e53f4bead","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            except errors.APIError:"},{"line_number":301,"context_line":"                raise"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @check_container_id"},{"line_number":304,"context_line":"    def get_websocket_url(self, container):"},{"line_number":305,"context_line":"        version \u003d CONF.docker.docker_remote_api_version"},{"line_number":306,"context_line":"        remote_api_port \u003d CONF.docker.docker_remote_api_port"},{"line_number":307,"context_line":"        url \u003d \"ws://\" + container.host + \":\" + remote_api_port + \\"},{"line_number":308,"context_line":"              \"/v\" + version + \"/containers/\" + container.container_id \\"},{"line_number":309,"context_line":"              + ATTACH_FLAG"},{"line_number":310,"context_line":"        return url"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @check_container_id"},{"line_number":313,"context_line":"    def resize(self, container, height\u003dNone, width\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_9ddf1439","line":310,"range":{"start_line":303,"start_character":4,"end_line":310,"end_character":18},"in_reply_to":"1a430d35_55b4b733","updated":"2017-02-08 20:19:37.000000000","message":"Yes. Actually, I am the one who adviced @Kevin to move the url to here, mainly for the further adoption of container runtime other than docker.","commit_id":"17c07a22e6ea3c217a07bf79111e8322732a7ad4"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"921d6093a2a0ef84f599e5ebbdcee40c73af4259","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            except errors.APIError:"},{"line_number":301,"context_line":"                raise"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @check_container_id"},{"line_number":304,"context_line":"    def get_websocket_url(self, container):"},{"line_number":305,"context_line":"        version \u003d CONF.docker.docker_remote_api_version"},{"line_number":306,"context_line":"        remote_api_port \u003d CONF.docker.docker_remote_api_port"},{"line_number":307,"context_line":"        url \u003d \"ws://\" + container.host + \":\" + remote_api_port + \\"},{"line_number":308,"context_line":"              \"/v\" + version + \"/containers/\" + container.container_id \\"},{"line_number":309,"context_line":"              + ATTACH_FLAG"},{"line_number":310,"context_line":"        return url"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @check_container_id"},{"line_number":313,"context_line":"    def resize(self, container, height\u003dNone, width\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_55b4b733","line":310,"range":{"start_line":303,"start_character":4,"end_line":310,"end_character":18},"in_reply_to":"1a430d35_adaaf982","updated":"2017-02-08 14:13:55.000000000","message":"Hi @Pradeep,\n   Thanks~\n   Since the url structure is Docker specified, other container driver is different, also thee remote_api_port may different according to the zun.conf in each compute node. so IMO move this to API maybe not a good choice. What do you think? :-）","commit_id":"17c07a22e6ea3c217a07bf79111e8322732a7ad4"}],"zun/container/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6581381ef812b7271c0cd1cdab5fb0660d1705f7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"\"\"kill signal to a container.\"\"\""},{"line_number":108,"context_line":"        raise NotImplementedError()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def resize(self, container, height, weight):"},{"line_number":111,"context_line":"        \"\"\"resize tty of a container.\"\"\""},{"line_number":112,"context_line":"        raise NotImplementedError()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_b084df5d","line":110,"updated":"2017-01-24 15:30:58.000000000","message":"miss \u0027attach\u0027 ?","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"\"\"kill signal to a container.\"\"\""},{"line_number":108,"context_line":"        raise NotImplementedError()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def resize(self, container, height, weight):"},{"line_number":111,"context_line":"        \"\"\"resize tty of a container.\"\"\""},{"line_number":112,"context_line":"        raise NotImplementedError()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_d8f3f708","line":110,"in_reply_to":"5a3905b3_27997320","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"f9aac844f14b7d46618a1c73c236d809cda6edfa","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"\"\"kill signal to a container.\"\"\""},{"line_number":108,"context_line":"        raise NotImplementedError()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def resize(self, container, height, weight):"},{"line_number":111,"context_line":"        \"\"\"resize tty of a container.\"\"\""},{"line_number":112,"context_line":"        raise NotImplementedError()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_27997320","line":110,"in_reply_to":"5a3905b3_b084df5d","updated":"2017-01-25 04:15:12.000000000","message":"+1","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"3a32ba133be2d348415ea8bf1b8dae1e0255ab49","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"\"\"kill signal to a container.\"\"\""},{"line_number":108,"context_line":"        raise NotImplementedError()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def resize(self, container, height, weight):"},{"line_number":111,"context_line":"        \"\"\"resize tty of a container.\"\"\""},{"line_number":112,"context_line":"        raise NotImplementedError()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_98e96f1d","line":110,"in_reply_to":"5a3905b3_b084df5d","updated":"2017-02-07 02:52:36.000000000","message":"Done","commit_id":"2f20d92874e96a3c13279dee4ae8fab0a95a69f0"}]}