)]}'
{"specs/kuryr-integration.rst":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"80c10178938508804747278e4f951e441c76a1d5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Hongbin Lu"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Other contributors:"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Work Items"},{"line_number":159,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_448fd974","line":156,"updated":"2017-01-30 07:01:08.000000000","message":"I am interested.","commit_id":"05cd2116450cb671d36286ad62f88aa0c4b8d1fc"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"68678239cff1fd340f1c63c583260e2b0b1efceb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Hongbin Lu"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Other contributors:"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Work Items"},{"line_number":159,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a461143_0c01686a","line":156,"in_reply_to":"3a461143_448fd974","updated":"2017-01-30 16:20:32.000000000","message":"will add you there :)","commit_id":"05cd2116450cb671d36286ad62f88aa0c4b8d1fc"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b21e0196b8f1435ce4236c79cfd23994a8d5a46f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   will be similar as create."},{"line_number":43,"context_line":"2. Support creating a container from a network. If users specify a network,"},{"line_number":44,"context_line":"   the container will be created from the network. Otherwise, the container"},{"line_number":45,"context_line":"   will be created from the default network, which can be specified by admin."},{"line_number":46,"context_line":"   On Docker, this can be implemented by adding --net\u003d\u003cID\u003e option when creating"},{"line_number":47,"context_line":"   the sandbox [4] of the container."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_438b2868","line":45,"range":{"start_line":45,"start_character":45,"end_line":45,"end_character":77},"updated":"2017-01-31 05:49:42.000000000","message":"In configuration files?","commit_id":"f3a3ccd5fea6e6158db2e35d3ea7fa1833a598c7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a3d4aff6e63a076646e8733ad8c8010dcb87a9a3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   will be similar as create."},{"line_number":43,"context_line":"2. Support creating a container from a network. If users specify a network,"},{"line_number":44,"context_line":"   the container will be created from the network. Otherwise, the container"},{"line_number":45,"context_line":"   will be created from the default network, which can be specified by admin."},{"line_number":46,"context_line":"   On Docker, this can be implemented by adding --net\u003d\u003cID\u003e option when creating"},{"line_number":47,"context_line":"   the sandbox [4] of the container."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_898faecb","line":45,"range":{"start_line":45,"start_character":45,"end_line":45,"end_character":77},"in_reply_to":"3a461143_438b2868","updated":"2017-02-01 16:31:00.000000000","message":"Yes, that is my original thoughts, but I will revisit if this is a good idea.","commit_id":"f3a3ccd5fea6e6158db2e35d3ea7fa1833a598c7"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b21e0196b8f1435ce4236c79cfd23994a8d5a46f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"---------------"},{"line_number":112,"context_line":"1. Add an new API endpoint /networks to the REST API interface."},{"line_number":113,"context_line":"2. In the API endpoint of creating a container, add a new option to specify"},{"line_number":114,"context_line":"   the network where the container will be created from. If the network is not"},{"line_number":115,"context_line":"   specified, Zun will use the default network."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_e3e0942b","line":115,"range":{"start_line":114,"start_character":57,"end_line":115,"end_character":47},"updated":"2017-01-31 05:49:42.000000000","message":"same default network as specified by the admin?","commit_id":"f3a3ccd5fea6e6158db2e35d3ea7fa1833a598c7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a3d4aff6e63a076646e8733ad8c8010dcb87a9a3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"---------------"},{"line_number":112,"context_line":"1. Add an new API endpoint /networks to the REST API interface."},{"line_number":113,"context_line":"2. In the API endpoint of creating a container, add a new option to specify"},{"line_number":114,"context_line":"   the network where the container will be created from. If the network is not"},{"line_number":115,"context_line":"   specified, Zun will use the default network."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a461143_69a9a224","line":115,"range":{"start_line":114,"start_character":57,"end_line":115,"end_character":47},"in_reply_to":"3a461143_e3e0942b","updated":"2017-02-01 16:31:00.000000000","message":"Yes, this might break the multi-tenancy model. I will re-think the idea.","commit_id":"f3a3ccd5fea6e6158db2e35d3ea7fa1833a598c7"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"ad694907294ffcda044c5ba9b834ff3dfb9597cd","unresolved":false,"context_lines":[{"line_number":166,"context_line":"----------"},{"line_number":167,"context_line":"1. Implement a new API endpoint for networks."},{"line_number":168,"context_line":"2. Extend the Docker driver to support creating containers from a network."},{"line_number":169,"context_line":"3. Implement unit/integration test."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_5e5e4877","line":169,"updated":"2017-02-02 00:45:21.000000000","message":"You have to write neutron driver to use network functionality which neutron provides.","commit_id":"ab14f7c046e3ec0c9742b0864f0105cb958d4126"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"afde095a02f5a98767080b01aa9db6bfc0264e8f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"----------"},{"line_number":167,"context_line":"1. Implement a new API endpoint for networks."},{"line_number":168,"context_line":"2. Extend the Docker driver to support creating containers from a network."},{"line_number":169,"context_line":"3. Implement unit/integration test."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_0bd55e42","line":169,"in_reply_to":"3a461143_5e5e4877","updated":"2017-02-03 16:31:21.000000000","message":"It seems we don\u0027t have plan to support something other than Neutron, so wrap it as a driver seems unnecessary.","commit_id":"ab14f7c046e3ec0c9742b0864f0105cb958d4126"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"ad694907294ffcda044c5ba9b834ff3dfb9597cd","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Dependencies"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":"Add a dependency to Kuryr-libnetwork"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_1ecbe01f","line":174,"updated":"2017-02-02 00:45:21.000000000","message":"Please add Neutron to the dependency.","commit_id":"ab14f7c046e3ec0c9742b0864f0105cb958d4126"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"afde095a02f5a98767080b01aa9db6bfc0264e8f","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Dependencies"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":"Add a dependency to Kuryr-libnetwork"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_4bcf66b0","line":174,"in_reply_to":"3a461143_1ecbe01f","updated":"2017-02-03 16:31:21.000000000","message":"Done","commit_id":"ab14f7c046e3ec0c9742b0864f0105cb958d4126"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"a3c757854767441b1c6f876c67e9563cdf952cd8","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"       $ neutron subnet-create --subnetpool testpool test 10.2.0.0/24"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"4. Users calls Zun APIs to create a container network."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"       POST /v1/networks"},{"line_number":69,"context_line":"       {"},{"line_number":70,"context_line":"           \u0027name\u0027: \u0027foo\u0027,"},{"line_number":71,"context_line":"           \u0027neutron_net\u0027: \u0027test\u0027,"},{"line_number":72,"context_line":"           \u0027neutron_pool\u0027: \u0027testpool\u0027,"},{"line_number":73,"context_line":"           \u0027neutron_subnet\u0027: \u0027test\u0027,"},{"line_number":74,"context_line":"           ..."},{"line_number":75,"context_line":"       }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"5. Zun calls Docker APIs to create a Docker network. This is equivalent to:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_b8d814f1","line":75,"range":{"start_line":66,"start_character":0,"end_line":75,"end_character":8},"updated":"2017-02-03 20:01:23.000000000","message":"Is this step mandatory? I think internally, step 4 and 5 can be triggered by step 6. By saying that, a user never explicitly create a container network. A user will only use the existing neutron network. Is my understanding correct?","commit_id":"4f002bfb0e46dcbb1001f7c24e5f3d9aec6046ed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"cfb7c2e2e0295f19d0d2363017e978b6c1710cb7","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"       $ neutron subnet-create --subnetpool testpool test 10.2.0.0/24"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"4. Users calls Zun APIs to create a container network."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"       POST /v1/networks"},{"line_number":69,"context_line":"       {"},{"line_number":70,"context_line":"           \u0027name\u0027: \u0027foo\u0027,"},{"line_number":71,"context_line":"           \u0027neutron_net\u0027: \u0027test\u0027,"},{"line_number":72,"context_line":"           \u0027neutron_pool\u0027: \u0027testpool\u0027,"},{"line_number":73,"context_line":"           \u0027neutron_subnet\u0027: \u0027test\u0027,"},{"line_number":74,"context_line":"           ..."},{"line_number":75,"context_line":"       }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"5. Zun calls Docker APIs to create a Docker network. This is equivalent to:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_e75599c6","line":75,"range":{"start_line":66,"start_character":0,"end_line":75,"end_character":8},"in_reply_to":"1a430d35_b8d814f1","updated":"2017-02-03 22:26:02.000000000","message":"Yes, from the users experience point of view, it might be better to make this step optional. The implementation might be similar to \u0027give me a network\u0027 feature in Nova. I would rather leave this to a follow-up BP, since the implementation doesn\u0027t seem to be trivial.","commit_id":"4f002bfb0e46dcbb1001f7c24e5f3d9aec6046ed"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"2f5dfbe3ecebefa3a22379aa8ad61dc8ae60b079","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"       $ docker run --net\u003dfoo kubernetes/pause --name sandbox"},{"line_number":93,"context_line":"       $ docker run --net\u003dcontainer:sandbox nginx"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"NOTE: It is assumed that the Neutron resources are pre-created by users at"},{"line_number":96,"context_line":"their tenants (as shown at step 1-3). That is for walking around the limitation"},{"line_number":97,"context_line":"that Kuryr can only create resources at single tenant."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_b6a57805","line":94,"updated":"2017-02-04 09:05:27.000000000","message":"hongbin, I get how the workflow works, but could you please describe it from the user\u0027s view for step 5 and step 7, it\u0027s will be better for user to understand what he/she should do if using zun/openstack ecosystem.\n\nseems that we need to provide more CLIs like:\n\nzun network list\nzun network create/delete etc\n\nso if yes, please describe them in the workflow.\n\nEli.","commit_id":"4f002bfb0e46dcbb1001f7c24e5f3d9aec6046ed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9dccb0f6020a5d01d4282041cf185deda04a631d","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"       $ docker run --net\u003dfoo kubernetes/pause --name sandbox"},{"line_number":93,"context_line":"       $ docker run --net\u003dcontainer:sandbox nginx"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"NOTE: It is assumed that the Neutron resources are pre-created by users at"},{"line_number":96,"context_line":"their tenants (as shown at step 1-3). That is for walking around the limitation"},{"line_number":97,"context_line":"that Kuryr can only create resources at single tenant."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_13d8de1c","line":94,"in_reply_to":"1a430d35_b6a57805","updated":"2017-02-06 22:11:59.000000000","message":"Done","commit_id":"4f002bfb0e46dcbb1001f7c24e5f3d9aec6046ed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"26671c546df49d7a99deeafe1d58ffba85d63cb5","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"       $ docker run --net\u003dfoo kubernetes/pause --name sandbox"},{"line_number":93,"context_line":"       $ docker run --net\u003dcontainer:sandbox nginx"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"NOTE: It is assumed that the Neutron resources are pre-created by users at"},{"line_number":96,"context_line":"their tenants (as shown at step 1-3). That is for walking around the limitation"},{"line_number":97,"context_line":"that Kuryr can only create resources at single tenant."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_6d189e85","line":94,"in_reply_to":"1a430d35_b6a57805","updated":"2017-02-04 16:12:43.000000000","message":"Thanks for the advice Eli. Will address them in the next patchset.","commit_id":"4f002bfb0e46dcbb1001f7c24e5f3d9aec6046ed"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3a8b0348b8b65d794106f1b6ac837a9a3cf54ede","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   example, some drivers might choose to create the container from a default"},{"line_number":47,"context_line":"   network that might be specified in a config file or hard-coded. It is up to"},{"line_number":48,"context_line":"   individual driver to decide how to create a container from a network."},{"line_number":49,"context_line":"   On Docker, this can be implemented by adding --net\u003d\u003cID\u003e option when creating"},{"line_number":50,"context_line":"   the sandbox [4] of the container."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"The typical workflow will be as following:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_b21a126d","line":49,"range":{"start_line":49,"start_character":3,"end_line":49,"end_character":12},"updated":"2017-02-10 08:18:19.000000000","message":"I think you meant Zun here.","commit_id":"78f5e7ce296a93b4365dc1e9983d49c0d125e871"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2925dd2413d229cb2f70f359ced6becc1b9e7180","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   example, some drivers might choose to create the container from a default"},{"line_number":47,"context_line":"   network that might be specified in a config file or hard-coded. It is up to"},{"line_number":48,"context_line":"   individual driver to decide how to create a container from a network."},{"line_number":49,"context_line":"   On Docker, this can be implemented by adding --net\u003d\u003cID\u003e option when creating"},{"line_number":50,"context_line":"   the sandbox [4] of the container."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"The typical workflow will be as following:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_fb09a632","line":49,"range":{"start_line":49,"start_character":3,"end_line":49,"end_character":12},"in_reply_to":"fa31d9ce_b21a126d","updated":"2017-02-10 22:25:50.000000000","message":"Done","commit_id":"78f5e7ce296a93b4365dc1e9983d49c0d125e871"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3a8b0348b8b65d794106f1b6ac837a9a3cf54ede","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":"Add a \u0027network\u0027 table. Add a foreign key \u0027network_id\u0027 to the existing table"},{"line_number":127,"context_line":"\u0027container\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_d2e86619","line":126,"range":{"start_line":126,"start_character":42,"end_line":126,"end_character":52},"updated":"2017-02-10 08:18:19.000000000","message":"This would be \u0027None\u0027 in case of containers created by Nova-Docker driver or what?","commit_id":"78f5e7ce296a93b4365dc1e9983d49c0d125e871"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2925dd2413d229cb2f70f359ced6becc1b9e7180","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":"Add a \u0027network\u0027 table. Add a foreign key \u0027network_id\u0027 to the existing table"},{"line_number":127,"context_line":"\u0027container\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_1e91089a","line":126,"range":{"start_line":126,"start_character":42,"end_line":126,"end_character":52},"in_reply_to":"fa31d9ce_d2e86619","updated":"2017-02-10 22:25:50.000000000","message":"Yes, it will be \u0027None\u0027 in nova-docker driver. A potential future work is to add support for \u0027network_id\u0027 in that driver as well. This will make all drivers hard-depend on Kuryr, which I am not sure if it is a good idea for now, but we can discuss it later.","commit_id":"78f5e7ce296a93b4365dc1e9983d49c0d125e871"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3a8b0348b8b65d794106f1b6ac837a9a3cf54ede","unresolved":false,"context_lines":[{"line_number":184,"context_line":"1. Implement a new API endpoint for networks."},{"line_number":185,"context_line":"2. Extend the Docker driver to support creating containers from a network."},{"line_number":186,"context_line":"3. Implement unit/integration test."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Dependencies"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_b2e4d23b","line":187,"updated":"2017-02-10 08:18:19.000000000","message":"Work item will include documentation on new network API also.","commit_id":"78f5e7ce296a93b4365dc1e9983d49c0d125e871"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2925dd2413d229cb2f70f359ced6becc1b9e7180","unresolved":false,"context_lines":[{"line_number":184,"context_line":"1. Implement a new API endpoint for networks."},{"line_number":185,"context_line":"2. Extend the Docker driver to support creating containers from a network."},{"line_number":186,"context_line":"3. Implement unit/integration test."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Dependencies"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa31d9ce_3e8ecc78","line":187,"in_reply_to":"fa31d9ce_b2e4d23b","updated":"2017-02-10 22:25:50.000000000","message":"Done","commit_id":"78f5e7ce296a93b4365dc1e9983d49c0d125e871"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"5f947effb9bb86e39d20e70bc1ba34bdb8720bd0","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"       $ neutron net-create test"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"2. Users calls Neutron APIs to create a Neutron subnetpool."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"       $ neutron subnetpool-create --pool-prefix 10.2.0.0/16 testpool"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_ea29ae8a","line":58,"updated":"2017-02-13 06:04:09.000000000","message":"Users call - applicable below as well.","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f7542c6373abdb54b0bc2497f1c3d9216b243e42","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"       $ neutron net-create test"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"2. Users calls Neutron APIs to create a Neutron subnetpool."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"       $ neutron subnetpool-create --pool-prefix 10.2.0.0/16 testpool"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_644a8d29","line":58,"in_reply_to":"fa31d9ce_ea29ae8a","updated":"2017-02-16 20:02:16.000000000","message":"Done","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"5f947effb9bb86e39d20e70bc1ba34bdb8720bd0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                            --neutron-subnet testsubnet \\"},{"line_number":73,"context_line":"                            foo"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"5. Zun calls Docker APIs to create a Docker network. This is equivalent to:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"       $ docker network create -d kuryr --ipam-driver\u003dkuryr \\"},{"line_number":78,"context_line":"             --subnet 10.2.0.0/24 --gateway 10.2.0.1 \\"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_ea852e59","line":75,"updated":"2017-02-13 06:04:09.000000000","message":"Assuming this step something done under the hood, there can be a mention about the same. Meaning, the user isn\u0027t really executing step 5, it\u0027s getting executed by zun internally.","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f7542c6373abdb54b0bc2497f1c3d9216b243e42","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                            --neutron-subnet testsubnet \\"},{"line_number":73,"context_line":"                            foo"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"5. Zun calls Docker APIs to create a Docker network. This is equivalent to:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"       $ docker network create -d kuryr --ipam-driver\u003dkuryr \\"},{"line_number":78,"context_line":"             --subnet 10.2.0.0/24 --gateway 10.2.0.1 \\"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_c45179da","line":75,"in_reply_to":"fa31d9ce_ea852e59","updated":"2017-02-16 20:02:16.000000000","message":"Done","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"5f947effb9bb86e39d20e70bc1ba34bdb8720bd0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"NOTE: In this step, docker engine will check the list of registered network"},{"line_number":84,"context_line":"plugin and find the API endpoint of Kuryr, then make a call to Kuryr to create"},{"line_number":85,"context_line":"a network with existing Neutron resources (i.e. test, testpool, etc.)."},{"line_number":86,"context_line":"It is assumed that the Neutron resources are pre-created by users at"},{"line_number":87,"context_line":"their tenants (as shown at step 1-3). That is for walking around the limitation"},{"line_number":88,"context_line":"that Kuryr can only create resources at single tenant."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_4ade3a6e","line":86,"updated":"2017-02-13 06:04:09.000000000","message":"Will there be a potential conflict if the test/testpool resources are created for a different tenant (via neutron) but the zun network-create specifies those resources for another tenant?","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f7542c6373abdb54b0bc2497f1c3d9216b243e42","unresolved":false,"context_lines":[{"line_number":83,"context_line":"NOTE: In this step, docker engine will check the list of registered network"},{"line_number":84,"context_line":"plugin and find the API endpoint of Kuryr, then make a call to Kuryr to create"},{"line_number":85,"context_line":"a network with existing Neutron resources (i.e. test, testpool, etc.)."},{"line_number":86,"context_line":"It is assumed that the Neutron resources are pre-created by users at"},{"line_number":87,"context_line":"their tenants (as shown at step 1-3). That is for walking around the limitation"},{"line_number":88,"context_line":"that Kuryr can only create resources at single tenant."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_4413c90d","line":86,"in_reply_to":"fa31d9ce_4ade3a6e","updated":"2017-02-16 20:02:16.000000000","message":"Good point. Changed it to uuid (instead of name) to avoid name conflict.","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"5f947effb9bb86e39d20e70bc1ba34bdb8720bd0","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":"Add a \u0027network\u0027 table. Add a foreign key \u0027network_id\u0027 to the existing table"},{"line_number":127,"context_line":"\u0027container\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_ead36e5d","line":126,"updated":"2017-02-13 06:04:09.000000000","message":"How about adding the project_id field along side this?\nThat would help you distinguish various tenants and may potentially resolve a conflict case as stated above?","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"de97d65f4941b135aa15e3bb5543837456088bdf","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":"Add a \u0027network\u0027 table. Add a foreign key \u0027network_id\u0027 to the existing table"},{"line_number":127,"context_line":"\u0027container\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_30ff85ab","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":75},"updated":"2017-02-14 03:17:26.000000000","message":"It is not clear to me if the data model support multiple networks for one container. A container must able to connect to multiple networks.","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f7542c6373abdb54b0bc2497f1c3d9216b243e42","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":"Add a \u0027network\u0027 table. Add a foreign key \u0027network_id\u0027 to the existing table"},{"line_number":127,"context_line":"\u0027container\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_641fed09","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":75},"in_reply_to":"fa31d9ce_30ff85ab","updated":"2017-02-16 20:02:16.000000000","message":"Good point. Split this table into two: \u0027network\u0027 and \u0027network_attachment\u0027. This should be able to model a container connecting to multiple networks.","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f7542c6373abdb54b0bc2497f1c3d9216b243e42","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":"Add a \u0027network\u0027 table. Add a foreign key \u0027network_id\u0027 to the existing table"},{"line_number":127,"context_line":"\u0027container\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_64f8cdc5","line":126,"in_reply_to":"fa31d9ce_ead36e5d","updated":"2017-02-16 20:02:16.000000000","message":"Done","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"5f947effb9bb86e39d20e70bc1ba34bdb8720bd0","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"REST API impact"},{"line_number":131,"context_line":"---------------"},{"line_number":132,"context_line":"1. Add an new API endpoint /networks to the REST API interface."},{"line_number":133,"context_line":"2. In the API endpoint of creating a container, add a new option to specify"},{"line_number":134,"context_line":"   the network where the container will be created from."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_ea9e0eb7","line":132,"updated":"2017-02-13 06:04:09.000000000","message":"Add a.","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f7542c6373abdb54b0bc2497f1c3d9216b243e42","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"REST API impact"},{"line_number":131,"context_line":"---------------"},{"line_number":132,"context_line":"1. Add an new API endpoint /networks to the REST API interface."},{"line_number":133,"context_line":"2. In the API endpoint of creating a container, add a new option to specify"},{"line_number":134,"context_line":"   the network where the container will be created from."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa31d9ce_a419e524","line":132,"in_reply_to":"fa31d9ce_ea9e0eb7","updated":"2017-02-16 20:02:16.000000000","message":"Done","commit_id":"8676b3ef68b4435e4a9deec09d44e67fb0ef77ea"}]}