)]}'
{"zun/container/os_capability/linux/os_capability_linux.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"42dbb79fc22c10ca0da0042d6dcc1c33c4a30bea","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def get_cpu_numa_info(self):"},{"line_number":31,"context_line":"        # TODO(sbiswas7): rootwrap changes for zun required."},{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            output \u003d subprocess.check_output([\u0027lscpu\u0027, \"-p\u003dsocket,cpu,online\"])"},{"line_number":34,"context_line":"        except Exception as e:"},{"line_number":35,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu: %s\"),"},{"line_number":36,"context_line":"                          six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_135dd514","line":33,"range":{"start_line":33,"start_character":70,"end_line":33,"end_character":76},"updated":"2017-02-08 21:20:21.000000000","message":"In my machine, I cannot get the online colume:\n\n  $ lscpu -p\u003dsocket,cpu,online\n  lscpu: unknown column: online","commit_id":"bcfca1b16702eb6818c7c24e3818d30c31fa66aa"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"5673c5df6bf27562254a542cecc0eb2d0354cd04","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def get_cpu_numa_info(self):"},{"line_number":31,"context_line":"        # TODO(sbiswas7): rootwrap changes for zun required."},{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            output \u003d subprocess.check_output([\u0027lscpu\u0027, \"-p\u003dsocket,cpu,online\"])"},{"line_number":34,"context_line":"        except Exception as e:"},{"line_number":35,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu: %s\"),"},{"line_number":36,"context_line":"                          six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_2fb6d3f8","line":33,"range":{"start_line":33,"start_character":70,"end_line":33,"end_character":76},"in_reply_to":"1a430d35_135dd514","updated":"2017-02-09 08:56:39.000000000","message":"I guess you are using Ubuntu 14.04? \nI tried this on Ubuntu 16.04, RHEL 7.2 - none of them had the issue.\nSo i think your lscpu is an older binary given the new code does have the online column:\n\nhttps://github.com/mmalecki/util-linux/blob/master/sys-utils/lscpu.c#L273\n\nHowever, I have put in a fix in the next patch to handle this condition.","commit_id":"bcfca1b16702eb6818c7c24e3818d30c31fa66aa"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e1e39da7fbaa22fd5c03ce0c02339db4ef30609c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def get_cpu_numa_info(self):"},{"line_number":31,"context_line":"        # TODO(sbiswas7): rootwrap changes for zun required."},{"line_number":32,"context_line":"        try:"},{"line_number":33,"context_line":"            output \u003d subprocess.check_output([\u0027lscpu\u0027, \"-p\u003dsocket,cpu,online\"])"},{"line_number":34,"context_line":"        except Exception as e:"},{"line_number":35,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu: %s\"),"},{"line_number":36,"context_line":"                          six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_94a6e551","line":33,"range":{"start_line":33,"start_character":70,"end_line":33,"end_character":76},"in_reply_to":"1a430d35_2fb6d3f8","updated":"2017-02-09 17:07:13.000000000","message":"Yes, I am using Ubuntu 14.04","commit_id":"bcfca1b16702eb6818c7c24e3818d30c31fa66aa"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ddfec1d9a2a75a6d89317c0bf8d2439757ae4c39","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # TODO(sbiswas7): rootwrap changes for zun required."},{"line_number":33,"context_line":"        old_lscpu \u003d False"},{"line_number":34,"context_line":"        try:"},{"line_number":35,"context_line":"            output \u003d subprocess.check_output([\u0027lscpu\u0027, \"-p\u003dsocket,cpu,online\"])"},{"line_number":36,"context_line":"        except Exception as e:"},{"line_number":37,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu \""},{"line_number":38,"context_line":"                          \"p\u003dsocket,cpu,online : %s\"), six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_f4cf2927","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":31},"updated":"2017-02-09 17:06:48.000000000","message":"Sorry, I didn\u0027t catch this in the previous review. Perhaps, it is better to leverage processutils.execute() at Oslo (https://docs.openstack.org/developer/oslo.concurrency/api/processutils.html#oslo_concurrency.processutils.execute) ? I am not sure exactly what is the benefits of using processutils, but it seems openstack projects are all using it.","commit_id":"4db7b6970a18c10d714aec6514b72cb320cfe86b"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"4ac1eacf5e8cc96c61d41a78735bcb6622f0db00","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # TODO(sbiswas7): rootwrap changes for zun required."},{"line_number":33,"context_line":"        old_lscpu \u003d False"},{"line_number":34,"context_line":"        try:"},{"line_number":35,"context_line":"            output \u003d subprocess.check_output([\u0027lscpu\u0027, \"-p\u003dsocket,cpu,online\"])"},{"line_number":36,"context_line":"        except Exception as e:"},{"line_number":37,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu \""},{"line_number":38,"context_line":"                          \"p\u003dsocket,cpu,online : %s\"), six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_a52c95ac","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":31},"in_reply_to":"1a430d35_f4cf2927","updated":"2017-02-10 04:03:42.000000000","message":"Thanks for pointing that out. \nI have changed it as per.","commit_id":"4db7b6970a18c10d714aec6514b72cb320cfe86b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"9eb963f902c28668dd780cdb83149a832308a59a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        old_lscpu \u003d False"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            output \u003d processutils.execute(\u0027lscpu\u0027, \u0027-p\u003dsocket,cpu,online\u0027)"},{"line_number":37,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":38,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu \""},{"line_number":39,"context_line":"                          \"p\u003dsocket,cpu,online : %s\"), six.text_type(e))"},{"line_number":40,"context_line":"            # There is a possibility that an older version of lscpu is used"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_5e72c77d","line":37,"updated":"2017-02-10 06:43:01.000000000","message":"We need to set old_lscpu here also in case the command is successful with online column.","commit_id":"c1c995d6b415a5a04b4bae0738296f235e1a7a2b"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"941994e13873f3e50f479d3792fc91f02111d288","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        old_lscpu \u003d False"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            output \u003d processutils.execute(\u0027lscpu\u0027, \u0027-p\u003dsocket,cpu,online\u0027)"},{"line_number":37,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":38,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu \""},{"line_number":39,"context_line":"                          \"p\u003dsocket,cpu,online : %s\"), six.text_type(e))"},{"line_number":40,"context_line":"            # There is a possibility that an older version of lscpu is used"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_b2c5b25c","line":37,"in_reply_to":"fa31d9ce_5e72c77d","updated":"2017-02-10 08:25:51.000000000","message":"If we set the old_lscpu command to true, at line 49 - the check would result into a wrong regex.","commit_id":"c1c995d6b415a5a04b4bae0738296f235e1a7a2b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"9eb963f902c28668dd780cdb83149a832308a59a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            output \u003d processutils.execute(\u0027lscpu\u0027, \u0027-p\u003dsocket,cpu,online\u0027)"},{"line_number":37,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":38,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu \""},{"line_number":39,"context_line":"                          \"p\u003dsocket,cpu,online : %s\"), six.text_type(e))"},{"line_number":40,"context_line":"            # There is a possibility that an older version of lscpu is used"},{"line_number":41,"context_line":"            # So let\u0027s try without the online column"},{"line_number":42,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_feed3b26","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":28},"updated":"2017-02-10 06:43:01.000000000","message":"- is missing","commit_id":"c1c995d6b415a5a04b4bae0738296f235e1a7a2b"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"941994e13873f3e50f479d3792fc91f02111d288","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            output \u003d processutils.execute(\u0027lscpu\u0027, \u0027-p\u003dsocket,cpu,online\u0027)"},{"line_number":37,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":38,"context_line":"            LOG.exception(_LE(\"There was a problem while executing lscpu \""},{"line_number":39,"context_line":"                          \"p\u003dsocket,cpu,online : %s\"), six.text_type(e))"},{"line_number":40,"context_line":"            # There is a possibility that an older version of lscpu is used"},{"line_number":41,"context_line":"            # So let\u0027s try without the online column"},{"line_number":42,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_d2a066a8","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":28},"in_reply_to":"fa31d9ce_feed3b26","updated":"2017-02-10 08:25:51.000000000","message":"Great catch.","commit_id":"c1c995d6b415a5a04b4bae0738296f235e1a7a2b"}]}