)]}'
{"zun/db/api.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e2c30b2ddeb325a9a94269d5f02f204468fa1614","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    return _get_dbdriver_instance().get_image_by_uuid(context, image_uuid)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def list_resource_provider(context, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":273,"context_line":"                           sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":274,"context_line":"    \"\"\"Get matching resource providers."},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_3b96ba4c","line":272,"updated":"2017-02-13 08:19:35.000000000","message":"list_resource_providers is probably a good verb to use.","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab852f2c80597ac1955ba2e589b477499dcb5802","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    return _get_dbdriver_instance().get_image_by_uuid(context, image_uuid)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def list_resource_provider(context, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":273,"context_line":"                           sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":274,"context_line":"    \"\"\"Get matching resource providers."},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_df6e5595","line":272,"in_reply_to":"fa31d9ce_3b96ba4c","updated":"2017-02-13 15:08:26.000000000","message":"The convention is: list_container, list_image, etc. Therefore, I named it as list_resource_provider to follow the style.\n\nHowever, I can create a bug ticket to change them all from list_XXX to list_XXXs. What do you think?","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"}],"zun/db/sqlalchemy/alembic/versions/6fd4f7582eb0_add_resource_provider_table.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e2c30b2ddeb325a9a94269d5f02f204468fa1614","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027uuid\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":38,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":39,"context_line":"        sa.Column(\u0027root_provider\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":40,"context_line":"        sa.Column(\u0027parent_provider\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":41,"context_line":"        sa.Column(\u0027can_host\u0027, sa.Integer(), default\u003d0),"},{"line_number":42,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_fb126261","line":39,"updated":"2017-02-13 08:19:35.000000000","message":"Root provider should be NULL. (?)","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab852f2c80597ac1955ba2e589b477499dcb5802","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":37,"context_line":"        sa.Column(\u0027uuid\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":38,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":39,"context_line":"        sa.Column(\u0027root_provider\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":40,"context_line":"        sa.Column(\u0027parent_provider\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":41,"context_line":"        sa.Column(\u0027can_host\u0027, sa.Integer(), default\u003d0),"},{"line_number":42,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_42d4481f","line":39,"in_reply_to":"fa31d9ce_fb126261","updated":"2017-02-13 15:08:26.000000000","message":"Done","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"}],"zun/db/sqlalchemy/api.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e2c30b2ddeb325a9a94269d5f02f204468fa1614","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    resource_provider\u003dprovider_id)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def update_resource_provider(self, context, provider_id, values):"},{"line_number":441,"context_line":"        # NOTE(dtantsur): this can lead to very strange errors"},{"line_number":442,"context_line":"        if \u0027uuid\u0027 in values:"},{"line_number":443,"context_line":"            msg \u003d _(\"Cannot overwrite UUID for an existing ResourceProvider.\")"},{"line_number":444,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_6a477e1d","line":441,"updated":"2017-02-13 08:19:35.000000000","message":"This can be removed.","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab852f2c80597ac1955ba2e589b477499dcb5802","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    resource_provider\u003dprovider_id)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def update_resource_provider(self, context, provider_id, values):"},{"line_number":441,"context_line":"        # NOTE(dtantsur): this can lead to very strange errors"},{"line_number":442,"context_line":"        if \u0027uuid\u0027 in values:"},{"line_number":443,"context_line":"            msg \u003d _(\"Cannot overwrite UUID for an existing ResourceProvider.\")"},{"line_number":444,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_62d78c23","line":441,"in_reply_to":"fa31d9ce_6a477e1d","updated":"2017-02-13 15:08:26.000000000","message":"Done","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"}],"zun/db/sqlalchemy/models.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e2c30b2ddeb325a9a94269d5f02f204468fa1614","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        schema.UniqueConstraint(\u0027uuid\u0027, name\u003d\u0027uniq_resource_provider0uuid\u0027),"},{"line_number":180,"context_line":"        table_args()"},{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_5b5a8e51","line":182,"updated":"2017-02-13 08:19:35.000000000","message":"This can\u0027t be NULL.","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab852f2c80597ac1955ba2e589b477499dcb5802","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        schema.UniqueConstraint(\u0027uuid\u0027, name\u003d\u0027uniq_resource_provider0uuid\u0027),"},{"line_number":180,"context_line":"        table_args()"},{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_c2e838e5","line":182,"in_reply_to":"fa31d9ce_5b5a8e51","updated":"2017-02-13 15:08:26.000000000","message":"Done. Primary key cannot be null by default, but I added nullable\u003dFalse for clarity.","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e2c30b2ddeb325a9a94269d5f02f204468fa1614","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"},{"line_number":186,"context_line":"    parent_provider \u003d Column(String(36))"},{"line_number":187,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_9ba6c651","line":184,"updated":"2017-02-13 08:19:35.000000000","message":"This also can be NULL.","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab852f2c80597ac1955ba2e589b477499dcb5802","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"},{"line_number":186,"context_line":"    parent_provider \u003d Column(String(36))"},{"line_number":187,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_c2cf587d","line":184,"in_reply_to":"fa31d9ce_9ba6c651","updated":"2017-02-13 15:08:26.000000000","message":"You mean this also cannot be null? Done.","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e2c30b2ddeb325a9a94269d5f02f204468fa1614","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"},{"line_number":186,"context_line":"    parent_provider \u003d Column(String(36))"},{"line_number":187,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_db7cbeed","line":185,"updated":"2017-02-13 08:19:35.000000000","message":"This should be a UUID field - containing the UUID of the root_resource provider","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab852f2c80597ac1955ba2e589b477499dcb5802","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"},{"line_number":186,"context_line":"    parent_provider \u003d Column(String(36))"},{"line_number":187,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_a2afc492","line":185,"in_reply_to":"fa31d9ce_db7cbeed","updated":"2017-02-13 15:08:26.000000000","message":"Done","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e2c30b2ddeb325a9a94269d5f02f204468fa1614","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"},{"line_number":186,"context_line":"    parent_provider \u003d Column(String(36))"},{"line_number":187,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_9b4a46ab","line":186,"updated":"2017-02-13 08:19:35.000000000","message":"Same as above. This can be null too.","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ab852f2c80597ac1955ba2e589b477499dcb5802","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":184,"context_line":"    name \u003d Column(String(255))"},{"line_number":185,"context_line":"    root_provider \u003d Column(String(36))"},{"line_number":186,"context_line":"    parent_provider \u003d Column(String(36))"},{"line_number":187,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_c296784b","line":186,"in_reply_to":"fa31d9ce_9b4a46ab","updated":"2017-02-13 15:08:26.000000000","message":"Done","commit_id":"a12dc809c5ac0d06e15db1a2a7271c21b2096eb4"}]}
