)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c68d80ec7c407e731dc02dcb2065c74eebad9de8","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        # container create will fail with 400 status."},{"line_number":233,"context_line":"        images \u003d compute_api.image_search(context, new_container, True)"},{"line_number":234,"context_line":"        if not images:"},{"line_number":235,"context_line":"            raise exception.ImageNotFound(image\u003dnew_container.image)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        if run:"},{"line_number":238,"context_line":"            compute_api.container_run(context, new_container)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_a1e08dfb","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":17},"updated":"2017-02-14 00:15:49.000000000","message":"It seems it is better to clean up the container object created at line #226 if this exception is raised.","commit_id":"e6a94780a3b0352195c3ea3a584baadc61763c7d"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"a09138078435b81b2b211c79345dc2e88620b9e1","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        # container create will fail with 400 status."},{"line_number":233,"context_line":"        images \u003d compute_api.image_search(context, new_container, True)"},{"line_number":234,"context_line":"        if not images:"},{"line_number":235,"context_line":"            raise exception.ImageNotFound(image\u003dnew_container.image)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        if run:"},{"line_number":238,"context_line":"            compute_api.container_run(context, new_container)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_593ad837","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":17},"in_reply_to":"fa31d9ce_a1e08dfb","updated":"2017-02-20 08:24:24.000000000","message":"+1","commit_id":"e6a94780a3b0352195c3ea3a584baadc61763c7d"}],"zun/compute/api.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"a09138078435b81b2b211c79345dc2e88620b9e1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            dests \u003d self.scheduler_client.select_destinations("},{"line_number":32,"context_line":"                context, [new_container])"},{"line_number":33,"context_line":"        except Exception as exc:"},{"line_number":34,"context_line":"            new_container.status \u003d fields.ContainerStatus.ERROR"},{"line_number":35,"context_line":"            new_container.status_reason \u003d str(exc)"},{"line_number":36,"context_line":"            new_container.save(context)"},{"line_number":37,"context_line":"            return"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        new_container.host \u003d dests[0][\u0027host\u0027]"},{"line_number":40,"context_line":"        new_container.save(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_598818e8","line":37,"range":{"start_line":33,"start_character":7,"end_line":37,"end_character":18},"updated":"2017-02-20 08:24:24.000000000","message":"Since you are handling all the exceptions, if there is no valid host  what will happen?","commit_id":"e6a94780a3b0352195c3ea3a584baadc61763c7d"}],"zun/compute/rpcapi.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"a09138078435b81b2b211c79345dc2e88620b9e1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return self._call(container.host, \u0027container_resize\u0027,"},{"line_number":92,"context_line":"                          container\u003dcontainer, height\u003dheight, width\u003dwidth)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def image_pull(self, context, container):"},{"line_number":95,"context_line":"        self._cast(container.host, \u0027image_pull\u0027, image\u003dcontainer.image)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def image_search(self, context, container, exact_match):"},{"line_number":98,"context_line":"        return self._call(container.host, \u0027image_search\u0027,"},{"line_number":99,"context_line":"                          image\u003dcontainer.image,"},{"line_number":100,"context_line":"                          image_driver_name\u003dcontainer.image_driver,"},{"line_number":101,"context_line":"                          exact_match\u003dexact_match)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_d97408ff","line":100,"range":{"start_line":94,"start_character":4,"end_line":100,"end_character":67},"updated":"2017-02-20 08:24:24.000000000","message":"you have changed the signature of these methods, they are used in image API, wouldn\u0027t that affect them?","commit_id":"e6a94780a3b0352195c3ea3a584baadc61763c7d"}]}