)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"bd4cd7a5a83c589f5a0f531074257ea6aef1def7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bin Zhou \u003clakerzhou@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-13 16:24:45 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"design specs for blueprint https://blueprints.launchpad.net/zun/+spec/container-snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I768046ba4d9e2f211af8397f59eea8a4a2b4471f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_97fca073","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":88},"updated":"2017-02-14 08:26:18.000000000","message":"Tweak the message:\nYou can refer to Hongbin\u0027s patch here;\nhttps://review.openstack.org/#/c/425883/","commit_id":"e044a8d675de93dc0d327c89bb679c74b4d8fdff"}],"specs/containter-snapshot.rst":[{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"bd4cd7a5a83c589f5a0f531074257ea6aef1def7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/zun/+spec/container-snapshot"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Zun needs to snapshot a running container, and make it available to user. "},{"line_number":15,"context_line":"Potentially, a user can restore the container from this snapshot image."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_3747744c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":74},"updated":"2017-02-14 08:26:18.000000000","message":"tweak the blank, some more in the followings","commit_id":"e044a8d675de93dc0d327c89bb679c74b4d8fdff"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"8d117c5b202b1119cdfdb9942397ee1dc1720987","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running "},{"line_number":26,"context_line":"   container instance."},{"line_number":27,"context_line":"   zun image-create \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":28,"context_line":"   # zun help image-create"},{"line_number":29,"context_line":"   usage: zun image-create \u003ccontainer\u003e \u003cname\u003e"},{"line_number":30,"context_line":"          Create a new image by taking a snapshot of a running container."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_5fc31389","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":19},"updated":"2017-02-14 13:32:50.000000000","message":"can we call it snapshot, i think that would be more meaningful. Thoughts?","commit_id":"e044a8d675de93dc0d327c89bb679c74b4d8fdff"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"0a3849c0aec57ebc6c4ebdab35c5c834d120ce7a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running "},{"line_number":26,"context_line":"   container instance."},{"line_number":27,"context_line":"   zun image-create \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":28,"context_line":"   # zun help image-create"},{"line_number":29,"context_line":"   usage: zun image-create \u003ccontainer\u003e \u003cname\u003e"},{"line_number":30,"context_line":"          Create a new image by taking a snapshot of a running container."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_7b3fc4b3","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":19},"in_reply_to":"fa31d9ce_5fc31389","updated":"2017-02-16 05:09:16.000000000","message":"The main reason to use image-create is to be consistent with NOVA. I don\u0027t think we have to be consistent with NOVA, but the command name should match well to the provided function. In term of a command of \"snapshot\", as a user, I would be looking for something like snapshot intervals, snapshot rotation policy as options of the command. While this implementation is essentially creating an image file.","commit_id":"e044a8d675de93dc0d327c89bb679c74b4d8fdff"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"8d117c5b202b1119cdfdb9942397ee1dc1720987","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running "},{"line_number":26,"context_line":"   container instance."},{"line_number":27,"context_line":"   zun image-create \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":28,"context_line":"   # zun help image-create"},{"line_number":29,"context_line":"   usage: zun image-create \u003ccontainer\u003e \u003cname\u003e"},{"line_number":30,"context_line":"          Create a new image by taking a snapshot of a running container."},{"line_number":31,"context_line":"   Positional arguments:"},{"line_number":32,"context_line":"          \u003cserver\u003e                Name or ID of container."},{"line_number":33,"context_line":"          \u003cname\u003e                  Name of snapshot."},{"line_number":34,"context_line":"2. Extend docker driver to enable “docker commit” command to create a "},{"line_number":35,"context_line":"   new image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Design Principles"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_bfd16f59","line":35,"range":{"start_line":25,"start_character":0,"end_line":35,"end_character":13},"updated":"2017-02-14 13:32:50.000000000","message":"there would be REST api change too.","commit_id":"e044a8d675de93dc0d327c89bb679c74b4d8fdff"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"0a3849c0aec57ebc6c4ebdab35c5c834d120ce7a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running "},{"line_number":26,"context_line":"   container instance."},{"line_number":27,"context_line":"   zun image-create \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":28,"context_line":"   # zun help image-create"},{"line_number":29,"context_line":"   usage: zun image-create \u003ccontainer\u003e \u003cname\u003e"},{"line_number":30,"context_line":"          Create a new image by taking a snapshot of a running container."},{"line_number":31,"context_line":"   Positional arguments:"},{"line_number":32,"context_line":"          \u003cserver\u003e                Name or ID of container."},{"line_number":33,"context_line":"          \u003cname\u003e                  Name of snapshot."},{"line_number":34,"context_line":"2. Extend docker driver to enable “docker commit” command to create a "},{"line_number":35,"context_line":"   new image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Design Principles"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_fb87345e","line":35,"range":{"start_line":25,"start_character":0,"end_line":35,"end_character":13},"in_reply_to":"fa31d9ce_bfd16f59","updated":"2017-02-16 05:09:16.000000000","message":"I will provide rest design in next patch.","commit_id":"e044a8d675de93dc0d327c89bb679c74b4d8fdff"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"bd4cd7a5a83c589f5a0f531074257ea6aef1def7","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Dependencies"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":91,"context_line":"Add a dependency to Nova"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Testing"},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_b7ae0496","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":24},"updated":"2017-02-14 08:26:18.000000000","message":"What does this mean? Could your give more explanation?","commit_id":"e044a8d675de93dc0d327c89bb679c74b4d8fdff"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f6712586512da36f7f5fc93665eb4ce512f7c0c8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun image-create \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help image-create"},{"line_number":28,"context_line":"   usage: zun image-create \u003ccontainer\u003e \u003cname\u003e"},{"line_number":29,"context_line":"          Create a new image by taking a snapshot of a running container."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa31d9ce_59b208e6","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":49},"updated":"2017-02-15 20:35:04.000000000","message":"Personally, I lean to a docker-style API:\n\n  $ zun commit \u003ccontainer-name\u003e \u003cimage-name\u003e\n\nHowever, I don\u0027t want to dominate the decision by my personal preference. Let\u0027s see what are the opinions from others.","commit_id":"34117c8e6fdb132ad16775636f9edbf88bb7eda3"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"61b73cd7cd6837c09c4083ab85706025751c02a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun image-create \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help image-create"},{"line_number":28,"context_line":"   usage: zun image-create \u003ccontainer\u003e \u003cname\u003e"},{"line_number":29,"context_line":"          Create a new image by taking a snapshot of a running container."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa31d9ce_29d414ea","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":49},"in_reply_to":"fa31d9ce_59b208e6","updated":"2017-02-16 05:08:06.000000000","message":"I think the new API should either follow NOVA or Docker. \"commit\" sounds good to me.","commit_id":"34117c8e6fdb132ad16775636f9edbf88bb7eda3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f6712586512da36f7f5fc93665eb4ce512f7c0c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"          \u003cserver\u003e                Name or ID of container."},{"line_number":32,"context_line":"          \u003cname\u003e                  Name of snapshot."},{"line_number":33,"context_line":"2. Extend docker driver to enable “docker commit” command to create a"},{"line_number":34,"context_line":"   new image."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Design Principles"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa31d9ce_d94358ad","line":34,"range":{"start_line":34,"start_character":3,"end_line":34,"end_character":12},"updated":"2017-02-15 20:35:04.000000000","message":"It seems docker commit will create a docker image in local host. However, we need to find out a way to extend it to multi-host scenario (i.e. how to deliver snapshot image from one host to another). I suggest to add a third step, which is for uploading the committed docker image to glance (in tarball format) or Docker Hub (this requires cloud admins to write down his/her docker hub account into config file). What do you think?","commit_id":"34117c8e6fdb132ad16775636f9edbf88bb7eda3"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"61b73cd7cd6837c09c4083ab85706025751c02a1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"          \u003cserver\u003e                Name or ID of container."},{"line_number":32,"context_line":"          \u003cname\u003e                  Name of snapshot."},{"line_number":33,"context_line":"2. Extend docker driver to enable “docker commit” command to create a"},{"line_number":34,"context_line":"   new image."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Design Principles"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa31d9ce_891a60c4","line":34,"range":{"start_line":34,"start_character":3,"end_line":34,"end_character":12},"in_reply_to":"fa31d9ce_d94358ad","updated":"2017-02-16 05:08:06.000000000","message":"thanks for the comments. I was trying to find if we have this kind of use case already, e.g. upload image to glance. I am not familiar with the docker hub option, but I will add both options to design. Hope others can advise the best solution.","commit_id":"34117c8e6fdb132ad16775636f9edbf88bb7eda3"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"32b7fb39cdf3c9bd230c5eae1103dba9250e541a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Proposed change"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun commit \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help commit"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_a36471e5","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":22},"updated":"2017-02-17 02:11:55.000000000","message":"Command","commit_id":"30d491ea49a887fc63159af141ce32df5694e44f"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"eb30027456d7400441f9d5d8c248caad48c35b41","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Proposed change"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun commit \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help commit"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_a622bfff","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":22},"in_reply_to":"fa31d9ce_a36471e5","updated":"2017-02-17 03:35:12.000000000","message":"Done","commit_id":"30d491ea49a887fc63159af141ce32df5694e44f"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"32b7fb39cdf3c9bd230c5eae1103dba9250e541a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response:"},{"line_number":80,"context_line":"If successful, this method does not return content in the response body."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_e35e6911","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":9},"updated":"2017-02-17 02:11:55.000000000","message":"What if it is not successful?","commit_id":"30d491ea49a887fc63159af141ce32df5694e44f"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"eb30027456d7400441f9d5d8c248caad48c35b41","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response:"},{"line_number":80,"context_line":"If successful, this method does not return content in the response body."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_460bc37d","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":9},"in_reply_to":"fa31d9ce_e35e6911","updated":"2017-02-17 03:35:12.000000000","message":"I add a list the error respond codes to be supported in error path.","commit_id":"30d491ea49a887fc63159af141ce32df5694e44f"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"32b7fb39cdf3c9bd230c5eae1103dba9250e541a","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Notifications impact"},{"line_number":87,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":88,"context_line":"None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Other end user impact"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_8395ad89","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":4},"updated":"2017-02-17 02:11:55.000000000","message":"No notifications are required at start and stop of snapshotting?","commit_id":"30d491ea49a887fc63159af141ce32df5694e44f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"cb77b0cc1a407301e28adbb37ff3dbbe690bba15","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Notifications impact"},{"line_number":87,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":88,"context_line":"None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Other end user impact"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_2fe40d0c","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":4},"in_reply_to":"fa31d9ce_261c0f77","updated":"2017-02-17 20:51:42.000000000","message":"@Zhoubin,\n\nI think Jay means to emit notification to rpc when there is an event on a container (i.e. being snapshotting). It is universal for other openstack services to broadcast notifications to a rpc queue when an event happened (i.e. a resource has changed its state). For example, this is the implementation in Magnum: https://review.openstack.org/#/c/315469/ .\n\nIn Zun, we haven\u0027t implemented notification yet so this might need to be addressed in a separated BP [1].\n\n[1] https://blueprints.launchpad.net/zun/+spec/zun-notification","commit_id":"30d491ea49a887fc63159af141ce32df5694e44f"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"eb30027456d7400441f9d5d8c248caad48c35b41","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Notifications impact"},{"line_number":87,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":88,"context_line":"None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Other end user impact"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_261c0f77","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":4},"in_reply_to":"fa31d9ce_8395ad89","updated":"2017-02-17 03:35:12.000000000","message":"Interesting. I did not consider to support any notifications. As noted earlier, a user has to poll the status to determine if the request completed. There maybe design patterns available to give the user status notifications. I think the implementation relies on the application to pull status unless all the related RPCs provide same notification mechanism. For example, the related docker api and glance api have to support notification. Otherwise this application would keep pull the status of the sub-operations. I personally am a big fan of \"fire and forget\" pattern. But I certainly want to follow the common practice. Jay, please advise.","commit_id":"30d491ea49a887fc63159af141ce32df5694e44f"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"4011426cf8dc7f81da51e683adc379ec72a28866","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI command to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun commit \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help commit"},{"line_number":28,"context_line":"   usage: zun commit \u003ccontainer\u003e \u003cname\u003e"},{"line_number":29,"context_line":"          Create a new image by taking a snapshot of a running container."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba2be162_01ac1233","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":43},"updated":"2017-03-02 13:01:22.000000000","message":"it will be useful to have commit message as well, like docker commit has, usually when we take snapshots of vm we save it with a message.","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b637f88f35e12e1945015ef7b8431ee3e611893d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI command to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun commit \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help commit"},{"line_number":28,"context_line":"   usage: zun commit \u003ccontainer\u003e \u003cname\u003e"},{"line_number":29,"context_line":"          Create a new image by taking a snapshot of a running container."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba2be162_fe014907","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":43},"in_reply_to":"ba2be162_01ac1233","updated":"2017-03-02 17:04:30.000000000","message":"This might be a good idea. Personally, I\u0027d rather to leave this as a future improvement and let this spec focus on the basic requirements of container snapshooting.","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b9572574f45c8c7cc61a8c3099886fb23e7d71f9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI command to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun commit \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help commit"},{"line_number":28,"context_line":"   usage: zun commit \u003ccontainer\u003e \u003cname\u003e"},{"line_number":29,"context_line":"          Create a new image by taking a snapshot of a running container."},{"line_number":30,"context_line":"   Positional arguments:"},{"line_number":31,"context_line":"          \u003cserver\u003e                Name or ID of container."},{"line_number":32,"context_line":"          \u003cname\u003e                  Name of snapshot."},{"line_number":33,"context_line":"2. Extend docker driver to enable “docker commit” command to create a"},{"line_number":34,"context_line":"   new image."},{"line_number":35,"context_line":"3. The new image should be accessable from other hosts. There are two"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da36d5c6_34b44bf1","line":32,"range":{"start_line":26,"start_character":3,"end_line":32,"end_character":51},"updated":"2017-02-20 08:53:44.000000000","message":"parameter name at all  three places don\u0027t mach i think we need to use \u003ccontainer-name\u003e \u003cimage-name\u003e at all three places.","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b637f88f35e12e1945015ef7b8431ee3e611893d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"1. Introduce a new CLI command to enable a user to take a snapshot of a running"},{"line_number":25,"context_line":"   container instance."},{"line_number":26,"context_line":"   zun commit \u003ccontainer-name\u003e \u003cimage-name\u003e"},{"line_number":27,"context_line":"   # zun help commit"},{"line_number":28,"context_line":"   usage: zun commit \u003ccontainer\u003e \u003cname\u003e"},{"line_number":29,"context_line":"          Create a new image by taking a snapshot of a running container."},{"line_number":30,"context_line":"   Positional arguments:"},{"line_number":31,"context_line":"          \u003cserver\u003e                Name or ID of container."},{"line_number":32,"context_line":"          \u003cname\u003e                  Name of snapshot."},{"line_number":33,"context_line":"2. Extend docker driver to enable “docker commit” command to create a"},{"line_number":34,"context_line":"   new image."},{"line_number":35,"context_line":"3. The new image should be accessable from other hosts. There are two"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba2be162_1ebe1d65","line":32,"range":{"start_line":26,"start_character":3,"end_line":32,"end_character":51},"in_reply_to":"da36d5c6_34b44bf1","updated":"2017-03-02 17:04:30.000000000","message":"+1","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b9572574f45c8c7cc61a8c3099886fb23e7d71f9","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Specify the createImage action in the request body."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"After making this request, a user typically must keep polling the status of the created image"},{"line_number":63,"context_line":"to determine whether the request succeeded."},{"line_number":64,"context_line":"If the operation succeeds, the created image has a status of active. User can also see the new"},{"line_number":65,"context_line":"image in the image back end that OpenStack Image service manages."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da36d5c6_14e2e7d5","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":43},"updated":"2017-02-20 08:53:44.000000000","message":"how to poll this, by polling glance api or what?","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b637f88f35e12e1945015ef7b8431ee3e611893d","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Specify the createImage action in the request body."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"After making this request, a user typically must keep polling the status of the created image"},{"line_number":63,"context_line":"to determine whether the request succeeded."},{"line_number":64,"context_line":"If the operation succeeds, the created image has a status of active. User can also see the new"},{"line_number":65,"context_line":"image in the image back end that OpenStack Image service manages."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba2be162_c112e856","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":43},"in_reply_to":"da36d5c6_14e2e7d5","updated":"2017-03-02 17:04:30.000000000","message":"I guess yes. It can be done by polling the glance api.","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b9572574f45c8c7cc61a8c3099886fb23e7d71f9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"1. The server must exist."},{"line_number":69,"context_line":"2. User can only create a new image from the container when its status is Running, Stopped,"},{"line_number":70,"context_line":"   and Paused."},{"line_number":71,"context_line":"3. The connection to the Image service is valid."},{"line_number":72,"context_line":"Example commit (commit Action)"},{"line_number":73,"context_line":"{"},{"line_number":74,"context_line":"    \"commit\" : {"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da36d5c6_d4ef6fae","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":48},"updated":"2017-02-20 08:53:44.000000000","message":"is it a precondition?","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b9572574f45c8c7cc61a8c3099886fb23e7d71f9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"2. User can only create a new image from the container when its status is Running, Stopped,"},{"line_number":70,"context_line":"   and Paused."},{"line_number":71,"context_line":"3. The connection to the Image service is valid."},{"line_number":72,"context_line":"Example commit (commit Action)"},{"line_number":73,"context_line":"{"},{"line_number":74,"context_line":"    \"commit\" : {"},{"line_number":75,"context_line":"        \"name\" : \"foo-image\""},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response:"},{"line_number":80,"context_line":"If successful, this method does not return content in the response body. Normal response codes: 202"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da36d5c6_14bbc7c5","line":77,"range":{"start_line":72,"start_character":0,"end_line":77,"end_character":1},"updated":"2017-02-20 08:53:44.000000000","message":"I think zun does not follow this style, we follow /containers/\u003cid\u003e/action i.e. action is part of the URL not body.","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b637f88f35e12e1945015ef7b8431ee3e611893d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"2. User can only create a new image from the container when its status is Running, Stopped,"},{"line_number":70,"context_line":"   and Paused."},{"line_number":71,"context_line":"3. The connection to the Image service is valid."},{"line_number":72,"context_line":"Example commit (commit Action)"},{"line_number":73,"context_line":"{"},{"line_number":74,"context_line":"    \"commit\" : {"},{"line_number":75,"context_line":"        \"name\" : \"foo-image\""},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Response:"},{"line_number":80,"context_line":"If successful, this method does not return content in the response body. Normal response codes: 202"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba2be162_815ab028","line":77,"range":{"start_line":72,"start_character":0,"end_line":77,"end_character":1},"in_reply_to":"da36d5c6_14bbc7c5","updated":"2017-03-02 17:04:30.000000000","message":"+1","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"4011426cf8dc7f81da51e683adc379ec72a28866","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Other end user impact"},{"line_number":92,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Performance Impact"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba2be162_e4362ce6","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":4},"updated":"2017-03-02 13:01:22.000000000","message":"it does have an end user impact","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b637f88f35e12e1945015ef7b8431ee3e611893d","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Other end user impact"},{"line_number":92,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Performance Impact"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba2be162_e149ac61","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":4},"in_reply_to":"ba2be162_e4362ce6","updated":"2017-03-02 17:04:30.000000000","message":"Could you elaborate?","commit_id":"a8a4690c81692895745f237f558d4bf40f610560"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"a0c1e18c8cf1300c40a758f4dc57af2fafcf861e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":"Creates an image from a container."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Specify the createImage action in the request body."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"After making this request, a user typically must keep polling the status of the created image"},{"line_number":63,"context_line":"from glance to determine whether the request succeeded."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_d27a7bf0","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":51},"updated":"2017-03-03 18:58:40.000000000","message":"i think its incorrect, we are passing image-name in body?","commit_id":"8bbcbb4b5fbc49cc3aca6297791273653f4b84c9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"3565cc28540567babe4c1a0f07f8384ca17d2fde","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":"Creates an image from a container."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Specify the createImage action in the request body."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"After making this request, a user typically must keep polling the status of the created image"},{"line_number":63,"context_line":"from glance to determine whether the request succeeded."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_a74e9238","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":51},"in_reply_to":"ba2be162_d27a7bf0","updated":"2017-03-04 17:45:48.000000000","message":"Done","commit_id":"8bbcbb4b5fbc49cc3aca6297791273653f4b84c9"}]}