)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"5bcb5162b2549f0df4ad051bde937661aaa5f3ba","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":425,"context_line":"    @exception.wrap_pecan_controller_exception"},{"line_number":426,"context_line":"    @validation.validate_query_param(pecan.request, schema.query_param_signal)"},{"line_number":427,"context_line":"    def kill(self, container_id, **kw):"},{"line_number":428,"context_line":"        container \u003d _get_container(container_id)"},{"line_number":429,"context_line":"        check_policy_on_container(container.as_dict(), \"container:kill\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_7e10c357","line":426,"range":{"start_line":426,"start_character":4,"end_line":426,"end_character":78},"updated":"2017-03-29 10:51:26.000000000","message":"Signal is not coming in query params, its coming in request body. So better would be to convert that in query params. I think modification at client side would be necessary.","commit_id":"a292d3d38e58472b843eaed456d0a5632c273d34"}],"zun/common/validation/parameter_types.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a73a2a0f480d4d46c60f37e0f2de692680c42ee4","unresolved":false,"context_lines":[{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"SIGNALS \u003d []"},{"line_number":157,"context_line":"for n in dir(signal):"},{"line_number":158,"context_line":"    if n.startswith(\u0027SIG\u0027) and \u0027_\u0027 not in n:"},{"line_number":159,"context_line":"        SIGNALS.append(n)"},{"line_number":160,"context_line":"        SIGNALS.append(str(getattr(signal, n)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_cc3c6895","line":157,"range":{"start_line":157,"start_character":9,"end_line":157,"end_character":20},"updated":"2017-03-13 16:08:00.000000000","message":"It seems this is incompatible with python 3.5. Consider using signal.Signals for the py35 cases.","commit_id":"a4605f1f6c0610802efaa291cb7492d5c6f0c3de"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"5bcb5162b2549f0df4ad051bde937661aaa5f3ba","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        SIGNALS.append(str(getattr(signal, s)))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"signal \u003d {"},{"line_number":173,"context_line":"    \u0027type\u0027: [\u0027string\u0027, \u0027integer\u0027, \u0027null\u0027],"},{"line_number":174,"context_line":"    \u0027enum\u0027: SIGNALS"},{"line_number":175,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_3e911bf2","line":173,"range":{"start_line":173,"start_character":24,"end_line":173,"end_character":31},"updated":"2017-03-29 10:51:26.000000000","message":"I dont see integer in the SIGNAL list.","commit_id":"a292d3d38e58472b843eaed456d0a5632c273d34"}],"zun/tests/unit/api/controllers/v1/test_containers.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"5bcb5162b2549f0df4ad051bde937661aaa5f3ba","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"            container_uuid \u003d test_container.get(\u0027uuid\u0027)"},{"line_number":1183,"context_line":"            params \u003d {\u0027signal\u0027: value}"},{"line_number":1184,"context_line":"            self.assertRaises(AppError, self.app.post,"},{"line_number":1185,"context_line":"                              \u0027/v1/containers/%s/kill\u0027 %"},{"line_number":1186,"context_line":"                              container_uuid, params)"},{"line_number":1187,"context_line":"            self.assertFalse(mock_container_kill.called)"},{"line_number":1188,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_de510f38","line":1185,"range":{"start_line":1184,"start_character":12,"end_line":1185,"end_character":56},"updated":"2017-03-29 10:51:26.000000000","message":"I would suggest to check the exception message like \u0027Invalid input for query parameters\u0027. Thoughts?","commit_id":"a292d3d38e58472b843eaed456d0a5632c273d34"}]}