)]}'
{"zun/filters.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a438d615d4b3681f4bcd73ec4ee31adcb744285d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_d62a22e7","line":1,"updated":"2017-03-14 20:04:45.000000000","message":"I am not sure why nova put this file under the root directory. However, in zun, I think it would be better to move this file to zun/scheduler/ directory if you agree.","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"13cf19615ea3fc9018781114c8c0f07c009d7ac3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_76f963c8","line":1,"in_reply_to":"3a1ff146_d62a22e7","updated":"2017-03-15 02:55:47.000000000","message":"Done","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a438d615d4b3681f4bcd73ec4ee31adcb744285d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    This class should be subclassed where one needs to use filters."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_filtered_objects(self, filters, objs, spec_obj, index\u003d0):"},{"line_number":66,"context_line":"        list_objs \u003d list(objs)"},{"line_number":67,"context_line":"        LOG.debug(\"Starting with %d host(s)\", len(list_objs))"},{"line_number":68,"context_line":"        part_filter_results \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_b68da67d","line":65,"range":{"start_line":65,"start_character":50,"end_line":65,"end_character":58},"updated":"2017-03-14 20:04:45.000000000","message":"There is no spec object in Zun. It seems this is a container object.","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"13cf19615ea3fc9018781114c8c0f07c009d7ac3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    This class should be subclassed where one needs to use filters."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_filtered_objects(self, filters, objs, spec_obj, index\u003d0):"},{"line_number":66,"context_line":"        list_objs \u003d list(objs)"},{"line_number":67,"context_line":"        LOG.debug(\"Starting with %d host(s)\", len(list_objs))"},{"line_number":68,"context_line":"        part_filter_results \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_93799132","line":65,"range":{"start_line":65,"start_character":50,"end_line":65,"end_character":58},"in_reply_to":"3a1ff146_b68da67d","updated":"2017-03-15 02:55:47.000000000","message":"Done","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a438d615d4b3681f4bcd73ec4ee31adcb744285d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            msg_dict \u003d {\"inst_uuid\": inst_uuid,"},{"line_number":99,"context_line":"                        \"str_results\": str(full_filter_results)}"},{"line_number":100,"context_line":"            full_msg \u003d (\"Filtering removed all hosts for the request with \""},{"line_number":101,"context_line":"                        \"instance ID \""},{"line_number":102,"context_line":"                        \"\u0027%(inst_uuid)s\u0027. Filter results: %(str_results)s\""},{"line_number":103,"context_line":"                        ) % msg_dict"},{"line_number":104,"context_line":"            msg_dict[\"str_results\"] \u003d str(part_filter_results)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_1073e1b2","line":101,"range":{"start_line":101,"start_character":25,"end_line":101,"end_character":33},"updated":"2017-03-14 20:04:45.000000000","message":"container","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"13cf19615ea3fc9018781114c8c0f07c009d7ac3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            msg_dict \u003d {\"inst_uuid\": inst_uuid,"},{"line_number":99,"context_line":"                        \"str_results\": str(full_filter_results)}"},{"line_number":100,"context_line":"            full_msg \u003d (\"Filtering removed all hosts for the request with \""},{"line_number":101,"context_line":"                        \"instance ID \""},{"line_number":102,"context_line":"                        \"\u0027%(inst_uuid)s\u0027. Filter results: %(str_results)s\""},{"line_number":103,"context_line":"                        ) % msg_dict"},{"line_number":104,"context_line":"            msg_dict[\"str_results\"] \u003d str(part_filter_results)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_f3a005a8","line":101,"range":{"start_line":101,"start_character":25,"end_line":101,"end_character":33},"in_reply_to":"3a1ff146_1073e1b2","updated":"2017-03-15 02:55:47.000000000","message":"Done","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a438d615d4b3681f4bcd73ec4ee31adcb744285d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                        ) % msg_dict"},{"line_number":104,"context_line":"            msg_dict[\"str_results\"] \u003d str(part_filter_results)"},{"line_number":105,"context_line":"            part_msg \u003d _LI(\"Filtering removed all hosts for the request with \""},{"line_number":106,"context_line":"                           \"instance ID \""},{"line_number":107,"context_line":"                           \"\u0027%(inst_uuid)s\u0027. Filter results: %(str_results)s\""},{"line_number":108,"context_line":"                           ) % msg_dict"},{"line_number":109,"context_line":"            LOG.debug(full_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_506559df","line":106,"range":{"start_line":106,"start_character":28,"end_line":106,"end_character":36},"updated":"2017-03-14 20:04:45.000000000","message":"container","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"13cf19615ea3fc9018781114c8c0f07c009d7ac3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                        ) % msg_dict"},{"line_number":104,"context_line":"            msg_dict[\"str_results\"] \u003d str(part_filter_results)"},{"line_number":105,"context_line":"            part_msg \u003d _LI(\"Filtering removed all hosts for the request with \""},{"line_number":106,"context_line":"                           \"instance ID \""},{"line_number":107,"context_line":"                           \"\u0027%(inst_uuid)s\u0027. Filter results: %(str_results)s\""},{"line_number":108,"context_line":"                           ) % msg_dict"},{"line_number":109,"context_line":"            LOG.debug(full_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_13a681c1","line":106,"range":{"start_line":106,"start_character":28,"end_line":106,"end_character":36},"in_reply_to":"3a1ff146_506559df","updated":"2017-03-15 02:55:47.000000000","message":"Done","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"}],"zun/loadables.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a438d615d4b3681f4bcd73ec4ee31adcb744285d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\""},{"line_number":14,"context_line":"Generic Loadable class support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Meant to be used by such things as scheduler filters where we"},{"line_number":17,"context_line":"want to load modules from certain directories and find certain types of"},{"line_number":18,"context_line":"classes within those modules.  Note that this is quite different than"},{"line_number":19,"context_line":"generic plugins and the pluginmanager code that exists elsewhere."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_160cba93","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":44},"updated":"2017-03-14 20:04:45.000000000","message":"It seems this class is only used by scheduler so it might be better to move this file to zun/scheduler/ directory if you agree.","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"13cf19615ea3fc9018781114c8c0f07c009d7ac3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\""},{"line_number":14,"context_line":"Generic Loadable class support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Meant to be used by such things as scheduler filters where we"},{"line_number":17,"context_line":"want to load modules from certain directories and find certain types of"},{"line_number":18,"context_line":"classes within those modules.  Note that this is quite different than"},{"line_number":19,"context_line":"generic plugins and the pluginmanager code that exists elsewhere."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_736895bb","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":44},"in_reply_to":"3a1ff146_160cba93","updated":"2017-03-15 02:55:47.000000000","message":"Done","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"}],"zun/scheduler/filters/noop_filter.py":[{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"31bbc5ecf24e0f70e51c6ca359511ed16a2b454f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Noop filter for now\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # Depend on the objects.NodeInfo of below patch to filter node,"},{"line_number":37,"context_line":"        # https://review.openstack.org/#/c/436572/6, no more thing can do now."},{"line_number":38,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_b14be558","line":37,"range":{"start_line":37,"start_character":18,"end_line":37,"end_character":24},"updated":"2017-03-15 03:23:55.000000000","message":"@Sudipta Biswas， Could you please take this BP into consideration when you implement the node_tracker.\n\nThanks","commit_id":"fe7703ba8a70f413a2dd2086e358ec2323d4a788"}]}