)]}'
{"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"4890f774577808dccab5558697f9e4c547f51cd7","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            utils.validate_container_state(container, \u0027delete_force\u0027)"},{"line_number":412,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":413,"context_line":"        compute_api.container_delete(context, container, force)"},{"line_number":414,"context_line":"        container.status \u003d consts.DELETING"},{"line_number":415,"context_line":"        container.save(context)"},{"line_number":416,"context_line":"        pecan.response.status \u003d 204"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    @pecan.expose(\u0027json\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_d112a9b1","line":415,"range":{"start_line":414,"start_character":8,"end_line":415,"end_character":31},"updated":"2017-08-24 04:27:04.000000000","message":"Do we need update container\u0027s status here? because when call container_delete, container\u0027s status is CONTAINER_DELETING, I think it\u0027s enough. correct me if I\u0027m wrong. \n\nBtw, container.save() will call dbapi.update_container(). It will raise the Exception \"Cannot overwrite UUID for an existing Container\".","commit_id":"5a3597b2c684f4887b7b6ff444bdcc5403d8902c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3f1b213c59f42972158fc672b10b668658e546b1","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            utils.validate_container_state(container, \u0027delete_force\u0027)"},{"line_number":412,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":413,"context_line":"        compute_api.container_delete(context, container, force)"},{"line_number":414,"context_line":"        container.status \u003d consts.DELETING"},{"line_number":415,"context_line":"        container.save(context)"},{"line_number":416,"context_line":"        pecan.response.status \u003d 204"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    @pecan.expose(\u0027json\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_702525ab","line":415,"range":{"start_line":414,"start_character":8,"end_line":415,"end_character":31},"in_reply_to":"7f287b81_d112a9b1","updated":"2017-08-24 11:13:17.000000000","message":"Yes you\u0027re right. Thanks Kien.","commit_id":"5a3597b2c684f4887b7b6ff444bdcc5403d8902c"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"b7a3a5983d33c8f229ea367fa5fdf276dd4e22ef","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            policy.enforce(context, \"container:delete_force\","},{"line_number":487,"context_line":"                           action\u003d\"container:delete_force\")"},{"line_number":488,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":489,"context_line":"        container.status \u003d consts.DELETING"},{"line_number":490,"context_line":"        compute_api.container_delete(context, container, force)"},{"line_number":491,"context_line":"        pecan.response.status \u003d 204"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f515b1d_ec33f1a9","line":489,"range":{"start_line":489,"start_character":8,"end_line":489,"end_character":42},"updated":"2017-09-29 16:41:14.000000000","message":"do we need to call container.save(context) here? if compute is not reachable then i think status would not persist to db, please correct me if i am wrong?","commit_id":"01a953f98a6ed2d2dbd011a05a0e50e2cb107b21"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"5879904116f87d383d07588d2284309f2e6143bf","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            policy.enforce(context, \"container:delete_force\","},{"line_number":487,"context_line":"                           action\u003d\"container:delete_force\")"},{"line_number":488,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":489,"context_line":"        container.status \u003d consts.DELETING"},{"line_number":490,"context_line":"        compute_api.container_delete(context, container, force)"},{"line_number":491,"context_line":"        pecan.response.status \u003d 204"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f515b1d_f5102252","line":489,"range":{"start_line":489,"start_character":8,"end_line":489,"end_character":42},"in_reply_to":"7f515b1d_e1d74bbe","updated":"2017-10-03 16:25:41.000000000","message":"What will we the status in that case? Because request is async and it will not fail, user will  get the status in DB which was there before issuing the command. isn\u0027t it confusing for the user, that request is getting succeeded each time without change in the status?","commit_id":"01a953f98a6ed2d2dbd011a05a0e50e2cb107b21"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"693eac0805a9b944acc5a72d163fbf4f9d5ca649","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            policy.enforce(context, \"container:delete_force\","},{"line_number":487,"context_line":"                           action\u003d\"container:delete_force\")"},{"line_number":488,"context_line":"        compute_api \u003d pecan.request.compute_api"},{"line_number":489,"context_line":"        container.status \u003d consts.DELETING"},{"line_number":490,"context_line":"        compute_api.container_delete(context, container, force)"},{"line_number":491,"context_line":"        pecan.response.status \u003d 204"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f515b1d_e1d74bbe","line":489,"range":{"start_line":489,"start_character":8,"end_line":489,"end_character":42},"in_reply_to":"7f515b1d_ec33f1a9","updated":"2017-10-03 10:53:19.000000000","message":"Good question, indeed. In case the compute service is not reachable, we shouldn\u0027t save this state.","commit_id":"01a953f98a6ed2d2dbd011a05a0e50e2cb107b21"}],"zun/compute/manager.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2b5f096bc6b20fd4a2e6c99f39fbd41c53b08249","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                self._fail_container(context, container, six.text_type(e))"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @translate_exception"},{"line_number":225,"context_line":"    def container_delete(self, context, container, force\u003dFalse):"},{"line_number":226,"context_line":"        LOG.debug(\u0027Deleting container: %s\u0027, container.uuid)"},{"line_number":227,"context_line":"        self._update_task_state(context, container, consts.CONTAINER_DELETING)"},{"line_number":228,"context_line":"        reraise \u003d not force"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_baf3639e","line":225,"updated":"2017-08-24 15:57:13.000000000","message":"Although the current implementation works, I think it is better to spawn a thread to execute the deleting in background (like what container_create do).","commit_id":"b1e52c0cd983e26e199429692f4fa4507929c02b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"54410df1fc81906fba47380d6bdcb596a36a417c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                self._fail_container(context, container, six.text_type(e))"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @translate_exception"},{"line_number":225,"context_line":"    def container_delete(self, context, container, force\u003dFalse):"},{"line_number":226,"context_line":"        LOG.debug(\u0027Deleting container: %s\u0027, container.uuid)"},{"line_number":227,"context_line":"        self._update_task_state(context, container, consts.CONTAINER_DELETING)"},{"line_number":228,"context_line":"        reraise \u003d not force"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_559d30ba","line":225,"in_reply_to":"7f287b81_baf3639e","updated":"2017-08-28 08:14:00.000000000","message":"Done","commit_id":"b1e52c0cd983e26e199429692f4fa4507929c02b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"feda2bfd9268b35fbccec4299ee6be35ea49fd4d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        utils.spawn_n(self._do_container_delete, context, container,"},{"line_number":233,"context_line":"                      force)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def _do_container_delete(self, context, container, force):"},{"line_number":236,"context_line":"        LOG.debug(\u0027Deleting container: %s\u0027, container.uuid)"},{"line_number":237,"context_line":"        self._update_task_state(context, container, consts.CONTAINER_DELETING)"},{"line_number":238,"context_line":"        reraise \u003d not force"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f5c4f37_6118fad2","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":28},"updated":"2017-09-21 03:20:00.000000000","message":"Nova uses @utils.synchronized(instance.uuid) [1] to synchronize concurrent delete of the same instance. I think we should borrow the approach in here.\n\n[1] https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2438","commit_id":"2eb37d60b90895d5a615dea5cf0d331c0648cdd6"}],"zun/tests/tempest/api/test_containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2b5f096bc6b20fd4a2e6c99f39fbd41c53b08249","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        container \u003d self.docker_client.get_container(container_id)"},{"line_number":417,"context_line":"        self.container_client.ensure_container_in_desired_state("},{"line_number":418,"context_line":"            container.uuid, \u0027Deleting\u0027)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def _get_container_state(self, container_id):"},{"line_number":421,"context_line":"        container \u003d self.docker_client.get_container(container_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_baac838c","line":418,"range":{"start_line":418,"start_character":29,"end_line":418,"end_character":37},"updated":"2017-08-24 15:57:13.000000000","message":"I think it is better to ensure the container being actually deleted (cannot be showed via Zun API).","commit_id":"b1e52c0cd983e26e199429692f4fa4507929c02b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"54410df1fc81906fba47380d6bdcb596a36a417c","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        container \u003d self.docker_client.get_container(container_id)"},{"line_number":417,"context_line":"        self.container_client.ensure_container_in_desired_state("},{"line_number":418,"context_line":"            container.uuid, \u0027Deleting\u0027)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def _get_container_state(self, container_id):"},{"line_number":421,"context_line":"        container \u003d self.docker_client.get_container(container_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_755eec12","line":418,"range":{"start_line":418,"start_character":29,"end_line":418,"end_character":37},"in_reply_to":"7f287b81_baac838c","updated":"2017-08-28 08:14:00.000000000","message":"Done","commit_id":"b1e52c0cd983e26e199429692f4fa4507929c02b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0ff6a26656dd7bedb3ed4a5934697a50e1177f07","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        container \u003d self.docker_client.get_container("},{"line_number":448,"context_line":"            container_id, self._get_docker_url(container_host))"},{"line_number":449,"context_line":"        self.container_client.ensure_container_in_desired_state("},{"line_number":450,"context_line":"            container.get(\u0027uuid\u0027), \u0027Deleting\u0027)"},{"line_number":451,"context_line":"        resp, _ \u003d self.docker_client.get_container(container.get(\u0027uuid\u0027))"},{"line_number":452,"context_line":"        self.assertEqual(404, resp.status)"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff5d4b2f_1bd9a182","line":450,"range":{"start_line":450,"start_character":36,"end_line":450,"end_character":44},"updated":"2017-09-19 14:53:41.000000000","message":"Madhuri,\n\nI guess the gate failed because this container hasn\u0027t been deleted. It looks we need to ensure the container is actually deleted (cannot be listed in Zun API) instead.","commit_id":"200e270d51bc0d6a1efc1aec155912ef2c8dac29"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"bb67ebfd368b758c732837f99acd66a694e28a27","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        container \u003d self.docker_client.get_container("},{"line_number":448,"context_line":"            container_id, self._get_docker_url(container_host))"},{"line_number":449,"context_line":"        self.container_client.ensure_container_in_desired_state("},{"line_number":450,"context_line":"            container.get(\u0027uuid\u0027), \u0027Deleting\u0027)"},{"line_number":451,"context_line":"        resp, _ \u003d self.docker_client.get_container(container.get(\u0027uuid\u0027))"},{"line_number":452,"context_line":"        self.assertEqual(404, resp.status)"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f5c4f37_8731c6ef","line":450,"range":{"start_line":450,"start_character":36,"end_line":450,"end_character":44},"in_reply_to":"bf57530f_efd612c4","updated":"2017-09-20 23:36:31.000000000","message":"I looked into it for a while but couldn\u0027t figure out why. I need to enable the debug mode in kuryr-libnetwork to do further trouble-shooting.","commit_id":"200e270d51bc0d6a1efc1aec155912ef2c8dac29"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3b99c4bbea7a94d2d836e55e5c3f881516b2a3d0","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        container \u003d self.docker_client.get_container("},{"line_number":448,"context_line":"            container_id, self._get_docker_url(container_host))"},{"line_number":449,"context_line":"        self.container_client.ensure_container_in_desired_state("},{"line_number":450,"context_line":"            container.get(\u0027uuid\u0027), \u0027Deleting\u0027)"},{"line_number":451,"context_line":"        resp, _ \u003d self.docker_client.get_container(container.get(\u0027uuid\u0027))"},{"line_number":452,"context_line":"        self.assertEqual(404, resp.status)"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bf57530f_efd612c4","line":450,"range":{"start_line":450,"start_character":36,"end_line":450,"end_character":44},"in_reply_to":"ff5d4b2f_1bd9a182","updated":"2017-09-20 05:22:15.000000000","message":"Hongbin I see some failures like \"container is not connected to the network\". I am not able to reproduce issue [1]. Are you aware of it?\n\n[1] http://logs.openstack.org/60/452660/10/check/gate-zun-devstack-dsvm-docker-sql/272ba06/logs/screen-zun-compute.txt.gz#_Sep_19_11_57_30_810795","commit_id":"200e270d51bc0d6a1efc1aec155912ef2c8dac29"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0ff6a26656dd7bedb3ed4a5934697a50e1177f07","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            container_id, self._get_docker_url(container_host))"},{"line_number":449,"context_line":"        self.container_client.ensure_container_in_desired_state("},{"line_number":450,"context_line":"            container.get(\u0027uuid\u0027), \u0027Deleting\u0027)"},{"line_number":451,"context_line":"        resp, _ \u003d self.docker_client.get_container(container.get(\u0027uuid\u0027))"},{"line_number":452,"context_line":"        self.assertEqual(404, resp.status)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def _get_container_state(self, container_id, docker_host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff5d4b2f_9b0911df","line":451,"range":{"start_line":451,"start_character":51,"end_line":451,"end_character":72},"updated":"2017-09-19 14:53:41.000000000","message":"The docker client get container by \u0027docker_id\u0027 (not container\u0027s uuid). You could see line #447 as an example.","commit_id":"200e270d51bc0d6a1efc1aec155912ef2c8dac29"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3b99c4bbea7a94d2d836e55e5c3f881516b2a3d0","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            container_id, self._get_docker_url(container_host))"},{"line_number":449,"context_line":"        self.container_client.ensure_container_in_desired_state("},{"line_number":450,"context_line":"            container.get(\u0027uuid\u0027), \u0027Deleting\u0027)"},{"line_number":451,"context_line":"        resp, _ \u003d self.docker_client.get_container(container.get(\u0027uuid\u0027))"},{"line_number":452,"context_line":"        self.assertEqual(404, resp.status)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def _get_container_state(self, container_id, docker_host\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf57530f_afe01a98","line":451,"range":{"start_line":451,"start_character":51,"end_line":451,"end_character":72},"in_reply_to":"ff5d4b2f_9b0911df","updated":"2017-09-20 05:22:15.000000000","message":"Done","commit_id":"200e270d51bc0d6a1efc1aec155912ef2c8dac29"}]}
