)]}'
{"zun/container/docker/utils.py":[{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"571ea89577b05d56095ddd9cfd35f8eeaf6b2b00","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def list_instances(self, inspect\u003dFalse):"},{"line_number":84,"context_line":"        \"\"\"List all containers.\"\"\""},{"line_number":85,"context_line":"        res \u003d []"},{"line_number":86,"context_line":"        for container in self.containers(all\u003dTrue, filters\u003d{\u0027name\u0027: \u0027zun-\u0027}):"},{"line_number":87,"context_line":"            info \u003d self.inspect_container(container[\u0027Id\u0027])"},{"line_number":88,"context_line":"            if not info:"},{"line_number":89,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_8ded6627","line":86,"range":{"start_line":86,"start_character":50,"end_line":86,"end_character":51},"updated":"2017-05-04 06:48:16.000000000","message":"1, why not using L96 list_containers? If you want to get the inspect info, I prefer to add inspect parameter to list_containers.\n\nI guess these two methods, one for get all containers, one for get zun-xxx containers.\n\n2, Seems this method is only called in create_sandbox to find out sandbox id. If this method only return zun-xxx containers, I guess we cannot get the sandbox id.","commit_id":"c56330de1147c24d13cf20f314ff86fd3191a01b"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"924d0bc2ed7a49f42344dbe3502095c9968217a2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def list_instances(self, inspect\u003dFalse):"},{"line_number":84,"context_line":"        \"\"\"List all containers.\"\"\""},{"line_number":85,"context_line":"        res \u003d []"},{"line_number":86,"context_line":"        for container in self.containers(all\u003dTrue, filters\u003d{\u0027name\u0027: \u0027zun-\u0027}):"},{"line_number":87,"context_line":"            info \u003d self.inspect_container(container[\u0027Id\u0027])"},{"line_number":88,"context_line":"            if not info:"},{"line_number":89,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_ae3259a6","line":86,"range":{"start_line":86,"start_character":50,"end_line":86,"end_character":51},"in_reply_to":"3f044301_8ded6627","updated":"2017-05-04 08:24:24.000000000","message":"Thanks @Shunli,\nI see, will abandon it.","commit_id":"c56330de1147c24d13cf20f314ff86fd3191a01b"}]}