)]}'
{"zun/container/os_capability/linux/os_capability_linux.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ce919e410c053d27506f5fe83ade47317dbcc012","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_container_numbers(self):"},{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            output \u003d processutils.execute(\u0027docker\u0027, \u0027system\u0027, \u0027info\u0027)"},{"line_number":64,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":65,"context_line":"            LOG.exception((\u0027There was a problem while executing %(cmd)s. \u0027"},{"line_number":66,"context_line":"                           \u0027Error: %(error)s.\u0027), {\u0027cmd\u0027: \u0027docker system info\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_15b7bff8","line":63,"range":{"start_line":63,"start_character":63,"end_line":63,"end_character":67},"updated":"2017-04-19 02:31:51.000000000","message":"@Shunli,\n\nI think it is better to use dockerpy for doing this: https://docker-py.readthedocs.io/en/stable/client.html#docker.client.DockerClient.info . Also, I think container driver is a better place for this docker-specific logic. This allows us to evolve to support container engines other than docker in the future.","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"191f15d37d8a4f512fe7d569a3632ddcfb139863","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_container_numbers(self):"},{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            output \u003d processutils.execute(\u0027docker\u0027, \u0027system\u0027, \u0027info\u0027)"},{"line_number":64,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":65,"context_line":"            LOG.exception((\u0027There was a problem while executing %(cmd)s. \u0027"},{"line_number":66,"context_line":"                           \u0027Error: %(error)s.\u0027), {\u0027cmd\u0027: \u0027docker system info\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_e8cc75bd","line":63,"range":{"start_line":63,"start_character":63,"end_line":63,"end_character":67},"in_reply_to":"7ffa3b31_15b7bff8","updated":"2017-04-19 05:59:30.000000000","message":"+1","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"9d80638d417835b806e485827c3a90a93bbc37ef","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_container_numbers(self):"},{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            output \u003d processutils.execute(\u0027docker\u0027, \u0027system\u0027, \u0027info\u0027)"},{"line_number":64,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":65,"context_line":"            LOG.exception((\u0027There was a problem while executing %(cmd)s. \u0027"},{"line_number":66,"context_line":"                           \u0027Error: %(error)s.\u0027), {\u0027cmd\u0027: \u0027docker system info\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_c80c193d","line":63,"range":{"start_line":63,"start_character":63,"end_line":63,"end_character":67},"in_reply_to":"7ffa3b31_15b7bff8","updated":"2017-04-19 07:42:44.000000000","message":"Done","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"9d80638d417835b806e485827c3a90a93bbc37ef","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_container_numbers(self):"},{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            output \u003d processutils.execute(\u0027docker\u0027, \u0027system\u0027, \u0027info\u0027)"},{"line_number":64,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":65,"context_line":"            LOG.exception((\u0027There was a problem while executing %(cmd)s. \u0027"},{"line_number":66,"context_line":"                           \u0027Error: %(error)s.\u0027), {\u0027cmd\u0027: \u0027docker system info\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_0b88bb6e","line":63,"range":{"start_line":63,"start_character":63,"end_line":63,"end_character":67},"in_reply_to":"7ffa3b31_e8cc75bd","updated":"2017-04-19 07:42:44.000000000","message":"Done","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"191f15d37d8a4f512fe7d569a3632ddcfb139863","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                                  \u0027error\u0027: six.text_type(e)})"},{"line_number":68,"context_line":"            raise exception.CommandError(cmd\u003d\u0027docker system info\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        output \u003d output[0].split()"},{"line_number":71,"context_line":"        idx1 \u003d output.index(\u0027Containers:\u0027)"},{"line_number":72,"context_line":"        idx2 \u003d output.index(\u0027Running:\u0027)"},{"line_number":73,"context_line":"        idx3 \u003d output.index(\u0027Paused:\u0027)"},{"line_number":74,"context_line":"        idx4 \u003d output.index(\u0027Stopped:\u0027)"},{"line_number":75,"context_line":"        total \u003d output[idx1+1]"},{"line_number":76,"context_line":"        running \u003d output[idx2+1]"},{"line_number":77,"context_line":"        paused \u003d output[idx3+1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_48bb690d","line":74,"range":{"start_line":70,"start_character":7,"end_line":74,"end_character":39},"updated":"2017-04-19 05:59:30.000000000","message":"I think it will also show sandbox containers, do we need to collet them here?","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"9d80638d417835b806e485827c3a90a93bbc37ef","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                                  \u0027error\u0027: six.text_type(e)})"},{"line_number":68,"context_line":"            raise exception.CommandError(cmd\u003d\u0027docker system info\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        output \u003d output[0].split()"},{"line_number":71,"context_line":"        idx1 \u003d output.index(\u0027Containers:\u0027)"},{"line_number":72,"context_line":"        idx2 \u003d output.index(\u0027Running:\u0027)"},{"line_number":73,"context_line":"        idx3 \u003d output.index(\u0027Paused:\u0027)"},{"line_number":74,"context_line":"        idx4 \u003d output.index(\u0027Stopped:\u0027)"},{"line_number":75,"context_line":"        total \u003d output[idx1+1]"},{"line_number":76,"context_line":"        running \u003d output[idx2+1]"},{"line_number":77,"context_line":"        paused \u003d output[idx3+1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_6bacdf33","line":74,"range":{"start_line":70,"start_character":7,"end_line":74,"end_character":39},"in_reply_to":"7ffa3b31_48bb690d","updated":"2017-04-19 07:42:44.000000000","message":"For container number quota limit, it\u0027s should not count the sandbox containers. For real statistics of the docker host, i think we should count the sandbox containers. I\u0027m also not sure if we should count sandbox containers. I lean to keep the origin info returned by the docker client, i\u0027m afraid if we do many tricks here, it will be the source of bugs. We can revisit this when there is a clear use case or scenario to use the container numbers. \n\noption A: return info of docker system info\noption B: client.containers(all\u003dTrue).filter(name!\u003d /zun-sandbox-xxxxxx)\n\nWhat\u0027s you guys opinion?","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"}],"zun/db/sqlalchemy/alembic/versions/4bf34495d060_add_container_number_info_to_compute_.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"191f15d37d8a4f512fe7d569a3632ddcfb139863","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027total_containers\u0027, sa.Integer(), nullable\u003dFalse))"},{"line_number":34,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027running_containers\u0027,"},{"line_number":36,"context_line":"                            sa.Integer(), nullable\u003dFalse))"},{"line_number":37,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":38,"context_line":"                  sa.Column(\u0027paused_containers\u0027, sa.Integer(), nullable\u003dFalse))"},{"line_number":39,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":40,"context_line":"                  sa.Column(\u0027stopped_containers\u0027,"},{"line_number":41,"context_line":"                            sa.Integer(), nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_e841150d","line":41,"range":{"start_line":32,"start_character":4,"end_line":41,"end_character":58},"updated":"2017-04-19 05:59:30.000000000","message":"do we need to have default value here, i am not sure?","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"9d80638d417835b806e485827c3a90a93bbc37ef","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027total_containers\u0027, sa.Integer(), nullable\u003dFalse))"},{"line_number":34,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027running_containers\u0027,"},{"line_number":36,"context_line":"                            sa.Integer(), nullable\u003dFalse))"},{"line_number":37,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":38,"context_line":"                  sa.Column(\u0027paused_containers\u0027, sa.Integer(), nullable\u003dFalse))"},{"line_number":39,"context_line":"    op.add_column(\u0027compute_node\u0027,"},{"line_number":40,"context_line":"                  sa.Column(\u0027stopped_containers\u0027,"},{"line_number":41,"context_line":"                            sa.Integer(), nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_0ef4495a","line":41,"range":{"start_line":32,"start_character":4,"end_line":41,"end_character":58},"in_reply_to":"7ffa3b31_e841150d","updated":"2017-04-19 07:42:44.000000000","message":"I think if added default value in model, no need to add default value in upgrade. Any time a new model object generated, there is a default value, no need to ask the db schema to give a default value again. Correct me if i am wrong.","commit_id":"d9fe29d3270326403265f8876719937bea36fd30"}]}
