)]}'
{"devstack/lib/zun":[{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"560df191c165130c4a5c935be160741cb87cd6d6","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    if [[ ${ZUN_DRIVER} \u003d\u003d \"docker\" || ${ZUN_DRIVER} \u003d\u003d \"nova-docker\" ]]; then"},{"line_number":391,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":392,"context_line":"    else"},{"line_number":393,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":394,"context_line":"    fi"},{"line_number":395,"context_line":"}"},{"line_number":396,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ff0f0b1f_71845ed3","line":393,"range":{"start_line":393,"start_character":8,"end_line":393,"end_character":58},"updated":"2017-05-24 19:54:38.000000000","message":"Should we do nothing in this case if docker and nova-docker are the only supported run time driver? I understand it changes the old deployment behavior. Is there any reason to start zun-compute in this case?","commit_id":"73ead98af11c92771303385e5864942e1e49c9ef"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"26577c831dff43c4bb447f60f30ff014ee0f0791","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    if [[ ${ZUN_DRIVER} \u003d\u003d \"docker\" || ${ZUN_DRIVER} \u003d\u003d \"nova-docker\" ]]; then"},{"line_number":391,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":392,"context_line":"    else"},{"line_number":393,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":394,"context_line":"    fi"},{"line_number":395,"context_line":"}"},{"line_number":396,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ff0f0b1f_770fae87","line":393,"range":{"start_line":393,"start_character":8,"end_line":393,"end_character":58},"in_reply_to":"ff0f0b1f_71845ed3","updated":"2017-05-24 20:49:25.000000000","message":"Create a ticket to track this: https://bugs.launchpad.net/zun/+bug/1693352","commit_id":"73ead98af11c92771303385e5864942e1e49c9ef"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"990c17833a6bd5c6f737bb12126b32391a8a8761","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    if [[ ${ZUN_DRIVER} \u003d\u003d \"docker\" || ${ZUN_DRIVER} \u003d\u003d \"nova-docker\" ]]; then"},{"line_number":391,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":392,"context_line":"    else"},{"line_number":393,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":394,"context_line":"    fi"},{"line_number":395,"context_line":"}"},{"line_number":396,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ff0f0b1f_14aab017","line":393,"range":{"start_line":393,"start_character":8,"end_line":393,"end_character":58},"in_reply_to":"ff0f0b1f_71845ed3","updated":"2017-05-24 20:27:00.000000000","message":"I haven\u0027t given it more thoughts in this case. I just simply copied the behavior from nova-compute, in which nova-compute is started regardless of the virt driver. Perhaps, you are right. We should not start the process if the provided driver is invalid. In addition, the devstack script should die in this case.","commit_id":"73ead98af11c92771303385e5864942e1e49c9ef"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"865bc87a550cd17d323c4f0fc63db51793c60a4c","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    if [[ ${ZUN_DRIVER} \u003d\u003d \"docker\" || ${ZUN_DRIVER} \u003d\u003d \"nova-docker\" ]]; then"},{"line_number":391,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":392,"context_line":"    else"},{"line_number":393,"context_line":"        run_process zun-compute \"$ZUN_BIN_DIR/zun-compute\""},{"line_number":394,"context_line":"    fi"},{"line_number":395,"context_line":"}"},{"line_number":396,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ff0f0b1f_2e2af8d9","line":393,"range":{"start_line":393,"start_character":8,"end_line":393,"end_character":58},"in_reply_to":"ff0f0b1f_770fae87","updated":"2017-05-25 02:00:51.000000000","message":"IMO it\u0027s OK to start zun-compute even if users specify a unsupported driver -- maybe they are doing this on purpose (for testing or developing).\nWe can pop some warning message to notify them zun-compute will not work appropriately in this case and suggest them to re-configure the docker driver after stack.sh completes.","commit_id":"73ead98af11c92771303385e5864942e1e49c9ef"}]}