)]}'
{"zun/conf/docker.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"dd016e904905aae3fafb5ab39c09f0a0f6820d90","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.StrOpt(\u0027docker_remote_api_port\u0027,"},{"line_number":50,"context_line":"               default\u003d\u00272375\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027Defines the remote api port for the docker daemon.\u0027),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027execute_timeout\u0027,"},{"line_number":53,"context_line":"               default\u003d5,"},{"line_number":54,"context_line":"               help\u003d\u0027Timeout in seconds for executing a command in a docker \u0027"},{"line_number":55,"context_line":"                    \u0027container.\u0027),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"ALL_OPTS \u003d (docker_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_6b9d5f58","line":55,"range":{"start_line":52,"start_character":4,"end_line":55,"end_character":34},"updated":"2017-04-24 05:15:09.000000000","message":"@Hongbin, what if we make it user defined in each command?\n\nWill that make negative impact on other users if a user specifies a high value for the timeout?","commit_id":"0e13631b225e6220c1129dbf2fd41bb3cc5eda1a"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f5bf020f4763287c570389017b1dbf193b45387f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.StrOpt(\u0027docker_remote_api_port\u0027,"},{"line_number":50,"context_line":"               default\u003d\u00272375\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027Defines the remote api port for the docker daemon.\u0027),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027execute_timeout\u0027,"},{"line_number":53,"context_line":"               default\u003d5,"},{"line_number":54,"context_line":"               help\u003d\u0027Timeout in seconds for executing a command in a docker \u0027"},{"line_number":55,"context_line":"                    \u0027container.\u0027),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"ALL_OPTS \u003d (docker_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_198a9a1a","line":55,"range":{"start_line":52,"start_character":4,"end_line":55,"end_character":34},"in_reply_to":"5ff73747_6b9d5f58","updated":"2017-04-24 21:15:47.000000000","message":"Yes, i think it will. A large timeout will block the whole thread. In addition, this timeout needs to be smaller than the RPC timeout (otherwise, RPC will disconnect while awaiting for output), and the RPC timeout is internal. Therefore, this timeout is better to be internal.","commit_id":"0e13631b225e6220c1129dbf2fd41bb3cc5eda1a"}]}
