)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"83677edc36fe72b0ca7b93ddb1cc4b1db21e1111","unresolved":false,"context_lines":[{"line_number":11,"context_line":"from the neutron, the value cannot be None."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove the check whether port has been deleted. Follow the guide"},{"line_number":14,"context_line":"that who create the resource should responsible for the delete"},{"line_number":15,"context_line":"of the resource, so zun should not try to delete the port that"},{"line_number":16,"context_line":"not deleted by docker\u0026kuryr-libnetwork."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibb3a5abee0f96e3a5f920efff515f9dfd386b2ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_7cd25502","line":15,"range":{"start_line":14,"start_character":5,"end_line":15,"end_character":14},"updated":"2017-04-26 23:46:30.000000000","message":"I think the neutron port was created by Zun, so Zun needs to delete it according to this statement. However, the deletion process should be robust and be able to handle all the edge cases.","commit_id":"0231c5d378fb20c0c9e89be9700be5493bd005c9"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"53bf7f0042af48127326e6d1854bc90f048f2481","unresolved":false,"context_lines":[{"line_number":11,"context_line":"from the neutron, the value cannot be None."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove the check whether port has been deleted. Follow the guide"},{"line_number":14,"context_line":"that who create the resource should responsible for the delete"},{"line_number":15,"context_line":"of the resource, so zun should not try to delete the port that"},{"line_number":16,"context_line":"not deleted by docker\u0026kuryr-libnetwork."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibb3a5abee0f96e3a5f920efff515f9dfd386b2ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_c75752ca","line":15,"range":{"start_line":14,"start_character":5,"end_line":15,"end_character":14},"in_reply_to":"5ff73747_7cd25502","updated":"2017-04-27 00:49:21.000000000","message":"Ah, you are right. The ported is created by zun.","commit_id":"0231c5d378fb20c0c9e89be9700be5493bd005c9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0dbdd77935989e51e7036dc3cc3a540aed71465a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"not deleted by docker\u0026kuryr-libnetwork."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibb3a5abee0f96e3a5f920efff515f9dfd386b2ec"},{"line_number":19,"context_line":"Close-bug: #1686312"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_41f1f294","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":19},"updated":"2017-04-26 23:44:57.000000000","message":"Hi @Shunli,\n\nI couldn\u0027t reproduce this bug although I followed the steps closely. Do you know why the neutron port could not be found as shown in the bug?","commit_id":"0231c5d378fb20c0c9e89be9700be5493bd005c9"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"53bf7f0042af48127326e6d1854bc90f048f2481","unresolved":false,"context_lines":[{"line_number":16,"context_line":"not deleted by docker\u0026kuryr-libnetwork."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibb3a5abee0f96e3a5f920efff515f9dfd386b2ec"},{"line_number":19,"context_line":"Close-bug: #1686312"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_475222e0","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":19},"in_reply_to":"5ff73747_41f1f294","updated":"2017-04-27 00:49:21.000000000","message":"I debugged the code， before https://github.com/openstack/zun/blob/master/zun/network/kuryr_network.py#L158, the neutron port still exist, but after this code executed, the neutron port is gone. And the follow deletion will fail. So I guess the docker will call libnetwork to delete the port when delete container.\n\nNothing special, there are two neutron network pre-created, and then create the zun container, stop it and delete it.\n\nMy kuryr-libnetwork is started in a container and follow the kurr-libnetwork document.","commit_id":"0231c5d378fb20c0c9e89be9700be5493bd005c9"}],"zun/network/kuryr_network.py":[{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"1e73fc608367f6d3cf76d7bb69ed7e6e5793e275","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                port_id \u003d neutron_ports[0][\u0027id\u0027]"},{"line_number":163,"context_line":"                self.neutron.delete_port(port_id)"},{"line_number":164,"context_line":"            except Exception:"},{"line_number":165,"context_line":"                LOG.info(\u0027Maybe your libnetwork distribution do not have patch\u0027"},{"line_number":166,"context_line":"                         \u0027 https://review.openstack.org/#/c/441024/ or neutron\u0027"},{"line_number":167,"context_line":"                         \u0027 tag extension does not supported or not enabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_4c9c8269","line":167,"range":{"start_line":164,"start_character":12,"end_line":167,"end_character":77},"updated":"2017-04-27 06:01:35.000000000","message":"instead of handling all exceptions, do we need to handle only exception for port not found and re-raise for others?","commit_id":"1e2fad92d9a282ac168d3795883e15d1b83fce6b"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"acdc5c7f7150ecb3e79f60b4003b3342d146d29d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            try:"},{"line_number":162,"context_line":"                port_id \u003d neutron_ports[0][\u0027id\u0027]"},{"line_number":163,"context_line":"                self.neutron.delete_port(port_id)"},{"line_number":164,"context_line":"            except Exception:"},{"line_number":165,"context_line":"                LOG.info(\u0027Maybe your libnetwork distribution do not have patch\u0027"},{"line_number":166,"context_line":"                         \u0027 https://review.openstack.org/#/c/441024/ or neutron\u0027"},{"line_number":167,"context_line":"                         \u0027 tag extension does not supported or not enabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_ec37cefe","line":167,"range":{"start_line":164,"start_character":12,"end_line":167,"end_character":77},"in_reply_to":"5ff73747_4c9c8269","updated":"2017-04-27 06:35:57.000000000","message":"Sure. Just catch the PortNotFoundClient exception, other exception raise to outter to handle.","commit_id":"1e2fad92d9a282ac168d3795883e15d1b83fce6b"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"88b035f3458b73954161a8ed5905c67510f6c9a5","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                port_id \u003d neutron_ports[0][\u0027id\u0027]"},{"line_number":164,"context_line":"                self.neutron.delete_port(port_id)"},{"line_number":165,"context_line":"            except exceptions.PortNotFoundClient:"},{"line_number":166,"context_line":"                LOG.info(\u0027Maybe your libnetwork distribution do not have patch\u0027"},{"line_number":167,"context_line":"                         \u0027 https://review.openstack.org/#/c/441024/ or neutron\u0027"},{"line_number":168,"context_line":"                         \u0027 tag extension does not supported or not enabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_404323b0","line":166,"range":{"start_line":166,"start_character":16,"end_line":166,"end_character":24},"updated":"2017-04-27 08:56:31.000000000","message":"A warn is better. This isn\u0027t a normal behavior, should highlight.","commit_id":"7807965a8a81fdecd538d221c2e253ba6e895155"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"a876ca5fbc4f103b3fa2733cb00a9dbe0aef2d97","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                port_id \u003d neutron_ports[0][\u0027id\u0027]"},{"line_number":164,"context_line":"                self.neutron.delete_port(port_id)"},{"line_number":165,"context_line":"            except exceptions.PortNotFoundClient:"},{"line_number":166,"context_line":"                LOG.info(\u0027Maybe your libnetwork distribution do not have patch\u0027"},{"line_number":167,"context_line":"                         \u0027 https://review.openstack.org/#/c/441024/ or neutron\u0027"},{"line_number":168,"context_line":"                         \u0027 tag extension does not supported or not enabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_00219bb0","line":166,"range":{"start_line":166,"start_character":16,"end_line":166,"end_character":24},"in_reply_to":"5ff73747_404323b0","updated":"2017-04-27 09:05:41.000000000","message":"Done","commit_id":"7807965a8a81fdecd538d221c2e253ba6e895155"}]}