)]}'
{"zun/scheduler/filter_scheduler.py":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"e013f2a0aae1a7bb45b0d26ef391f54da2380ec4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        hosts \u003d self.hosts_up(context)\r"},{"line_number":46,"context_line":"        nodes \u003d objects.ComputeNode.list(context)\r"},{"line_number":47,"context_line":"        nodes \u003d [node for node in nodes if node.hostname in hosts]\r"},{"line_number":48,"context_line":"        hosts \u003d self.filter_handler.get_filtered_objects(self.enabled_filters,\r"},{"line_number":49,"context_line":"                                                         nodes,\r"},{"line_number":50,"context_line":"                                                         container)\r"},{"line_number":51,"context_line":"        if not hosts:\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_aacfd827","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":13},"updated":"2017-05-03 04:01:23.000000000","message":"LGTM!\nThe variable name \"hosts\" in L45 and L48 are easily confused.","commit_id":"3429ab68326fdbfc3116387aa89df8b578a34204"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"8c26e2fb72e6550126cc1ba02aba47cad6bf6446","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        hosts \u003d self.hosts_up(context)\r"},{"line_number":46,"context_line":"        nodes \u003d objects.ComputeNode.list(context)\r"},{"line_number":47,"context_line":"        nodes \u003d [node for node in nodes if node.hostname in hosts]\r"},{"line_number":48,"context_line":"        hosts \u003d self.filter_handler.get_filtered_objects(self.enabled_filters,\r"},{"line_number":49,"context_line":"                                                         nodes,\r"},{"line_number":50,"context_line":"                                                         container)\r"},{"line_number":51,"context_line":"        if not hosts:\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_e84ba85c","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":13},"in_reply_to":"5ff73747_aacfd827","updated":"2017-05-03 05:39:17.000000000","message":"+1, it is better if change the name of the variables.","commit_id":"3429ab68326fdbfc3116387aa89df8b578a34204"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"9c415b08afdead4227b8d7de85d9f8e9a87643a7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        hosts \u003d self.hosts_up(context)\r"},{"line_number":46,"context_line":"        nodes \u003d objects.ComputeNode.list(context)\r"},{"line_number":47,"context_line":"        nodes \u003d [node for node in nodes if node.hostname in hosts]\r"},{"line_number":48,"context_line":"        hosts \u003d self.filter_handler.get_filtered_objects(self.enabled_filters,\r"},{"line_number":49,"context_line":"                                                         nodes,\r"},{"line_number":50,"context_line":"                                                         container)\r"},{"line_number":51,"context_line":"        if not hosts:\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_b9bf34cf","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":13},"in_reply_to":"5ff73747_aacfd827","updated":"2017-05-03 08:07:14.000000000","message":"Done","commit_id":"3429ab68326fdbfc3116387aa89df8b578a34204"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"9c415b08afdead4227b8d7de85d9f8e9a87643a7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        hosts \u003d self.hosts_up(context)\r"},{"line_number":46,"context_line":"        nodes \u003d objects.ComputeNode.list(context)\r"},{"line_number":47,"context_line":"        nodes \u003d [node for node in nodes if node.hostname in hosts]\r"},{"line_number":48,"context_line":"        hosts \u003d self.filter_handler.get_filtered_objects(self.enabled_filters,\r"},{"line_number":49,"context_line":"                                                         nodes,\r"},{"line_number":50,"context_line":"                                                         container)\r"},{"line_number":51,"context_line":"        if not hosts:\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_79b9ace7","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":13},"in_reply_to":"5ff73747_e84ba85c","updated":"2017-05-03 08:07:14.000000000","message":"Done","commit_id":"3429ab68326fdbfc3116387aa89df8b578a34204"}],"zun/scheduler/filters/cpu_filter.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e793eb46b2415dcc91da8d7eebb18f269a13de1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def host_passes(self, host_state, container):"},{"line_number":29,"context_line":"        cpu_free \u003d host_state.cpus - host_state.cpu_used"},{"line_number":30,"context_line":"        if cpu_free \u003c container.cpu:"},{"line_number":31,"context_line":"            LOG.debug(\"%(host_state)s does not have %(container_vcpus).2f \""},{"line_number":32,"context_line":"                      \"usable vcpus, it only has %(free_vcpus).2f usable \""},{"line_number":33,"context_line":"                      \"vcpus\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_9cfeba03","line":30,"range":{"start_line":30,"start_character":32,"end_line":30,"end_character":35},"updated":"2017-05-04 04:22:07.000000000","message":"I think it need to handle the case that container.cpu is None (compare cpu_free with None doesn\u0027t seem right).","commit_id":"b55985c658e93827a88b80fb75f42cae47d7a86a"}]}