)]}'
{"zun/compute/claims.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"\"\"For use with compute drivers that do not support resource tracking.\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":32,"context_line":"        self.migration \u003d kwargs.pop(\u0027migration\u0027, None)"},{"line_number":33,"context_line":"        self.claimed_numa_topology \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_9c88f771","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":22},"updated":"2017-05-17 22:48:42.000000000","message":"I don\u0027t think Zun supports container migration as Nova did for virtual machines.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"\"\"For use with compute drivers that do not support resource tracking.\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":32,"context_line":"        self.migration \u003d kwargs.pop(\u0027migration\u0027, None)"},{"line_number":33,"context_line":"        self.claimed_numa_topology \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_5224830d","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":22},"in_reply_to":"ff0f0b1f_9c88f771","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        pass"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __str__(self):"},{"line_number":54,"context_line":"        return \"[Claim: %d MB memory, %d VCPU]\" % (self.memory,"},{"line_number":55,"context_line":"                                                   self.cpu)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_e2bbc80b","line":54,"range":{"start_line":54,"start_character":39,"end_line":54,"end_character":40},"updated":"2017-05-17 22:48:42.000000000","message":"Cpu is a floating number.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        pass"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __str__(self):"},{"line_number":54,"context_line":"        return \"[Claim: %d MB memory, %d VCPU]\" % (self.memory,"},{"line_number":55,"context_line":"                                                   self.cpu)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_02bfdcfb","line":54,"range":{"start_line":54,"start_character":25,"end_line":54,"end_character":26},"updated":"2017-05-17 22:48:42.000000000","message":"Memory is a string (i.e. \"512M\"), so the format is wrong.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        pass"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __str__(self):"},{"line_number":54,"context_line":"        return \"[Claim: %d MB memory, %d VCPU]\" % (self.memory,"},{"line_number":55,"context_line":"                                                   self.cpu)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_f2c6f716","line":54,"range":{"start_line":54,"start_character":25,"end_line":54,"end_character":26},"in_reply_to":"ff0f0b1f_02bfdcfb","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        pass"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __str__(self):"},{"line_number":54,"context_line":"        return \"[Claim: %d MB memory, %d VCPU]\" % (self.memory,"},{"line_number":55,"context_line":"                                                   self.cpu)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_92d57bbc","line":54,"range":{"start_line":54,"start_character":39,"end_line":54,"end_character":40},"in_reply_to":"ff0f0b1f_e2bbc80b","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def abort(self):"},{"line_number":93,"context_line":"        \"\"\"Requiring claimed resources has failed or been aborted.\"\"\""},{"line_number":94,"context_line":"        LOG.debug(\"Aborting claim: %s\", self, container\u003dself.container)"},{"line_number":95,"context_line":"        self.tracker.abort_container_claim(self.context, self.container,"},{"line_number":96,"context_line":"                                           self.hostname)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_3c4a0b27","line":94,"range":{"start_line":94,"start_character":46,"end_line":94,"end_character":70},"updated":"2017-05-17 22:48:42.000000000","message":"this parameter is unused?","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def abort(self):"},{"line_number":93,"context_line":"        \"\"\"Requiring claimed resources has failed or been aborted.\"\"\""},{"line_number":94,"context_line":"        LOG.debug(\"Aborting claim: %s\", self, container\u003dself.container)"},{"line_number":95,"context_line":"        self.tracker.abort_container_claim(self.context, self.container,"},{"line_number":96,"context_line":"                                           self.hostname)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_e5fe2f04","line":94,"range":{"start_line":94,"start_character":46,"end_line":94,"end_character":70},"in_reply_to":"ff0f0b1f_3c4a0b27","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If an individual limit is None, the resource will be considered"},{"line_number":113,"context_line":"        # unlimited:"},{"line_number":114,"context_line":"        memory_limit \u003d limits.get(\u0027memory\u0027)"},{"line_number":115,"context_line":"        cpu_limit \u003d limits.get(\u0027cpu\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        LOG.info(_(\"Attempting claim: memory %(memory)s, \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_c2bd6469","line":114,"range":{"start_line":114,"start_character":23,"end_line":114,"end_character":29},"updated":"2017-05-17 22:48:42.000000000","message":"This doesn\u0027t work very well because \u0027limits\u0027 is always an empty dict. Therefore, this test always passed. We needs to populate the limits somewhere to make this test work. For example, Nova populated it in filters:\n\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/filters/core_filter.py#L52\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/filters/ram_filter.py#L63","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If an individual limit is None, the resource will be considered"},{"line_number":113,"context_line":"        # unlimited:"},{"line_number":114,"context_line":"        memory_limit \u003d limits.get(\u0027memory\u0027)"},{"line_number":115,"context_line":"        cpu_limit \u003d limits.get(\u0027cpu\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        LOG.info(_(\"Attempting claim: memory %(memory)s, \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_a556f705","line":114,"range":{"start_line":114,"start_character":23,"end_line":114,"end_character":29},"in_reply_to":"ff0f0b1f_3dc5658f","updated":"2017-05-18 02:19:29.000000000","message":"yeah, I would like to split it up and fix it later. Now we just update the resource claim, no limits specified.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"db8b13d2c118388f24fcee573e0ee38b8a6cb64a","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If an individual limit is None, the resource will be considered"},{"line_number":113,"context_line":"        # unlimited:"},{"line_number":114,"context_line":"        memory_limit \u003d limits.get(\u0027memory\u0027)"},{"line_number":115,"context_line":"        cpu_limit \u003d limits.get(\u0027cpu\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        LOG.info(_(\"Attempting claim: memory %(memory)s, \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_3dc5658f","line":114,"range":{"start_line":114,"start_character":23,"end_line":114,"end_character":29},"in_reply_to":"ff0f0b1f_c2bd6469","updated":"2017-05-17 23:08:56.000000000","message":"I am fine if you want to fix this in a separated patch. It seems the fix won\u0027t be trivial. I created a ticket for that: https://bugs.launchpad.net/zun/+bug/1691587","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        LOG.info(_(\u0027Total %(type)s: %(total)d %(unit)s, used: %(used).02f \u0027"},{"line_number":153,"context_line":"                   \u0027%(unit)s\u0027),"},{"line_number":154,"context_line":"                 {\u0027type\u0027: type_, \u0027total\u0027: total, \u0027unit\u0027: unit, \u0027used\u0027: used},"},{"line_number":155,"context_line":"                 container\u003dself.container)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if limit is None:"},{"line_number":158,"context_line":"            # treat resource as unlimited:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_e255081f","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":26},"updated":"2017-05-17 22:48:42.000000000","message":"It seems this variable is unsed.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        LOG.info(_(\u0027Total %(type)s: %(total)d %(unit)s, used: %(used).02f \u0027"},{"line_number":153,"context_line":"                   \u0027%(unit)s\u0027),"},{"line_number":154,"context_line":"                 {\u0027type\u0027: type_, \u0027total\u0027: total, \u0027unit\u0027: unit, \u0027used\u0027: used},"},{"line_number":155,"context_line":"                 container\u003dself.container)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if limit is None:"},{"line_number":158,"context_line":"            # treat resource as unlimited:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_256307df","line":155,"range":{"start_line":155,"start_character":17,"end_line":155,"end_character":26},"in_reply_to":"ff0f0b1f_e255081f","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if requested \u003e free:"},{"line_number":172,"context_line":"            return (_(\u0027Free %(type)s %(free).02f \u0027"},{"line_number":173,"context_line":"                      \u0027%(unit)s \u003c requested %(requested)d %(unit)s\u0027) %"},{"line_number":174,"context_line":"                    {\u0027type\u0027: type_, \u0027free\u0027: free, \u0027unit\u0027: unit,"},{"line_number":175,"context_line":"                     \u0027requested\u0027: requested})"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_a235d0f9","line":173,"range":{"start_line":173,"start_character":56,"end_line":173,"end_character":57},"updated":"2017-05-17 22:48:42.000000000","message":"requested could be a floating number (i.e. cpu) or a string (i.e. memory). Suggest to change this to string instead.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if requested \u003e free:"},{"line_number":172,"context_line":"            return (_(\u0027Free %(type)s %(free).02f \u0027"},{"line_number":173,"context_line":"                      \u0027%(unit)s \u003c requested %(requested)d %(unit)s\u0027) %"},{"line_number":174,"context_line":"                    {\u0027type\u0027: type_, \u0027free\u0027: free, \u0027unit\u0027: unit,"},{"line_number":175,"context_line":"                     \u0027requested\u0027: requested})"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_e5d18f59","line":173,"range":{"start_line":173,"start_character":56,"end_line":173,"end_character":57},"in_reply_to":"ff0f0b1f_a235d0f9","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"}],"zun/compute/compute_node_tracker.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                  during the container build."},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        # No memory and cpu specified, no need to claim resource now."},{"line_number":83,"context_line":"        if not (container.memory and container.cpu):"},{"line_number":84,"context_line":"            return claims.NopClaim()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # We should have the compute node created here, just get it."}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_b193e44f","line":83,"range":{"start_line":83,"start_character":11,"end_line":83,"end_character":51},"updated":"2017-05-17 22:48:42.000000000","message":"I think this condition is too strong. We should claim resources if there is either cpu or memory specified. Otherwise, \"zun run --cpu 0.1 nginx\" won\u0027t claim the cpu resource since its memory will be None thus returning NoClaim here.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                  during the container build."},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        # No memory and cpu specified, no need to claim resource now."},{"line_number":83,"context_line":"        if not (container.memory and container.cpu):"},{"line_number":84,"context_line":"            return claims.NopClaim()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # We should have the compute node created here, just get it."}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_45703b73","line":83,"range":{"start_line":83,"start_character":11,"end_line":83,"end_character":51},"in_reply_to":"ff0f0b1f_b193e44f","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # TODO(Shunli): Calculate the numa usage here"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _update(self, context, compute_node):"},{"line_number":176,"context_line":"        if not self._resource_change(compute_node):"},{"line_number":177,"context_line":"            return"},{"line_number":178,"context_line":"        # Persist the stats to the Scheduler"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_bcb73bd9","line":175,"range":{"start_line":175,"start_character":22,"end_line":175,"end_character":29},"updated":"2017-05-17 22:48:42.000000000","message":"context is unused?","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # TODO(Shunli): Calculate the numa usage here"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _update(self, context, compute_node):"},{"line_number":176,"context_line":"        if not self._resource_change(compute_node):"},{"line_number":177,"context_line":"            return"},{"line_number":178,"context_line":"        # Persist the stats to the Scheduler"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_65e69f19","line":175,"range":{"start_line":175,"start_character":22,"end_line":175,"end_character":29},"in_reply_to":"ff0f0b1f_bcb73bd9","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                  with updates"},{"line_number":228,"context_line":"        \"\"\""},{"line_number":229,"context_line":"        usage \u003d {}"},{"line_number":230,"context_line":"        if isinstance(object_or_dict, objects.Container):"},{"line_number":231,"context_line":"            # (Fixme): The Container.memory is string."},{"line_number":232,"context_line":"            memory \u003d 0"},{"line_number":233,"context_line":"            if object_or_dict.memory:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_3cb1eb90","line":230,"range":{"start_line":230,"start_character":22,"end_line":230,"end_character":36},"updated":"2017-05-17 22:48:42.000000000","message":"It seems this will always be object. If this is the case, this check doesn\u0027t seem to be needed.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                  with updates"},{"line_number":228,"context_line":"        \"\"\""},{"line_number":229,"context_line":"        usage \u003d {}"},{"line_number":230,"context_line":"        if isinstance(object_or_dict, objects.Container):"},{"line_number":231,"context_line":"            # (Fixme): The Container.memory is string."},{"line_number":232,"context_line":"            memory \u003d 0"},{"line_number":233,"context_line":"            if object_or_dict.memory:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_259e6763","line":230,"range":{"start_line":230,"start_character":22,"end_line":230,"end_character":36},"in_reply_to":"ff0f0b1f_3cb1eb90","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"72da9a0277fdbde6fda674872889e97791f7d302","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self._update_usage_from_container(container, hostname)"},{"line_number":97,"context_line":"        elevated \u003d context.elevated()"},{"line_number":98,"context_line":"        # persist changes to the compute node:"},{"line_number":99,"context_line":"        self._update(elevated, self.compute_node)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return claim"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_28b87e28","line":99,"range":{"start_line":99,"start_character":21,"end_line":99,"end_character":29},"updated":"2017-05-18 02:45:03.000000000","message":"This parameter was removed.","commit_id":"d94712460527b9da69d3ee3c7d1cdb0ba9793e2d"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"e1f322f5f4e832f2afb1296a47f3a8e6eb24f3df","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self._update_usage_from_container(container, hostname)"},{"line_number":97,"context_line":"        elevated \u003d context.elevated()"},{"line_number":98,"context_line":"        # persist changes to the compute node:"},{"line_number":99,"context_line":"        self._update(elevated, self.compute_node)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return claim"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_487a9224","line":99,"range":{"start_line":99,"start_character":21,"end_line":99,"end_character":29},"in_reply_to":"ff0f0b1f_28b87e28","updated":"2017-05-18 08:25:50.000000000","message":"Done","commit_id":"d94712460527b9da69d3ee3c7d1cdb0ba9793e2d"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"72da9a0277fdbde6fda674872889e97791f7d302","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        cn \u003d self.compute_node"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        # update the compute_node"},{"line_number":211,"context_line":"        self._update(context, cn)"},{"line_number":212,"context_line":"        LOG.debug(\u0027Compute_service record updated for %(host)s\u0027,"},{"line_number":213,"context_line":"                  {\u0027host\u0027: self.host})"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_486612f0","line":211,"range":{"start_line":211,"start_character":21,"end_line":211,"end_character":28},"updated":"2017-05-18 02:45:03.000000000","message":"This method doesn\u0027t take context anymore.","commit_id":"d94712460527b9da69d3ee3c7d1cdb0ba9793e2d"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"e1f322f5f4e832f2afb1296a47f3a8e6eb24f3df","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        cn \u003d self.compute_node"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        # update the compute_node"},{"line_number":211,"context_line":"        self._update(context, cn)"},{"line_number":212,"context_line":"        LOG.debug(\u0027Compute_service record updated for %(host)s\u0027,"},{"line_number":213,"context_line":"                  {\u0027host\u0027: self.host})"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_28775e3d","line":211,"range":{"start_line":211,"start_character":21,"end_line":211,"end_character":28},"in_reply_to":"ff0f0b1f_486612f0","updated":"2017-05-18 08:25:50.000000000","message":"Done","commit_id":"d94712460527b9da69d3ee3c7d1cdb0ba9793e2d"}],"zun/compute/manager.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"bff2ad8c27c6c8db8cf53af4240b16291ddd6552","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                                               sandbox_id, image)"},{"line_number":137,"context_line":"                container.task_state \u003d None"},{"line_number":138,"context_line":"                container.save(context)"},{"line_number":139,"context_line":"                return container"},{"line_number":140,"context_line":"        except exception.DockerError as e:"},{"line_number":141,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":142,"context_line":"                LOG.error(\"Error occurred while calling Docker create API: %s\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_ff71f00d","line":139,"updated":"2017-05-19 09:15:37.000000000","message":"We also want to release the claim on container delete. Isn\u0027t it?","commit_id":"66d790135f47c25964def3170b5c4552c9e8fa5d"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"032fca8e55dad9e93074b338cff60c63da0adbbf","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                                               sandbox_id, image)"},{"line_number":137,"context_line":"                container.task_state \u003d None"},{"line_number":138,"context_line":"                container.save(context)"},{"line_number":139,"context_line":"                return container"},{"line_number":140,"context_line":"        except exception.DockerError as e:"},{"line_number":141,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":142,"context_line":"                LOG.error(\"Error occurred while calling Docker create API: %s\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_7f496089","line":139,"in_reply_to":"ff0f0b1f_ff71f00d","updated":"2017-05-19 09:20:20.000000000","message":"yeah, refer to the commit message. It will be done in another patch. Do not want to get this patch too big.","commit_id":"66d790135f47c25964def3170b5c4552c9e8fa5d"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                        cpu_used +\u003d float(nanocpus) / 1e9"},{"line_number":636,"context_line":"            return cpu_used"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def get_available_nodes(self, refresh\u003dFalse):"},{"line_number":639,"context_line":"        return [self._host.get_hostname()]"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_3740e435","line":638,"range":{"start_line":638,"start_character":34,"end_line":638,"end_character":41},"updated":"2017-05-17 22:48:42.000000000","message":"It seems we don\u0027t have use cases for refresh? If there is no use case, how about removing it.","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                        cpu_used +\u003d float(nanocpus) / 1e9"},{"line_number":636,"context_line":"            return cpu_used"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def get_available_nodes(self, refresh\u003dFalse):"},{"line_number":639,"context_line":"        return [self._host.get_hostname()]"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_459f1b50","line":638,"range":{"start_line":638,"start_character":34,"end_line":638,"end_character":41},"in_reply_to":"ff0f0b1f_3740e435","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"}],"zun/container/docker/host.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9b7e79ede1af004792ffadb43ef40c47e0b5e0e4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            if self._hostname is None:"},{"line_number":35,"context_line":"                self._hostname \u003d hostname"},{"line_number":36,"context_line":"            elif hostname !\u003d self._hostname:"},{"line_number":37,"context_line":"                LOG.error(_(\u0027Hostname has changed from %(old)s \u0027"},{"line_number":38,"context_line":"                            \u0027to %(new)s. A restart is required \u0027"},{"line_number":39,"context_line":"                            \u0027to take effect.\u0027),"},{"line_number":40,"context_line":"                          {\u0027old\u0027: self._hostname,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_9703300e","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":25},"updated":"2017-05-17 22:48:42.000000000","message":"This is logged as error but no exception is thrown, which seems to be inconsistent. I think we should log it as warning/info if no exception is thrown. Alternatively, we could log it as error and throw an exception. What do you think?","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"488738eb4d48cc10eafac82c6d373c6947ee7c0b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            if self._hostname is None:"},{"line_number":35,"context_line":"                self._hostname \u003d hostname"},{"line_number":36,"context_line":"            elif hostname !\u003d self._hostname:"},{"line_number":37,"context_line":"                LOG.error(_(\u0027Hostname has changed from %(old)s \u0027"},{"line_number":38,"context_line":"                            \u0027to %(new)s. A restart is required \u0027"},{"line_number":39,"context_line":"                            \u0027to take effect.\u0027),"},{"line_number":40,"context_line":"                          {\u0027old\u0027: self._hostname,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_e5dcef19","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":25},"in_reply_to":"ff0f0b1f_9703300e","updated":"2017-05-18 02:19:29.000000000","message":"Done","commit_id":"fa1cc482b085f14292dc8f00ff55776ac73c4d36"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"72da9a0277fdbde6fda674872889e97791f7d302","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            if self._hostname is None:"},{"line_number":35,"context_line":"                self._hostname \u003d hostname"},{"line_number":36,"context_line":"            elif hostname !\u003d self._hostname:"},{"line_number":37,"context_line":"                LOG.warning(_(\u0027Hostname has changed from %(old)s \u0027"},{"line_number":38,"context_line":"                              \u0027to %(new)s. A restart is required \u0027"},{"line_number":39,"context_line":"                              \u0027to take effect.\u0027),"},{"line_number":40,"context_line":"                            {\u0027old\u0027: self._hostname,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_284abe54","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":27},"updated":"2017-05-18 02:45:03.000000000","message":"How about assigning the new hostname after:\n\n  self._hostname \u003d hostname","commit_id":"d94712460527b9da69d3ee3c7d1cdb0ba9793e2d"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"e1f322f5f4e832f2afb1296a47f3a8e6eb24f3df","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            if self._hostname is None:"},{"line_number":35,"context_line":"                self._hostname \u003d hostname"},{"line_number":36,"context_line":"            elif hostname !\u003d self._hostname:"},{"line_number":37,"context_line":"                LOG.warning(_(\u0027Hostname has changed from %(old)s \u0027"},{"line_number":38,"context_line":"                              \u0027to %(new)s. A restart is required \u0027"},{"line_number":39,"context_line":"                              \u0027to take effect.\u0027),"},{"line_number":40,"context_line":"                            {\u0027old\u0027: self._hostname,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_28acfe8a","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":27},"in_reply_to":"ff0f0b1f_284abe54","updated":"2017-05-18 08:25:50.000000000","message":"Done","commit_id":"d94712460527b9da69d3ee3c7d1cdb0ba9793e2d"}]}
