)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6494f289ba2eeed7c43f393f61bfe725a33a6228","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This patch works well with DockerDriver, but currently"},{"line_number":11,"context_line":"not sure how it will work with NovaDockerDriver since sandbox"},{"line_number":12,"context_line":"container lies in differnt tenant."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I649fa55357ee6a8ec8221818a2de5466578491e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f013ff3_3840d035","line":11,"range":{"start_line":11,"start_character":31,"end_line":11,"end_character":47},"updated":"2017-05-14 03:21:47.000000000","message":"I would suggest to skip this driver for now. Until this BP is implemented https://review.openstack.org/#/c/438134/ , I don\u0027t have a better idea to bring the sandbox instance back to user\u0027s tenant.","commit_id":"d9f4251434f356ce3af744a4e77f8971ed8ada1e"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"d45420cf2903ca8f6aca371a2f72dd44d5dcee2b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This patch works well with DockerDriver, but currently"},{"line_number":11,"context_line":"not sure how it will work with NovaDockerDriver since sandbox"},{"line_number":12,"context_line":"container lies in differnt tenant."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I649fa55357ee6a8ec8221818a2de5466578491e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f013ff3_dd3e5028","line":11,"range":{"start_line":11,"start_character":31,"end_line":11,"end_character":47},"in_reply_to":"1f013ff3_3840d035","updated":"2017-05-16 08:56:48.000000000","message":"I have added a check at api layer, it will raise an exception when security_groups parameter is used with NovaDockerDriver. I can add that at compute layer but that will make little bit hard to debug for developers. Please let me know your opinion.","commit_id":"d9f4251434f356ce3af744a4e77f8971ed8ada1e"}],"zun/api/controllers/v1/containers.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"25863d6d3b1290f51a5e17a5aa1de462b3ba2722","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # security_groups is provided and container driver"},{"line_number":214,"context_line":"        # is NovaDockerDriver, i will look into how"},{"line_number":215,"context_line":"        # to handle the security_groups with NovaDockerDriver"},{"line_number":216,"context_line":"        if container_dict.get(\u0027security_groups\u0027) and\\"},{"line_number":217,"context_line":"                CONF.container_driver \u003d\u003d \u0027docker.driver.NovaDockerDriver\u0027:"},{"line_number":218,"context_line":"            msg \u003d _(\"security_groups is not supported with NovaDockerDriver\")"},{"line_number":219,"context_line":"            raise exception.InvalidValue(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_50d34739","line":216,"range":{"start_line":216,"start_character":52,"end_line":216,"end_character":53},"updated":"2017-05-16 09:27:13.000000000","message":"parentheses is better","commit_id":"d692c7f28c93812f35a3e1baf0bd371850433ad2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b25a47d2282214ae7141b1fd71d151c31e52ebbd","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # is NovaDockerDriver, i will look into how"},{"line_number":216,"context_line":"        # to handle the security_groups with NovaDockerDriver"},{"line_number":217,"context_line":"        if (container_dict.get(\u0027security_groups\u0027) and"},{"line_number":218,"context_line":"                CONF.container_driver \u003d\u003d \u0027docker.driver.NovaDockerDriver\u0027):"},{"line_number":219,"context_line":"            msg \u003d _(\"security_groups is not supported with NovaDockerDriver\")"},{"line_number":220,"context_line":"            raise exception.InvalidValue(msg)"},{"line_number":221,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_263633e8","line":218,"range":{"start_line":218,"start_character":21,"end_line":218,"end_character":37},"updated":"2017-05-16 21:50:16.000000000","message":"This config reside on compute node (not api node), so I think it is better to do this check in zun-compute.","commit_id":"f12d2e66d965824cc843ef851b04634a18530bcd"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b25a47d2282214ae7141b1fd71d151c31e52ebbd","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":272,"context_line":"    @exception.wrap_pecan_controller_exception"},{"line_number":273,"context_line":"    @validation.validated(schema.add_security_groups)"},{"line_number":274,"context_line":"    def add_security_groups(self, container_id, **security_groups):"},{"line_number":275,"context_line":"        \"\"\"Add security groups to an existing container."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        :param security_groups: a json list of security groups."}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_85a17cac","line":274,"range":{"start_line":274,"start_character":8,"end_line":274,"end_character":27},"updated":"2017-05-16 21:50:16.000000000","message":"Pradeep,\n\nI think it is better to modify this API to accept a single security group (i.e. add_security_group). I suggested that because it will make the API consistent with Nova: https://developer.openstack.org/api-ref/compute/?expanded\u003dadd-security-group-to-a-server-addsecuritygroup-action-detail#add-security-group-to-a-server-addsecuritygroup-action . In addition, I think the implementation would looks more elegant if the security group are processed one-by-one.","commit_id":"f12d2e66d965824cc843ef851b04634a18530bcd"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b25a47d2282214ae7141b1fd71d151c31e52ebbd","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            raise exception.InvalidValue(msg % ("},{"line_number":296,"context_line":"                \u0027,\u0027.join(common_security_groups)))"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        check_policy_on_container("},{"line_number":299,"context_line":"            container.as_dict(), \"container:add_security_groups\")"},{"line_number":300,"context_line":"        utils.validate_container_state(container, \u0027add_security_groups\u0027)"},{"line_number":301,"context_line":"        context \u003d pecan.request.context"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_a5c0f82b","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":33},"updated":"2017-05-16 21:50:16.000000000","message":"I think this check should move to the beginning.","commit_id":"f12d2e66d965824cc843ef851b04634a18530bcd"}],"zun/compute/api.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6494f289ba2eeed7c43f393f61bfe725a33a6228","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def container_get_archive(self, context, container, *args):"},{"line_number":107,"context_line":"        return self.rpcapi.container_get_archive(context, container, *args)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def add_security_groups(self, context, container, *args):"},{"line_number":110,"context_line":"        return self.rpcapi.add_security_groups(context, container, *args)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def container_put_archive(self, context, container, *args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_585b9c2d","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":27},"updated":"2017-05-14 03:21:47.000000000","message":"It looks this api is not used?","commit_id":"d9f4251434f356ce3af744a4e77f8971ed8ada1e"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"d45420cf2903ca8f6aca371a2f72dd44d5dcee2b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def container_get_archive(self, context, container, *args):"},{"line_number":107,"context_line":"        return self.rpcapi.container_get_archive(context, container, *args)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def add_security_groups(self, context, container, *args):"},{"line_number":110,"context_line":"        return self.rpcapi.add_security_groups(context, container, *args)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def container_put_archive(self, context, container, *args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_bd24a40e","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":27},"in_reply_to":"1f013ff3_585b9c2d","updated":"2017-05-16 08:56:48.000000000","message":"It\u0027s used now  to update i.e. add other security groups to container once the container is created.","commit_id":"d9f4251434f356ce3af744a4e77f8971ed8ada1e"}],"zun/container/docker/driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b25a47d2282214ae7141b1fd71d151c31e52ebbd","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                **search_opts).get(\u0027security_groups\u0027, [])"},{"line_number":505,"context_line":"            security_group_ids \u003d [item[\u0027id\u0027] for item in security_groups_list"},{"line_number":506,"context_line":"                                  if item[\u0027name\u0027] in security_groups]"},{"line_number":507,"context_line":"            if len(security_group_ids) \u003d\u003d len(security_groups):"},{"line_number":508,"context_line":"                return security_group_ids"},{"line_number":509,"context_line":"            else:"},{"line_number":510,"context_line":"                raise exception.ZunException(_("}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_a516b8f0","line":507,"range":{"start_line":507,"start_character":46,"end_line":507,"end_character":61},"updated":"2017-05-16 21:50:16.000000000","message":"I think it is better to remove duplicated item in this list first.","commit_id":"f12d2e66d965824cc843ef851b04634a18530bcd"}],"zun/network/kuryr_network.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b25a47d2282214ae7141b1fd71d151c31e52ebbd","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                            \u0027or neutron tag extension does not supported or\u0027"},{"line_number":172,"context_line":"                            \u0027 not enabled.\u0027)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def add_security_group_to_port(self, container, network_name,"},{"line_number":175,"context_line":"                                   security_group_ids):"},{"line_number":176,"context_line":"        container_id \u003d container[\u0027Id\u0027]"},{"line_number":177,"context_line":"        neutron_ports \u003d None"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f013ff3_05256cc2","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":34},"updated":"2017-05-16 21:50:16.000000000","message":"The name suggested that this method is for adding a security group to a neutron port. However, the implementation seems to be adding security groups (plural) to all ports of a container. I think we need to either rename the method or modify the implementation to make them consistent.","commit_id":"f12d2e66d965824cc843ef851b04634a18530bcd"}],"zun/tests/tempest/api/common/datagen.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"25863d6d3b1290f51a5e17a5aa1de462b3ba2722","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \u0027command\u0027: \u0027sleep 10000\u0027,"},{"line_number":55,"context_line":"        \u0027memory\u0027: \u0027100\u0027,"},{"line_number":56,"context_line":"        \u0027environment\u0027: {},"},{"line_number":57,"context_line":"        \u0027image_driver\u0027: \u0027docker\u0027,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    data.update(kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_508a271b","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":33},"updated":"2017-05-16 09:27:13.000000000","message":"do we actually need this?","commit_id":"d692c7f28c93812f35a3e1baf0bd371850433ad2"}]}
