)]}'
{"zun/container/docker/driver.py":[{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"4ccbcaf72cac847ea23de43fafd5e39531a4ff82","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                port_bindings \u003d inspect[\u0027HostConfig\u0027][\u0027PortBindings\u0027]"},{"line_number":644,"context_line":"                if port_bindings:"},{"line_number":645,"context_line":"                    for port_info in port_bindings:"},{"line_number":646,"context_line":"                        for one in port_bindings[port_info]:"},{"line_number":647,"context_line":"                            port_used.append(int(one[\u0027HostPort\u0027]))"},{"line_number":648,"context_line":"            return port_used"},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_277ae823","line":646,"range":{"start_line":646,"start_character":28,"end_line":646,"end_character":31},"updated":"2017-05-15 07:30:36.000000000","message":"minor comments, good to give a more meaningful name.","commit_id":"69b05785731197f7c8faff2299ec01f940152d8d"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"522132c609280dcd8e02413afe591571da962085","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                        cpu_used +\u003d float(nanocpus) / 1e9"},{"line_number":634,"context_line":"            return cpu_used"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    def get_port_used(self):"},{"line_number":637,"context_line":"        port_used \u003d []"},{"line_number":638,"context_line":"        with docker_utils.docker_client() as docker:"},{"line_number":639,"context_line":"            containers \u003d docker.containers()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_8b21b450","line":636,"range":{"start_line":636,"start_character":7,"end_line":636,"end_character":21},"updated":"2017-05-15 19:07:46.000000000","message":"change to plural? I am thinking get_ports().","commit_id":"e8ea93b42d3637b4587727a27d7a3a27502d90bf"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"522132c609280dcd8e02413afe591571da962085","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                inspect \u003d docker.inspect_container(cnt_id)"},{"line_number":643,"context_line":"                port_bindings \u003d inspect[\u0027HostConfig\u0027][\u0027PortBindings\u0027]"},{"line_number":644,"context_line":"                if port_bindings:"},{"line_number":645,"context_line":"                    for port_info in port_bindings:"},{"line_number":646,"context_line":"                        for hostport_info in port_bindings[port_info]:"},{"line_number":647,"context_line":"                            port_used.append(int(hostport_info[\u0027HostPort\u0027]))"},{"line_number":648,"context_line":"            return port_used"},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_8b7d341e","line":646,"range":{"start_line":645,"start_character":19,"end_line":646,"end_character":70},"updated":"2017-05-15 19:07:46.000000000","message":"It doesn\u0027t look correct to me. Is \"port_info\" a index of port_bindings? If yes, then the first for loop should be something like \"for port_info in range(0, len(port_bindings))\". Please double check.","commit_id":"e8ea93b42d3637b4587727a27d7a3a27502d90bf"}]}
