)]}'
{"zun/conf/docker.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"f062e40e12be9bb6326af098909b154c57349a8e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d\u0027Default timeout in seconds for docker client \u0027"},{"line_number":29,"context_line":"                    \u0027operations.\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027api_url\u0027,"},{"line_number":31,"context_line":"               default\u003d\u0027tcp://$docker_remote_api_host:$docker_remote_api_port\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027API endpoint of docker daemon\u0027),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027api_insecure\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_5ff9fcc5","line":31,"updated":"2017-05-19 09:01:55.000000000","message":"I think this is not correct as this URL is not valid. So I think it better to leave it as it is or remove the default option. WDYT?","commit_id":"c630656bbdb28e9f3d5413629011d320b187b126"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"133d06aff6ebb73cc7d3b3dd9a1dc32cbbc5a78b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d\u0027Default timeout in seconds for docker client \u0027"},{"line_number":29,"context_line":"                    \u0027operations.\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027api_url\u0027,"},{"line_number":31,"context_line":"               default\u003d\u0027tcp://$docker_remote_api_host:$docker_remote_api_port\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027API endpoint of docker daemon\u0027),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027api_insecure\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_6502e20b","line":31,"in_reply_to":"ff0f0b1f_5ff9fcc5","updated":"2017-05-19 15:39:11.000000000","message":"I tested it locally and it seems this URL will work if the configs \u0027docker_remote_api_host\u0027 and \u0027docker_remote_api_port\u0027 are correctly set. The idea is to let docker daemon listen to TCP port by default so that it can be remotely accessible by services in different host (i.e. zun-api, zun-wsproxy). We can leave it as is or remove the default. That means operators need to manually set this config if they want zun-api/zun-wsproxy to access docker daemon in compute host, which is also fine. I am open to consider this opinion.","commit_id":"c630656bbdb28e9f3d5413629011d320b187b126"}]}