)]}'
{"zun/compute/compute_node_tracker.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fb013290738b22717de85a0f983ca9e3ac5b157f","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)"},{"line_number":244,"context_line":"    def remove_usage_from_container(self, context, container,"},{"line_number":245,"context_line":"                                    is_removed\u003dFalse):"},{"line_number":246,"context_line":"        \"\"\"Just a wrapper of the private function to hold lock.\"\"\""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # We need to get the latest compute node info"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_c21eefb9","line":245,"range":{"start_line":245,"start_character":36,"end_line":245,"end_character":46},"updated":"2017-06-02 20:36:36.000000000","message":"Nit: according to the method name, it seems to suggest that is_remove is always True.","commit_id":"8dcccadef78ba4db929d6e3210b315ae256b3669"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"a15d13b17083ea1d559f468763c2d7a407aeb1cb","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)"},{"line_number":244,"context_line":"    def remove_usage_from_container(self, context, container,"},{"line_number":245,"context_line":"                                    is_removed\u003dFalse):"},{"line_number":246,"context_line":"        \"\"\"Just a wrapper of the private function to hold lock.\"\"\""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # We need to get the latest compute node info"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_d7eb3c75","line":245,"range":{"start_line":245,"start_character":36,"end_line":245,"end_character":46},"in_reply_to":"df140735_c21eefb9","updated":"2017-06-05 00:39:13.000000000","message":"Done","commit_id":"8dcccadef78ba4db929d6e3210b315ae256b3669"}],"zun/compute/manager.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"31b92b05ccb8bb285f0bb6ed0f050fcfc1306b75","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # Remove the claimed resource"},{"line_number":220,"context_line":"        rt \u003d self._get_resource_tracker()"},{"line_number":221,"context_line":"        rt.update_available_resources(context)"},{"line_number":222,"context_line":"        return container"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_security_group(self, context, container, security_group):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_68116652","line":221,"range":{"start_line":221,"start_character":11,"end_line":221,"end_character":37},"updated":"2017-06-01 23:53:14.000000000","message":"Hi Shunli,\n\nI think this will work fine but it will recompile all the containers to re-calculate the resource usage of that node, which looks heavy. Did you consider an alternative approach which simply deduct resource usage of that container from the node? This seems to be what Nova is doing.","commit_id":"cc2e3e1ab3d8a60207fa6915e8925732c778bb1f"},{"author":{"_account_id":8264,"name":"Shunli Zhou","username":"ShunliZhou"},"change_message_id":"0ac6dc286a9d24fbda4ae5291f0540e7fec5c7a2","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # Remove the claimed resource"},{"line_number":220,"context_line":"        rt \u003d self._get_resource_tracker()"},{"line_number":221,"context_line":"        rt.update_available_resources(context)"},{"line_number":222,"context_line":"        return container"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_security_group(self, context, container, security_group):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_ebefb01b","line":221,"range":{"start_line":221,"start_character":11,"end_line":221,"end_character":37},"in_reply_to":"df140735_68116652","updated":"2017-06-02 01:01:58.000000000","message":"Seems i need add a public method in compute node tracker to update a single container resource. Let me see.","commit_id":"cc2e3e1ab3d8a60207fa6915e8925732c778bb1f"}]}